Varun Vasudev added a comment - 15/Jun/16 09:07 Uploaded patch file with fix.

Hadoop QA added a comment - 15/Jun/16 15:24 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 2m 36s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 45s trunk passed +1 mvneclipse 0m 39s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 3s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 2m 3s the patch passed +1 javac 2m 3s the patch passed -1 checkstyle 0m 34s hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 43 unchanged - 0 fixed = 46 total (was 43) +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 55s the patch passed +1 javadoc 1m 1s the patch passed +1 unit 2m 13s hadoop-yarn-common in the patch passed. +1 unit 13m 11s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 40m 50s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 84m 28s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810791/YARN-5246.001.patch JIRA Issue YARN-5246 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 010fcbc9a755 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 25064fb Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12028/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12028/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12028/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12028/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12028/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Junping Du added a comment - 17/Jun/16 01:59 Thanks Varun Vasudev for delivering the patch. The patch looks good in overall. Just remove some unnecessary import as checkstyle report should be fine.

Varun Vasudev added a comment - 17/Jun/16 07:27 Thanks for the review Junping Du . Uploaded a new patch with the checkstyle fixes.

Hadoop QA added a comment - 17/Jun/16 08:44 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 49s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 2m 37s trunk passed +1 javadoc 1m 6s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 2m 8s the patch passed +1 javac 2m 8s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 59s the patch passed +1 javadoc 1m 0s the patch passed +1 unit 2m 9s hadoop-yarn-common in the patch passed. +1 unit 12m 53s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 32m 36s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 75m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811308/YARN-5246.002.patch JIRA Issue YARN-5246 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b0abc68ec833 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09e82ac Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12062/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/12062/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Junping Du added a comment - 17/Jun/16 15:10 02 patch LGTM. +1. Will commit it shortly.

Junping Du added a comment - 20/Jun/16 00:55 I have commit the patch to trunk and branch-2. Thanks Varun Vasudev for patch contribution!

Hudson added a comment - 20/Jun/16 00:55 SUCCESS: Integrated in Hadoop-trunk-Commit #9984 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9984/ ) YARN-5246 . NMWebAppFilter web redirects drop query parameters. (junping_du: rev d0162f2040a4d98fbac51527dfc9447888cb32ab) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/util/TestWebAppUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebAppFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebAppFilter.java

Jason Lowe added a comment - 05/Jan/17 20:38 Thanks, Varun! I committed this to branch-2.8 as well.