Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5206

RegistrySecurity includes id:pass in exception text if considered invalid

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      RegistrySecurity.digest(String) throws an IOE if the "digest" auth isn't considered valid...this means that info may into logs.

      fix is trivial

      1. YARN-5206-001.patch
        1.0 kB
        Steve Loughran

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        patch 001; removes the text

        Show
        stevel@apache.org Steve Loughran added a comment - patch 001; removes the text
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 8s trunk passed
        +1 compile 0m 14s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 18s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 13s the patch passed
        +1 compile 0m 10s the patch passed
        +1 javac 0m 10s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 14s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 27s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 0m 47s hadoop-yarn-registry in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        11m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808605/YARN-5206-001.patch
        JIRA Issue YARN-5206
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8e2fd8da93a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bddea5f
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11868/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11868/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 8s trunk passed +1 compile 0m 14s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 10s the patch passed +1 javac 0m 10s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 14s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 27s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 0m 47s hadoop-yarn-registry in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 11m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808605/YARN-5206-001.patch JIRA Issue YARN-5206 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e2fd8da93a9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bddea5f Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11868/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry Console output https://builds.apache.org/job/PreCommit-YARN-Build/11868/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Will commit this later today if no objections.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Will commit this later today if no objections.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Steve! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.

        Show
        jlowe Jason Lowe added a comment - Thanks, Steve! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9928 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9928/)
        YARN-5206. RegistrySecurity includes id:pass in exception text if (jlowe: rev 8c8a377cac10b086a7ff37ee366b79e6b04d2738)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9928 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9928/ ) YARN-5206 . RegistrySecurity includes id:pass in exception text if (jlowe: rev 8c8a377cac10b086a7ff37ee366b79e6b04d2738) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java
        Hide
        stevel@apache.org Steve Loughran added a comment -

        thanks for doing the commit

        Show
        stevel@apache.org Steve Loughran added a comment - thanks for doing the commit
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            stevel@apache.org Steve Loughran
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development