Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: webapp
    • Labels:
      None
    1. YARN-5161-YARN-3368.05.patch
      37 kB
      Kai Sasaki
    2. Screen Shot 2016-06-20 at 23.15.05.png
      51 kB
      Kai Sasaki
    3. YARN-5161-YARN-3368.04.patch
      37 kB
      Kai Sasaki
    4. Screen Shot 2016-06-11 at 12.33.39.png
      68 kB
      Kai Sasaki
    5. YARN-5161-YARN-3368.03.patch
      2 kB
      Kai Sasaki
    6. Screen Shot 2016-05-31 at 21.22.30.png
      129 kB
      Kai Sasaki
    7. YARN-5161.02.patch
      3 kB
      Kai Sasaki
    8. apache_logo.png
      100 kB
      Kai Sasaki
    9. hadoop_logo.png
      26 kB
      Kai Sasaki
    10. YARN-5161.01.patch
      2 kB
      Kai Sasaki

      Activity

      Hide
      lewuathe Kai Sasaki added a comment -

      hadoop_logo.png is put under hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/public/assets/images/.

      Show
      lewuathe Kai Sasaki added a comment - hadoop_logo.png is put under hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/public/assets/images/ .
      Hide
      sunilg Sunil G added a comment -

      Thanks Kai Sasaki for the patch.
      Could you please attach a screen shot of the complete web UI with this logo?

      Also I know that this logo is what we used in old UI, and I have seen a ticket/discussion on adding Apache name also to this logo. We can see whether it possible later.

      Show
      sunilg Sunil G added a comment - Thanks Kai Sasaki for the patch. Could you please attach a screen shot of the complete web UI with this logo? Also I know that this logo is what we used in old UI, and I have seen a ticket/discussion on adding Apache name also to this logo. We can see whether it possible later.
      Hide
      sunilg Sunil G added a comment -

      Hi Kai Sasaki
      I have tried the patch locally. Couple comments

      • Patch is not applying cleaning for the png file attached, you might need to generate a patch with the png file also.
      • We could change the icon as Apache hadoop YARN. Wangda Tan, thoughts?
      Show
      sunilg Sunil G added a comment - Hi Kai Sasaki I have tried the patch locally. Couple comments Patch is not applying cleaning for the png file attached, you might need to generate a patch with the png file also. We could change the icon as Apache hadoop YARN . Wangda Tan , thoughts?
      Hide
      sunilg Sunil G added a comment -

      I guess we must use the official logo, so current logo attached in this JIRA seems fine. Kai Sasaki, Could you please attach a patch with the apache logo png file.

      Show
      sunilg Sunil G added a comment - I guess we must use the official logo, so current logo attached in this JIRA seems fine. Kai Sasaki , Could you please attach a patch with the apache logo png file.
      Hide
      lewuathe Kai Sasaki added a comment -

      Sunil G Do you mean apache log not hadoop logo?

      Show
      lewuathe Kai Sasaki added a comment - Sunil G Do you mean apache log not hadoop logo?
      Hide
      sunilg Sunil G added a comment -

      Kai Sasaki, Sorry for the confusion. The hadoop logo which you have updated first itself is correct. I will now try the new patch which you have uploaded. Thank You.

      Show
      sunilg Sunil G added a comment - Kai Sasaki , Sorry for the confusion. The hadoop logo which you have updated first itself is correct. I will now try the new patch which you have uploaded. Thank You.
      Hide
      lewuathe Kai Sasaki added a comment -

      I updated to use hadoop_logo.png and renamed to kick CI.

      Show
      lewuathe Kai Sasaki added a comment - I updated to use hadoop_logo.png and renamed to kick CI.
      Hide
      sunilg Sunil G added a comment -

      Hi Kai Sasaki
      Thanks for updating patch. Few quick comments.

      Since this patch contains a binary file, I cannot apply it with patch -p0 -i <patch-name> as it skips binary file. Some how this patch cannot be applied with "git apply" command. Seems patch is not generated by using "format-patch". And we can apply binary patches using git apply --binary <patch_file>. So could you please regenerate patch by using git format-patch command. May be I am missing something or some command line option. pls feel free to correct me if I am missing something.

      Few other nits:
      1. I think we can change the color scheme of UI links. Since hadoop logo is more blueish color, we can change the top level links color to a closer color tone to hadoop logo. It may make UI more unique in color tone. What do you think?
      2. I feel alternate text can be "Apache Hadoop". I feel we can skip YARN. alt="Apache Hadoop"

      Show
      sunilg Sunil G added a comment - Hi Kai Sasaki Thanks for updating patch. Few quick comments. Since this patch contains a binary file, I cannot apply it with patch -p0 -i <patch-name> as it skips binary file. Some how this patch cannot be applied with "git apply" command. Seems patch is not generated by using "format-patch". And we can apply binary patches using git apply --binary <patch_file> . So could you please regenerate patch by using git format-patch command. May be I am missing something or some command line option. pls feel free to correct me if I am missing something. Few other nits: 1. I think we can change the color scheme of UI links. Since hadoop logo is more blueish color, we can change the top level links color to a closer color tone to hadoop logo. It may make UI more unique in color tone. What do you think? 2. I feel alternate text can be "Apache Hadoop". I feel we can skip YARN. alt="Apache Hadoop"
      Hide
      lewuathe Kai Sasaki added a comment -

      So could you please regenerate patch by using git format-patch command.

      Sure, I'll rebase and generate a patch with format-patch.

      I think we can change the color scheme of UI links.

      It's difficult to answer for me since I'm not and graphical designer. Current YARN UI also has same color tone and I don't feel so much of wrong style. But anyway I can change and I'll attache screen shot of new style.
      Also I'll change alternate text as you said. Thanks!

      Show
      lewuathe Kai Sasaki added a comment - So could you please regenerate patch by using git format-patch command. Sure, I'll rebase and generate a patch with format-patch . I think we can change the color scheme of UI links. It's difficult to answer for me since I'm not and graphical designer. Current YARN UI also has same color tone and I don't feel so much of wrong style. But anyway I can change and I'll attache screen shot of new style. Also I'll change alternate text as you said. Thanks!
      Hide
      lewuathe Kai Sasaki added a comment -

      Sunil G
      I updated the patch in `format-patch` format which seems include binary file (hadoop_logo.png and attached the screen shot after updated. Please check this when you get a chance.

      Show
      lewuathe Kai Sasaki added a comment - Sunil G I updated the patch in `format-patch` format which seems include binary file ( hadoop_logo.png and attached the screen shot after updated. Please check this when you get a chance.
      Hide
      hadoopqa Hadoop QA added a comment -
      +1 overall



      Vote Subsystem Runtime Comment
      0 reexec 2m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 asflicense 0m 29s The patch does not generate ASF License warnings.
      3m 8s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:6d3a5f5
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809615/YARN-5161-YARN-3368.04.patch
      JIRA Issue YARN-5161
      Optional Tests asflicense
      uname Linux 83727a573467 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3368 / b775df6
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/11989/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 2m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 3m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:6d3a5f5 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809615/YARN-5161-YARN-3368.04.patch JIRA Issue YARN-5161 Optional Tests asflicense uname Linux 83727a573467 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / b775df6 modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/11989/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Thank you very much Kai Sasaki.
      Path applies cleanly now.

      Color tone seems closer to logo now. I think I will check with Sreenath Somarajapuram and Wangda Tan for an opinion here on UI color tone. Sreenath Somarajapuram/Wangda Tan pls share your thoughts on UI links color tone w.r.t apache logo.

      Show
      sunilg Sunil G added a comment - Thank you very much Kai Sasaki . Path applies cleanly now. Color tone seems closer to logo now. I think I will check with Sreenath Somarajapuram and Wangda Tan for an opinion here on UI color tone. Sreenath Somarajapuram / Wangda Tan pls share your thoughts on UI links color tone w.r.t apache logo.
      Hide
      Sreenath Sreenath Somarajapuram added a comment -

      The texts are a bit on the lighter side.
      Would be better to use a more darker shade.

      Show
      Sreenath Sreenath Somarajapuram added a comment - The texts are a bit on the lighter side. Would be better to use a more darker shade.
      Hide
      sunilg Sunil G added a comment -

      Thanks Kai Sasaki
      Could you please help to share an update patch with a darker color tone for links.

      Show
      sunilg Sunil G added a comment - Thanks Kai Sasaki Could you please help to share an update patch with a darker color tone for links.
      Hide
      lewuathe Kai Sasaki added a comment -

      Thanks Sreenath Somarajapuram and Sunil G for reviewing.
      I updated to use darker color and attache screenshot as well.

      Show
      lewuathe Kai Sasaki added a comment - Thanks Sreenath Somarajapuram and Sunil G for reviewing. I updated to use darker color and attache screenshot as well.
      Hide
      hadoopqa Hadoop QA added a comment -
      +1 overall



      Vote Subsystem Runtime Comment
      0 reexec 2m 39s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 asflicense 0m 16s The patch does not generate ASF License warnings.
      3m 12s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:6d3a5f5
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811827/YARN-5161-YARN-3368.05.patch
      JIRA Issue YARN-5161
      Optional Tests asflicense
      uname Linux d07019f6502d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3368 / b775df6
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/12079/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 2m 39s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 3m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:6d3a5f5 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811827/YARN-5161-YARN-3368.05.patch JIRA Issue YARN-5161 Optional Tests asflicense uname Linux d07019f6502d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / b775df6 modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/12079/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Thanks Kai Sasaki for the latest patch and screen shots. This looks much better.
      Offline synced with Sreenath Somarajapuram, he mentioned that we can use ember bootstrap link color. Seems current screen shot looks almost fine, I will wait for a feedback from Sreenath Somarajapuram as well.

      Show
      sunilg Sunil G added a comment - Thanks Kai Sasaki for the latest patch and screen shots. This looks much better. Offline synced with Sreenath Somarajapuram , he mentioned that we can use ember bootstrap link color. Seems current screen shot looks almost fine, I will wait for a feedback from Sreenath Somarajapuram as well.
      Hide
      sunilg Sunil G added a comment -

      Sreenath Somarajapuram, if this color scheme is fine, I will commit the patch tomorrow. pls confirm.

      Show
      sunilg Sunil G added a comment - Sreenath Somarajapuram , if this color scheme is fine, I will commit the patch tomorrow. pls confirm.
      Hide
      Sreenath Sreenath Somarajapuram added a comment -

      +1 Looks good to me.

      Show
      Sreenath Sreenath Somarajapuram added a comment - +1 Looks good to me.
      Hide
      sunilg Sunil G added a comment -

      Thanks Kai Sasaki for the patch and thanks Sreenath Somarajapuram for the review. Committed to the branch.

      Show
      sunilg Sunil G added a comment - Thanks Kai Sasaki for the patch and thanks Sreenath Somarajapuram for the review. Committed to the branch.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/)
      YARN-5161. YARN-3368 Add Apache Hadoop logo in YarnUI home page. (Kai (wangda: rev 35f08122e23b8ee48abeb04bcc5cb7b7b907db35)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/application.hbs
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/styles/app.css
      • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/public/assets/images/hadoop_logo.png
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/ ) YARN-5161 . YARN-3368 Add Apache Hadoop logo in YarnUI home page. (Kai (wangda: rev 35f08122e23b8ee48abeb04bcc5cb7b7b907db35) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/application.hbs (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/styles/app.css (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/public/assets/images/hadoop_logo.png

        People

        • Assignee:
          lewuathe Kai Sasaki
          Reporter:
          sunilg Sunil G
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development