[YARN-5109] timestamps are stored unencoded causing parse errors

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: YARN-2928
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Component/s: timelineserver
• Labels: yarn-2928-1st-milestone
• Target Version/s: YARN-2928
• Hadoop Flags: Reviewed
• Assignee: Varun Saxena
• Reporter: Sangjin Lee
• Created: 18/May/16 04:56
• Updated: 21/Oct/17 06:05
• Resolved: 27/May/16 04:41

Description

When we store timestamps (for example as part of the row key or part of the column name for an event), the bytes are used as is without any encoding. If the byte value happens to contain a separator character we use (e.g. "!" or "="), it causes a parse failure when we read it.

I came across this while looking into this error in the timeline reader:

2016-05-17 21:28:38,643 WARN org.apache.hadoop.yarn.server.timelineservice.storage.common.TimelineStorageUtils: incorrectly formatted column name: it will be discarded

I traced the data that was causing this, and the column name (for the event) was the following:

i:e!YARN_RM_CONTAINER_CREATED=\x7F\xFF\xFE\xABDY=\x99=YARN_CONTAINER_ALLOCATED_HOST

Note that the column name is supposed to be of the format (event id)=(timestamp)=(event info key). However, observe the timestamp portion:

\x7F\xFF\xFE\xABDY=\x99

The presence of the separator ("=") causes the parse error.

Issue Links

• is related to: YARN-5170 Eliminate singleton converters and static method access