Entering invalid value for am in yarn logs CLI does not give any error message
yarn logs -applicationId <applicationID> -am 30
impl.TimelineClientImpl: Timeline service address: <ATS>
INFO client.RMProxy: Connecting to ResourceManager at <RM>
Simple patch to add the error message.
This message was automatically generated.
Hi Jian He, thanks for delivering patch. However, the attached two files are name the same and we cannot see different from timestamp (it shows yesterday in my local timezone). Can you point me which one is the latest or rename the patch in a right order? Thanks!
The highlighted one in blue is the right one. I'll change the name accordingly if any review comments.
Thanks Jian! The patch above looks good.
However, can we add a unit test for this invalid AM value case? It should be similar as TestLogsCLI#testInvalidApplicationId().
new patch addressed the comment
Thanks Jian He for updating the patch. 2nd patch looks good. +1 pending on Jenkins result.
The test failure in TestLogsCLI#testFetchApplictionLogs is not related as it also shows in other JIRAs (like: YARN-5224) and YARN-5248 already track it. The checkstyle issue seems to be minor, put up another patch with this tiny change.
Will commit the patch once Jenkins report positive.
I have commit the latest patch to trunk and branch-2. Thanks Jian He for patch contribution!
SUCCESS: Integrated in Hadoop-trunk-Commit #9968 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9968/)
YARN-5083. YARN CLI for AM logs does not give any error message if (junping_du: rev e14ee0d3b55816bed1d27a8caf78001985119e3c)