Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5069

TestFifoScheduler.testResourceOverCommit race condition

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None

      Description

      There is a race condition between updating the node resources and the node report becoming available. If the update takes too long, the report will be set to null and we will get an NPE when checking the report's available resources.

      1. YARN-5069.001.patch
        1 kB
        Eric Badger
      2. YARN-5069-b2.7.001.patch
        1 kB
        Eric Badger

        Activity

        Hide
        ebadger Eric Badger added a comment -

        Attaching trunk patch.

        Show
        ebadger Eric Badger added a comment - Attaching trunk patch.
        Hide
        ebadger Eric Badger added a comment -

        Attaching branch 2.7 patch.

        Show
        ebadger Eric Badger added a comment - Attaching branch 2.7 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s YARN-5069 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803265/YARN-5069-b2.7.001.patch
        JIRA Issue YARN-5069
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11399/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-5069 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803265/YARN-5069-b2.7.001.patch JIRA Issue YARN-5069 Console output https://builds.apache.org/job/PreCommit-YARN-Build/11399/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Eric Payne, you committed YARN-4556, which is similar to this. Can you review this patch?

        Show
        ebadger Eric Badger added a comment - Eric Payne , you committed YARN-4556 , which is similar to this. Can you review this patch?
        Hide
        eepayne Eric Payne added a comment -

        +1. Committing

        Show
        eepayne Eric Payne added a comment - +1. Committing
        Hide
        ebadger Eric Badger added a comment -

        Thanks, Eric Payne!

        Show
        ebadger Eric Badger added a comment - Thanks, Eric Payne !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9768 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9768/)
        YARN-5069. TestFifoScheduler.testResourceOverCommit race condition. (epayne: rev 1217c8f6b49e3afd8ca008ffddcf6615f0accfc5)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9768 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9768/ ) YARN-5069 . TestFifoScheduler.testResourceOverCommit race condition. (epayne: rev 1217c8f6b49e3afd8ca008ffddcf6615f0accfc5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java
        Hide
        eepayne Eric Payne added a comment -

        Thanks, Eric Badger. I committed this to trunk, branch-2, branch-2.8, and branch-2.7.

        Show
        eepayne Eric Payne added a comment - Thanks, Eric Badger . I committed this to trunk, branch-2, branch-2.8, and branch-2.7.
        Hide
        eepayne Eric Payne added a comment -

        Changing Fix Version to 2.7.3 since branch 2.7.3 has not yet been created.

        Show
        eepayne Eric Payne added a comment - Changing Fix Version to 2.7.3 since branch 2.7.3 has not yet been created.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            ebadger Eric Badger
            Reporter:
            ebadger Eric Badger
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development