Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5027

NM should clean up app log dirs after NM restart

    Details

    • Hadoop Flags:
      Reviewed

      Description

      If nm start without recovery enabled, there may be many deprecated app log dir in NM log dirs, NM should clean up them.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10720/)
        YARN-5027. NM should clean up app log dirs after NM restart. Contributed (jlowe: rev 7146359bfd436a76585fb1f3ea93716795308cec)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10720 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10720/ ) YARN-5027 . NM should clean up app log dirs after NM restart. Contributed (jlowe: rev 7146359bfd436a76585fb1f3ea93716795308cec) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to sandflee for the contribution and to Chris Trezzo] for additional review! I committed this to trunk, branch-2, and branch-2.8.

        Show
        jlowe Jason Lowe added a comment - Thanks to sandflee for the contribution and to Chris Trezzo ] for additional review! I committed this to trunk, branch-2, and branch-2.8.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 36s trunk passed
        +1 compile 0m 27s trunk passed
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 26s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 16s trunk passed
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 24s the patch passed
        +1 javac 0m 24s the patch passed
        +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 145 unchanged - 1 fixed = 145 total (was 146)
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 46s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 14m 47s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        28m 0s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5027
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 18065be40add 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dd4ed6a
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13585/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13585/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 36s trunk passed +1 compile 0m 27s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 145 unchanged - 1 fixed = 145 total (was 146) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 46s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 14m 47s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 28m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5027 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 18065be40add 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dd4ed6a Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13585/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13585/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ctrezzo Chris Trezzo added a comment -

        The exists check is on the root log dir, not the app log dirs.

        Ah. Gotcha. +1 from me as well.

        Show
        ctrezzo Chris Trezzo added a comment - The exists check is on the root log dir, not the app log dirs. Ah. Gotcha. +1 from me as well.
        Hide
        jlowe Jason Lowe added a comment -

        +1 for the latest patch. I'll commit this tomorrow if there are no objections.

        Show
        jlowe Jason Lowe added a comment - +1 for the latest patch. I'll commit this tomorrow if there are no objections.
        Hide
        jlowe Jason Lowe added a comment -

        I don't believe it will leak those directories. The exists check is on the root log dir, not the app log dirs. Since we rename the log dirs underneath the same root log dir, if that root dir doesn't exist then none of the DEL directories will either.

        Show
        jlowe Jason Lowe added a comment - I don't believe it will leak those directories. The exists check is on the root log dir, not the app log dirs. Since we rename the log dirs underneath the same root log dir, if that root dir doesn't exist then none of the DEL directories will either.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 37s trunk passed
        +1 compile 0m 25s trunk passed
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 26s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 16s trunk passed
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 23s the patch passed
        +1 javac 0m 23s the patch passed
        +1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 145 unchanged - 1 fixed = 145 total (was 146)
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 45s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 14m 44s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        27m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-5027
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 86f70b18b29c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dd4ed6a
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13582/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13582/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 37s trunk passed +1 compile 0m 25s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 23s the patch passed +1 javac 0m 23s the patch passed +1 checkstyle 0m 14s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 145 unchanged - 1 fixed = 145 total (was 146) +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 14m 44s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 27m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-5027 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 86f70b18b29c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dd4ed6a Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13582/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13582/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ctrezzo Chris Trezzo added a comment - - edited

        Does the current patch have the potential to leak application_*_*_DEL_* directories? In ResourceLocalizationService#cleanupLogDir would we want to check if the renamed _DEL_ directory exists in the case where the original log directory doesn't exist and delete if necessary?

        Show
        ctrezzo Chris Trezzo added a comment - - edited Does the current patch have the potential to leak application_*_*_DEL_* directories? In ResourceLocalizationService#cleanupLogDir would we want to check if the renamed _DEL_ directory exists in the case where the original log directory doesn't exist and delete if necessary?
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch! Looks good to me, kicking another Jenkins run to make sure it's still clean.

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch! Looks good to me, kicking another Jenkins run to make sure it's still clean.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 30s trunk passed
        +1 compile 0m 23s trunk passed with JDK v1.8.0_91
        +1 compile 0m 26s trunk passed with JDK v1.7.0_101
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 48s trunk passed
        +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 22s trunk passed with JDK v1.7.0_101
        +1 mvninstall 0m 25s the patch passed
        +1 compile 0m 19s the patch passed with JDK v1.8.0_91
        +1 javac 0m 19s the patch passed
        +1 compile 0m 24s the patch passed with JDK v1.7.0_101
        +1 javac 0m 24s the patch passed
        +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 0 new + 147 unchanged - 1 fixed = 147 total (was 148)
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 1s the patch passed
        +1 javadoc 0m 15s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_101
        +1 unit 11m 8s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
        +1 unit 11m 40s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        37m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch
        JIRA Issue YARN-5027
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 778aaaa9a4f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3fa1380
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11465/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11465/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 30s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_91 +1 compile 0m 26s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 48s trunk passed +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 25s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_91 +1 javac 0m 19s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_101 +1 javac 0m 24s the patch passed +1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 0 new + 147 unchanged - 1 fixed = 147 total (was 148) +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_101 +1 unit 11m 8s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 40s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 37m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804018/YARN-5027.01.patch JIRA Issue YARN-5027 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 778aaaa9a4f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3fa1380 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11465/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11465/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            sandflee sandflee
            Reporter:
            sandflee sandflee
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development