Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It would be valuable to know the resource consumed by a container in the RM audit log.

      1. YARN-5003.001.patch
        23 kB
        Nathan Roberts

        Issue Links

          Activity

          Hide
          nroberts Nathan Roberts added a comment -

          Attaching patch

          Show
          nroberts Nathan Roberts added a comment - Attaching patch
          Hide
          templedf Daniel Templeton added a comment -

          I didn't do a careful review yet, but the patch looks reasonable. I don't see any obvious red flags.

          Show
          templedf Daniel Templeton added a comment - I didn't do a careful review yet, but the patch looks reasonable. I don't see any obvious red flags.
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. I'll commit this tomorrow if there are no objections.

          I see this is targeted to 3.0.0. Given the audit log is already key,value pairs and should be parsed as such, is there a reason this shouldn't go into 2.9.0 as well?

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. I'll commit this tomorrow if there are no objections. I see this is targeted to 3.0.0. Given the audit log is already key,value pairs and should be parsed as such, is there a reason this shouldn't go into 2.9.0 as well?
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Nathan Roberts for the contribution and to Daniel Templeton for additional review! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks to Nathan Roberts for the contribution and to Daniel Templeton for additional review! I committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9708/)
          YARN-5003. Add container resource to RM audit log. Contributed by Nathan (jlowe: rev ed54f5f1ff7862f8216f77d5ea8f9ccea674ccd1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9708/ ) YARN-5003 . Add container resource to RM audit log. Contributed by Nathan (jlowe: rev ed54f5f1ff7862f8216f77d5ea8f9ccea674ccd1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java

            People

            • Assignee:
              nroberts Nathan Roberts
              Reporter:
              nroberts Nathan Roberts
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development