Hi John Zhuge,
Thanks a lot for deep reviewing my patch. Tomorrow I will do the recommended changes. Until I have some questions that will help my work:
45, 62, 91: javac errors, switch to non-deprecated constructor?
I noticed that and I am planning to solve this situation. Even if I change the called constructor from test, inside MiniYarnCluster we still call the deprecated constructor from the other constructors. So at the end we call deprecated method.
Last week I created a new JIRA ticket to follow up this. Please check YARN-5007.
Is it fine with you if I resolve it with the ticket I linked?
Second and more important:
I compared the test results what was posted by Hadoop QA. More or less the same tests are failing so it seems they are not intermittent.
Do you have idea what can cause this? The changes should not be related. Most of them fail with timeout. Other failures are happening in classes that was not changed. So it doesn't really make sense.Do you have idea? Locally they do not fail.