[YARN-4937] EntityGroupFSTimelineStore to close cached leveldb instances in serviceStop()

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 2.8.0
• Component/s: timelineserver

Environment

JUnit test runs with

• Assignee: Unassigned
• Reporter: Steve Loughran
• Created: 09/Apr/16 11:57
• Updated: 09/Apr/16 12:18
• Resolved: 09/Apr/16 12:18

Description

When I enable ATS1.5 and non-summary data, all my JUnit test runs with it fail pass if called individually. But if executed together, the 2nd+ service fails, key exception text is

org.fusesource.leveldbjni.internal.NativeDB$DBException: IO error: lock /Users/stevel/Projects/spark/yarn-timeline/yarn-timeline-history/target/tmp/integration/leveldb/timelineEntityGroupId_1111_0_application_1111_0000-timeline-cache.ldb/LOCK: already held by process

I believe the problem is that EntityGroupFSTimelineStore.cachedLogs isn't cleaning up its logs in serviceStop(), and as my tests use the same directory and appIds in its test runs, the next attempt to create a cache item fails.