[YARN-4925] ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
• Target Version/s: 2.7.4
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Bibin Chundatt
• Created: 06/Apr/16 02:08
• Updated: 03/Jun/17 01:02
• Resolved: 03/Jun/17 01:02

Description

Currently with nodelabel AMRMClient will not be able to specify nodelabels with Node/Rack requests.For application like spark NODE_LOCAL requests cannot be asked with label expression.
As per the check in AMRMClientImpl#checkNodeLabelExpression

    // Don't allow specify node label against ANY request
    if ((containerRequest.getRacks() != null && 
        (!containerRequest.getRacks().isEmpty()))
        || 
        (containerRequest.getNodes() != null && 
        (!containerRequest.getNodes().isEmpty()))) {
      throw new InvalidContainerRequestException(
          "Cannot specify node label with rack and node");
    }

AppSchedulingInfo#updateResourceRequests we do reset of labels to that of OFF-SWITCH.

The above check is not required for ContainerRequest ask /cc wangda thank you for confirming

Issue Links

• is related to: YARN-4140 RM container allocation delayed incase of app submitted to Nodelabel partition