Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4906

Capture container start/finish time in container metrics

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    1. YARN-4906.1.patch
      8 kB
      Jian He
    2. YARN-4906.2.patch
      8 kB
      Jian He
    3. YARN-4906.3.patch
      9 kB
      Jian He

      Activity

      Hide
      jianhe Jian He added a comment -

      Uploaded a patch which adds start/finish time, exit code into container metrics.
      It is done outside of ContainerMonitor, because I think these kind of metrics need not to be dependent on whether resource-calculator plugin or vmem/pmem flag is enabled or not.

      Show
      jianhe Jian He added a comment - Uploaded a patch which adds start/finish time, exit code into container metrics. It is done outside of ContainerMonitor, because I think these kind of metrics need not to be dependent on whether resource-calculator plugin or vmem/pmem flag is enabled or not.
      Hide
      vvasudev Varun Vasudev added a comment - - edited

      Thanks for the patch Jian He. Few things -

      1. Do you think we should add a duration metric? For longer running containers, it would be a useful metric. You'll have to use the MonotonicClock for that though.
      2. long unrgisterDelay = conf.getLong(
        +          YarnConfiguration.NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS,
        +          YarnConfiguration.DEFAULT_NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS);
        

        Typo in the spelling of unregisterDelay

      3. The start time won't be preserved during a work preserving NM restart - this is also true for the other statistical metrics like the histograms, and the advanced actual resource usage metrics. I'm open to fixing this in a follow up JIRA.
      Show
      vvasudev Varun Vasudev added a comment - - edited Thanks for the patch Jian He . Few things - Do you think we should add a duration metric? For longer running containers, it would be a useful metric. You'll have to use the MonotonicClock for that though. long unrgisterDelay = conf.getLong( + YarnConfiguration.NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS, + YarnConfiguration.DEFAULT_NM_CONTAINER_METRICS_UNREGISTER_DELAY_MS); Typo in the spelling of unregisterDelay The start time won't be preserved during a work preserving NM restart - this is also true for the other statistical metrics like the histograms, and the advanced actual resource usage metrics. I'm open to fixing this in a follow up JIRA.
      Hide
      jianhe Jian He added a comment -

      Varun Vasudev, thanks for your review !
      I think the duration metrics may be derived from finish-start time by the consumer.
      Fixed the typo.

      Show
      jianhe Jian He added a comment - Varun Vasudev , thanks for your review ! I think the duration metrics may be derived from finish-start time by the consumer. Fixed the typo.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 15s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
      +1 mvninstall 6m 30s trunk passed
      +1 compile 0m 22s trunk passed with JDK v1.8.0_74
      +1 compile 0m 26s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 18s trunk passed
      +1 mvnsite 0m 27s trunk passed
      +1 mvneclipse 0m 13s trunk passed
      +1 findbugs 0m 51s trunk passed
      +1 javadoc 0m 17s trunk passed with JDK v1.8.0_74
      +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 24s the patch passed
      +1 compile 0m 20s the patch passed with JDK v1.8.0_74
      +1 javac 0m 20s the patch passed
      +1 compile 0m 24s the patch passed with JDK v1.7.0_95
      +1 javac 0m 24s the patch passed
      -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 9 new + 111 unchanged - 0 fixed = 120 total (was 111)
      +1 mvnsite 0m 25s the patch passed
      +1 mvneclipse 0m 11s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 0m 59s the patch passed
      +1 javadoc 0m 15s the patch passed with JDK v1.8.0_74
      +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
      -1 unit 8m 59s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74.
      -1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 17s Patch does not generate ASF License warnings.
      33m 18s



      Reason Tests
      JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestAuxServices
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestAuxServices



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:fbe3e86
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796867/YARN-4906.2.patch
      JIRA Issue YARN-4906
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux d51ebe137397 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 89c9347
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10957/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10957/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 30s trunk passed +1 compile 0m 22s trunk passed with JDK v1.8.0_74 +1 compile 0m 26s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 51s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 20s the patch passed with JDK v1.8.0_74 +1 javac 0m 20s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_95 +1 javac 0m 24s the patch passed -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 9 new + 111 unchanged - 0 fixed = 120 total (was 111) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 -1 unit 8m 59s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74. -1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 33m 18s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestAuxServices JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestAuxServices Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796867/YARN-4906.2.patch JIRA Issue YARN-4906 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d51ebe137397 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 89c9347 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10957/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10957/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 10s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
      +1 mvninstall 7m 49s trunk passed
      +1 compile 0m 28s trunk passed with JDK v1.8.0_77
      +1 compile 0m 29s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 17s trunk passed
      +1 mvnsite 0m 31s trunk passed
      +1 mvneclipse 0m 13s trunk passed
      +1 findbugs 0m 52s trunk passed
      +1 javadoc 0m 20s trunk passed with JDK v1.8.0_77
      +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 25s the patch passed
      +1 compile 0m 21s the patch passed with JDK v1.8.0_77
      +1 javac 0m 21s the patch passed
      +1 compile 0m 25s the patch passed with JDK v1.7.0_95
      +1 javac 0m 25s the patch passed
      -1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 9 new + 111 unchanged - 0 fixed = 120 total (was 111)
      +1 mvnsite 0m 32s the patch passed
      +1 mvneclipse 0m 12s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 9s the patch passed
      +1 javadoc 0m 19s the patch passed with JDK v1.8.0_77
      +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
      -1 unit 9m 24s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_77.
      -1 unit 9m 48s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 19s Patch does not generate ASF License warnings.
      35m 59s



      Reason Tests
      JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
        hadoop.yarn.server.nodemanager.containermanager.TestAuxServices
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
        hadoop.yarn.server.nodemanager.containermanager.TestAuxServices



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:fbe3e86
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796867/YARN-4906.2.patch
      JIRA Issue YARN-4906
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux c19946254014 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / f61de41
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10960/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10960/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 49s trunk passed +1 compile 0m 28s trunk passed with JDK v1.8.0_77 +1 compile 0m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 52s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 25s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_77 +1 javac 0m 21s the patch passed +1 compile 0m 25s the patch passed with JDK v1.7.0_95 +1 javac 0m 25s the patch passed -1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 9 new + 111 unchanged - 0 fixed = 120 total (was 111) +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 -1 unit 9m 24s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_77. -1 unit 9m 48s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 35m 59s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy   hadoop.yarn.server.nodemanager.containermanager.TestAuxServices JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy   hadoop.yarn.server.nodemanager.containermanager.TestAuxServices Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796867/YARN-4906.2.patch JIRA Issue YARN-4906 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c19946254014 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f61de41 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10960/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10960/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10960/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      jianhe Jian He added a comment -

      Fixed TestAuxServices,
      TestNMProxy fails on existing code, opened YARN-4922 to track

      Show
      jianhe Jian He added a comment - Fixed TestAuxServices, TestNMProxy fails on existing code, opened YARN-4922 to track
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 12s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
      +1 mvninstall 6m 57s trunk passed
      +1 compile 0m 23s trunk passed with JDK v1.8.0_77
      +1 compile 0m 26s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 18s trunk passed
      +1 mvnsite 0m 28s trunk passed
      +1 mvneclipse 0m 13s trunk passed
      +1 findbugs 0m 50s trunk passed
      +1 javadoc 0m 17s trunk passed with JDK v1.8.0_77
      +1 javadoc 0m 20s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 24s the patch passed
      +1 compile 0m 20s the patch passed with JDK v1.8.0_77
      +1 javac 0m 20s the patch passed
      +1 compile 0m 23s the patch passed with JDK v1.7.0_95
      +1 javac 0m 23s the patch passed
      -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 6 new + 111 unchanged - 0 fixed = 117 total (was 111)
      +1 mvnsite 0m 25s the patch passed
      +1 mvneclipse 0m 10s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 1s the patch passed
      +1 javadoc 0m 14s the patch passed with JDK v1.8.0_77
      +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
      -1 unit 8m 58s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_77.
      -1 unit 9m 31s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 19s Patch does not generate ASF License warnings.
      33m 40s



      Reason Tests
      JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:fbe3e86
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796943/YARN-4906.3.patch
      JIRA Issue YARN-4906
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 7d7b84b303c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / f65f5b1
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10961/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10961/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 57s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_77 +1 compile 0m 26s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 50s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 20s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 20s the patch passed with JDK v1.8.0_77 +1 javac 0m 20s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_95 +1 javac 0m 23s the patch passed -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 6 new + 111 unchanged - 0 fixed = 117 total (was 111) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 -1 unit 8m 58s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_77. -1 unit 9m 31s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 33m 40s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestNMProxy Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796943/YARN-4906.3.patch JIRA Issue YARN-4906 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7d7b84b303c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f65f5b1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10961/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10961/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      vvasudev Varun Vasudev added a comment -

      Latest patch looks good to me. +1.

      I'll commit it tomorrow if no one objects.

      Show
      vvasudev Varun Vasudev added a comment - Latest patch looks good to me. +1. I'll commit it tomorrow if no one objects.
      Hide
      vvasudev Varun Vasudev added a comment -

      Committed to trunk and branch-2. Thanks Jian He!

      Show
      vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Jian He !
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9566/)
      YARN-4906. Capture container start/finish time in container metrics. (vvasudev: rev b41e65e5bc9459b4d950a2c53860a223f1a0d2ec)

      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainerMetrics.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9566/ ) YARN-4906 . Capture container start/finish time in container metrics. (vvasudev: rev b41e65e5bc9459b4d950a2c53860a223f1a0d2ec) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainerMetrics.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestAuxServices.java

        People

        • Assignee:
          jianhe Jian He
          Reporter:
          jianhe Jian He
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development