Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5065 Umbrella JIRA of SLS fixes / improvements
  3. YARN-4899

Queue metrics of SLS capacity scheduler only activated after app submit to the queue

    Details

    • Hadoop Flags:
      Reviewed

      Description

      We should start recording queue metrics since cluster start.

      1. YARN-4899.2.patch
        3 kB
        Jonathan Hung
      2. YARN-4899.1.patch
        3 kB
        Wangda Tan

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11073/)
        YARN-4899. Queue metrics of SLS capacity scheduler only activated after (wangda: rev 5ed63e3e9d9937cf7441b7ceb5feafbf486f3387)

        • (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11073/ ) YARN-4899 . Queue metrics of SLS capacity scheduler only activated after (wangda: rev 5ed63e3e9d9937cf7441b7ceb5feafbf486f3387) (edit) hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/SLSCapacityScheduler.java
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk, thanks Jonathan Hung and thanks reviews from Jian He Min Shen

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk, thanks Jonathan Hung and thanks reviews from Jian He Min Shen
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committing...

        Show
        leftnoteasy Wangda Tan added a comment - Committing...
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 39s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 29s trunk passed
        +1 javadoc 0m 15s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 14s the patch passed
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 17s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 42s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 1m 1s hadoop-sls in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        21m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-4899
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845461/YARN-4899.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d7474bea8f0b 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fadd69
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14543/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14543/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 39s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 1m 1s hadoop-sls in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 21m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-4899 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845461/YARN-4899.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d7474bea8f0b 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fadd69 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14543/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/14543/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 51s trunk passed
        +1 compile 0m 20s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 0m 32s trunk passed
        +1 javadoc 0m 15s trunk passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 16s the patch passed
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 37s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 0m 56s hadoop-sls in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        21m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-4899
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845461/YARN-4899.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 579ba8b08566 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fadd69
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14541/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14541/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 51s trunk passed +1 compile 0m 20s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 0m 56s hadoop-sls in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 21m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-4899 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12845461/YARN-4899.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 579ba8b08566 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fadd69 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14541/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/14541/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks review from Min Shen and patch uploaded by Jonathan Hung, missed this JIRA previously.

        Latest patch LGTM, will commit later.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks review from Min Shen and patch uploaded by Jonathan Hung , missed this JIRA previously. Latest patch LGTM, will commit later.
        Hide
        jhung Jonathan Hung added a comment -

        Uploaded patch addressing checkstyle and review.

        Show
        jhung Jonathan Hung added a comment - Uploaded patch addressing checkstyle and review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 50s trunk passed
        +1 compile 0m 17s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 21s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 0m 33s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        -0 checkstyle 0m 12s hadoop-tools/hadoop-sls: The patch generated 5 new + 100 unchanged - 0 fixed = 105 total (was 100)
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 35s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 0m 53s hadoop-sls in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        19m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-4899
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 33df6bd90953 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fadd69
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14533/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14533/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/14533/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 50s trunk passed +1 compile 0m 17s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 12s hadoop-tools/hadoop-sls: The patch generated 5 new + 100 unchanged - 0 fixed = 105 total (was 100) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 53s hadoop-sls in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 19m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-4899 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 33df6bd90953 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fadd69 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14533/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14533/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/14533/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 49s trunk passed
        +1 compile 0m 17s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 25s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 0m 28s trunk passed
        +1 javadoc 0m 15s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        -0 checkstyle 0m 13s hadoop-tools/hadoop-sls: The patch generated 5 new + 100 unchanged - 0 fixed = 105 total (was 100)
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 0m 54s hadoop-sls in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        14m 46s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4899
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d6698c81e32f 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9e03ee5
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13611/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13611/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13611/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 49s trunk passed +1 compile 0m 17s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 25s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 13s hadoop-tools/hadoop-sls: The patch generated 5 new + 100 unchanged - 0 fixed = 105 total (was 100) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 54s hadoop-sls in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 14m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4899 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d6698c81e32f 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e03ee5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13611/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13611/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/13611/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        mshen Min Shen added a comment -

        The checkstyle output is inaccessible now.
        Need to rekick jenkins to check if these issues are relevant.

        Also, it seems a duplicate to keep referring "counter.queues." when defining these counter names:

                  "counter.queue." + queueName + ".pending.memory",
                  "counter.queue." + queueName + ".pending.cores",
                  "counter.queue." + queueName + ".allocated.memory",
                  "counter.queue." + queueName + ".allocated.cores" };
        
        Show
        mshen Min Shen added a comment - The checkstyle output is inaccessible now. Need to rekick jenkins to check if these issues are relevant. Also, it seems a duplicate to keep referring "counter.queues." when defining these counter names: "counter.queue." + queueName + ".pending.memory", "counter.queue." + queueName + ".pending.cores", "counter.queue." + queueName + ".allocated.memory", "counter.queue." + queueName + ".allocated.cores" };
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 42s trunk passed
        +1 compile 0m 24s trunk passed with JDK v1.8.0_91
        +1 compile 0m 21s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 42s trunk passed
        +1 javadoc 0m 21s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 19s the patch passed with JDK v1.8.0_91
        +1 javac 0m 19s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.7.0_95
        +1 javac 0m 17s the patch passed
        -1 checkstyle 0m 15s hadoop-tools/hadoop-sls: patch generated 5 new + 98 unchanged - 0 fixed = 103 total (was 98)
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 55s the patch passed
        +1 javadoc 0m 16s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95
        +1 unit 1m 9s hadoop-sls in the patch passed with JDK v1.8.0_91.
        +1 unit 1m 3s hadoop-sls in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        20m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch
        JIRA Issue YARN-4899
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4a0e70eaf064 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 996a210
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11388/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11388/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11388/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 42s trunk passed +1 compile 0m 24s trunk passed with JDK v1.8.0_91 +1 compile 0m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 42s trunk passed +1 javadoc 0m 21s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 22s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_91 +1 javac 0m 19s the patch passed +1 compile 0m 17s the patch passed with JDK v1.7.0_95 +1 javac 0m 17s the patch passed -1 checkstyle 0m 15s hadoop-tools/hadoop-sls: patch generated 5 new + 98 unchanged - 0 fixed = 103 total (was 98) +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 55s the patch passed +1 javadoc 0m 16s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95 +1 unit 1m 9s hadoop-sls in the patch passed with JDK v1.8.0_91. +1 unit 1m 3s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 20m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803092/YARN-4899.1.patch JIRA Issue YARN-4899 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4a0e70eaf064 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 996a210 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11388/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-sls.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11388/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Console output https://builds.apache.org/job/PreCommit-YARN-Build/11388/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        lgtm, kick jenkins

        Show
        jianhe Jian He added a comment - lgtm, kick jenkins

          People

          • Assignee:
            jhung Jonathan Hung
            Reporter:
            leftnoteasy Wangda Tan
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development