Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Incase of dataTables_wrapper the min height is 302 , Need to set the same to 10px.
      For pages containing 2 tables causes layout problem when min_height=302
      When dataTables_wrapper is in DIV rendering with border at min_height

      1. Border and DefaultHeight.png
        41 kB
        Bibin A Chundatt
      2. 0001-YARN-4897.patch
        0.7 kB
        Bibin A Chundatt

        Activity

        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Rohith Sharma K S
        Thank you for review and commit

        Show
        bibinchundatt Bibin A Chundatt added a comment - Rohith Sharma K S Thank you for review and commit
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9595 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9595/)
        YARN-4897. dataTables_wrapper change min height. Contributed by Bibin A (rohithsharmaks: rev 4ee7f0a3e7814d66d6e11aa4b559da5ac93c4b99)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/css/jui-dt.css
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9595 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9595/ ) YARN-4897 . dataTables_wrapper change min height. Contributed by Bibin A (rohithsharmaks: rev 4ee7f0a3e7814d66d6e11aa4b559da5ac93c4b99) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.9.4/css/jui-dt.css
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Committed to trunk/branch-2.. thanks Bibin A Chundatt for the patch!

        Show
        rohithsharma Rohith Sharma K S added a comment - Committed to trunk/branch-2.. thanks Bibin A Chundatt for the patch!
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        This change make sense to me. +1 lgtm, I will commit it if no objections

        Show
        rohithsharma Rohith Sharma K S added a comment - This change make sense to me. +1 lgtm, I will commit it if no objections
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 28s trunk passed
        +1 compile 0m 22s trunk passed with JDK v1.8.0_74
        +1 compile 0m 27s trunk passed with JDK v1.7.0_95
        +1 mvnsite 0m 30s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 javadoc 0m 27s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 32s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 21s the patch passed with JDK v1.8.0_74
        +1 javac 0m 21s the patch passed
        +1 compile 0m 24s the patch passed with JDK v1.7.0_95
        +1 javac 0m 24s the patch passed
        +1 mvnsite 0m 28s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) with tabs.
        +1 javadoc 0m 24s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 31s the patch passed with JDK v1.7.0_95
        +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        17m 2s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796845/0001-YARN-4897.patch
        JIRA Issue YARN-4897
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit
        uname Linux 938707b4d6e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5092c94
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10956/artifact/patchprocess/whitespace-tabs.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10956/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10956/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 28s trunk passed +1 compile 0m 22s trunk passed with JDK v1.8.0_74 +1 compile 0m 27s trunk passed with JDK v1.7.0_95 +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 12s trunk passed +1 javadoc 0m 27s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 32s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 26s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_74 +1 javac 0m 21s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_95 +1 javac 0m 24s the patch passed +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) with tabs. +1 javadoc 0m 24s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 31s the patch passed with JDK v1.7.0_95 +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 17m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796845/0001-YARN-4897.patch JIRA Issue YARN-4897 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit uname Linux 938707b4d6e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5092c94 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10956/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10956/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/10956/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch for the same. Please do review

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch for the same. Please do review
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attached snapshot for the same.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attached snapshot for the same.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Would you attach screen shot to know which page has been affected? It is just to know about how UI looks..

        Show
        rohithsharma Rohith Sharma K S added a comment - Would you attach screen shot to know which page has been affected? It is just to know about how UI looks..

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development