[YARN-489] Setter of xxxxPBImpl doesn't really set the collection, but append its items to an existing collection

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Zhijie Shen
• Reporter: Zhijie Shen
• Created: 19/Mar/13 18:47
• Updated: 06/Sep/13 00:57
• Resolved: 06/Sep/13 00:57

Description

For example, AllocateResponsePBImpl#setAllocatedContainers, AllocateResponsePBImpl#setUpdatedNodes, CountersPBImpl#addAllCounterGroups and ContainerLaunchContextPBImpl#setLocalResources.

In particular, in ContainerLaunchContextPBImpl, setters will clean up the list before appending the items.

We need to investigate the issue to ensure all cases of collection setter are handled correctly.

Issue Links

• duplicates: YARN-555 ContainerLaunchContext is buggy when it comes to setter methods on a new instance
• relates to: YARN-609 Fix synchronization issues in APIs which take in lists