Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4862

Handle duplicate completed containers in RMNodeImpl

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: resourcemanager
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      As per comment from Sharad Agarwal, there should be safe guard for duplicated container status in RMNodeImpl before creating UpdatedContainerInfo.
      Or else in heavily loaded cluster where event processing is gradually slow, if any duplicated container are sent to RM(may be bug in NM also), there is significant impact that RMNodImpl always create UpdatedContainerInfo for duplicated containers. This result in increase in the heap memory and causes problem like YARN-4852.
      This is an optimization for issue kind YARN-4852

      1. 0001-YARN-4862.patch
        6 kB
        Rohith Sharma K S
      2. 0002-YARN-4862.patch
        6 kB
        Rohith Sharma K S
      3. 0003-YARN-4862.patch
        7 kB
        Rohith Sharma K S
      4. YARN-4862-004.patch
        13 kB
        Rohith Sharma K S
      5. YARN-4862-005.patch
        13 kB
        Rohith Sharma K S
      6. YARN-4862-006.patch
        14 kB
        Rohith Sharma K S

        Activity

        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating the patch for handling duplicated containers. Kindly review the patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Updating the patch for handling duplicated containers. Kindly review the patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 17s trunk passed
        +1 compile 0m 36s trunk passed with JDK v1.8.0_74
        +1 compile 0m 30s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 12s trunk passed
        +1 javadoc 0m 28s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 27s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_74
        +1 javac 0m 36s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_95
        +1 javac 0m 28s the patch passed
        -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 1 new + 46 unchanged - 1 fixed = 47 total (was 47)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 23s the patch passed
        +1 javadoc 0m 27s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95
        -1 unit 76m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        -1 unit 76m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        171m 18s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795182/0001-YARN-4862.patch
        JIRA Issue YARN-4862
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 535ca1c1f300 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 19b645c
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10864/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10864/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 17s trunk passed +1 compile 0m 36s trunk passed with JDK v1.8.0_74 +1 compile 0m 30s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 12s trunk passed +1 javadoc 0m 28s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 27s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 31s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_74 +1 javac 0m 36s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_95 +1 javac 0m 28s the patch passed -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 1 new + 46 unchanged - 1 fixed = 47 total (was 47) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 27s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95 -1 unit 76m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. -1 unit 76m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 171m 18s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795182/0001-YARN-4862.patch JIRA Issue YARN-4862 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 535ca1c1f300 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19b645c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10864/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10864/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10864/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the same patch fixing checkstyle errors

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the same patch fixing checkstyle errors
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 43s trunk passed
        +1 compile 0m 32s trunk passed with JDK v1.8.0_77
        +1 compile 0m 32s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 12s trunk passed
        +1 javadoc 0m 21s trunk passed with JDK v1.8.0_77
        +1 javadoc 0m 28s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.8.0_77
        +1 javac 0m 27s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_95
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 0 new + 46 unchanged - 1 fixed = 46 total (was 47)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 20s the patch passed with JDK v1.8.0_77
        +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95
        -1 unit 76m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
        -1 unit 49m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        144m 32s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
          hadoop.yarn.webapp.TestRMWithCSRFFilter
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798459/0002-YARN-4862.patch
        JIRA Issue YARN-4862
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6c416f65622a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 35f0770
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11059/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11059/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 43s trunk passed +1 compile 0m 32s trunk passed with JDK v1.8.0_77 +1 compile 0m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 12s trunk passed +1 javadoc 0m 21s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 28s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 32s the patch passed +1 compile 0m 27s the patch passed with JDK v1.8.0_77 +1 javac 0m 27s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_95 +1 javac 0m 28s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 0 new + 46 unchanged - 1 fixed = 46 total (was 47) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95 -1 unit 76m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. -1 unit 49m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 144m 32s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels   hadoop.yarn.webapp.TestRMWithCSRFFilter   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798459/0002-YARN-4862.patch JIRA Issue YARN-4862 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6c416f65622a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 35f0770 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11059/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11059/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11059/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        I think the RMNodeImpl#completedContainers could be leaked. e.g. If the container is completed at RM side (preempted etc.),
        1. container may be first added into RMNodeImpl#containersToBeRemovedFromNM.
        2. At this point completedContainers does not have the container, so completedContainers.removeAll(this.containersToBeRemovedFromNM); does nothing,
        3. later on, container finished at NM and gets added into the completedContainers, and this container will remain there forever.

        Show
        jianhe Jian He added a comment - I think the RMNodeImpl#completedContainers could be leaked. e.g. If the container is completed at RM side (preempted etc.), 1. container may be first added into RMNodeImpl#containersToBeRemovedFromNM. 2. At this point completedContainers does not have the container, so completedContainers.removeAll(this.containersToBeRemovedFromNM); does nothing, 3. later on, container finished at NM and gets added into the completedContainers, and this container will remain there forever.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Hi Jian He, apologies for long delay!!
        In a positive case flow is NM inform RM that container is finished intern RM wait for AM to pull finished containers and after AM pulls the finished containers RM informs to NM that remove from NMContext.

        In preemption flow,

        1. RM preempt the containers which inform RMContainerImpl first that KillContainer.
        2. In KillContainer#transistion, informs the RMnodeImpl to cleanUpTheContainers and also inform RMAppAttemptImpl that add to JustFinishedContainers so that let AM pulls finished containers on next heartbeat. It is assumedthat containersToCleanUp will be sent first to NM and later containersToBeRemovedFromNM is sent next heartbeat of NM.

        I see that there is potential container leak in NodeManager module in preemption flow. There can be situation where {{containersToCleanUp }} and {{containersToBeRemovedFromNM }} can go together in the same heartbeat. If same containerId details sent to NM together, then container will never-ever removed in NMContext.

        CC :/ Jason Lowe Basically I feel it is bug from RM that should inform back to RMNode if rmContainer is null whenever finished containers are received from NM

        And for this JIRA, I think current patch approach should be fine if we fix the above mentioned issue. Thoughts?

        Show
        rohithsharma Rohith Sharma K S added a comment - Hi Jian He , apologies for long delay!! In a positive case flow is NM inform RM that container is finished intern RM wait for AM to pull finished containers and after AM pulls the finished containers RM informs to NM that remove from NMContext. In preemption flow, RM preempt the containers which inform RMContainerImpl first that KillContainer. In KillContainer#transistion, informs the RMnodeImpl to cleanUpTheContainers and also inform RMAppAttemptImpl that add to JustFinishedContainers so that let AM pulls finished containers on next heartbeat. It is assumedthat containersToCleanUp will be sent first to NM and later containersToBeRemovedFromNM is sent next heartbeat of NM. I see that there is potential container leak in NodeManager module in preemption flow. There can be situation where {{containersToCleanUp }} and {{containersToBeRemovedFromNM }} can go together in the same heartbeat. If same containerId details sent to NM together, then container will never-ever removed in NMContext. CC :/ Jason Lowe Basically I feel it is bug from RM that should inform back to RMNode if rmContainer is null whenever finished containers are received from NM And for this JIRA, I think current patch approach should be fine if we fix the above mentioned issue. Thoughts?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s YARN-4862 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798459/0002-YARN-4862.patch
        JIRA Issue YARN-4862
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12089/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-4862 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798459/0002-YARN-4862.patch JIRA Issue YARN-4862 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12089/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I have created YARN-5279 for tracking separately.

        Show
        rohithsharma Rohith Sharma K S added a comment - I have created YARN-5279 for tracking separately.
        Hide
        jlowe Jason Lowe added a comment -

        Agree that the RM needs to inform the NM to stop tracking a container if the RM receives an update for a container it doesn't know about. As a sanity-check we could put in some logic similar to what was done in YARN-5197. Then the RM can detect when the NM has stopped reporting a completed container so we can also remove it from the completedContainers tracking set. That should prevent any leak from occurring in the new set even if the RM somehow fails to send the container removal event to the RMNodeImpl.

        Besides the suggestion above to harden against leaks, another minor comment on the patch:

                if (!completedContainers.contains(containerId)) {
                  completedContainers.add(containerId);
                  newlyCompletedContainers.add(remoteContainer);
                }
        

        The above should be simplified to the following to avoid the double-lookup on the completedContainers set:

          if (completedContainers.add(containerId)) {
            newlyCompletedContainers.add(remoteContainer);
          }
        
        Show
        jlowe Jason Lowe added a comment - Agree that the RM needs to inform the NM to stop tracking a container if the RM receives an update for a container it doesn't know about. As a sanity-check we could put in some logic similar to what was done in YARN-5197 . Then the RM can detect when the NM has stopped reporting a completed container so we can also remove it from the completedContainers tracking set. That should prevent any leak from occurring in the new set even if the RM somehow fails to send the container removal event to the RMNodeImpl. Besides the suggestion above to harden against leaks, another minor comment on the patch: if (!completedContainers.contains(containerId)) { completedContainers.add(containerId); newlyCompletedContainers.add(remoteContainer); } The above should be simplified to the following to avoid the double-lookup on the completedContainers set: if (completedContainers.add(containerId)) { newlyCompletedContainers.add(remoteContainer); }
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Jason Lowe for looking into the issue and for the comments on the patch!

        In order to prevent any leak from new set i.e completedContainers, currently I do not see any other way to do sanity check other than fixing YARN-5279. If any alternatives it can be achieved, kindly suggest.

        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Jason Lowe for looking into the issue and for the comments on the patch! In order to prevent any leak from new set i.e completedContainers, currently I do not see any other way to do sanity check other than fixing YARN-5279 . If any alternatives it can be achieved, kindly suggest.
        Hide
        jlowe Jason Lowe added a comment -

        What I was thinking is a similar idea to YARN-5197. We can track the completed containers in the completedContainers set and also count how many completed containers are in the status report. If the number of completed containers in the report doesn't match the completedContainers set size then we know there's at least one completed container the RM is tracking that the NM is no longer reporting. Then we can walk the set and figure out which ones we need to discard. Essentially this is what YARN-5197 does for the launchedContainers set, comparing the number of running containers in the report against the number of containers in the tracking set. When they're off then we know the RM is out of sync with the NM and needs correcting.

        Show
        jlowe Jason Lowe added a comment - What I was thinking is a similar idea to YARN-5197 . We can track the completed containers in the completedContainers set and also count how many completed containers are in the status report. If the number of completed containers in the report doesn't match the completedContainers set size then we know there's at least one completed container the RM is tracking that the NM is no longer reporting. Then we can walk the set and figure out which ones we need to discard. Essentially this is what YARN-5197 does for the launchedContainers set, comparing the number of running containers in the report against the number of containers in the tracking set. When they're off then we know the RM is out of sync with the NM and needs correcting.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Jason for your suggestion

        I see there are two different scenarios where container leak can occur after this JIRA patch.

        1. NM forgets the completed-container status. -> Similar to YARN-5197 approach can be done to handle this leak.
        2. (RM forgets) YarnScheduler clears RMcontainer details because of preemption. As a result scheduler(RMContainer) inform RMNodeImpl to add into containersToCleanUp list. And also RMAppAttempt inform RMnodeImpl to add into containersToBeRemovedFromNM after AM pulls finished containers. If NM-RM heartbeat interval is more then AM-RM heartbeat interval, then it is sure that both can go together in the same nodeHeartbeat response. If this is the case, then YARN-5279 issue occurs and also NM keeps sending these container status as completed to NM. At this point, RM start tracking the completedContainers but never get purged from the completedContainer set.
        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Jason for your suggestion I see there are two different scenarios where container leak can occur after this JIRA patch. NM forgets the completed-container status. -> Similar to YARN-5197 approach can be done to handle this leak. (RM forgets) YarnScheduler clears RMcontainer details because of preemption. As a result scheduler(RMContainer) inform RMNodeImpl to add into containersToCleanUp list. And also RMAppAttempt inform RMnodeImpl to add into containersToBeRemovedFromNM after AM pulls finished containers. If NM-RM heartbeat interval is more then AM-RM heartbeat interval, then it is sure that both can go together in the same nodeHeartbeat response. If this is the case, then YARN-5279 issue occurs and also NM keeps sending these container status as completed to NM. At this point, RM start tracking the completedContainers but never get purged from the completedContainer set.
        Hide
        sunilg Sunil G added a comment -

        Agreeing to the discussion here.

        Basically its better that we do a sanity like in YARN-5197 always. It can help to minimize the risk of leaking or syncing NM and RM in a much better way. I also do not see this as a performance bottleneck, as we are operating on a small set of running vs finished for a node per heartbeat.

        Reg YARN-5279, Interestingly preemption was trying to make use of KILL_CONTAINER event for killing a container forcefully from RM. Even though preemption module informed AM that a container to be preempted, in case of AMs which doesnt handle this preemption messages, RM is forced to kill with KILL_CONTAINER.
        So I think we need not have to inform attempt immediately in KILL_CONTAINER. Rather we can add to RMNodeImpl's containersToCleanUp list, and can wait for NM to report back with completed container list. This will slowup the cleanup in case if we preempt AM container, but may be more cleaner. Will this be fine for preemption scenario? Thoughts.

        Show
        sunilg Sunil G added a comment - Agreeing to the discussion here. Basically its better that we do a sanity like in YARN-5197 always. It can help to minimize the risk of leaking or syncing NM and RM in a much better way. I also do not see this as a performance bottleneck, as we are operating on a small set of running vs finished for a node per heartbeat. Reg YARN-5279 , Interestingly preemption was trying to make use of KILL_CONTAINER event for killing a container forcefully from RM. Even though preemption module informed AM that a container to be preempted, in case of AMs which doesnt handle this preemption messages, RM is forced to kill with KILL_CONTAINER. So I think we need not have to inform attempt immediately in KILL_CONTAINER. Rather we can add to RMNodeImpl's containersToCleanUp list, and can wait for NM to report back with completed container list. This will slowup the cleanup in case if we preempt AM container, but may be more cleaner. Will this be fine for preemption scenario? Thoughts.
        Hide
        jlowe Jason Lowe added a comment -

        I also do not see this as a performance bottleneck, as we are operating on a small set of running vs finished for a node per heartbeat.

        The performance impact is basically zero because we're not doing that small set comparison most of the time. The only thing we do all the time is simply increment of an integer during a scan of the node report that was already being done before, then simply comparing that integer to the size of a hash set which is also super cheap. Only when those numbers are different do we do the diff between the set and the report. For YARN-5197, those numbers will always be the same unless the NM failed to report a container completion which should be a rare event. The performance hit is going to be very hard to detect in practice because of the cheap conditional check up-front before doing the full diff.

        This will slowup the cleanup in case if we preempt AM container, but may be more cleaner.

        It won't slow how fast the container will be killed, if that's what you mean by "cleanup case." Only the NM can kill it anyway, and it won't know to do so until it subsequently heartbeats. It will slow down how fast the RM will re-schedule the resource associated with the preempted container, since it will wait until the NM confirms the container completion before releasing the resources within the scheduler bookkeeping and re-allocating them. This means today the RM can, and does, accidentally overcommit nodes because it considers the resources free before they actually are free. Filed YARN-5290 as we've recently seen this in practice on some of our clusters.

        Show
        jlowe Jason Lowe added a comment - I also do not see this as a performance bottleneck, as we are operating on a small set of running vs finished for a node per heartbeat. The performance impact is basically zero because we're not doing that small set comparison most of the time. The only thing we do all the time is simply increment of an integer during a scan of the node report that was already being done before, then simply comparing that integer to the size of a hash set which is also super cheap. Only when those numbers are different do we do the diff between the set and the report. For YARN-5197 , those numbers will always be the same unless the NM failed to report a container completion which should be a rare event. The performance hit is going to be very hard to detect in practice because of the cheap conditional check up-front before doing the full diff. This will slowup the cleanup in case if we preempt AM container, but may be more cleaner. It won't slow how fast the container will be killed, if that's what you mean by "cleanup case." Only the NM can kill it anyway, and it won't know to do so until it subsequently heartbeats. It will slow down how fast the RM will re-schedule the resource associated with the preempted container, since it will wait until the NM confirms the container completion before releasing the resources within the scheduler bookkeeping and re-allocating them. This means today the RM can, and does, accidentally overcommit nodes because it considers the resources free before they actually are free. Filed YARN-5290 as we've recently seen this in practice on some of our clusters.
        Hide
        sunilg Sunil G added a comment -

        It will slow down how fast the RM will re-schedule the resource associated with the preempted container

        Thanks Jason Lowe. Yes, I meant the slowness in cleaning up a container in RM. Currently KILL_CONTAINER call flow is doing over commit if the container is really running in NM. YARN-5290 is correct in this context as RM is overcommitting few resources before its actually is available.
        On the same note, preemption also fire KILL_CONTAINER events for those containers which are in ACQUIRED etc. In such cases, we can cleanup immediately. You have mentioned this corner case already in YARN-5290. I think this can be handled.

        Show
        sunilg Sunil G added a comment - It will slow down how fast the RM will re-schedule the resource associated with the preempted container Thanks Jason Lowe . Yes, I meant the slowness in cleaning up a container in RM. Currently KILL_CONTAINER call flow is doing over commit if the container is really running in NM. YARN-5290 is correct in this context as RM is overcommitting few resources before its actually is available. On the same note, preemption also fire KILL_CONTAINER events for those containers which are in ACQUIRED etc. In such cases, we can cleanup immediately. You have mentioned this corner case already in YARN-5290 . I think this can be handled.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating the rebased patch fixing review comments from Jason.

        This JIRA is depends upon YARN-5279 for avoiding leak in the new set completedContainers.

        I rechecked the 2 scenarios mainly discussed in earlier comments

        1. RM(scheduler) forgets container details (YARN-5279). In this case, for any unknown completed container reported from NodeManager, scheduler will intimate back to RMNodeImpl that these containers are no more maintained by scheduler, so inform to NodeManager to remove from NMContext. This event avoids leak in new set completedContainer which clears containers that are acknowledging to NM in heartbeat response
        2. NM forgets to send completedContainer
          1. NM do not send completedContainer at once also. It is nothing but YARN-5197.
          2. NM sends completed container in one heartbeat and later it forgets it in next heartbeat. In this case, RMNodeImpl#completedContainer need not worry about leak because if once completed container has been sent then RM keep track of these containers. Even though NM forgets sending later, completedContainer will be cleared when RM acknowledge back to NM in heartbeat to remove from context.
        Show
        rohithsharma Rohith Sharma K S added a comment - Updating the rebased patch fixing review comments from Jason. This JIRA is depends upon YARN-5279 for avoiding leak in the new set completedContainers. I rechecked the 2 scenarios mainly discussed in earlier comments RM(scheduler) forgets container details ( YARN-5279 ). In this case, for any unknown completed container reported from NodeManager, scheduler will intimate back to RMNodeImpl that these containers are no more maintained by scheduler, so inform to NodeManager to remove from NMContext. This event avoids leak in new set completedContainer which clears containers that are acknowledging to NM in heartbeat response NM forgets to send completedContainer NM do not send completedContainer at once also. It is nothing but YARN-5197 . NM sends completed container in one heartbeat and later it forgets it in next heartbeat. In this case, RMNodeImpl#completedContainer need not worry about leak because if once completed container has been sent then RM keep track of these containers. Even though NM forgets sending later, completedContainer will be cleared when RM acknowledge back to NM in heartbeat to remove from context.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 24s trunk passed
        +1 compile 0m 31s trunk passed
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 53s trunk passed
        +1 javadoc 0m 19s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139)
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 58s the patch passed
        +1 javadoc 0m 16s the patch passed
        -1 unit 32m 25s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        46m 3s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
          hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814027/0003-YARN-4862.patch
        JIRA Issue YARN-4862
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 947167378a83 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4fd37ee
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12150/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12150/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 24s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 53s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed -1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 58s the patch passed +1 javadoc 0m 16s the patch passed -1 unit 32m 25s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 46m 3s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart   hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814027/0003-YARN-4862.patch JIRA Issue YARN-4862 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 947167378a83 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4fd37ee Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12150/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12150/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12150/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 31s trunk passed
        +1 compile 0m 31s trunk passed
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 0s trunk passed
        +1 javadoc 0m 23s trunk passed
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139)
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 58s the patch passed
        +1 javadoc 0m 16s the patch passed
        +1 unit 32m 26s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        46m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch
        JIRA Issue YARN-4862
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ffd6dbe07ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4fd37ee
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12151/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12151/artifact/patchprocess/whitespace-eol.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12151/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12151/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 31s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 58s the patch passed +1 javadoc 0m 16s the patch passed +1 unit 32m 26s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 46m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch JIRA Issue YARN-4862 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ffd6dbe07ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4fd37ee Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12151/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12151/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12151/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12151/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Hi Rohith Sharma K S
        Thanks for the patch. I have one doubt on completedContainers, I think we might need to make it thread safe.

        Show
        sunilg Sunil G added a comment - Hi Rohith Sharma K S Thanks for the patch. I have one doubt on completedContainers , I think we might need to make it thread safe.
        Hide
        sunilg Sunil G added a comment -

        Sorry. I think I overlooked. updateNodeHeartbeatResponseForCleanup is internally modifying all these variables under writelock.

        Show
        sunilg Sunil G added a comment - Sorry. I think I overlooked. updateNodeHeartbeatResponseForCleanup is internally modifying all these variables under writelock.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 0m 33s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 42s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 55s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 1m 2s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 34m 49s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        50m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4862
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 163150d3e6a9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ac35ee9
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13556/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13556/artifact/patchprocess/whitespace-eol.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13556/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13556/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 8s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 42s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 55s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 2s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 34m 49s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 50m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4862 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 163150d3e6a9 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac35ee9 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13556/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13556/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13556/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13556/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 latest patch lgtm. I can cleanup the whitespace and checkstyle nits on commit.

        It doesn't look like this change is ready to go even without YARN-5279, Rohith Sharma K S please confirm.

        Show
        jlowe Jason Lowe added a comment - +1 latest patch lgtm. I can cleanup the whitespace and checkstyle nits on commit. It doesn't look like this change is ready to go even without YARN-5279 , Rohith Sharma K S please confirm.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 38s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 57s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139)
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 findbugs 1m 1s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 38m 12s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        53m 15s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4862
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fad3b211da0c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ac35ee9
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13557/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13557/artifact/patchprocess/whitespace-eol.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13557/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13557/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 42s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 1s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 38m 12s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 53m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4862 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814032/0003-YARN-4862.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fad3b211da0c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac35ee9 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13557/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/13557/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13557/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13557/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        This patch is independent of YARN-5279. I will remove link and lets handle independently.

        Show
        rohithsharma Rohith Sharma K S added a comment - This patch is independent of YARN-5279 . I will remove link and lets handle independently.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I request please hold down committing this patch. Actually I was discovered some scenarios where completedContainers list get never removed which would lead to leak in completedContainers gradually. I will confirm those scenarios.

        Show
        rohithsharma Rohith Sharma K S added a comment - I request please hold down committing this patch. Actually I was discovered some scenarios where completedContainers list get never removed which would lead to leak in completedContainers gradually. I will confirm those scenarios.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating patch handling completed container leak. The scenario is when ever RM do not track containers, in RMNodeImpl conatainerId get added to completedContainer list. Since this container is not tracked by RM, RM just ignore it. This causes leak in completedContainer.

        I have updated patch fixing the leak by triggering an event to RMNodeImpl. This is basically same issue as YARN-5279. But I would prefer to add in this JIRA itself rather than committing separately.

        As part of latest patch attached, I have combined patch of YARN-5279 too. With respect addressing comments of YARN-5279, I have not created different event class and name as per comment. I have reused same event type FINISHED_CONTAINERS_PULLED_BY_AM and its class RMNodeFinishedContainersPulledByAMEvent. It is because, both event are same to RMNodeImpl. May be I can change existing event type FINISHED_CONTAINERS_PULLED_BY_AM to CONTAINERS_TO_BE_REMOVED_FROM_NM. Thoughts?

        Show
        rohithsharma Rohith Sharma K S added a comment - Updating patch handling completed container leak. The scenario is when ever RM do not track containers, in RMNodeImpl conatainerId get added to completedContainer list. Since this container is not tracked by RM, RM just ignore it. This causes leak in completedContainer. I have updated patch fixing the leak by triggering an event to RMNodeImpl. This is basically same issue as YARN-5279 . But I would prefer to add in this JIRA itself rather than committing separately. As part of latest patch attached, I have combined patch of YARN-5279 too. With respect addressing comments of YARN-5279 , I have not created different event class and name as per comment. I have reused same event type FINISHED_CONTAINERS_PULLED_BY_AM and its class RMNodeFinishedContainersPulledByAMEvent. It is because, both event are same to RMNodeImpl. May be I can change existing event type FINISHED_CONTAINERS_PULLED_BY_AM to CONTAINERS_TO_BE_REMOVED_FROM_NM. Thoughts?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 12s trunk passed
        +1 compile 0m 35s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 3s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 2s the patch passed
        -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 938 unchanged - 0 fixed = 939 total (was 938)
        -1 unit 38m 23s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        54m 13s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestResourceTrackerService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4862
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835972/YARN-4862-004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cfafdf32ec47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aa3cab1
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13665/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13665/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 12s trunk passed +1 compile 0m 35s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 3s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed -0 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 2s the patch passed -1 javadoc 0m 18s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 1 new + 938 unchanged - 0 fixed = 939 total (was 938) -1 unit 38m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 54m 13s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestResourceTrackerService Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4862 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835972/YARN-4862-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cfafdf32ec47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aa3cab1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13665/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13665/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13665/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Getting close. The javadoc nit needs to be fixed. I assume the test failures are unrelated but have not verified that.

        Show
        jlowe Jason Lowe added a comment - Getting close. The javadoc nit needs to be fixed. I assume the test failures are unrelated but have not verified that.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated patch fixing java doc and test failure.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated patch fixing java doc and test failure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 56s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 2s the patch passed
        +1 javadoc 0m 18s the patch passed
        -1 unit 38m 44s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        53m 54s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestResourceTrackerService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4862
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836336/YARN-4862-005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 28705d9fac57 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5b577f4
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13733/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13733/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13733/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13733/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 42s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 2s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 38m 44s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 53m 54s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestResourceTrackerService Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4862 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836336/YARN-4862-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 28705d9fac57 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5b577f4 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13733/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13733/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13733/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13733/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Test failures are unrelated to this patch.

        Show
        rohithsharma Rohith Sharma K S added a comment - Test failures are unrelated to this patch.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the update!

        Containers were removed from the test but the comments weren't updated, so now the comments don't match the code.

            // Create 2 unknown containers tracked by NM
        ...
              // asserting for 2 since two unknown containers status has been sent
              if (containersToBeRemovedFromNM == 1) {
        

        I'm also curious why a sleep was added instead of something like a drainEvents call.

        Show
        jlowe Jason Lowe added a comment - Thanks for the update! Containers were removed from the test but the comments weren't updated, so now the comments don't match the code. // Create 2 unknown containers tracked by NM ... // asserting for 2 since two unknown containers status has been sent if (containersToBeRemovedFromNM == 1) { I'm also curious why a sleep was added instead of something like a drainEvents call.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I'm also curious why a sleep was added instead of something like a drainEvents call.

        I used draiEvents in attached patch.

        I retained sending 2 container status in node heart beat to verification. There are 2 scenarios can occur in reality when NM reports container status to RM.

        1. Application belongs to container-status are tracked by RM. Here, RMNodeImpl triggers an event to scheduler as completed containers.
        2. Application belongs to container-status are NOT tracked by RM. Here, RMNodeImpl trigger event to scheduler with only one container as completed. Rest all containers belong to this application will be skipped.

        In earlier patches, test case was sending container status with 2nd scenario. But in latest patch, I have modified test code for 1st scenario.

        I would think still we can optimize such that if application is not tracked by RM then RMNodeImpl need not to report even one completed container to scheduler at all. May be I am open to handle it in this JIRA or create new JIRA optimize this scenario.

        Show
        rohithsharma Rohith Sharma K S added a comment - I'm also curious why a sleep was added instead of something like a drainEvents call. I used draiEvents in attached patch. I retained sending 2 container status in node heart beat to verification. There are 2 scenarios can occur in reality when NM reports container status to RM. Application belongs to container-status are tracked by RM. Here, RMNodeImpl triggers an event to scheduler as completed containers. Application belongs to container-status are NOT tracked by RM. Here, RMNodeImpl trigger event to scheduler with only one container as completed. Rest all containers belong to this application will be skipped. In earlier patches, test case was sending container status with 2nd scenario. But in latest patch, I have modified test code for 1st scenario. I would think still we can optimize such that if application is not tracked by RM then RMNodeImpl need not to report even one completed container to scheduler at all. May be I am open to handle it in this JIRA or create new JIRA optimize this scenario.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 54s trunk passed
        +1 compile 0m 32s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 38s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 0m 57s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 29s the patch passed
        +1 javac 0m 29s the patch passed
        -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 1s the patch passed
        +1 javadoc 0m 18s the patch passed
        -1 unit 38m 53s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        54m 19s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4862
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836518/YARN-4862-006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux df2fae1822c5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cb5cc0d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13749/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13749/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13749/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13749/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed -0 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 200 unchanged - 1 fixed = 201 total (was 201) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 38m 53s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 54m 19s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4862 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836518/YARN-4862-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux df2fae1822c5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cb5cc0d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13749/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13749/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13749/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13749/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        I don't think we need to worry too much about optimizing the case where the RM doesn't know about an application corresponding to a NM container status since that should be a relatively rare event.

        Test failure is unrelated and tracked by YARN-5548.

        +1 for the latest patch. I'll commit this later today if there are no objections.

        Show
        jlowe Jason Lowe added a comment - I don't think we need to worry too much about optimizing the case where the RM doesn't know about an application corresponding to a NM container status since that should be a relatively rare event. Test failure is unrelated and tracked by YARN-5548 . +1 for the latest patch. I'll commit this later today if there are no objections.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to Rohith Sharma K S for the contribution and to Jian He and Sunil G for additional review! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks to Rohith Sharma K S for the contribution and to Jian He and Sunil G for additional review! I committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10762 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10762/)
        YARN-4862. Handle duplicate completed containers in RMNodeImpl. (jlowe: rev 352cbaa7a54a94bad2bed131d6a250c5b21a7701)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10762 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10762/ ) YARN-4862 . Handle duplicate completed containers in RMNodeImpl. (jlowe: rev 352cbaa7a54a94bad2bed131d6a250c5b21a7701) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMNodeTransitions.java
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Jason Lowe for the reviewing and committing patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Jason Lowe for the reviewing and committing patch

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            rohithsharma Rohith Sharma K S
          • Votes:
            0 Vote for this issue
            Watchers:
            16 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development