Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      https://issues.apache.org/jira/browse/YARN-4526 removed the public constructor on SystemClock - making it an incompatible change.

      cc Karthik Kambatla

      1. YARN-4816.1.txt
        0.8 kB
        Siddharth Seth

        Activity

        Hide
        sseth Siddharth Seth added a comment -

        Trivial patch. Re-introduces the public constructor and marks it as deprecated.

        Karthik Kambatla - please review.

        Show
        sseth Siddharth Seth added a comment - Trivial patch. Re-introduces the public constructor and marks it as deprecated. Karthik Kambatla - please review.
        Hide
        kasha Karthik Kambatla added a comment -

        My bad. Thanks for catching and fixing this, Sid.

        +1.

        Show
        kasha Karthik Kambatla added a comment - My bad. Thanks for catching and fixing this, Sid. +1.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 55s Docker mode activated.
        0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 21s trunk passed
        +1 compile 0m 26s trunk passed with JDK v1.8.0_74
        +1 compile 0m 28s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 33s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 33s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 36s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 29s the patch passed
        +1 compile 0m 22s the patch passed with JDK v1.8.0_74
        +1 javac 0m 22s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.7.0_95
        +1 javac 0m 27s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 32s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 29s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95
        +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        33m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793414/YARN-4816.1.txt
        JIRA Issue YARN-4816
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 861cdb1cdb41 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 19e8f07
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10779/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10779/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 55s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 21s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_74 +1 compile 0m 28s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 33s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 33s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 36s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 29s the patch passed +1 compile 0m 22s the patch passed with JDK v1.8.0_74 +1 javac 0m 22s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_95 +1 javac 0m 27s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 29s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 32s the patch passed with JDK v1.7.0_95 +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 33m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793414/YARN-4816.1.txt JIRA Issue YARN-4816 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 861cdb1cdb41 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19e8f07 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10779/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/10779/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sseth Siddharth Seth added a comment -

        Thanks for the review Karthik Kambatla - committing to master and branch-2.

        Show
        sseth Siddharth Seth added a comment - Thanks for the review Karthik Kambatla - committing to master and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9462 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9462/)
        YARN-4816. Fix incompatible change in SystemClock. (sseth: rev eba66a64d28b50a660d6f537c767677f5fa0f7ea)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/SystemClock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9462 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9462/ ) YARN-4816 . Fix incompatible change in SystemClock. (sseth: rev eba66a64d28b50a660d6f537c767677f5fa0f7ea) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/SystemClock.java

          People

          • Assignee:
            sseth Siddharth Seth
            Reporter:
            sseth Siddharth Seth
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development