Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Distributed shell app gets stuck on stopping containers after App completes with the following exception

      app log
      15/12/10 14:52:20 INFO distributedshell.ApplicationMaster: Application completed. Stopping running containers
      15/12/10 14:52:20 WARN ipc.Client: Exception encountered while connecting to the server : java.nio.channels.ClosedByInterruptException
      
      1. YARN-4794-branch-2.7.patch
        5 kB
        Jian He
      2. YARN-4794.2.patch
        4 kB
        Jian He
      3. YARN-4794.1.patch
        4 kB
        Jian He

        Activity

        Hide
        jianhe Jian He added a comment -

        there's a dead lock in NMClient.
        In NMClientImpl#startContainer, it first grabs "startingContainer" lock, and if exception happens, it calls removeStartedContainer which grabs "NMClient" lock.
        On the other hand, if NMClient is stopping in the meantime, it first calls cleanupRunningContainers which takes "NMClient" lock, and then calls stopContainer which takes "container" lock. Thus, deadlock.

        Show
        jianhe Jian He added a comment - there's a dead lock in NMClient. In NMClientImpl#startContainer, it first grabs "startingContainer" lock, and if exception happens, it calls removeStartedContainer which grabs "NMClient" lock. On the other hand, if NMClient is stopping in the meantime, it first calls cleanupRunningContainers which takes "NMClient" lock, and then calls stopContainer which takes "container" lock. Thus, deadlock.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Tentatively targeting all unreleased versions..

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Tentatively targeting all unreleased versions..
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Jian He, is it possible to get this in within a week for 2.7.3? Let me know if you need any help. Tx

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Jian He , is it possible to get this in within a week for 2.7.3? Let me know if you need any help. Tx
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 53s trunk passed
        +1 compile 0m 15s trunk passed with JDK v1.8.0_77
        +1 compile 0m 18s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 34s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_77
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_77
        +1 javac 0m 13s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.7.0_95
        +1 javac 0m 17s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 43s the patch passed
        +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_95
        -1 unit 66m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_77.
        -1 unit 66m 39s hadoop-yarn-client in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        146m 33s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy
          hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy
          hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797399/YARN-4794.1.patch
        JIRA Issue YARN-4794
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 934268296c79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aede8c1
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10977/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10977/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 53s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_77 +1 compile 0m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 34s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 19s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_77 +1 javac 0m 13s the patch passed +1 compile 0m 17s the patch passed with JDK v1.7.0_95 +1 javac 0m 17s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 43s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_95 -1 unit 66m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_77. -1 unit 66m 39s hadoop-yarn-client in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 146m 33s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_95 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797399/YARN-4794.1.patch JIRA Issue YARN-4794 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 934268296c79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aede8c1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10977/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10977/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/10977/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Jian He for working on the patch. Nice issue!!

        Making clear to folks before giving +1 that since NMClientImpl is annotated as @Private, removing protected method should not be any compatible issue.

        +1 LGTM, if there is no objections I will commit it EOD

        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Jian He for working on the patch. Nice issue!! Making clear to folks before giving +1 that since NMClientImpl is annotated as @Private, removing protected method should not be any compatible issue. +1 LGTM, if there is no objections I will commit it EOD
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the summary to reflect actual issue.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the summary to reflect actual issue.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committing shortly

        Show
        rohithsharma Rohith Sharma K S added a comment - committing shortly
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Jian He Can you check test failures please. I checked the test case logs, it seems unrelated to this patch. Can you also check and confirm please.

        Show
        rohithsharma Rohith Sharma K S added a comment - Jian He Can you check test failures please. I checked the test case logs, it seems unrelated to this patch. Can you also check and confirm please.
        Hide
        jianhe Jian He added a comment -

        Rohith Sharma K S, thanks for reviewing , I checked the tests, they are not related.

        Show
        jianhe Jian He added a comment - Rohith Sharma K S , thanks for reviewing , I checked the tests, they are not related.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        The patch looks fine to me too.

        Not related to this patch but I see both startedContainers.putIfAbsent() and startedContainers.put() in addStartingContainer(), that is duplicated and unnecesary?

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - The patch looks fine to me too. Not related to this patch but I see both startedContainers.putIfAbsent() and startedContainers.put() in addStartingContainer(), that is duplicated and unnecesary?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Yes, this can be optimized!

        Show
        rohithsharma Rohith Sharma K S added a comment - Yes, this can be optimized!
        Hide
        jianhe Jian He added a comment -

        thanks for the reviews,
        removed that duplicate call

        Show
        jianhe Jian He added a comment - thanks for the reviews, removed that duplicate call
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 47s trunk passed
        +1 compile 0m 15s trunk passed with JDK v1.8.0_77
        +1 compile 0m 18s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 36s trunk passed
        +1 javadoc 0m 14s trunk passed with JDK v1.8.0_77
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.8.0_77
        +1 javac 0m 14s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_95
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 45s the patch passed
        +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77
        +1 javadoc 0m 15s the patch passed with JDK v1.7.0_95
        -1 unit 66m 11s hadoop-yarn-client in the patch failed with JDK v1.8.0_77.
        -1 unit 66m 29s hadoop-yarn-client in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        146m 5s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.yarn.client.TestGetGroups
          hadoop.yarn.client.api.impl.TestAMRMProxy
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.client.TestGetGroups
          hadoop.yarn.client.api.impl.TestAMRMProxy
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798065/YARN-4794.2.patch
        JIRA Issue YARN-4794
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 590cb7aa4f6a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 44bbc50
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11038/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11038/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 47s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_77 +1 compile 0m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 36s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_77 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_77 +1 javac 0m 14s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_95 +1 javac 0m 16s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_77 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_95 -1 unit 66m 11s hadoop-yarn-client in the patch failed with JDK v1.8.0_77. -1 unit 66m 29s hadoop-yarn-client in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 146m 5s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.api.impl.TestAMRMProxy JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_95 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.api.impl.TestAMRMProxy JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798065/YARN-4794.2.patch JIRA Issue YARN-4794 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 590cb7aa4f6a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44bbc50 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11038/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11038/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/11038/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 lgtm, will commit it..

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 lgtm, will commit it..
        Hide
        rohithsharma Rohith Sharma K S added a comment - - edited

        Committed to trunk/branch-2/branch-2.8
        Patch do not apply in branch-2.7 cleanly. Jian He would you provide branch-2.7 patch too?

        Show
        rohithsharma Rohith Sharma K S added a comment - - edited Committed to trunk/branch-2/branch-2.8 Patch do not apply in branch-2.7 cleanly. Jian He would you provide branch-2.7 patch too?
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9594 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9594/)
        YARN-4794. Deadlock in NMClientImpl. Contributed by Jian He. (rohithsharmaks: rev ff722bbbdfaf9715643507628e94ece26d904b9d)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9594 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9594/ ) YARN-4794 . Deadlock in NMClientImpl. Contributed by Jian He. (rohithsharmaks: rev ff722bbbdfaf9715643507628e94ece26d904b9d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java
        Hide
        jianhe Jian He added a comment -

        branch-2.7 patch attached, Rohith Sharma K S, could you review ? thanks !

        Show
        jianhe Jian He added a comment - branch-2.7 patch attached, Rohith Sharma K S , could you review ? thanks !
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 lgtm.

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 lgtm.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to branch-2.7 also.. thanks Jian He for the patch!! thanks Vinod Kumar Vavilapalli for additional review

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to branch-2.7 also.. thanks Jian He for the patch!! thanks Vinod Kumar Vavilapalli for additional review
        Hide
        ctrezzo Chris Trezzo added a comment -

        Adding 2.6.5 to the target versions with the intention of backporting this to branch-2.6. Please let me know if you think otherwise. Thanks!

        Show
        ctrezzo Chris Trezzo added a comment - Adding 2.6.5 to the target versions with the intention of backporting this to branch-2.6. Please let me know if you think otherwise. Thanks!
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        sjlee0 Sangjin Lee added a comment -

        Cherry-picked it to 2.6.5. Slightly modified the 2.7 version to avoid using the java 1.7 style (exception multi-catch).

        Show
        sjlee0 Sangjin Lee added a comment - Cherry-picked it to 2.6.5. Slightly modified the 2.7 version to avoid using the java 1.7 style (exception multi-catch).
        Hide
        ctrezzo Chris Trezzo added a comment -

        Thanks!

        Show
        ctrezzo Chris Trezzo added a comment - Thanks!

          People

          • Assignee:
            jianhe Jian He
            Reporter:
            ssathish@hortonworks.com Sumana Sathish
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development