Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4748

ApplicationHistoryManagerOnTimelineStore should not swallow exceptions on generateApplicationReport

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We're directly swallowing AuthorizationExceptions and ApplicationAttemptNotFoundExceptions when generating application reports. we should at least mark down the exception before proceed with default values (which will assign app attempt id to -1).

        Activity

        Hide
        gtCarrera9 Li Lu added a comment -

        Quick patch to log exceptions when generating application reports.

        Show
        gtCarrera9 Li Lu added a comment - Quick patch to log exceptions when generating application reports.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 7s trunk passed
        +1 compile 0m 17s trunk passed with JDK v1.8.0_72
        +1 compile 0m 19s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 26s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 16s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.8.0_72
        +1 javac 0m 14s the patch passed
        +1 compile 0m 15s the patch passed with JDK v1.7.0_95
        +1 javac 0m 15s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 47s the patch passed
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95
        +1 unit 3m 46s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72.
        +1 unit 3m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        21m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790597/YARN-4748-trunk.001.patch
        JIRA Issue YARN-4748
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 47095768758f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0fa54d4
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10668/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10668/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 7s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_72 +1 compile 0m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 16s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_72 +1 javac 0m 14s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_95 +1 javac 0m 15s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 47s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95 +1 unit 3m 46s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_72. +1 unit 3m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 21m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790597/YARN-4748-trunk.001.patch JIRA Issue YARN-4748 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 47095768758f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fa54d4 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10668/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/10668/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        +1

        Show
        jianhe Jian He added a comment - +1
        Hide
        jianhe Jian He added a comment -

        Committed to trunk, branch-2, branch-2.8, thanks Li !

        Show
        jianhe Jian He added a comment - Committed to trunk, branch-2, branch-2.8, thanks Li !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9397/)
        YARN-4748. ApplicationHistoryManagerOnTimelineStore should not swallow (jianhe: rev d93c22ec274b1a0f29609217039b80732886fed7)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9397 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9397/ ) YARN-4748 . ApplicationHistoryManagerOnTimelineStore should not swallow (jianhe: rev d93c22ec274b1a0f29609217039b80732886fed7) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryManagerOnTimelineStore.java

          People

          • Assignee:
            gtCarrera9 Li Lu
            Reporter:
            gtCarrera9 Li Lu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development