[YARN-4746] yarn web services should convert parse failures of appId, appAttemptId and containerId to 400

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: webapp
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Steve Loughran
• Created: 29/Feb/16 17:04
• Updated: 30/Aug/16 01:05
• Resolved: 04/Apr/16 12:56

Description

I'm seeing somewhere in the WS API tests of mine an error with exception conversion of a bad app ID sent in as an argument to a GET. I know it's in ATS, but a scan of the core RM web services implies a same problem

WebServices.parseApplicationId() uses ConverterUtils.toApplicationId to convert an argument; this throws IllegalArgumentException, which is then handled somewhere by jetty as a 500 error.

In fact, it's a bad argument, which should be handled by returning a 400. This can be done by catching the raised argument and explicitly converting it