Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4746

yarn web services should convert parse failures of appId, appAttemptId and containerId to 400

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: webapp
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      I'm seeing somewhere in the WS API tests of mine an error with exception conversion of a bad app ID sent in as an argument to a GET. I know it's in ATS, but a scan of the core RM web services implies a same problem

      WebServices.parseApplicationId() uses ConverterUtils.toApplicationId to convert an argument; this throws IllegalArgumentException, which is then handled somewhere by jetty as a 500 error.

      In fact, it's a bad argument, which should be handled by returning a 400. This can be done by catching the raised argument and explicitly converting it

      1. 0001-YARN-4746.patch
        1 kB
        Bibin A Chundatt
      2. 0002-YARN-4746.patch
        9 kB
        Bibin A Chundatt
      3. 0003-YARN-4746.patch
        13 kB
        Bibin A Chundatt
      4. 0003-YARN-4746.patch
        13 kB
        Bibin A Chundatt
      5. 0004-YARN-4746.patch
        16 kB
        Bibin A Chundatt
      6. 0005-YARN-4746.patch
        17 kB
        Bibin A Chundatt

        Activity

        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Bibin A Chundatt for your contributions and Steve Loughran for the reviews. Have committed the patch to Branch 2.8, Branch 2 and trunk.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Bibin A Chundatt for your contributions and Steve Loughran for the reviews. Have committed the patch to Branch 2.8, Branch 2 and trunk.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9548 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9548/)
        YARN-4746. yarn web services should convert parse failures of appId, (naganarasimha_gr: rev 5092c94195a63bd2c3e36d5a74b4c061cea1b847)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesApps.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ConverterUtils.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9548 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9548/ ) YARN-4746 . yarn web services should convert parse failures of appId, (naganarasimha_gr: rev 5092c94195a63bd2c3e36d5a74b4c061cea1b847) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ConverterUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/NMWebServices.java
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the patch Bibin A Chundatt, Overall modifications seems to be fine. Will wait for few hours if no more comments will commit it.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Bibin A Chundatt , Overall modifications seems to be fine. Will wait for few hours if no more comments will commit it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 6m 51s trunk passed
        +1 compile 1m 49s trunk passed with JDK v1.8.0_74
        +1 compile 2m 10s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 mvneclipse 0m 59s trunk passed
        +1 findbugs 3m 49s trunk passed
        +1 javadoc 1m 25s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 42s the patch passed
        +1 compile 1m 50s the patch passed with JDK v1.8.0_74
        +1 javac 1m 50s the patch passed
        +1 compile 2m 10s the patch passed with JDK v1.7.0_95
        +1 javac 2m 10s the patch passed
        +1 checkstyle 0m 34s the patch passed
        +1 mvnsite 1m 54s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 29s the patch passed
        +1 javadoc 1m 20s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 40s the patch passed with JDK v1.7.0_95
        +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74.
        +1 unit 9m 13s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_74.
        -1 unit 64m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95.
        +1 unit 9m 39s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
        -1 unit 65m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        194m 8s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestRMAdminService
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestRMAdminService
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796651/0005-YARN-4746.patch
        JIRA Issue YARN-4746
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ee5f25fc5c32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 81d04ca
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10938/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10938/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 51s trunk passed +1 compile 1m 49s trunk passed with JDK v1.8.0_74 +1 compile 2m 10s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 59s trunk passed +1 findbugs 3m 49s trunk passed +1 javadoc 1m 25s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 1m 50s the patch passed with JDK v1.8.0_74 +1 javac 1m 50s the patch passed +1 compile 2m 10s the patch passed with JDK v1.7.0_95 +1 javac 2m 10s the patch passed +1 checkstyle 0m 34s the patch passed +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 29s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 40s the patch passed with JDK v1.7.0_95 +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 0m 22s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. +1 unit 9m 13s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_74. -1 unit 64m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 39s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. -1 unit 65m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 194m 8s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796651/0005-YARN-4746.patch JIRA Issue YARN-4746 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ee5f25fc5c32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81d04ca Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10938/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10938/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10938/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        NGarla_Unused
        Thnk you for reviewing patch.
        Uploading new patch after handling Varun Saxena comments .

        Show
        bibinchundatt Bibin A Chundatt added a comment - NGarla_Unused Thnk you for reviewing patch. Uploading new patch after handling Varun Saxena comments .
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Bibin A Chundatt,
        Overall approach seems to be fine but seems like Varun Saxena's comment is not considered. Can you take a look at it ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Bibin A Chundatt , Overall approach seems to be fine but seems like Varun Saxena 's comment is not considered. Can you take a look at it ?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Steve Loughran
        Could you please review of latest patch attached.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Steve Loughran Could you please review of latest patch attached.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 41s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 6m 59s trunk passed
        +1 compile 1m 53s trunk passed with JDK v1.8.0_74
        +1 compile 2m 16s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 2m 1s trunk passed
        +1 mvneclipse 0m 57s trunk passed
        +1 findbugs 3m 51s trunk passed
        +1 javadoc 1m 27s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 41s the patch passed
        +1 compile 1m 41s the patch passed with JDK v1.8.0_74
        +1 javac 1m 41s the patch passed
        +1 compile 2m 5s the patch passed with JDK v1.7.0_95
        +1 javac 2m 5s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 1m 47s the patch passed
        +1 mvneclipse 0m 47s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 29s the patch passed
        +1 javadoc 1m 18s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 39s the patch passed with JDK v1.7.0_95
        +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74.
        +1 unit 9m 10s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_74.
        -1 unit 73m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95.
        +1 unit 9m 50s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
        -1 unit 74m 38s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        223m 6s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794229/0004-YARN-4746.patch
        JIRA Issue YARN-4746
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 20eb5294bf47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fbe3e86
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10818/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10818/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 41s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 59s trunk passed +1 compile 1m 53s trunk passed with JDK v1.8.0_74 +1 compile 2m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 35s trunk passed +1 mvnsite 2m 1s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 3m 51s trunk passed +1 javadoc 1m 27s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 1m 41s the patch passed with JDK v1.8.0_74 +1 javac 1m 41s the patch passed +1 compile 2m 5s the patch passed with JDK v1.7.0_95 +1 javac 2m 5s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 29s the patch passed +1 javadoc 1m 18s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 39s the patch passed with JDK v1.7.0_95 +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. +1 unit 9m 10s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_74. -1 unit 73m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 26s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 50s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. -1 unit 74m 38s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 223m 6s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794229/0004-YARN-4746.patch JIRA Issue YARN-4746 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 20eb5294bf47 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fbe3e86 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10818/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10818/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10818/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching latest patch with testcase fix

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching latest patch with testcase fix
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 7m 16s trunk passed
        +1 compile 2m 41s trunk passed with JDK v1.8.0_74
        +1 compile 2m 15s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 35s trunk passed
        +1 mvneclipse 0m 38s trunk passed
        +1 findbugs 3m 7s trunk passed
        +1 javadoc 1m 22s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 23s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 2m 29s the patch passed with JDK v1.8.0_74
        +1 javac 2m 29s the patch passed
        +1 compile 2m 15s the patch passed with JDK v1.7.0_95
        +1 javac 2m 15s the patch passed
        +1 checkstyle 0m 32s the patch passed
        +1 mvnsite 1m 30s the patch passed
        +1 mvneclipse 0m 34s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 44s the patch passed
        +1 javadoc 1m 19s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 22s the patch passed with JDK v1.7.0_95
        +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        -1 unit 9m 44s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74.
        -1 unit 75m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        -1 unit 9m 53s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 unit 76m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        213m 56s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794117/0003-YARN-4746.patch
        JIRA Issue YARN-4746
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 84d3e3dcca4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dc951e6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10816/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10816/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 7m 16s trunk passed +1 compile 2m 41s trunk passed with JDK v1.8.0_74 +1 compile 2m 15s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 38s trunk passed +1 findbugs 3m 7s trunk passed +1 javadoc 1m 22s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 23s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 2m 29s the patch passed with JDK v1.8.0_74 +1 javac 2m 29s the patch passed +1 compile 2m 15s the patch passed with JDK v1.7.0_95 +1 javac 2m 15s the patch passed +1 checkstyle 0m 32s the patch passed +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 44s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 22s the patch passed with JDK v1.7.0_95 +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 9m 44s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74. -1 unit 75m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 9m 53s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 unit 76m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 213m 56s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794117/0003-YARN-4746.patch JIRA Issue YARN-4746 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 84d3e3dcca4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dc951e6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10816/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10816/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10816/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch after testcase fix

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch after testcase fix
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 7m 18s trunk passed
        +1 compile 2m 7s trunk passed with JDK v1.8.0_74
        +1 compile 2m 19s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 1m 43s trunk passed
        +1 mvneclipse 0m 42s trunk passed
        +1 findbugs 3m 19s trunk passed
        +1 javadoc 1m 13s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 35s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 1m 58s the patch passed with JDK v1.8.0_74
        +1 javac 1m 58s the patch passed
        +1 compile 2m 18s the patch passed with JDK v1.7.0_95
        +1 javac 2m 18s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 1m 39s the patch passed
        +1 mvneclipse 0m 36s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 5s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 27s the patch passed with JDK v1.7.0_95
        +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74.
        -1 unit 67m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        -1 unit 9m 26s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 unit 69m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        198m 38s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794052/0003-YARN-4746.patch
        JIRA Issue YARN-4746
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f4dcdfabb06e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dc951e6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10811/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10811/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 7m 18s trunk passed +1 compile 2m 7s trunk passed with JDK v1.8.0_74 +1 compile 2m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 3m 19s trunk passed +1 javadoc 1m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 35s trunk passed with JDK v1.7.0_95 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 1m 58s the patch passed with JDK v1.8.0_74 +1 javac 1m 58s the patch passed +1 compile 2m 18s the patch passed with JDK v1.7.0_95 +1 javac 2m 18s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 27s the patch passed with JDK v1.7.0_95 +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74. -1 unit 67m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 9m 26s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 unit 69m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 198m 38s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794052/0003-YARN-4746.patch JIRA Issue YARN-4746 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f4dcdfabb06e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dc951e6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10811/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10811/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10811/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Steve Loughran
        Thanks you for review.Uploading patch with below changes

        1. testInvalidAppAttempts corrected to check invalid attempt earlier was checking invalid appId
        2. Moved parse validation for applicationID to WebAppUtil and re-factoring done
          Please do review
        Show
        bibinchundatt Bibin A Chundatt added a comment - Steve Loughran Thanks you for review.Uploading patch with below changes testInvalidAppAttempts corrected to check invalid attempt earlier was checking invalid appId Moved parse validation for applicationID to WebAppUtil and re-factoring done Please do review
        Hide
        stevel@apache.org Steve Loughran added a comment -

        looks reasonable.

        Given all uses of the conversion in these pages now look like:

        try {
              id = ConverterUtils.toApplicationId(recordFactory, appId);
            } catch (IllegalArgumentException e) {
              throw new BadRequestException(e);
            }
        
        

        could we factor this out into something which always does this for the web UIs?

        Show
        stevel@apache.org Steve Loughran added a comment - looks reasonable. Given all uses of the conversion in these pages now look like: try { id = ConverterUtils.toApplicationId(recordFactory, appId); } catch (IllegalArgumentException e) { throw new BadRequestException(e); } could we factor this out into something which always does this for the web UIs?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 51s Maven dependency ordering for branch
        +1 mvninstall 7m 12s trunk passed
        +1 compile 1m 52s trunk passed with JDK v1.8.0_74
        +1 compile 2m 10s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 1m 57s trunk passed
        +1 mvneclipse 0m 55s trunk passed
        +1 findbugs 3m 45s trunk passed
        +1 javadoc 1m 24s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 40s the patch passed
        +1 compile 1m 46s the patch passed with JDK v1.8.0_74
        +1 javac 1m 46s the patch passed
        +1 compile 2m 10s the patch passed with JDK v1.7.0_95
        +1 javac 2m 10s the patch passed
        +1 checkstyle 0m 31s the patch passed
        +1 mvnsite 1m 52s the patch passed
        +1 mvneclipse 0m 47s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 1m 17s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 35s the patch passed with JDK v1.7.0_95
        +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74.
        -1 unit 9m 4s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74.
        -1 unit 76m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
        +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95.
        -1 unit 10m 15s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
        -1 unit 74m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        216m 32s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          new org.apache.hadoop.yarn.webapp.BadRequestException(Throwable) not thrown in org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices.getNodeApp(String) At NMWebServices.java:org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices.getNodeApp(String) At NMWebServices.java:[line 150]
        JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
        JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792032/0002-YARN-4746.patch
        JIRA Issue YARN-4746
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4b0dd1d8a7f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 02a250d
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10802/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10802/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 7m 12s trunk passed +1 compile 1m 52s trunk passed with JDK v1.8.0_74 +1 compile 2m 10s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 3m 45s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 40s the patch passed +1 compile 1m 46s the patch passed with JDK v1.8.0_74 +1 javac 1m 46s the patch passed +1 compile 2m 10s the patch passed with JDK v1.7.0_95 +1 javac 2m 10s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 3s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 17s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_95 +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. -1 unit 9m 4s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_74. -1 unit 76m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 2m 31s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. -1 unit 10m 15s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. -1 unit 74m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 216m 32s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager   new org.apache.hadoop.yarn.webapp.BadRequestException(Throwable) not thrown in org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices.getNodeApp(String) At NMWebServices.java:org.apache.hadoop.yarn.server.nodemanager.webapp.NMWebServices.getNodeApp(String) At NMWebServices.java: [line 150] JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792032/0002-YARN-4746.patch JIRA Issue YARN-4746 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4b0dd1d8a7f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 02a250d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-YARN-Build/10802/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10802/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10802/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch for review after updation.

        1. BadRequestException with cause addded
        2. ConverterUtils#toApplicationId updated validation was missing
        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch for review after updation. BadRequestException with cause addded ConverterUtils#toApplicationId updated validation was missing
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Having played with this some more, I think it's probably wise to review all the uses of the conversion logic in the codebase; bits of it appear to assume that the return value is null if there's no match, rather than anything else.

        regarding the patch, -1 I'm afraid. Loses the stack. Look at what I've done in YARN-4696 here

        Show
        stevel@apache.org Steve Loughran added a comment - Having played with this some more, I think it's probably wise to review all the uses of the conversion logic in the codebase; bits of it appear to assume that the return value is null if there's no match, rather than anything else. regarding the patch, -1 I'm afraid. Loses the stack. Look at what I've done in YARN-4696 here
        Hide
        varun_saxena Varun Saxena added a comment -

        Bibin A Chundatt, although its not mentioned as this part of this JIRA but I think we can extend this check to app attempt id and container id as well.

        Show
        varun_saxena Varun Saxena added a comment - Bibin A Chundatt , although its not mentioned as this part of this JIRA but I think we can extend this check to app attempt id and container id as well.

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development