Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4732

*ProcessTree classes have too many whitespace issues

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed
    • Release Note:

      Description

      *ProcessTree classes have too many whitespace issues - extra newlines between methods, spaces in empty lines etc.

      1. YARN-4732.1.patch
        12 kB
        Gabor Liptak

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9479 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9479/)
        YARN-4732. *ProcessTree classes have too many whitespace issues (kasha: rev 7fae4c68e6d599d0c01bb2cb2c8d5e52925b3e1e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestWindowsBasedProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsBasedProcessTree.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9479 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9479/ ) YARN-4732 . *ProcessTree classes have too many whitespace issues (kasha: rev 7fae4c68e6d599d0c01bb2cb2c8d5e52925b3e1e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestWindowsBasedProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestResourceCalculatorProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/WindowsBasedProcessTree.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestProcfsBasedProcessTree.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorProcessTree.java
        Hide
        kasha Karthik Kambatla added a comment -

        +1

        Thanks for your contribution, Gabor Liptak. Juts committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - +1 Thanks for your contribution, Gabor Liptak . Juts committed this to trunk and branch-2.
        Hide
        gliptak Gabor Liptak added a comment -

        Karthik Kambatla Any other changes you would like to see? Thanks

        Show
        gliptak Gabor Liptak added a comment - Karthik Kambatla Any other changes you would like to see? Thanks
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 1s Maven dependency ordering for branch
        +1 mvninstall 6m 50s trunk passed
        +1 compile 5m 46s trunk passed with JDK v1.8.0_74
        +1 compile 6m 35s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 4s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 2m 8s trunk passed
        +1 javadoc 0m 47s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 58s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 0m 51s the patch passed
        +1 compile 5m 45s the patch passed with JDK v1.8.0_74
        +1 javac 5m 45s the patch passed
        +1 compile 6m 40s the patch passed with JDK v1.7.0_95
        +1 javac 6m 40s the patch passed
        +1 checkstyle 1m 4s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 33s the patch passed
        +1 javadoc 0m 49s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 0s the patch passed with JDK v1.7.0_95
        +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 0s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        57m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792151/YARN-4732.1.patch
        JIRA Issue YARN-4732
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7761000401ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 55f73a1
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10731/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10731/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 1s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 5m 46s trunk passed with JDK v1.8.0_74 +1 compile 6m 35s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 8s trunk passed +1 javadoc 0m 47s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 58s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 0m 51s the patch passed +1 compile 5m 45s the patch passed with JDK v1.8.0_74 +1 javac 5m 45s the patch passed +1 compile 6m 40s the patch passed with JDK v1.7.0_95 +1 javac 6m 40s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 33s the patch passed +1 javadoc 0m 49s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 0s the patch passed with JDK v1.7.0_95 +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 2m 0s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_74. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 57m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792151/YARN-4732.1.patch JIRA Issue YARN-4732 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7761000401ed 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 55f73a1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10731/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10731/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            gliptak Gabor Liptak
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development