Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 0.23.7, 2.0.4-alpha, 3.0.0-alpha1
-
Fix Version/s: 0.23.7, 2.1.0-beta
-
Component/s: None
-
Labels:None
Description
coverage fix org.apache.hadoop.yarn.server.webproxy.amfilter
patch YARN-468-trunk.patch for trunk, branch-2, branch-0.23
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
The eclipse:eclipse failure looks like it is spurious. It failed before it ever reached code changed by the patch with no real indication as to why it failed. Just saying that you may need to turn on debugging to find it.
It works for me locally, so I kicked the build again. We will see what happens.
That being said the test changes look fine to me. I am +1 assuming Jenkins comes back OK still.
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12573308/YARN-468-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 tests included appear to have a timeout.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/513//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/513//console
This message is automatically generated.
Thanks Aleksey,
I put this into branch-2, branch-0.23 and trunk
Integrated in Hadoop-trunk-Commit #3469 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3469/)
YARN-468. coverage fix for org.apache.hadoop.yarn.server.webproxy.amfilter (Aleksey Gorshkov via bobby) (Revision 1456458)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456458
Files :
- /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
- /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
Integrated in Hadoop-Yarn-trunk #156 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/156/)
YARN-468. coverage fix for org.apache.hadoop.yarn.server.webproxy.amfilter (Aleksey Gorshkov via bobby) (Revision 1456458)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456458
Files :
- /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
- /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
Integrated in Hadoop-Hdfs-0.23-Build #554 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/554/)
svn merge -c 1456458 FIXES: YARN-468. coverage fix for org.apache.hadoop.yarn.server.webproxy.amfilter (Aleksey Gorshkov via bobby) (Revision 1456463)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456463
Files :
- /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt
- /hadoop/common/branches/branch-0.23/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
Integrated in Hadoop-Hdfs-trunk #1345 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1345/)
YARN-468. coverage fix for org.apache.hadoop.yarn.server.webproxy.amfilter (Aleksey Gorshkov via bobby) (Revision 1456458)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456458
Files :
- /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
- /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
Integrated in Hadoop-Mapreduce-trunk #1373 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1373/)
YARN-468. coverage fix for org.apache.hadoop.yarn.server.webproxy.amfilter (Aleksey Gorshkov via bobby) (Revision 1456458)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1456458
Files :
- /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
- /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12573308/YARN-468-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 tests included appear to have a timeout.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/504//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/504//console
This message is automatically generated.