Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4657

Javadoc comment is broken for Resources.multiplyByAndAddTo()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The comment is

        /**
         * Multiply @param rhs by @param by, and add the result to @param lhs
         * without creating any new {@link Resource} object
         */
      

      The @param tag can't be used that way. {@code rhs} is the correct thing to do.

      1. YARN-4657.001.patch
        0.9 kB
        Daniel Templeton

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9543 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9543/)
        YARN-4657. Javadoc comment is broken for Resources.multiplyByAndAddTo(). (kasha: rev 81d04cae41182808ace5d86cdac7e4d71871eb1e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/Resources.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9543 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9543/ ) YARN-4657 . Javadoc comment is broken for Resources.multiplyByAndAddTo(). (kasha: rev 81d04cae41182808ace5d86cdac7e4d71871eb1e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/resource/Resources.java
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for reporting and fixing this, Daniel.

        Just committed to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - Thanks for reporting and fixing this, Daniel. Just committed to trunk and branch-2.
        Hide
        kasha Karthik Kambatla added a comment -

        +1, checking this in.

        Show
        kasha Karthik Kambatla added a comment - +1, checking this in.
        Hide
        templedf Daniel Templeton added a comment -

        No new tests needed for a comment change.

        Show
        templedf Daniel Templeton added a comment - No new tests needed for a comment change.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 26s trunk passed
        +1 compile 0m 43s trunk passed with JDK v1.8.0_74
        +1 compile 0m 35s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 41s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 39s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 34s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_74
        +1 javac 0m 36s the patch passed
        +1 compile 0m 33s the patch passed with JDK v1.7.0_95
        +1 javac 0m 33s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 42s the patch passed
        +1 javadoc 0m 43s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 43s the patch passed with JDK v1.7.0_95
        +1 unit 2m 38s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 39s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        27m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794611/YARN-4657.001.patch
        JIRA Issue YARN-4657
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8660ca28e21e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e7ed05e
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10840/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10840/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 26s trunk passed +1 compile 0m 43s trunk passed with JDK v1.8.0_74 +1 compile 0m 35s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 41s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 39s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 34s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_74 +1 javac 0m 36s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_95 +1 javac 0m 33s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 43s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 43s the patch passed with JDK v1.7.0_95 +1 unit 2m 38s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 2m 39s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 27m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794611/YARN-4657.001.patch JIRA Issue YARN-4657 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8660ca28e21e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e7ed05e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10840/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/10840/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            templedf Daniel Templeton
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development