Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4648

Move preemption related tests from TestFairScheduler to TestFairSchedulerPreemption

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. YARN-4648.03.patch
      112 kB
      Kai Sasaki
    2. YARN-4648.02.patch
      111 kB
      Kai Sasaki
    3. YARN-4648.01.patch
      111 kB
      Kai Sasaki

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 19s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
      0 mvndep 0m 10s Maven dependency ordering for branch
      +1 mvninstall 7m 26s trunk passed
      +1 compile 0m 29s trunk passed with JDK v1.8.0_72
      +1 compile 0m 33s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 20s trunk passed
      +1 mvnsite 0m 37s trunk passed
      +1 mvneclipse 0m 16s trunk passed
      +1 findbugs 1m 9s trunk passed
      +1 javadoc 0m 27s trunk passed with JDK v1.8.0_72
      +1 javadoc 0m 31s trunk passed with JDK v1.7.0_95
      0 mvndep 0m 8s Maven dependency ordering for patch
      +1 mvninstall 0m 34s the patch passed
      +1 compile 0m 30s the patch passed with JDK v1.8.0_72
      +1 javac 0m 30s the patch passed
      +1 compile 0m 30s the patch passed with JDK v1.7.0_95
      +1 javac 0m 30s the patch passed
      +1 checkstyle 0m 16s the patch passed
      +1 mvnsite 0m 33s the patch passed
      +1 mvneclipse 0m 13s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 23s the patch passed
      +1 javadoc 0m 22s the patch passed with JDK v1.8.0_72
      +1 javadoc 0m 26s the patch passed with JDK v1.7.0_95
      -1 unit 67m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
      -1 unit 69m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 21s Patch does not generate ASF License warnings.
      155m 40s



      Reason Tests
      JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786646/YARN-4648.01.patch
      JIRA Issue YARN-4648
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux ba61bd0cbbfa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / cfa8513
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10515/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Max memory used 77MB
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10515/console
      Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 26s trunk passed +1 compile 0m 29s trunk passed with JDK v1.8.0_72 +1 compile 0m 33s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 27s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 31s trunk passed with JDK v1.7.0_95 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 34s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_72 +1 javac 0m 30s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_95 +1 javac 0m 30s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 22s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 26s the patch passed with JDK v1.7.0_95 -1 unit 67m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. -1 unit 69m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 155m 40s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786646/YARN-4648.01.patch JIRA Issue YARN-4648 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ba61bd0cbbfa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cfa8513 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10515/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10515/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-YARN-Build/10515/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      lewuathe Kai Sasaki added a comment -

      Tsuyoshi Ozawa The failed tests cannot be reproduced. Could you rerun them please?

      Show
      lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa The failed tests cannot be reproduced. Could you rerun them please?
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Kai Sasaki, sure, I'll check this on this weekend.

      Show
      ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki , sure, I'll check this on this weekend.
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Kai Sasaki thank you for your contribution. I looked over your patch. I have some comments, so could you address them?

        private void startResourceManagerWithoutThreshold() {
      

      Why not reusing startResourceManager(threshold) with the threshold larger than 1.0f?

      +import org.apache.hadoop.yarn.api.records.*;
      

      Please don't use * import.

      Show
      ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki thank you for your contribution. I looked over your patch. I have some comments, so could you address them? private void startResourceManagerWithoutThreshold() { Why not reusing startResourceManager(threshold) with the threshold larger than 1.0f? + import org.apache.hadoop.yarn.api.records.*; Please don't use * import.
      Hide
      lewuathe Kai Sasaki added a comment -

      Tsuyoshi Ozawa Thank you so much for reviewing!

      Why not reusing startResourceManager(threshold) with the threshold larger than 1.0f?
      

      The main different between startResourceManager and startResourceManagerWithoutThreshold seems to be Yarn configuration and initialization of FairScheduler. We can reuse startResourceManager but I'm afraid we cannot be confident not to break existing test code. If a code used by TestFairSchedulerPreemption (in the case startResourceManagerWithoutThreshold) is changed, we cannot say the test code after moving checks the same functionality as before moving. Can we change initialization code?

      Show
      lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa Thank you so much for reviewing! Why not reusing startResourceManager(threshold) with the threshold larger than 1.0f? The main different between startResourceManager and startResourceManagerWithoutThreshold seems to be Yarn configuration and initialization of FairScheduler . We can reuse startResourceManager but I'm afraid we cannot be confident not to break existing test code. If a code used by TestFairSchedulerPreemption (in the case startResourceManagerWithoutThreshold ) is changed, we cannot say the test code after moving checks the same functionality as before moving. Can we change initialization code?
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Kai Sasaki Instead of changing the sequence of initialization, how about changing the name of startResourceManagerWithoutThreshold? I think the name of startResourceManagerWithoutThreshold looks confusing since
      the behaviour of the method named startResourceManagerWithoutThreshold() looks to be equals to startResourceManager(1.1f). What do you think?

      Show
      ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki Instead of changing the sequence of initialization, how about changing the name of startResourceManagerWithoutThreshold ? I think the name of startResourceManagerWithoutThreshold looks confusing since the behaviour of the method named startResourceManagerWithoutThreshold() looks to be equals to startResourceManager(1.1f). What do you think?
      Hide
      lewuathe Kai Sasaki added a comment -

      Tsuyoshi Ozawa It's reasonable. I'll update. Thanks!

      Show
      lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa It's reasonable. I'll update. Thanks!
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 14s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
      +1 mvninstall 6m 42s trunk passed
      +1 compile 0m 26s trunk passed with JDK v1.8.0_72
      +1 compile 0m 29s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 18s trunk passed
      +1 mvnsite 0m 35s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 5s trunk passed
      +1 javadoc 0m 20s trunk passed with JDK v1.8.0_72
      +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 29s the patch passed
      +1 compile 0m 23s the patch passed with JDK v1.8.0_72
      +1 javac 0m 23s the patch passed
      +1 compile 0m 25s the patch passed with JDK v1.7.0_95
      +1 javac 0m 25s the patch passed
      +1 checkstyle 0m 15s the patch passed
      +1 mvnsite 0m 31s the patch passed
      +1 mvneclipse 0m 13s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 13s the patch passed
      +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72
      +1 javadoc 0m 23s the patch passed with JDK v1.7.0_95
      -1 unit 70m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
      -1 unit 71m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 17s Patch does not generate ASF License warnings.
      158m 17s



      Reason Tests
      JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788055/YARN-4648.02.patch
      JIRA Issue YARN-4648
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux b51af266f295 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 4b0e59f
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10570/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10570/console
      Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 42s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_72 +1 compile 0m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 29s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_72 +1 javac 0m 23s the patch passed +1 compile 0m 25s the patch passed with JDK v1.7.0_95 +1 javac 0m 25s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 13s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_95 -1 unit 70m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. -1 unit 71m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 158m 17s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788055/YARN-4648.02.patch JIRA Issue YARN-4648 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b51af266f295 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b0e59f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10570/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10570/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10570/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Kai Sasaki Thank you for updating. Unfortunatelly, startResourceManagerForPreemptionTest is still confusing because the name of the class is TestFairSchedulerPreemption.

      My suggestion is to rename startResourceManager to startResourceManagerWithStubbedFairScheduler, and startResourceManagerForPreemptionTest to startResourceManagerWithRealFairScheduler. Do you have any better idea?

      Show
      ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki Thank you for updating. Unfortunatelly, startResourceManagerForPreemptionTest is still confusing because the name of the class is TestFairSchedulerPreemption. My suggestion is to rename startResourceManager to startResourceManagerWithStubbedFairScheduler, and startResourceManagerForPreemptionTest to startResourceManagerWithRealFairScheduler. Do you have any better idea?
      Hide
      lewuathe Kai Sasaki added a comment -

      Tsuyoshi Ozawa That naming much better, I also think. I'll update. Thanks!

      Show
      lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa That naming much better, I also think. I'll update. Thanks!
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 10m 42s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
      +1 mvninstall 7m 0s trunk passed
      +1 compile 0m 30s trunk passed with JDK v1.8.0_72
      +1 compile 0m 30s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 18s trunk passed
      +1 mvnsite 0m 34s trunk passed
      +1 mvneclipse 0m 15s trunk passed
      +1 findbugs 1m 5s trunk passed
      +1 javadoc 0m 23s trunk passed with JDK v1.8.0_72
      +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 29s the patch passed
      +1 compile 0m 27s the patch passed with JDK v1.8.0_72
      +1 javac 0m 27s the patch passed
      +1 compile 0m 27s the patch passed with JDK v1.7.0_95
      +1 javac 0m 27s the patch passed
      +1 checkstyle 0m 15s the patch passed
      +1 mvnsite 0m 32s the patch passed
      +1 mvneclipse 0m 12s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 15s the patch passed
      +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72
      +1 javadoc 0m 25s the patch passed with JDK v1.7.0_95
      -1 unit 67m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
      -1 unit 67m 46s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 18s Patch does not generate ASF License warnings.
      162m 43s



      Reason Tests
      JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788880/YARN-4648.03.patch
      JIRA Issue YARN-4648
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 295686f86f87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / d5abd29
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10592/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10592/console
      Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 42s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 0s trunk passed +1 compile 0m 30s trunk passed with JDK v1.8.0_72 +1 compile 0m 30s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 23s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 29s the patch passed +1 compile 0m 27s the patch passed with JDK v1.8.0_72 +1 javac 0m 27s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_95 +1 javac 0m 27s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 25s the patch passed with JDK v1.7.0_95 -1 unit 67m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. -1 unit 67m 46s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 162m 43s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788880/YARN-4648.03.patch JIRA Issue YARN-4648 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 295686f86f87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10592/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10592/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/10592/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      +1, checking this in.

      Show
      ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Note: The failures of TestClientRMTokens and TestAMAuthorization are tracked on HADOOP-12687. It's not related to the patch uploaded here.

      Show
      ozawa Tsuyoshi Ozawa added a comment - Note: The failures of TestClientRMTokens and TestAMAuthorization are tracked on HADOOP-12687 . It's not related to the patch uploaded here.
      Hide
      ozawa Tsuyoshi Ozawa added a comment -

      Committed this to trunk and branch-2. Thanks Kai Sasaki for your contribution!

      Show
      ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Kai Sasaki for your contribution!
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9349 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9349/)
      YARN-4648. Move preemption related tests from TestFairScheduler to (ozawa: rev 0e12114c9ccb0c6b16c258227a433b075418796e)

      • hadoop-yarn-project/CHANGES.txt
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairSchedulerPreemption.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9349 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9349/ ) YARN-4648 . Move preemption related tests from TestFairScheduler to (ozawa: rev 0e12114c9ccb0c6b16c258227a433b075418796e) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairSchedulerPreemption.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
      Hide
      lewuathe Kai Sasaki added a comment -

      Tsuyoshi Ozawa Thanks for reviewing!

      Show
      lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa Thanks for reviewing!

        People

        • Assignee:
          lewuathe Kai Sasaki
          Reporter:
          kasha Karthik Kambatla
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development