Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-2928 YARN Timeline Service v.2: alpha 1
  3. YARN-4644

TestRMRestart fails and findbugs issue in YARN-2928 branch

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: YARN-2928
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This was reported by YARN-4238 QA report. Refer to https://builds.apache.org/job/PreCommit-YARN-Build/10389/testReport/

      Error reported is as under :

      org.mockito.exceptions.verification.TooManyActualInvocations: 
      noOpSystemMetricPublisher.appCreated(
          <any>,
          <any>
      );
      Wanted 3 times:
      -> at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartGetApplicationList(TestRMRestart.java:955)
      But was 6 times. Undesired invocation:
      -> at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.recover(ResourceManager.java:1274)
      
      	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testRMRestartGetApplicationList(TestRMRestart.java:955)
      

      Failing because in RMAppImpl#recover, sendATSCreateEvent has been called twice.
      Has been introduced during rebase I guess.
      After removing the duplicate call, the test passes.

      There is a findbugs warning in resourcemanager in YARN-2928 branch as well. Fix it as part of this JIRA itself.

      DLS	Dead store to keepAliveApps in org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
      Bug type DLS_DEAD_LOCAL_STORE (click for details) 
      In class org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService
      In method org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
      Local variable named keepAliveApps
      At ResourceTrackerService.java:[line 486]
      

        Attachments

        1. YARN-4644-YARN-2928.01.patch
          1 kB
          Varun Saxena
        2. YARN-4644-YARN-2928.02.patch
          2 kB
          Varun Saxena

          Issue Links

            Activity

              People

              • Assignee:
                varun_saxena Varun Saxena
                Reporter:
                varun_saxena Varun Saxena
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: