Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
In Topcli support Apppriority
Attachments
Attachments
- 0003-YARN-4628.patch
- 3 kB
- Bibin Chundatt
- 0002-YARN-4628.patch
- 2 kB
- Bibin Chundatt
- 0001-YARN-4628.patch
- 3 kB
- Bibin Chundatt
Activity
Thanks for the patch bibinchundatt. Some minor fixes required -
1)
-import com.google.common.cache.Cache; -import com.google.common.cache.CacheBuilder; +import com.google.common.cache.Cache; +import com.google.common.cache.CacheBuilder; +
This change is not required.
2)
Rename priorityComparator to AppPriorityComparator
Also, it looks like the patch hasn't gone through Jenkins - can you please submit the patch for Jenkins once you make the changes?
Thank you for review comments. Attaching patch after handling comments
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 6m 45s | trunk passed |
+1 | compile | 0m 16s | trunk passed with JDK v1.8.0_72 |
+1 | compile | 0m 17s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 16s | trunk passed |
+1 | mvnsite | 0m 22s | trunk passed |
+1 | mvneclipse | 0m 13s | trunk passed |
+1 | findbugs | 0m 34s | trunk passed |
+1 | javadoc | 0m 18s | trunk passed with JDK v1.8.0_72 |
+1 | javadoc | 0m 17s | trunk passed with JDK v1.7.0_95 |
+1 | mvninstall | 0m 20s | the patch passed |
+1 | compile | 0m 19s | the patch passed with JDK v1.8.0_72 |
+1 | javac | 0m 19s | the patch passed |
+1 | compile | 0m 17s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 0m 17s | the patch passed |
-1 | checkstyle | 0m 12s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: patch generated 1 new + 151 unchanged - 0 fixed = 152 total (was 151) |
+1 | mvnsite | 0m 20s | the patch passed |
+1 | mvneclipse | 0m 10s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 0m 45s | the patch passed |
+1 | javadoc | 0m 13s | the patch passed with JDK v1.8.0_72 |
+1 | javadoc | 0m 14s | the patch passed with JDK v1.7.0_95 |
-1 | unit | 64m 29s | hadoop-yarn-client in the patch failed with JDK v1.8.0_72. |
-1 | unit | 64m 40s | hadoop-yarn-client in the patch failed with JDK v1.7.0_95. |
+1 | asflicense | 0m 18s | Patch does not generate ASF License warnings. |
142m 45s |
Reason | Tests |
---|---|
JDK v1.8.0_72 Failed junit tests | hadoop.yarn.client.TestGetGroups |
JDK v1.8.0_72 Timed out junit tests | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
org.apache.hadoop.yarn.client.api.impl.TestYarnClient | |
org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | |
org.apache.hadoop.yarn.client.api.impl.TestNMClient | |
JDK v1.7.0_95 Failed junit tests | hadoop.yarn.client.TestGetGroups |
JDK v1.7.0_95 Timed out junit tests | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
org.apache.hadoop.yarn.client.api.impl.TestYarnClient | |
org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | |
org.apache.hadoop.yarn.client.api.impl.TestNMClient |
This message was automatically generated.
Thanks for the patch bibinchundatt. Couple of things -
1)
priority = appReport.getPriority().getPriority();
appReport.getPriority() can return null - can you add a null check?
2) Can you run the unit tests on your machine to confirm if they're passing?
vvasudev
Thank you for review . Will handle the same and upload patch soon
Hi bibinchundatt
Whether this cli will show "Higher" priority at the top. (because current comparator is in ascending order) ?
Good point sunilg. Bibin, can you please change the comparator to address Sunil's comment?
Thanks for review comment.
By default if we are sorting on prority will be done in descending order since ascendingSort = false by default . (Higher priority first) .
if (ascendingSort) { Collections.sort(appsInfo, comparator); } else { Collections.sort(appsInfo, Collections.reverseOrder(comparator)); }
Also we do have option for reversing in in top cli.
vvasudev
Handled latest review comments too. Attaching lated patch. Please do review
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 7m 12s | trunk passed |
+1 | compile | 0m 17s | trunk passed with JDK v1.8.0_66 |
+1 | compile | 0m 19s | trunk passed with JDK v1.7.0_91 |
+1 | checkstyle | 0m 16s | trunk passed |
+1 | mvnsite | 0m 24s | trunk passed |
+1 | mvneclipse | 0m 13s | trunk passed |
+1 | findbugs | 0m 34s | trunk passed |
+1 | javadoc | 0m 15s | trunk passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 18s | trunk passed with JDK v1.7.0_91 |
+1 | mvninstall | 0m 19s | the patch passed |
+1 | compile | 0m 14s | the patch passed with JDK v1.8.0_66 |
+1 | javac | 0m 14s | the patch passed |
+1 | compile | 0m 17s | the patch passed with JDK v1.7.0_91 |
+1 | javac | 0m 17s | the patch passed |
-1 | checkstyle | 0m 13s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: patch generated 1 new + 151 unchanged - 0 fixed = 152 total (was 151) |
+1 | mvnsite | 0m 23s | the patch passed |
+1 | mvneclipse | 0m 11s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 0m 46s | the patch passed |
+1 | javadoc | 0m 13s | the patch passed with JDK v1.8.0_66 |
+1 | javadoc | 0m 15s | the patch passed with JDK v1.7.0_91 |
-1 | unit | 64m 38s | hadoop-yarn-client in the patch failed with JDK v1.8.0_66. |
-1 | unit | 64m 48s | hadoop-yarn-client in the patch failed with JDK v1.7.0_91. |
+1 | asflicense | 0m 19s | Patch does not generate ASF License warnings. |
143m 35s |
Reason | Tests |
---|---|
JDK v1.8.0_66 Failed junit tests | hadoop.yarn.client.TestGetGroups |
JDK v1.8.0_66 Timed out junit tests | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | |
org.apache.hadoop.yarn.client.api.impl.TestYarnClient | |
org.apache.hadoop.yarn.client.api.impl.TestNMClient | |
JDK v1.7.0_91 Failed junit tests | hadoop.yarn.client.TestGetGroups |
JDK v1.7.0_91 Timed out junit tests | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
org.apache.hadoop.yarn.client.api.impl.TestAMRMClient | |
org.apache.hadoop.yarn.client.api.impl.TestYarnClient | |
org.apache.hadoop.yarn.client.api.impl.TestNMClient |
This message was automatically generated.
+1. Committed to trunk and branch-2 with a minor modification - changed "#PRIOR" to "PRIOR".
Thanks bibinchundatt!
FAILURE: Integrated in Hadoop-trunk-Commit #9282 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9282/)
YARN-4628. Display application priority in yarn top. Contributed by (vvasudev: rev 663a80031cf6f17151622fff327171dedd976df3)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/TopCLI.java
- hadoop-yarn-project/CHANGES.txt
sunilg/rohithsharma
Attaching patch for review