Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4478 [Umbrella] : Track all the Test failures in YARN
  3. YARN-4614

TestApplicationPriority#testApplicationPriorityAllocationWithChangeInPriority fails occasionally

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      jenkins

    • Hadoop Flags:
      Reviewed

      Description

      TestApplicationPriority#testApplicationPriorityAllocationWithChangeInPriority has sporadically failed in precommit builds. Sample failure:

      Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
      Running org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority
      Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 116.776 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority
      testApplicationPriorityAllocationWithChangeInPriority(org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority)  Time elapsed: 50.687 sec  <<< FAILURE!
      java.lang.AssertionError: Attempt state is not correct (timedout): expected: SCHEDULED actual: ALLOCATED for the application attempt appattempt_1453255879005_0002_000001
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForState(MockRM.java:197)
      	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForState(MockRM.java:172)
      	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForAttemptScheduled(MockRM.java:831)
      	at org.apache.hadoop.yarn.server.resourcemanager.MockRM.launchAM(MockRM.java:818)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority.testApplicationPriorityAllocationWithChangeInPriority(TestApplicationPriority.java:494)
      

        Activity

        Hide
        sunilg Sunil G added a comment -

        Thanks Jason Lowe for filing this, I will take a dig in it if its fine. I have seen this failures few times.

        Show
        sunilg Sunil G added a comment - Thanks Jason Lowe for filing this, I will take a dig in it if its fine. I have seen this failures few times.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        It seems timing issue, randomly fails in my machine.

        Show
        rohithsharma Rohith Sharma K S added a comment - It seems timing issue, randomly fails in my machine.
        Hide
        sunilg Sunil G added a comment -

        We had some fixes in MockRM to ensure states are perfectly fine before moving to one another. And I verified and found that those fixes are in-cooperated in TestApplicationPriority. I have some doubts in using some old apis from MockRM, with which I will try to make the fix and will share analysis.

        Show
        sunilg Sunil G added a comment - We had some fixes in MockRM to ensure states are perfectly fine before moving to one another. And I verified and found that those fixes are in-cooperated in TestApplicationPriority . I have some doubts in using some old apis from MockRM, with which I will try to make the fix and will share analysis.
        Hide
        sunilg Sunil G added a comment -

        There was a mistake in testApplicationPriorityAllocationWithChangeInPriority. An extra nodeHeartbeat() was called after MockRM#submitApp. Hence a state was jumped across while verifying in MockRM#launchAM.

        Sequence should be submitApp-> launchAM-> registerAttempt. Attaching a patch.

        Show
        sunilg Sunil G added a comment - There was a mistake in testApplicationPriorityAllocationWithChangeInPriority . An extra nodeHeartbeat() was called after MockRM#submitApp . Hence a state was jumped across while verifying in MockRM#launchAM . Sequence should be submitApp-> launchAM-> registerAttempt. Attaching a patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 4s trunk passed
        +1 compile 0m 31s trunk passed with JDK v1.8.0_66
        +1 compile 0m 34s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 15s trunk passed
        +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 25s the patch passed with JDK v1.8.0_66
        +1 javac 0m 25s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_91
        +1 javac 0m 28s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 24s the patch passed
        +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91
        -1 unit 67m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 72m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 31s Patch does not generate ASF License warnings.
        158m 58s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783869/0001-YARN-4614.patch
        JIRA Issue YARN-4614
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8a3f2d2d65c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 34a3900
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10370/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10370/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 4s trunk passed +1 compile 0m 31s trunk passed with JDK v1.8.0_66 +1 compile 0m 34s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 15s trunk passed +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 33s the patch passed +1 compile 0m 25s the patch passed with JDK v1.8.0_66 +1 javac 0m 25s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_91 +1 javac 0m 28s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91 -1 unit 67m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 72m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 158m 58s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783869/0001-YARN-4614.patch JIRA Issue YARN-4614 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a3f2d2d65c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34a3900 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10370/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10370/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10370/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        thanks Sunil G for your analysis. It make sense to me. I verified the test using debug point in eclipse, as you said that one extra node heartbeat kick off scheduling and allocate a container which attempt goes to ALLOCATED state. And also I verified test with patch using debug mode, test cases passes.

        Show
        rohithsharma Rohith Sharma K S added a comment - thanks Sunil G for your analysis. It make sense to me. I verified the test using debug point in eclipse, as you said that one extra node heartbeat kick off scheduling and allocate a container which attempt goes to ALLOCATED state. And also I verified test with patch using debug mode, test cases passes.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1, committing in

        Show
        rohithsharma Rohith Sharma K S added a comment - +1, committing in
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to trunk/branch-2/branch-2.8.. thanks Sunil G for the patch..

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to trunk/branch-2/branch-2.8.. thanks Sunil G for the patch..
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9172 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9172/)
        YARN-4614. Fix random failure in (rohithsharmaks: rev 99829eb221482928d8a1b148ae3c802cc7c9253e)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationPriority.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9172 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9172/ ) YARN-4614 . Fix random failure in (rohithsharmaks: rev 99829eb221482928d8a1b148ae3c802cc7c9253e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationPriority.java hadoop-yarn-project/CHANGES.txt
        Hide
        sunilg Sunil G added a comment -

        Thank you Rohith Sharma K S for the review and commit!

        Show
        sunilg Sunil G added a comment - Thank you Rohith Sharma K S for the review and commit!

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development