Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4612

Fix rumen and scheduler load simulator handle killed tasks properly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha1, 2.8.2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Killed tasks might not any attempts. Rumen and SLS throw exceptions when processing such data.

      1. YARN-4612-2.patch
        32 kB
        Ming Ma
      2. YARN-4612.patch
        31 kB
        Ming Ma

        Activity

        Hide
        mingma Ming Ma added a comment -

        Here is the draft patch. Also tested it with actual data.

        Show
        mingma Ming Ma added a comment - Here is the draft patch. Also tested it with actual data.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 32s Maven dependency ordering for branch
        +1 mvninstall 7m 51s trunk passed
        +1 compile 1m 1s trunk passed with JDK v1.8.0_66
        +1 compile 1m 15s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 44s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 32s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 0m 34s the patch passed
        +1 compile 1m 1s the patch passed with JDK v1.8.0_66
        -1 javac 1m 52s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new + 151 unchanged - 1 fixed = 153 total (was 152)
        +1 javac 1m 1s the patch passed
        +1 compile 1m 15s the patch passed with JDK v1.7.0_91
        -1 javac 3m 7s hadoop-tools-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new + 151 unchanged - 1 fixed = 153 total (was 152)
        +1 javac 1m 15s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 40s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 28s the patch passed with JDK v1.7.0_91
        +1 unit 0m 16s hadoop-rumen in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 17s hadoop-rumen in the patch passed with JDK v1.7.0_91.
        +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        40m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783262/YARN-4612.patch
        JIRA Issue YARN-4612
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a16ba1f58df1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1acc509
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        javac hadoop-tools-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/10336/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.8.0_66.txt
        javac hadoop-tools-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10336/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10336/testReport/
        modules C: hadoop-tools/hadoop-rumen hadoop-tools/hadoop-sls U: hadoop-tools
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10336/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 1m 1s trunk passed with JDK v1.8.0_66 +1 compile 1m 15s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 44s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 32s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 34s the patch passed +1 compile 1m 1s the patch passed with JDK v1.8.0_66 -1 javac 1m 52s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new + 151 unchanged - 1 fixed = 153 total (was 152) +1 javac 1m 1s the patch passed +1 compile 1m 15s the patch passed with JDK v1.7.0_91 -1 javac 3m 7s hadoop-tools-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new + 151 unchanged - 1 fixed = 153 total (was 152) +1 javac 1m 15s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 40s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 28s the patch passed with JDK v1.7.0_91 +1 unit 0m 16s hadoop-rumen in the patch passed with JDK v1.8.0_66. +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 17s hadoop-rumen in the patch passed with JDK v1.7.0_91. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 40m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783262/YARN-4612.patch JIRA Issue YARN-4612 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a16ba1f58df1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1acc509 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javac hadoop-tools-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/10336/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.8.0_66.txt javac hadoop-tools-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10336/artifact/patchprocess/diff-compile-javac-hadoop-tools-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10336/testReport/ modules C: hadoop-tools/hadoop-rumen hadoop-tools/hadoop-sls U: hadoop-tools Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10336/console This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        The json had a new job with zero task attempt which is the new unit test. The updated patch should fix the javac warning by switching to use new APIs.

        Show
        mingma Ming Ma added a comment - The json had a new job with zero task attempt which is the new unit test. The updated patch should fix the javac warning by switching to use new APIs.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 17s Maven dependency ordering for branch
        +1 mvninstall 7m 32s trunk passed
        +1 compile 1m 0s trunk passed with JDK v1.8.0_66
        +1 compile 1m 15s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 43s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 9s trunk passed
        +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 30s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.8.0_66
        +1 javac 1m 46s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 0 new + 148 unchanged - 4 fixed = 148 total (was 152)
        +1 javac 0m 57s hadoop-tools in the patch passed with JDK v1.8.0_66.
        +1 compile 1m 13s the patch passed with JDK v1.7.0_91
        +1 javac 2m 59s hadoop-tools-jdk1.7.0_91 with JDK v1.7.0_91 generated 0 new + 148 unchanged - 4 fixed = 148 total (was 152)
        +1 javac 1m 13s hadoop-tools in the patch passed with JDK v1.7.0_91.
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 28s the patch passed
        +1 javadoc 0m 22s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 27s the patch passed with JDK v1.7.0_91
        +1 unit 0m 14s hadoop-rumen in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 48s hadoop-sls in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 17s hadoop-rumen in the patch passed with JDK v1.7.0_91.
        +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        23m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783382/YARN-4612-2.patch
        JIRA Issue YARN-4612
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 783b343c8180 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1425578
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10342/testReport/
        modules C: hadoop-tools/hadoop-rumen hadoop-tools/hadoop-sls U: hadoop-tools
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10342/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 32s trunk passed +1 compile 1m 0s trunk passed with JDK v1.8.0_66 +1 compile 1m 15s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 26s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 32s the patch passed +1 compile 0m 57s the patch passed with JDK v1.8.0_66 +1 javac 1m 46s hadoop-tools-jdk1.8.0_66 with JDK v1.8.0_66 generated 0 new + 148 unchanged - 4 fixed = 148 total (was 152) +1 javac 0m 57s hadoop-tools in the patch passed with JDK v1.8.0_66. +1 compile 1m 13s the patch passed with JDK v1.7.0_91 +1 javac 2m 59s hadoop-tools-jdk1.7.0_91 with JDK v1.7.0_91 generated 0 new + 148 unchanged - 4 fixed = 148 total (was 152) +1 javac 1m 13s hadoop-tools in the patch passed with JDK v1.7.0_91. +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 28s the patch passed +1 javadoc 0m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 27s the patch passed with JDK v1.7.0_91 +1 unit 0m 14s hadoop-rumen in the patch passed with JDK v1.8.0_66. +1 unit 0m 48s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 17s hadoop-rumen in the patch passed with JDK v1.7.0_91. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 23m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783382/YARN-4612-2.patch JIRA Issue YARN-4612 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 783b343c8180 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1425578 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10342/testReport/ modules C: hadoop-tools/hadoop-rumen hadoop-tools/hadoop-sls U: hadoop-tools Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10342/console This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        +1 LGTM. Checking this in

        Show
        xgong Xuan Gong added a comment - +1 LGTM. Checking this in
        Hide
        xgong Xuan Gong added a comment -

        Committed into trunk/branch-2. Thanks, Ming.

        Show
        xgong Xuan Gong added a comment - Committed into trunk/branch-2. Thanks, Ming.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9189 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9189/)
        YARN-4612. Fix rumen and scheduler load simulator handle killed tasks (xgong: rev 4efdf3a979c361348612f817a3253be6d0de58f7)

        • hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobBuilder.java
        • hadoop-tools/hadoop-sls/src/main/data/2jobs2min-rumen-jh.json
        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/utils/SLSUtils.java
        • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9189 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9189/ ) YARN-4612 . Fix rumen and scheduler load simulator handle killed tasks (xgong: rev 4efdf3a979c361348612f817a3253be6d0de58f7) hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobBuilder.java hadoop-tools/hadoop-sls/src/main/data/2jobs2min-rumen-jh.json hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/utils/SLSUtils.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java hadoop-yarn-project/CHANGES.txt
        Hide
        mingma Ming Ma added a comment -

        Thanks Xuan Gong.

        Show
        mingma Ming Ma added a comment - Thanks Xuan Gong .
        Hide
        zhouyejoe Ye Zhou added a comment -

        Konstantin Shvachko Patch applies to branch 2.7. Build and Unit Tests passed.

        Show
        zhouyejoe Ye Zhou added a comment - Konstantin Shvachko Patch applies to branch 2.7. Build and Unit Tests passed.
        Hide
        shv Konstantin Shvachko added a comment -

        I just committed this to branch-2.8 and branch-2.7.
        Thank you Ye Zhou for backporting.

        Show
        shv Konstantin Shvachko added a comment - I just committed this to branch-2.8 and branch-2.7. Thank you Ye Zhou for backporting.

          People

          • Assignee:
            mingma Ming Ma
            Reporter:
            mingma Ming Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development