Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
Reviewed
Description
Simulate cluster with 10 racks with 100 nodes using sls and of we check the table for Total Outstanding Resource Requests will consume complete page.
Good to support pagination for the table
Attachments
Attachments
- 0001-YARN-4607.patch
- 6 kB
- Bibin Chundatt
- 0002-YARN-4607.patch
- 7 kB
- Bibin Chundatt
- 0003-YARN-4607.patch
- 6 kB
- Bibin Chundatt
- 0004-YARN-4607.patch
- 7 kB
- Bibin Chundatt
- Request_without_pagination.jpg
- 343 kB
- Bibin Chundatt
- Request with Pagination.jpg
- 358 kB
- Bibin Chundatt
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 15m 52s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
0 | mvndep | 0m 10s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 53s | trunk passed |
+1 | compile | 1m 8s | trunk passed with JDK v1.8.0_74 |
+1 | compile | 1m 15s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 25s | trunk passed |
+1 | mvnsite | 0m 57s | trunk passed |
+1 | mvneclipse | 0m 26s | trunk passed |
+1 | findbugs | 1m 47s | trunk passed |
+1 | javadoc | 0m 38s | trunk passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 50s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 50s | the patch passed |
+1 | compile | 1m 8s | the patch passed with JDK v1.8.0_74 |
+1 | javac | 1m 8s | the patch passed |
+1 | compile | 1m 18s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 1m 18s | the patch passed |
+1 | checkstyle | 0m 23s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23) |
+1 | mvnsite | 0m 52s | the patch passed |
+1 | mvneclipse | 0m 23s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 2m 11s | the patch passed |
+1 | javadoc | 0m 35s | the patch passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 46s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 0m 21s | hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. |
-1 | unit | 72m 53s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. |
+1 | unit | 0m 24s | hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. |
-1 | unit | 74m 53s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. |
+1 | asflicense | 0m 21s | Patch does not generate ASF License warnings. |
189m 0s |
Reason | Tests |
---|---|
JDK v1.8.0_74 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestAMAuthorization |
This message was automatically generated.
Overall patch looks good, can you add screenshot of before and after container request table?
And about below code in patch, which scenario will hit? Why table data need to be removed?
if (requestTableData.charAt(requestTableData.length() - 2) == ',') { requestTableData.delete(requestTableData.length() - 2, requestTableData.length() - 1); }
- The default table height is 302px reduced to 10px when only one row is available causing issue in layout and border with div
- To removed "," from last row
Point 1: In any of fields in JobCounters will be able to see the behavior (eg : JobCounter/MB_MILLIS_REDUCES) table
overall patch looks good to me.. I do test in cluster and see everything works normal. Later I will commit it.
One doubt is does sorting in supported in tables?
One doubt is does sorting in supported in tables?
IIUC default value of bSortable is true should be sortable
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 12s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
0 | mvndep | 0m 10s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 56s | trunk passed |
+1 | compile | 2m 24s | trunk passed with JDK v1.8.0_74 |
+1 | compile | 2m 4s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 32s | trunk passed |
+1 | mvnsite | 1m 26s | trunk passed |
+1 | mvneclipse | 0m 40s | trunk passed |
+1 | findbugs | 2m 54s | trunk passed |
+1 | javadoc | 1m 6s | trunk passed with JDK v1.8.0_74 |
+1 | javadoc | 1m 20s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 1m 14s | the patch passed |
+1 | compile | 1m 51s | the patch passed with JDK v1.8.0_74 |
+1 | javac | 1m 51s | the patch passed |
+1 | compile | 2m 6s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 2m 6s | the patch passed |
+1 | checkstyle | 0m 30s | hadoop-yarn-project/hadoop-yarn: patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23) |
+1 | mvnsite | 1m 22s | the patch passed |
+1 | mvneclipse | 0m 35s | the patch passed |
-1 | whitespace | 0m 0s | The patch has 2 line(s) with tabs. |
+1 | findbugs | 3m 25s | the patch passed |
+1 | javadoc | 0m 58s | the patch passed with JDK v1.8.0_74 |
+1 | javadoc | 1m 15s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 1m 51s | hadoop-yarn-common in the patch passed with JDK v1.8.0_74. |
+1 | unit | 0m 21s | hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. |
-1 | unit | 68m 32s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. |
+1 | unit | 2m 11s | hadoop-yarn-common in the patch passed with JDK v1.7.0_95. |
+1 | unit | 0m 24s | hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. |
-1 | unit | 69m 9s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. |
+1 | asflicense | 0m 19s | Patch does not generate ASF License warnings. |
177m 20s |
Reason | Tests |
---|---|
JDK v1.8.0_74 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerPreemption | |
hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens |
This message was automatically generated.
Hi Bibin Chundatt
Some nits
- I think css modification is really required since it is not much affects the rendering.
- Can you rename the method name WebPageUtils#requestsTableInit to WebPageUtils#resourceRequestsTableInit for readability. Similarly, keep the resourceRequest instead of requests in other places also for readability.
I think css modification is really required since it is not much affects the rendering.
IIUC For table with only one row , we will be able to see the impact.
In any of fields in JobCounters will be able to see the behavior (eg : JobCounter/MB_MILLIS_REDUCES) table
Thanks Bibin Chundatt for pointing out the reason for css modification.
I tested for empty table i.e no pending resource request, I did not see any issue with table height. I think the issue would occur for other tables which are using {{.dataTables_wrapper }}. I suggest this can be handled in different JIRA by letting others know about css changes. And also raise ticket for which table are you facing the problem. For current JIRA, can you upload patch without css modification, so let this patch go in?
Rohith Sharma K S
Thank you for looking into patch.
For Single row the impact will be seen for css . Raised YARN-4867 for the same.
Can you rename the method name WebPageUtils#requestsTableInit to WebPageUtils#resourceRequestsTableInit for readability. Similarly, keep the resourceRequest instead of requests in other places also for readability.
Done
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 13s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
0 | mvndep | 0m 10s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 29s | trunk passed |
+1 | compile | 1m 4s | trunk passed with JDK v1.8.0_74 |
+1 | compile | 1m 16s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 24s | trunk passed |
+1 | mvnsite | 0m 56s | trunk passed |
+1 | mvneclipse | 0m 28s | trunk passed |
+1 | findbugs | 1m 44s | trunk passed |
+1 | javadoc | 0m 38s | trunk passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 49s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 9s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 47s | the patch passed |
+1 | compile | 1m 1s | the patch passed with JDK v1.8.0_74 |
+1 | javac | 1m 1s | the patch passed |
+1 | compile | 1m 14s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 1m 14s | the patch passed |
-1 | checkstyle | 0m 23s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: patch generated 1 new + 21 unchanged - 2 fixed = 22 total (was 23) |
+1 | mvnsite | 0m 52s | the patch passed |
+1 | mvneclipse | 0m 22s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 2m 4s | the patch passed |
+1 | javadoc | 0m 34s | the patch passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 44s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 0m 19s | hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. |
-1 | unit | 65m 0s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. |
+1 | unit | 0m 24s | hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. |
-1 | unit | 65m 53s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. |
-1 | asflicense | 0m 18s | Patch generated 1 ASF License warnings. |
155m 27s |
Reason | Tests |
---|---|
JDK v1.8.0_74 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestRMAdminService | |
hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestRMAdminService | |
hadoop.yarn.server.resourcemanager.TestAMAuthorization |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 15s | Docker mode activated. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
0 | mvndep | 0m 19s | Maven dependency ordering for branch |
+1 | mvninstall | 6m 42s | trunk passed |
+1 | compile | 1m 6s | trunk passed with JDK v1.8.0_74 |
+1 | compile | 1m 18s | trunk passed with JDK v1.7.0_95 |
+1 | checkstyle | 0m 26s | trunk passed |
+1 | mvnsite | 0m 57s | trunk passed |
+1 | mvneclipse | 0m 28s | trunk passed |
+1 | findbugs | 1m 43s | trunk passed |
+1 | javadoc | 0m 39s | trunk passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 48s | trunk passed with JDK v1.7.0_95 |
0 | mvndep | 0m 10s | Maven dependency ordering for patch |
+1 | mvninstall | 0m 47s | the patch passed |
+1 | compile | 1m 5s | the patch passed with JDK v1.8.0_74 |
+1 | javac | 1m 5s | the patch passed |
+1 | compile | 1m 14s | the patch passed with JDK v1.7.0_95 |
+1 | javac | 1m 14s | the patch passed |
+1 | checkstyle | 0m 22s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: patch generated 0 new + 21 unchanged - 2 fixed = 21 total (was 23) |
+1 | mvnsite | 0m 52s | the patch passed |
+1 | mvneclipse | 0m 23s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | findbugs | 2m 4s | the patch passed |
+1 | javadoc | 0m 34s | the patch passed with JDK v1.8.0_74 |
+1 | javadoc | 0m 44s | the patch passed with JDK v1.7.0_95 |
+1 | unit | 0m 20s | hadoop-yarn-server-common in the patch passed with JDK v1.8.0_74. |
-1 | unit | 64m 33s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. |
+1 | unit | 0m 26s | hadoop-yarn-server-common in the patch passed with JDK v1.7.0_95. |
-1 | unit | 69m 8s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. |
-1 | asflicense | 0m 21s | Patch generated 1 ASF License warnings. |
158m 54s |
Reason | Tests |
---|---|
JDK v1.8.0_74 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestRMAdminService | |
hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling | |
JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
hadoop.yarn.server.resourcemanager.TestRMAdminService | |
hadoop.yarn.server.resourcemanager.TestAMAuthorization |
This message was automatically generated.
There are many other JIRA to track test case failures. Committing this patch!
committed to trunk/branch-2!! thanks Bibin Chundatt for your contributions
FAILURE: Integrated in Hadoop-trunk-Commit #9546 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9546/)
YARN-4607. Pagination support for AppAttempt page (rohithsharmaks: rev 1e6f92977dc5431b117745feb5a3491e88a559c0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/WebPageUtils.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppAttemptBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppAttemptPage.java
Rohith Sharma K S
Could you please review patch attached