Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4562

YARN WebApp ignores the configuration passed to it for keystore settings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      The conf can be passed to WebApps builder, however the following code in WebApps.java that builds the HttpServer2 object:

              if (httpScheme.equals(WebAppUtils.HTTPS_PREFIX)) {
                WebAppUtils.loadSslConfiguration(builder);
              }
      

      ...results in loadSslConfiguration creating a new Configuration object; the one that is passed in is ignored, as far as the keystore/etc. settings are concerned. loadSslConfiguration has another overload with Configuration parameter that should be used instead.

      1. YARN-4562.patch
        0.8 kB
        Sergey Shelukhin

        Activity

        Hide
        sershe Sergey Shelukhin added a comment -

        Trivial patch. Vinod Kumar Vavilapalli Siddharth Seth can you take a look?

        Show
        sershe Sergey Shelukhin added a comment - Trivial patch. Vinod Kumar Vavilapalli Siddharth Seth can you take a look?
        Hide
        sershe Sergey Shelukhin added a comment -

        Or Hitesh Shah. I dunno who owns WebApp

        Show
        sershe Sergey Shelukhin added a comment - Or Hitesh Shah . I dunno who owns WebApp
        Hide
        vvasudev Varun Vasudev added a comment -

        Submitted patch to Jenkins.

        Show
        vvasudev Varun Vasudev added a comment - Submitted patch to Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 59s trunk passed
        +1 compile 0m 27s trunk passed with JDK v1.8.0_74
        +1 compile 0m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 34s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 14s trunk passed
        +1 javadoc 0m 36s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 40s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.8.0_74
        +1 javac 0m 27s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.7.0_95
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 33s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 38s the patch passed with JDK v1.7.0_95
        +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
        +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
        -1 asflicense 0m 19s Patch generated 1 ASF License warnings.
        24m 17s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781130/YARN-4562.patch
        JIRA Issue YARN-4562
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ca00769c77c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 09d63d5
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10907/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10907/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10907/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 59s trunk passed +1 compile 0m 27s trunk passed with JDK v1.8.0_74 +1 compile 0m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 14s trunk passed +1 javadoc 0m 36s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 40s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 31s the patch passed +1 compile 0m 27s the patch passed with JDK v1.8.0_74 +1 javac 0m 27s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_95 +1 javac 0m 30s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 33s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 38s the patch passed with JDK v1.7.0_95 +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 19s Patch generated 1 ASF License warnings. 24m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781130/YARN-4562.patch JIRA Issue YARN-4562 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ca00769c77c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09d63d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10907/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10907/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/10907/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        sershe Sergey Shelukhin added a comment -

        Hmm... ping?

        Show
        sershe Sergey Shelukhin added a comment - Hmm... ping?
        Hide
        vvasudev Varun Vasudev added a comment -

        Sergey Shelukhin - just to clarify - we add ssl-server.xml to the configuration object so any settings you provide in your conf object will be overridden by corresponding settings in ssl-server.xml. Is that ok with you?

        Show
        vvasudev Varun Vasudev added a comment - Sergey Shelukhin - just to clarify - we add ssl-server.xml to the configuration object so any settings you provide in your conf object will be overridden by corresponding settings in ssl-server.xml. Is that ok with you?
        Hide
        sershe Sergey Shelukhin added a comment -

        That is true only if ssl-server.xml is present Yes, that works.

        Show
        sershe Sergey Shelukhin added a comment - That is true only if ssl-server.xml is present Yes, that works.
        Hide
        vvasudev Varun Vasudev added a comment -

        +1. I'll commit this tomorrow if no one objects.

        Show
        vvasudev Varun Vasudev added a comment - +1. I'll commit this tomorrow if no one objects.
        Hide
        vvasudev Varun Vasudev added a comment -

        Committed to trunk and branch-2. Thanks Sergey Shelukhin!

        Show
        vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Sergey Shelukhin !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9589/)
        YARN-4562. YARN WebApp ignores the configuration passed to it for (vvasudev: rev 07920acc165f17e8fe3ca9d21283a2123223f438)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9589 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9589/ ) YARN-4562 . YARN WebApp ignores the configuration passed to it for (vvasudev: rev 07920acc165f17e8fe3ca9d21283a2123223f438) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java

          People

          • Assignee:
            sershe Sergey Shelukhin
            Reporter:
            sershe Sergey Shelukhin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development