Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4555

TestDefaultContainerExecutor#testContainerLaunchError fails on non-english locale environment

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: nodemanager, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In my env where LANG=ja_JP.UTF-8, the test fails with

      -------------------------------------------------------------------------------
      Test set: org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor
      -------------------------------------------------------------------------------
      Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor
      testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor)  Time elapsed: 1.149 sec  <<< FAILURE!
      java.lang.AssertionError: Invalid Diagnostics message: Exception from container-launch.
      Container id: CONTAINER_ID
      Exit code: 127
      Exception message: bash: target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: そのようなファイルやディレクトリはありません
      
      Stack trace: ExitCodeException exitCode=127: bash: target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: そのようなファイルやディ>レクトリはありません
      

      This is because the test code assertion assumes the English locale as below.

      250           public Object answer(InvocationOnMock invocationOnMock)
      251               throws Throwable {
      252             String diagnostics = (String) invocationOnMock.getArguments()[0];
      253             assertTrue("Invalid Diagnostics message: " + diagnostics,
      254                 diagnostics.contains("No such file or directory"));
      255             return null;
      256           }
      

      This exists on trunk, too.

      1. YARN-4555.1.patch
        1 kB
        Takashi Ohnishi

        Activity

        Hide
        bwtakacy Takashi Ohnishi added a comment -

        Thanks Rohith Sharma K S for commtting !

        Show
        bwtakacy Takashi Ohnishi added a comment - Thanks Rohith Sharma K S for commtting !
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 12s trunk passed
        +1 compile 0m 29s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 48s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 30s the patch passed
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 58s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 15m 41s hadoop-yarn-server-nodemanager in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        31m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4555
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2346e7e50ab8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9f32364
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13533/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13533/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 12s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 48s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 58s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 15m 41s hadoop-yarn-server-nodemanager in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 31m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4555 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2346e7e50ab8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f32364 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13533/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13533/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10694 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10694/)
        YARN-4555. TestDefaultContainerExecutor#testContainerLaunchError fails (rohithsharmaks: rev b110c4b5e82d8310f13a22bba1c8afbcca80144f)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDefaultContainerExecutor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10694 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10694/ ) YARN-4555 . TestDefaultContainerExecutor#testContainerLaunchError fails (rohithsharmaks: rev b110c4b5e82d8310f13a22bba1c8afbcca80144f) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDefaultContainerExecutor.java
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committed to trunk/branch-2..thanks Takashi Ohnishi for patch!!

        Show
        rohithsharma Rohith Sharma K S added a comment - committed to trunk/branch-2..thanks Takashi Ohnishi for patch!!
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committing shortly..

        Show
        rohithsharma Rohith Sharma K S added a comment - committing shortly..
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 35s trunk passed
        +1 compile 0m 20s trunk passed with JDK v1.8.0_92
        +1 compile 0m 25s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 50s trunk passed
        +1 javadoc 0m 17s trunk passed with JDK v1.8.0_92
        +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 19s the patch passed with JDK v1.8.0_92
        +1 javac 0m 19s the patch passed
        +1 compile 0m 23s the patch passed with JDK v1.7.0_95
        +1 javac 0m 23s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 58s the patch passed
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_92
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
        +1 unit 10m 59s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_92.
        +1 unit 11m 30s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        37m 1s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch
        JIRA Issue YARN-4555
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f0103d68cb50 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8eadd71
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11214/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/11214/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 35s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_92 +1 compile 0m 25s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 50s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_92 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 23s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_92 +1 javac 0m 19s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_95 +1 javac 0m 23s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 58s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_92 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 +1 unit 10m 59s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_92. +1 unit 11m 30s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 37m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch JIRA Issue YARN-4555 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f0103d68cb50 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8eadd71 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11214/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11214/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vvasudev Varun Vasudev added a comment -

        Patch should work with docker as well, no issue from that end.

        Show
        vvasudev Varun Vasudev added a comment - Patch should work with docker as well, no issue from that end.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I am not sure about the patch fix in different environment, I would like to take an opinion from who is recently working on docker.
        cc:/Varun Vasudev

        Show
        rohithsharma Rohith Sharma K S added a comment - I am not sure about the patch fix in different environment, I would like to take an opinion from who is recently working on docker. cc:/ Varun Vasudev
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 18s trunk passed
        +1 compile 0m 23s trunk passed with JDK v1.8.0_66
        +1 compile 0m 28s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 10s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 54s trunk passed
        +1 javadoc 0m 17s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 21s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 21s the patch passed with JDK v1.8.0_66
        +1 javac 0m 21s the patch passed
        +1 compile 0m 24s the patch passed with JDK v1.7.0_91
        +1 javac 0m 24s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 59s the patch passed
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_91
        +1 unit 8m 24s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
        +1 unit 8m 59s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        32m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch
        JIRA Issue YARN-4555
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 093b02e4a138 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6702e7d
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10188/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10188/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 18s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_66 +1 compile 0m 28s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 23s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_66 +1 javac 0m 21s the patch passed +1 compile 0m 24s the patch passed with JDK v1.7.0_91 +1 javac 0m 24s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_91 +1 unit 8m 24s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. +1 unit 8m 59s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 32m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch JIRA Issue YARN-4555 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 093b02e4a138 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6702e7d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10188/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10188/console This message was automatically generated.
        Hide
        bwtakacy Takashi Ohnishi added a comment -

        I've created a patch which set LANG=C for container executor shell script.

        Show
        bwtakacy Takashi Ohnishi added a comment - I've created a patch which set LANG=C for container executor shell script.
        Hide
        bwtakacy Takashi Ohnishi added a comment -

        For work-around,

        $ LANG=C mvn test
        

        makes this test succeeds.

        Show
        bwtakacy Takashi Ohnishi added a comment - For work-around, $ LANG=C mvn test makes this test succeeds.

          People

          • Assignee:
            bwtakacy Takashi Ohnishi
            Reporter:
            bwtakacy Takashi Ohnishi
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development