Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4461

Redundant nodeLocalityDelay log in LeafQueue

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In LeafQueue#setupQueueConfigs there's a redundant log of nodeLocalityDelay:

              "nodeLocalityDelay = " + nodeLocalityDelay + "\n" +
              "labels=" + labelStrBuilder.toString() + "\n" +
              "nodeLocalityDelay = " +  nodeLocalityDelay + "\n" +
      

        Activity

        Hide
        eepayne Eric Payne added a comment -

        Thanks a lot, Jason Lowe and Wangda Tan!

        Show
        eepayne Eric Payne added a comment - Thanks a lot, Jason Lowe and Wangda Tan !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8980 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8980/)
        YARN-4461. Redundant nodeLocalityDelay log in LeafQueue. Contributed by (jlowe: rev 91828fef6b9314f72d1f973f00e81404dc6bba91)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8980 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8980/ ) YARN-4461 . Redundant nodeLocalityDelay log in LeafQueue. Contributed by (jlowe: rev 91828fef6b9314f72d1f973f00e81404dc6bba91) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to Eric for the contribution and to Wangda for additional review! I committed this to trunk, branch-2, and branch-2.8.

        Show
        jlowe Jason Lowe added a comment - Thanks to Eric for the contribution and to Wangda for additional review! I committed this to trunk, branch-2, and branch-2.8.
        Hide
        jlowe Jason Lowe added a comment -

        +1 committing this.

        Show
        jlowe Jason Lowe added a comment - +1 committing this.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Eric Payne, patch looks good, +1.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Eric Payne , patch looks good, +1.
        Hide
        eepayne Eric Payne added a comment -

        The two failing tests above (TestClientRMTokens and TestAMAuthorization) both work for me in my local environment.

        Show
        eepayne Eric Payne added a comment - The two failing tests above ( TestClientRMTokens and TestAMAuthorization ) both work for me in my local environment.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 31s trunk passed
        +1 compile 0m 33s trunk passed with JDK v1.8.0_66
        +1 compile 0m 35s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 43s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 27s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 30s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 40s the patch passed
        +1 compile 0m 31s the patch passed with JDK v1.8.0_66
        +1 javac 0m 31s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.7.0_91
        +1 javac 0m 36s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 41s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 27s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 30s the patch passed with JDK v1.7.0_91
        -1 unit 67m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 52s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        152m 56s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777882/YARN-4461.001.patch
        JIRA Issue YARN-4461
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c0c8b554da4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ae67c84
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9999/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 76MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9999/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 31s trunk passed +1 compile 0m 33s trunk passed with JDK v1.8.0_66 +1 compile 0m 35s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 30s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 40s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_66 +1 javac 0m 31s the patch passed +1 compile 0m 36s the patch passed with JDK v1.7.0_91 +1 javac 0m 36s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 41s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 27s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 30s the patch passed with JDK v1.7.0_91 -1 unit 67m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 52s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 152m 56s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777882/YARN-4461.001.patch JIRA Issue YARN-4461 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c0c8b554da4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae67c84 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9999/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9999/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9999/console This message was automatically generated.
        Hide
        eepayne Eric Payne added a comment -

        Jason Lowe, thank you for raising this issue. Would you mind looking at the patch?

        Show
        eepayne Eric Payne added a comment - Jason Lowe , thank you for raising this issue. Would you mind looking at the patch?

          People

          • Assignee:
            eepayne Eric Payne
            Reporter:
            jlowe Jason Lowe
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development