Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4434

NodeManager Disk Checker parameter documentation is not correct

    Details

    • Hadoop Flags:
      Reviewed

      Description

      In the description of yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage, it says

      The default value is 100 i.e. the entire disk can be used.
      

      But, in yarn-default.xml and source code, the default value is 90.

      1. YARN-4434.001.patch
        2 kB
        Weiwei Yang
      2. YARN-4434.branch-2.6.patch
        2 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bwtakacy opened a pull request:

          https://github.com/apache/hadoop/pull/62

          YARN-4434.NodeManager Disk Checker parameter documentation is not cor…

          …rect

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bwtakacy/hadoop feature/YARN-4434

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/hadoop/pull/62.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #62


          commit d1fabcaa9000f50b839f54e53868fa3ee921fa80
          Author: Takashi Ohnishi <bwtakacy@gmail.com>
          Date: 2015-12-08T08:02:14Z

          YARN-4434.NodeManager Disk Checker parameter documentation is not correct


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bwtakacy opened a pull request: https://github.com/apache/hadoop/pull/62 YARN-4434 .NodeManager Disk Checker parameter documentation is not cor… …rect You can merge this pull request into a Git repository by running: $ git pull https://github.com/bwtakacy/hadoop feature/ YARN-4434 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit d1fabcaa9000f50b839f54e53868fa3ee921fa80 Author: Takashi Ohnishi <bwtakacy@gmail.com> Date: 2015-12-08T08:02:14Z YARN-4434 .NodeManager Disk Checker parameter documentation is not correct
          Hide
          cheersyang Weiwei Yang added a comment -

          The default value was changed by YARN-2566, we need to update the doc accordingly. Just submitted a patch for the doc update. Please help to review, thanks

          Show
          cheersyang Weiwei Yang added a comment - The default value was changed by YARN-2566 , we need to update the doc accordingly. Just submitted a patch for the doc update. Please help to review, thanks
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 mvnsite 0m 14s trunk passed
          +1 mvnsite 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 asflicense 0m 14s Patch generated 3 ASF License warnings.
          0m 54s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Issue YARN-4434
          GITHUB PR https://github.com/apache/hadoop/pull/62
          Optional Tests asflicense mvnsite
          uname Linux 38b5907d5d67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fc47084
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9898/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
          Max memory used 29MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9898/console
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9898/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 14s trunk passed +1 mvnsite 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 14s Patch generated 3 ASF License warnings. 0m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Issue YARN-4434 GITHUB PR https://github.com/apache/hadoop/pull/62 Optional Tests asflicense mvnsite uname Linux 38b5907d5d67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fc47084 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9898/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Max memory used 29MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9898/console Console output https://builds.apache.org/job/PreCommit-YARN-Build/9898/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Takashi Ohnishi and Weiwei Yang. I'm +1 for the Weiwei's patch. Committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Takashi Ohnishi and Weiwei Yang . I'm +1 for the Weiwei's patch. Committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I had to rebase the patch for branch-2.6. Attaching the rebased patch.

          Show
          ajisakaa Akira Ajisaka added a comment - I had to rebase the patch for branch-2.6. Attaching the rebased patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, branch-2.8, branch-2.7, branch-2.6, and branch-2.6.3. Thanks Weiwei Yang for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, branch-2.7, branch-2.6, and branch-2.6.3. Thanks Weiwei Yang for the contribution.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aajisaka commented on the pull request:

          https://github.com/apache/hadoop/pull/62#issuecomment-163142562

          Thank you for the pull request. I reviewed the patch (A) and the another patch in YARN-4434 jira (B) and decided to commit the patch (B) because the patch (B) replaces "i.e. the entire disk" with "i.e. 90% of the disk" as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/62#issuecomment-163142562 Thank you for the pull request. I reviewed the patch (A) and the another patch in YARN-4434 jira (B) and decided to commit the patch (B) because the patch (B) replaces "i.e. the entire disk" with "i.e. 90% of the disk" as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aajisaka commented on the pull request:

          https://github.com/apache/hadoop/pull/62#issuecomment-163142634

          I've committed the patch (B), so would you close this pull request?

          Show
          githubbot ASF GitHub Bot added a comment - Github user aajisaka commented on the pull request: https://github.com/apache/hadoop/pull/62#issuecomment-163142634 I've committed the patch (B), so would you close this pull request?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8947/)
          YARN-4434. NodeManager Disk Checker parameter documentation is not (aajisaka: rev 50edcb947ccbb736924c43735d23f3c156961049)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManager.md
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8947/ ) YARN-4434 . NodeManager Disk Checker parameter documentation is not (aajisaka: rev 50edcb947ccbb736924c43735d23f3c156961049) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManager.md hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/679/)
          YARN-4434. NodeManager Disk Checker parameter documentation is not (aajisaka: rev 50edcb947ccbb736924c43735d23f3c156961049)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManager.md
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #679 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/679/ ) YARN-4434 . NodeManager Disk Checker parameter documentation is not (aajisaka: rev 50edcb947ccbb736924c43735d23f3c156961049) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManager.md hadoop-yarn-project/CHANGES.txt
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bwtakacy commented on the pull request:

          https://github.com/apache/hadoop/pull/62#issuecomment-163488815

          OK.
          I will close this PR.

          Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user bwtakacy commented on the pull request: https://github.com/apache/hadoop/pull/62#issuecomment-163488815 OK. I will close this PR. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bwtakacy closed the pull request at:

          https://github.com/apache/hadoop/pull/62

          Show
          githubbot ASF GitHub Bot added a comment - Github user bwtakacy closed the pull request at: https://github.com/apache/hadoop/pull/62
          Hide
          djp Junping Du added a comment -

          Hi Akira Ajisaka, we are moving on to 2.6.3-RC0. Would you hold on any commit bit (unless they are agreed blockers) to branch-2.6.3 in later commit effort? Thanks.

          Show
          djp Junping Du added a comment - Hi Akira Ajisaka , we are moving on to 2.6.3-RC0. Would you hold on any commit bit (unless they are agreed blockers) to branch-2.6.3 in later commit effort? Thanks.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm sorry about that. Thank you Junping Du!

          Show
          ajisakaa Akira Ajisaka added a comment - I'm sorry about that. Thank you Junping Du !
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pulled this into 2.7.2 to keep the release up-to-date with 2.6.3. Changing fix-versions to reflect the same.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.7.2 to keep the release up-to-date with 2.6.3. Changing fix-versions to reflect the same.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              bwtakacy Takashi Ohnishi
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development