Details

      Description

      While debugging in eclipse came across a scenario where in i had to get to know the name of the queue but every time i tried to see the queue it was getting hung. On seeing the stack realized there was a deadlock but on analysis found out that it was only due to queue.toString() during debugging as AbstractCSQueue.getAbsoluteUsedCapacity was synchronized.
      Hence we need to ensure following :

      1. queueCapacity, resource-usage has their own read/write lock hence synchronization is not req
      2. numContainers is volatile hence synchronization is not req.
      3. read/write lock could be added to Ordering Policy. Read operations don't need synchronized. So getNumApplications doesn't need synchronized.
        (First 2 will be handled in this jira and the third will be handled in YARN-4443)
      1. deadlock.log
        161 kB
        Naganarasimha G R
      2. YARN-4416.v1.001.patch
        12 kB
        Naganarasimha G R
      3. YARN-4416.v1.002.patch
        13 kB
        Naganarasimha G R
      4. YARN-4416.v2.001.patch
        5 kB
        Naganarasimha G R
      5. YARN-4416.v2.002.patch
        5 kB
        Naganarasimha G R
      6. YARN-4416.v2.003.patch
        5 kB
        Naganarasimha G R

        Activity

        Hide
        Naganarasimha Naganarasimha G R added a comment -

        attaching the stack trace for deadlock

        Show
        Naganarasimha Naganarasimha G R added a comment - attaching the stack trace for deadlock
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for reporting this issue, Naganarasimha G R.

        Looked at the code, all methods used by org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue#toString don't need to be synchronized:

        • queueCapacity, resource-usage has their own read/write lock.
        • numContainers is volatile.
        • read/write lock could be added to OrderingPolicy. Read operations don't need synchronized. So getNumApplications doesn't need synchronized.
        Show
        leftnoteasy Wangda Tan added a comment - Thanks for reporting this issue, Naganarasimha G R . Looked at the code, all methods used by org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue#toString don't need to be synchronized: queueCapacity, resource-usage has their own read/write lock. numContainers is volatile. read/write lock could be added to OrderingPolicy. Read operations don't need synchronized. So getNumApplications doesn't need synchronized.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the comments Tan, Wangda,

        queueCapacity, resource-usage has their own read/write lock.

        Hence have removed unwanted synchronization on the methods

        numContainers is volatile.

        as its volatile i have removed the synchronization for the get method also there was unnecessary override of getNumContainers in LeafQueue, hence removed it

        read/write lock could be added to OrderingPolicy. Read operations don't need synchronized. So getNumApplications doesn't need synchronized.

        i have added locks for the access of schedulableEntities in AbstractComparatorOrderingPolicy but not completely sure of the modifications as there already synchronization on entitiesToReorder. So would like additional(/focused) review for this part in particular

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the comments Tan, Wangda , queueCapacity, resource-usage has their own read/write lock. Hence have removed unwanted synchronization on the methods numContainers is volatile. as its volatile i have removed the synchronization for the get method also there was unnecessary override of getNumContainers in LeafQueue, hence removed it read/write lock could be added to OrderingPolicy. Read operations don't need synchronized. So getNumApplications doesn't need synchronized. i have added locks for the access of schedulableEntities in AbstractComparatorOrderingPolicy but not completely sure of the modifications as there already synchronization on entitiesToReorder . So would like additional(/focused) review for this part in particular
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Also there is unused variable in LeafQueue

          // absolute capacity as a resource (based on cluster resource)
          private Resource absoluteCapacityResource = Resources.none();
        ...
        private void updateAbsoluteCapacityResource(Resource clusterResource) {
            absoluteCapacityResource =
                Resources.multiplyAndNormalizeUp(resourceCalculator, labelManager
                    .getResourceByLabel(RMNodeLabelsManager.NO_LABEL, clusterResource),
                    queueCapacities.getAbsoluteCapacity(), minimumAllocation);
          }
        

        Was not sure why this is required. If not required shall i delete it ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Also there is unused variable in LeafQueue // absolute capacity as a resource (based on cluster resource) private Resource absoluteCapacityResource = Resources.none(); ... private void updateAbsoluteCapacityResource(Resource clusterResource) { absoluteCapacityResource = Resources.multiplyAndNormalizeUp(resourceCalculator, labelManager .getResourceByLabel(RMNodeLabelsManager.NO_LABEL, clusterResource), queueCapacities.getAbsoluteCapacity(), minimumAllocation); } Was not sure why this is required. If not required shall i delete it ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 13s trunk passed
        +1 compile 0m 31s trunk passed with JDK v1.8.0_66
        +1 compile 0m 32s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 38s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 19s trunk passed
        +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 28s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 31s the patch passed with JDK v1.8.0_66
        +1 javac 0m 31s the patch passed
        +1 compile 0m 34s the patch passed with JDK v1.7.0_85
        +1 javac 0m 34s the patch passed
        -1 checkstyle 0m 13s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 139, now 137).
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 1m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues.
        +1 javadoc 0m 25s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85
        -1 unit 64m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 65m 14s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 16s Patch generated 1 ASF License warnings.
        149m 28s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.getAbsoluteUsedCapacity() is unsynchronized, org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.setAbsoluteUsedCapacity(float) is synchronized At AbstractCSQueue.java:synchronized At AbstractCSQueue.java:[line 138]
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775929/YARN-4416.v1.001.patch
        JIRA Issue YARN-4416
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8cb050b17691 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 86c95cb
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9876/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9876/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 13s trunk passed +1 compile 0m 31s trunk passed with JDK v1.8.0_66 +1 compile 0m 32s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 28s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 38s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_66 +1 javac 0m 31s the patch passed +1 compile 0m 34s the patch passed with JDK v1.7.0_85 +1 javac 0m 34s the patch passed -1 checkstyle 0m 13s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 139, now 137). +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 30s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues. +1 javadoc 0m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_85 -1 unit 64m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 65m 14s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 16s Patch generated 1 ASF License warnings. 149m 28s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.getAbsoluteUsedCapacity() is unsynchronized, org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.setAbsoluteUsedCapacity(float) is synchronized At AbstractCSQueue.java:synchronized At AbstractCSQueue.java: [line 138] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775929/YARN-4416.v1.001.patch JIRA Issue YARN-4416 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8cb050b17691 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86c95cb findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9876/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9876/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9876/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        FindBugs and check style issue corrected in the attached patch, ASF license issue related to HDFS-9414, have reopened it.

        Show
        Naganarasimha Naganarasimha G R added a comment - FindBugs and check style issue corrected in the attached patch, ASF license issue related to HDFS-9414 , have reopened it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 4s trunk passed
        +1 compile 0m 30s trunk passed with JDK v1.8.0_66
        +1 compile 0m 33s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 29s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 36s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.8.0_66
        +1 javac 0m 32s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.7.0_85
        +1 javac 0m 32s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 28s the patch passed with JDK v1.7.0_85
        -1 unit 65m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        149m 59s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775942/YARN-4416.v1.002.patch
        JIRA Issue YARN-4416
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8a9be2f477b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 42d4901
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9877/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9877/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 4s trunk passed +1 compile 0m 30s trunk passed with JDK v1.8.0_66 +1 compile 0m 33s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 29s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 36s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_66 +1 javac 0m 32s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_85 +1 javac 0m 32s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 28s the patch passed with JDK v1.7.0_85 -1 unit 65m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 149m 59s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775942/YARN-4416.v1.002.patch JIRA Issue YARN-4416 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a9be2f477b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 42d4901 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9877/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9877/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9877/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        i have added locks for the access of schedulableEntities in AbstractComparatorOrderingPolicy but not completely sure of the modifications as there already synchronization on entitiesToReorder. So would like additional(/focused) review for this part in particular

        AbstractComparatorOrderingPolicy or OrderingPolicy is accessed under the lock from LeafQueue. This dependency does exists now. I feel, its better to access this via LeafQueue lock.

        Show
        sunilg Sunil G added a comment - i have added locks for the access of schedulableEntities in AbstractComparatorOrderingPolicy but not completely sure of the modifications as there already synchronization on entitiesToReorder. So would like additional(/focused) review for this part in particular AbstractComparatorOrderingPolicy or OrderingPolicy is accessed under the lock from LeafQueue. This dependency does exists now. I feel, its better to access this via LeafQueue lock.
        Hide
        sunilg Sunil G added a comment -

        Sorry, I was not very clear in my earlier comments.

        Almost all api's exposed from LeafQueue is used with Lock from Queue. Hence with this new lock, we are getting a hierarchy. Is this intentional.?
        Because we are going to have a new lock in a major code path.

        Also In LeafQueue#assignContainers

            for (Iterator<FiCaSchedulerApp> assignmentIterator =
                orderingPolicy.getAssignmentIterator(); assignmentIterator.hasNext();) {
              FiCaSchedulerApp application = assignmentIterator.next();
        
        

        we access the iterator from ordering policy under LeafQueue lock, so I could see that, now we have some methods in LeafQueue which is removed with LeafQueue lock and directly used only new lock from OrderingPolicy. So we need to slightly careful here as we should ensure we do not delete any item w/o LeafQueue lock. (we are now doing under LeafQueue lock, hence no issues as of now)

        Show
        sunilg Sunil G added a comment - Sorry, I was not very clear in my earlier comments. Almost all api's exposed from LeafQueue is used with Lock from Queue. Hence with this new lock, we are getting a hierarchy. Is this intentional.? Because we are going to have a new lock in a major code path. Also In LeafQueue#assignContainers for (Iterator<FiCaSchedulerApp> assignmentIterator = orderingPolicy.getAssignmentIterator(); assignmentIterator.hasNext();) { FiCaSchedulerApp application = assignmentIterator.next(); we access the iterator from ordering policy under LeafQueue lock, so I could see that, now we have some methods in LeafQueue which is removed with LeafQueue lock and directly used only new lock from OrderingPolicy. So we need to slightly careful here as we should ensure we do not delete any item w/o LeafQueue lock. (we are now doing under LeafQueue lock, hence no issues as of now)
        Hide
        sunilg Sunil G added a comment -

        A typo
        Almost all api's exposed from LeafQueue is used with Lock from Queue ==> Almost all api's exposed from AbstractComparatorOrderingPolicy is used with Lock from Queue

        Show
        sunilg Sunil G added a comment - A typo Almost all api's exposed from LeafQueue is used with Lock from Queue ==> Almost all api's exposed from AbstractComparatorOrderingPolicy is used with Lock from Queue
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Sunil G,

        Hence with this new lock, we are getting a hierarchy. Is this intentional.?

        Yes Sunil, even i was skeptical about it, but went ahead with Tan, Wangda's suggestion as there were similar read write locks held in queueCapacity, resource-usage & some methods were already updating them without locks on LeafQueue. Further was of the opinion that Ordering policy should not be dependent on LeafQueue for ensuring multithreaded consistency as its independent entity and can be used else where.

        we access the iterator from ordering policy under LeafQueue lock, so I could see that, now we have some methods in LeafQueue which is removed with LeafQueue lock and directly used only new lock from OrderingPolicy.

        Still all the methods which are modifying the Ordering policy is done holding lock on LeafQueue and if in future if any other place they modify they need to ensure first lock on Leaf queue is held. Also TreeSet iterator failsfast when the underlying set gets modified

        But Anyway need to evaluate the impact on the performance. Planning to run SLS with and without these changes to validate it.

        Further IMO i think we could have read write lock in LeafQueue which would better avoid all Synchronized locks on LeafQueue for the getter(/reads) in the leaf queue. Thoughts ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Sunil G , Hence with this new lock, we are getting a hierarchy. Is this intentional.? Yes Sunil, even i was skeptical about it, but went ahead with Tan, Wangda 's suggestion as there were similar read write locks held in queueCapacity, resource-usage & some methods were already updating them without locks on LeafQueue. Further was of the opinion that Ordering policy should not be dependent on LeafQueue for ensuring multithreaded consistency as its independent entity and can be used else where. we access the iterator from ordering policy under LeafQueue lock, so I could see that, now we have some methods in LeafQueue which is removed with LeafQueue lock and directly used only new lock from OrderingPolicy. Still all the methods which are modifying the Ordering policy is done holding lock on LeafQueue and if in future if any other place they modify they need to ensure first lock on Leaf queue is held. Also TreeSet iterator failsfast when the underlying set gets modified But Anyway need to evaluate the impact on the performance. Planning to run SLS with and without these changes to validate it. Further IMO i think we could have read write lock in LeafQueue which would better avoid all Synchronized locks on LeafQueue for the getter(/reads) in the leaf queue. Thoughts ?
        Hide
        sunilg Sunil G added a comment -

        I also agree that we need to make ordering policy independent. But a fail fast iterator will also be pblm as we have an open loophole to change some contents in SchedulableEntity. A discussion took place while doing priority with Jian on same line. And we dropped the plan to have locks inside ordering policy due to tight coupling with leafqueue. Looping Jian He also to the thread.

        Show
        sunilg Sunil G added a comment - I also agree that we need to make ordering policy independent. But a fail fast iterator will also be pblm as we have an open loophole to change some contents in SchedulableEntity. A discussion took place while doing priority with Jian on same line. And we dropped the plan to have locks inside ordering policy due to tight coupling with leafqueue. Looping Jian He also to the thread.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Sunil G,
        Hmm true, but any other way to avoid sync locks for the get API's ? I feel thats really not good its like web ui,CLI, REST everybody access Queue to get information and if any problem else where Main Scheduler Thread can get stuck. Also we can have unexpected deadlocks for read calls like one in the attached stack trace.
        Can Read/Write locks in the leaf queue be an option ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Sunil G , Hmm true, but any other way to avoid sync locks for the get API's ? I feel thats really not good its like web ui,CLI, REST everybody access Queue to get information and if any problem else where Main Scheduler Thread can get stuck. Also we can have unexpected deadlocks for read calls like one in the attached stack trace. Can Read/Write locks in the leaf queue be an option ?
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks for sharing your thoughts, Naganarasimha G R/Sunil G.

        Looked at code, I think we need to be very careful with the locking changes of OrderingPolicy. Since it will likely cause CME in the future.

        I would prefer to split the JIRA into two parts:

        • Remove redundant locks, such as getAbsoluteCapacity.
        • Improve locks of OrderingPolicy. Even if it closely related to LeafQueue, but I think we should try best to decouple it from LeafQueue to better API design. Potentially we need to rethink API of OrderingPolicy.

        I suggest to convert both JIRAs to sub jiras of YARN-3091.

        Show
        leftnoteasy Wangda Tan added a comment - Thanks for sharing your thoughts, Naganarasimha G R / Sunil G . Looked at code, I think we need to be very careful with the locking changes of OrderingPolicy. Since it will likely cause CME in the future. I would prefer to split the JIRA into two parts: Remove redundant locks, such as getAbsoluteCapacity. Improve locks of OrderingPolicy. Even if it closely related to LeafQueue, but I think we should try best to decouple it from LeafQueue to better API design. Potentially we need to rethink API of OrderingPolicy. I suggest to convert both JIRAs to sub jiras of YARN-3091 .
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Tan, Wangda,
        Will convert this jira and raise a new one under YARN-3091.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Tan, Wangda , Will convert this jira and raise a new one under YARN-3091 .
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Tan, Wangda, as per your earlier comment i have split the jira into 2 and have only focused on correcting by removing synchronization on the methods which are used in toString excluding the changes required for ordering policy.
        Further i have taken care of two things

        • absoluteCapacityResource was not used hence the variable and the method i have removed
        • getNumContainers was unnecessarily overridded in leaf queue hence removed it.
          Please provide your feed back
        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , as per your earlier comment i have split the jira into 2 and have only focused on correcting by removing synchronization on the methods which are used in toString excluding the changes required for ordering policy. Further i have taken care of two things absoluteCapacityResource was not used hence the variable and the method i have removed getNumContainers was unnecessarily overridded in leaf queue hence removed it. Please provide your feed back
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 30s trunk passed
        +1 compile 0m 26s trunk passed with JDK v1.8.0_66
        +1 compile 0m 29s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 9s trunk passed
        -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
        +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 26s the patch passed with JDK v1.8.0_66
        +1 javac 0m 26s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.7.0_91
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues.
        -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        +1 javadoc 0m 27s the patch passed with JDK v1.7.0_91
        -1 unit 63m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 65m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        146m 48s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.getAbsoluteUsedCapacity() is unsynchronized, org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.setAbsoluteUsedCapacity(float) is synchronized At AbstractCSQueue.java:synchronized At AbstractCSQueue.java:[line 138]
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776864/YARN-4416.v2.001.patch
        JIRA Issue YARN-4416
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5b57367875bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 21daa6c
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9930/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 76MB
        Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9930/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 30s trunk passed +1 compile 0m 26s trunk passed with JDK v1.8.0_66 +1 compile 0m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 9s trunk passed -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 33s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_66 +1 javac 0m 26s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_91 +1 javac 0m 30s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues. -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 0m 27s the patch passed with JDK v1.7.0_91 -1 unit 63m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 65m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 146m 48s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.getAbsoluteUsedCapacity() is unsynchronized, org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.setAbsoluteUsedCapacity(float) is synchronized At AbstractCSQueue.java:synchronized At AbstractCSQueue.java: [line 138] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776864/YARN-4416.v2.001.patch JIRA Issue YARN-4416 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5b57367875bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 21daa6c findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9930/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9930/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9930/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Tan, Wangda, attaching a patch removing the findbugs issues but the neither the test cases reported nor the javadocs are related to the modifications in the patch. Ran locally the test case failing in TestSubmitApplicationWithRMHA, and it passed

        Show
        Naganarasimha Naganarasimha G R added a comment - Tan, Wangda , attaching a patch removing the findbugs issues but the neither the test cases reported nor the javadocs are related to the modifications in the patch. Ran locally the test case failing in TestSubmitApplicationWithRMHA , and it passed
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 33s trunk passed
        +1 compile 0m 25s trunk passed with JDK v1.8.0_66
        +1 compile 0m 29s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 36s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 9s trunk passed
        -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
        +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 26s the patch passed with JDK v1.8.0_66
        +1 javac 0m 26s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.7.0_91
        +1 javac 0m 30s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 36s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 18s the patch passed
        -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91
        -1 unit 63m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        145m 41s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777288/YARN-4416.v2.002.patch
        JIRA Issue YARN-4416
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 52f81d6b18f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bf5295b
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9950/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9950/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 33s trunk passed +1 compile 0m 25s trunk passed with JDK v1.8.0_66 +1 compile 0m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 9s trunk passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 0m 26s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 33s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_66 +1 javac 0m 26s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_91 +1 javac 0m 30s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 18s the patch passed -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 0m 26s the patch passed with JDK v1.7.0_91 -1 unit 63m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 145m 41s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777288/YARN-4416.v2.002.patch JIRA Issue YARN-4416 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52f81d6b18f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf5295b findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9950/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 75MB Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9950/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Naganarasimha G R, getNumApplications calls ordering policy method. Is there any issue if we remove the synchronized lock?

        Show
        leftnoteasy Wangda Tan added a comment - Naganarasimha G R , getNumApplications calls ordering policy method. Is there any issue if we remove the synchronized lock?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Tan, Wangda, YARN-4416.v2.002.patch removed synchronized lock on getNumApplications.
        but i presume there will be possibility that in between getNumPendingApplications and getNumActiveApplications that activateApplications can be called and number of applications count can be given as a wrong value(more than actual). Shall i revert for this ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , YARN-4416 .v2.002.patch removed synchronized lock on getNumApplications. but i presume there will be possibility that in between getNumPendingApplications and getNumActiveApplications that activateApplications can be called and number of applications count can be given as a wrong value( more than actual ). Shall i revert for this ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Reverting the removal of lock on LeafQueue.getNumApplications

        Show
        Naganarasimha Naganarasimha G R added a comment - Reverting the removal of lock on LeafQueue.getNumApplications
        Hide
        leftnoteasy Wangda Tan added a comment -

        Naganarasimha G R, I would suggest to revert the change. And delay all OrderingPolicy-related changes to other JIRAs.

        Show
        leftnoteasy Wangda Tan added a comment - Naganarasimha G R , I would suggest to revert the change. And delay all OrderingPolicy-related changes to other JIRAs.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 4s trunk passed
        +1 compile 0m 30s trunk passed with JDK v1.8.0_66
        +1 compile 0m 31s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 39s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 14s trunk passed
        +1 javadoc 0m 23s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 29s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 36s the patch passed
        +1 compile 0m 29s the patch passed with JDK v1.8.0_66
        +1 javac 0m 29s the patch passed
        +1 compile 0m 33s the patch passed with JDK v1.7.0_91
        +1 javac 0m 33s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 38s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91
        -1 unit 68m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 66m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        153m 1s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777533/YARN-4416.v2.003.patch
        JIRA Issue YARN-4416
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 57b74b3cbd45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dfcbbdd
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9971/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9971/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 4s trunk passed +1 compile 0m 30s trunk passed with JDK v1.8.0_66 +1 compile 0m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 14s trunk passed +1 javadoc 0m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 29s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 36s the patch passed +1 compile 0m 29s the patch passed with JDK v1.8.0_66 +1 javac 0m 29s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_91 +1 javac 0m 33s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 38s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91 -1 unit 68m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 66m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 153m 1s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777533/YARN-4416.v2.003.patch JIRA Issue YARN-4416 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 57b74b3cbd45 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dfcbbdd findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9971/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9971/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9971/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Thanks Naganarasimha G R for update.

        Latest patch looks good, +1, could you run failed unit tests locally? (just to be safe)

        Show
        leftnoteasy Wangda Tan added a comment - Thanks Naganarasimha G R for update. Latest patch looks good, +1, could you run failed unit tests locally? (just to be safe)
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8978/)
        YARN-4416. Deadlock due to synchronised get Methods in AbstractCSQueue. (wangda: rev 9b856d9787be5ec88ef34574b9b98755d7b669ea)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8978/ ) YARN-4416 . Deadlock due to synchronised get Methods in AbstractCSQueue. (wangda: rev 9b856d9787be5ec88ef34574b9b98755d7b669ea) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Tan, Wangda, i tested TestWorkPreservingRMRestart and it runs fine in my local setup, but TestClientRMTokens and TestAMAuthorization are already existing issues for which jira's have already been raised.

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , i tested TestWorkPreservingRMRestart and it runs fine in my local setup, but TestClientRMTokens and TestAMAuthorization are already existing issues for which jira's have already been raised.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk/branch-2. Thanks Naganarasimha G R, and thanks Sunil G for reviewing the patch.

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2. Thanks Naganarasimha G R , and thanks Sunil G for reviewing the patch.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the review and commit Tan, Wangda & Sunil G

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the review and commit Tan, Wangda & Sunil G
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to branch-2.8.

        Show
        leftnoteasy Wangda Tan added a comment - Committed to branch-2.8.

          People

          • Assignee:
            Naganarasimha Naganarasimha G R
            Reporter:
            Naganarasimha Naganarasimha G R
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development