Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4400

AsyncDispatcher.waitForDrained should be final

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: yarn
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. YARN-4400.001.patch
      0.9 kB
      Daniel Templeton

      Activity

      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9019 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9019/)
      YARN-4400. AsyncDispatcher.waitForDrained should be final. Contributed (junping_du: rev bb5df272b9c0be9830ee8480cd33e75d26deb9d1)

      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java
      • hadoop-yarn-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9019 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9019/ ) YARN-4400 . AsyncDispatcher.waitForDrained should be final. Contributed (junping_du: rev bb5df272b9c0be9830ee8480cd33e75d26deb9d1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java hadoop-yarn-project/CHANGES.txt
      Hide
      djp Junping Du added a comment -

      I have commit the patch to trunk, branch-2 and branch-2.8. Thanks Daniel Templeton for contributing the patch!

      Show
      djp Junping Du added a comment - I have commit the patch to trunk, branch-2 and branch-2.8. Thanks Daniel Templeton for contributing the patch!
      Hide
      djp Junping Du added a comment -

      Nice catch, Daniel Templeton! +1 on the patch, committing it now.

      Show
      djp Junping Du added a comment - Nice catch, Daniel Templeton ! +1 on the patch, committing it now.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 9m 4s trunk passed
      +1 compile 0m 31s trunk passed with JDK v1.8.0_66
      +1 compile 0m 32s trunk passed with JDK v1.7.0_85
      +1 checkstyle 0m 17s trunk passed
      +1 mvnsite 0m 38s trunk passed
      +1 mvneclipse 0m 14s trunk passed
      +1 findbugs 1m 32s trunk passed
      +1 javadoc 0m 35s trunk passed with JDK v1.8.0_66
      +1 javadoc 0m 39s trunk passed with JDK v1.7.0_85
      +1 mvninstall 0m 35s the patch passed
      +1 compile 0m 31s the patch passed with JDK v1.8.0_66
      +1 javac 0m 31s the patch passed
      +1 compile 0m 33s the patch passed with JDK v1.7.0_85
      +1 javac 0m 33s the patch passed
      +1 checkstyle 0m 17s the patch passed
      +1 mvnsite 0m 37s the patch passed
      +1 mvneclipse 0m 15s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 42s the patch passed
      +1 javadoc 0m 35s the patch passed with JDK v1.8.0_66
      +1 javadoc 0m 39s the patch passed with JDK v1.7.0_85
      +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
      +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
      +1 asflicense 0m 25s Patch does not generate ASF License warnings.
      26m 12s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774854/YARN-4400.001.patch
      JIRA Issue YARN-4400
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 8bee22303cec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 43acf9a
      findbugs v3.0.0
      JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9813/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
      Max memory used 76MB
      Powered by Apache Yetus http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9813/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 4s trunk passed +1 compile 0m 31s trunk passed with JDK v1.8.0_66 +1 compile 0m 32s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 38s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 35s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 39s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 35s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_66 +1 javac 0m 31s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_85 +1 javac 0m 33s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 37s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 35s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 39s the patch passed with JDK v1.7.0_85 +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 26m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774854/YARN-4400.001.patch JIRA Issue YARN-4400 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8bee22303cec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 43acf9a findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9813/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9813/console This message was automatically generated.

        People

        • Assignee:
          templedf Daniel Templeton
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development