Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4388

Cleanup "mapreduce.job.hdfs-servers" from yarn-default.xml

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: yarn
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It is obviously that "mapreduce.job.hdfs-servers" shouldn't belongs to yarn configuration so we should move it to mapred-default.xml.

        Activity

        Hide
        djp Junping Du added a comment -

        Upload a patch which is quite straight-forward.

        Show
        djp Junping Du added a comment - Upload a patch which is quite straight-forward.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 35s trunk passed
        +1 compile 9m 41s trunk passed with JDK v1.8.0_66
        +1 compile 9m 49s trunk passed with JDK v1.7.0_85
        +1 checkstyle 1m 5s trunk passed
        +1 mvnsite 1m 42s trunk passed
        +1 mvneclipse 0m 44s trunk passed
        -1 findbugs 1m 27s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings.
        +1 javadoc 1m 44s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 6s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 33s the patch passed
        +1 compile 10m 14s the patch passed with JDK v1.8.0_66
        +1 javac 10m 14s the patch passed
        +1 compile 10m 8s the patch passed with JDK v1.7.0_85
        +1 javac 10m 8s the patch passed
        +1 checkstyle 1m 5s the patch passed
        +1 mvnsite 1m 44s the patch passed
        +1 mvneclipse 0m 44s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 5m 3s the patch passed
        +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 15s the patch passed with JDK v1.7.0_85
        +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
        +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
        +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85.
        -1 asflicense 0m 24s Patch generated 1 ASF License warnings.
        91m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774081/YARN-4388.patch
        JIRA Issue YARN-4388
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux eb0c19a3d2fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 28dfe72
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9782/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9782/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9782/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
        Max memory used 78MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9782/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 35s trunk passed +1 compile 9m 41s trunk passed with JDK v1.8.0_66 +1 compile 9m 49s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 5s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 44s trunk passed -1 findbugs 1m 27s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 2 extant Findbugs warnings. +1 javadoc 1m 44s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 6s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 33s the patch passed +1 compile 10m 14s the patch passed with JDK v1.8.0_66 +1 javac 10m 14s the patch passed +1 compile 10m 8s the patch passed with JDK v1.7.0_85 +1 javac 10m 8s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 3s the patch passed +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 15s the patch passed with JDK v1.7.0_85 +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_66. +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 24s Patch generated 1 ASF License warnings. 91m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774081/YARN-4388.patch JIRA Issue YARN-4388 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux eb0c19a3d2fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28dfe72 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9782/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9782/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9782/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9782/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        LGTM.

        Show
        varun_saxena Varun Saxena added a comment - LGTM.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 17s Maven dependency ordering for branch
        +1 mvninstall 7m 4s trunk passed
        +1 compile 6m 50s trunk passed
        +1 checkstyle 1m 37s trunk passed
        +1 mvnsite 1m 37s trunk passed
        +1 mvneclipse 0m 42s trunk passed
        +1 findbugs 3m 19s trunk passed
        +1 javadoc 1m 10s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 18s the patch passed
        +1 compile 7m 22s the patch passed
        +1 javac 7m 22s the patch passed
        +1 checkstyle 1m 31s the patch passed
        +1 mvnsite 1m 32s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 3s The patch has no ill-formed XML file.
        +1 findbugs 3m 43s the patch passed
        +1 javadoc 1m 25s the patch passed
        +1 unit 0m 30s hadoop-yarn-api in the patch passed.
        +1 unit 2m 24s hadoop-yarn-common in the patch passed.
        +1 unit 2m 37s hadoop-mapreduce-client-core in the patch passed.
        +1 asflicense 0m 26s The patch does not generate ASF License warnings.
        70m 9s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue YARN-4388
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774081/YARN-4388.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux fa650b83cfa5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6fbfb50
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13568/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13568/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 4s trunk passed +1 compile 6m 50s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 3m 19s trunk passed +1 javadoc 1m 10s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 7m 22s the patch passed +1 javac 7m 22s the patch passed +1 checkstyle 1m 31s the patch passed +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 findbugs 3m 43s the patch passed +1 javadoc 1m 25s the patch passed +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 24s hadoop-yarn-common in the patch passed. +1 unit 2m 37s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 70m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4388 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774081/YARN-4388.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux fa650b83cfa5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fbfb50 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13568/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/13568/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed to trunk, branch-2.
        Thanks Junping Du for your contribution.

        Show
        varun_saxena Varun Saxena added a comment - Committed to trunk, branch-2. Thanks Junping Du for your contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10710 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10710/)
        YARN-4388. Cleanup mapreduce.job.hdfs-servers from yarn-default.xml (varunsaxena: rev dd4ed6a587bf9cc57eb38d7957d8a907901a1cac)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10710 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10710/ ) YARN-4388 . Cleanup mapreduce.job.hdfs-servers from yarn-default.xml (varunsaxena: rev dd4ed6a587bf9cc57eb38d7957d8a907901a1cac) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml

          People

          • Assignee:
            djp Junping Du
            Reporter:
            djp Junping Du
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development