Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      updateNodeResource CLI should not accept negative values for MemSize and vCores.

        Activity

        Hide
        djp Junping Du added a comment -

        Thanks Wangda Tan for review and commit!

        Show
        djp Junping Du added a comment - Thanks Wangda Tan for review and commit!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/640/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #640 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/640/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2577/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2577 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2577/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2661 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2661/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2661 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2661/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #729 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/729/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #729 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/729/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1451 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1451/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1451 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1451/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #719 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/719/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #719 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/719/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8882/)
        YARN-4384. updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8882/ ) YARN-4384 . updateNodeResource CLI should not accept negative values for (wangda: rev 23c625ec571b01c0a2811728608890da38f86890) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java hadoop-yarn-project/CHANGES.txt
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk/branch-2, thanks Junping Du!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Junping Du !
        Hide
        leftnoteasy Wangda Tan added a comment -

        +1, committing...

        Show
        leftnoteasy Wangda Tan added a comment - +1, committing...
        Hide
        djp Junping Du added a comment -

        Test failures are not related and tracked by YARN-4351.

        Show
        djp Junping Du added a comment - Test failures are not related and tracked by YARN-4351 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 8s trunk passed
        +1 compile 0m 16s trunk passed with JDK v1.8.0_66
        +1 compile 0m 20s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 36s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.8.0_66
        +1 javac 0m 17s the patch passed
        +1 compile 0m 20s the patch passed with JDK v1.7.0_85
        +1 javac 0m 20s the patch passed
        +1 checkstyle 0m 9s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 43s the patch passed
        +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 18s the patch passed with JDK v1.7.0_85
        -1 unit 49m 26s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 49m 37s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        114m 7s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773870/YARN-4384.patch
        JIRA Issue YARN-4384
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ec0bd3708079 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 201f14e
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9767/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9767/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 8s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_66 +1 compile 0m 20s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 36s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 21s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_66 +1 javac 0m 17s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_85 +1 javac 0m 20s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 43s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 18s the patch passed with JDK v1.7.0_85 -1 unit 49m 26s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 49m 37s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 114m 7s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773870/YARN-4384.patch JIRA Issue YARN-4384 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec0bd3708079 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 201f14e findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9767/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9767/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9767/console This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Upload a patch to fix this.

        Show
        djp Junping Du added a comment - Upload a patch to fix this.
        Hide
        djp Junping Du added a comment -

        Thanks for reporting this, Sushmitha Sreenivasan! I agree that we should check the value to make sure admin/user won't set some invalid values to memory and vCore unintentionally. Will update a patch to fix it.

        Show
        djp Junping Du added a comment - Thanks for reporting this, Sushmitha Sreenivasan ! I agree that we should check the value to make sure admin/user won't set some invalid values to memory and vCore unintentionally. Will update a patch to fix it.

          People

          • Assignee:
            djp Junping Du
            Reporter:
            ssreenivasan Sushmitha Sreenivasan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development