[YARN-4363] In TestFairScheduler, testcase should not create FairScheduler redundantly

• Type: Test
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.9.0, 3.0.0-alpha2
• Component/s: fairscheduler
• Hadoop Flags: Reviewed
• Assignee: Tao Jie
• Reporter: Tao Jie
• Created: 17/Nov/15 07:48
• Updated: 27/Oct/16 06:40
• Resolved: 27/Oct/16 06:30

Description

I am trying to make some improvement on fairscheduler, but get some test failure on TestFairScheduler, due to redundant FairScheduler creation:
In TestFairScheduler, FairScheduler and RM is created, then set RMContext of RM to scheduler.

@Before
  public void setUp() throws IOException {
    scheduler = new FairScheduler();
    conf = createConfiguration();
    resourceManager = new MockRM(conf);
    scheduler.setRMContext(resourceManager.getRMContext());
  }

However in several case, scheduler is renewed, as a result RMcontext in scheduler is null.

 @Test  
  public void testMinZeroResourcesSettings() throws IOException {  
    scheduler = new FairScheduler();
    YarnConfiguration conf = new YarnConfiguration();
    ...
    scheduler.init(conf);

Then do scheduler.init(conf), I get a NPE(I try to get something from RMContext in scheduler initialization).
So FairScheduler should not be renewed in test block.