Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4330

MiniYARNCluster is showing multiple Failed to instantiate default resource calculator warning messages.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: test, yarn
    • Labels:
    • Environment:

      OSX, JUnit

    • Hadoop Flags:
      Reviewed

      Description

      Whenever I try to start a MiniYARNCluster on Branch-2 (commit #0b61cca), I see multiple stack traces warning me that a resource calculator plugin could not be created

      (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
      java.lang.UnsupportedOperationException: Could not determine OS
      

      This is a minicluster. It doesn't need resource calculation. It certainly doesn't need test logs being cluttered with even more stack traces which will only generate false alarms about tests failing.

      There needs to be a way to turn this off, and the minicluster should have it that way by default.

      Being ruthless and marking as a blocker, because its a fairly major regression for anyone testing with the minicluster.

      1. YARN-4330.002.patch
        15 kB
        Varun Saxena
      2. YARN-4330.003.patch
        17 kB
        Varun Saxena
      3. YARN-4330.004.patch
        15 kB
        Varun Saxena
      4. YARN-4330.01.patch
        20 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looks like YARN-3534 triggered this.

          Full Stack: note the sheer number of repeated traces

          Projects/slider/slider-core/target/teststandalonerest/teststandalonerest-logDir-nm-0_0
          2015-11-04 17:49:31,322 [Thread-2] INFO  server.MiniYARNCluster (MiniYARNCluster.java:serviceInit(540)) - Starting NM: 0
          2015-11-04 17:49:31,383 [Thread-2] INFO  nodemanager.NodeManager (NodeManager.java:getNodeHealthScriptRunner(255)) - Node Manager health check script is not available or doesn't have execute permission, so not starting the node health script runner.
          2015-11-04 17:49:31,469 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeResourceMonitorImpl.serviceInit(NodeResourceMonitorImpl.java:73)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,472 [Thread-2] INFO  nodemanager.NodeResourceMonitorImpl (NodeResourceMonitorImpl.java:serviceInit(76)) -  Using ResourceCalculatorPlugin : null
          2015-11-04 17:49:31,475 [Thread-2] INFO  containermanager.ContainerManagerImpl (ContainerManagerImpl.java:serviceInit(261)) - AMRMProxyService is disabled
          2015-11-04 17:49:31,475 [Thread-2] INFO  localizer.ResourceLocalizationService (ResourceLocalizationService.java:validateConf(224)) - per directory file limit = 8192
          2015-11-04 17:49:31,549 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:114)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,551 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getContainerMemoryMB(NodeManagerHardwareUtils.java:247)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:134)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,552 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getVCores(NodeManagerHardwareUtils.java:158)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:137)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,554 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getContainerMemoryMB(NodeManagerHardwareUtils.java:247)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.serviceInit(NodeStatusUpdaterImpl.java:167)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,555 [Thread-2] WARN  util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator.
          java.lang.UnsupportedOperationException: Could not determine OS
          	at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41)
          	at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182)
          	at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getVCores(NodeManagerHardwareUtils.java:158)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.serviceInit(NodeStatusUpdaterImpl.java:174)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107)
          	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.service.Service$init.call(Unknown Source)
          	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
          	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120)
          	at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110)
          	at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127)
          	at org.apache.slider.agent.rest.TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:606)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          2015-11-04 17:49:31,558 [Thread-2] INFO  server.MiniYARNCluster (MiniYARNCluster.java:startResourceManager(326)) - Waiting for RM to start...
          2015-11-04 17:49:31,558 [RM-0] INFO  resourcemanager.ResourceManager (ResourceManager.java:transitionToActive(1024)) - Transitioning to active state
          2015-11-04 17:49:31,571 [RM-0] INFO  recovery.RMStateStore (RMStateStore.java:transition(487)) - Updating AMRMToken
          2015-11-04 17:49:31,572 [RM-0] INFO  recovery.RMStateStore (RMStateStore.java:transition(438)) - Storing RMDTMasterKey.
          
          
          Show
          stevel@apache.org Steve Loughran added a comment - Looks like YARN-3534 triggered this. Full Stack: note the sheer number of repeated traces Projects/slider/slider-core/target/teststandalonerest/teststandalonerest-logDir-nm-0_0 2015-11-04 17:49:31,322 [ Thread -2] INFO server.MiniYARNCluster (MiniYARNCluster.java:serviceInit(540)) - Starting NM: 0 2015-11-04 17:49:31,383 [ Thread -2] INFO nodemanager.NodeManager (NodeManager.java:getNodeHealthScriptRunner(255)) - Node Manager health check script is not available or doesn't have execute permission, so not starting the node health script runner. 2015-11-04 17:49:31,469 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.NodeResourceMonitorImpl.serviceInit(NodeResourceMonitorImpl.java:73) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,472 [ Thread -2] INFO nodemanager.NodeResourceMonitorImpl (NodeResourceMonitorImpl.java:serviceInit(76)) - Using ResourceCalculatorPlugin : null 2015-11-04 17:49:31,475 [ Thread -2] INFO containermanager.ContainerManagerImpl (ContainerManagerImpl.java:serviceInit(261)) - AMRMProxyService is disabled 2015-11-04 17:49:31,475 [ Thread -2] INFO localizer.ResourceLocalizationService (ResourceLocalizationService.java:validateConf(224)) - per directory file limit = 8192 2015-11-04 17:49:31,549 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:114) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,551 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getContainerMemoryMB(NodeManagerHardwareUtils.java:247) at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:134) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,552 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getVCores(NodeManagerHardwareUtils.java:158) at org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl.serviceInit(ContainersMonitorImpl.java:137) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.containermanager.ContainerManagerImpl.serviceInit(ContainerManagerImpl.java:271) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,554 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getContainerMemoryMB(NodeManagerHardwareUtils.java:247) at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.serviceInit(NodeStatusUpdaterImpl.java:167) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,555 [ Thread -2] WARN util.ResourceCalculatorPlugin (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) - java.lang.UnsupportedOperationException: Could not determine OS: Failed to instantiate default resource calculator. java.lang.UnsupportedOperationException: Could not determine OS at org.apache.hadoop.util.SysInfo.newInstance(SysInfo.java:43) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.<init>(ResourceCalculatorPlugin.java:41) at org.apache.hadoop.yarn.util.ResourceCalculatorPlugin.getResourceCalculatorPlugin(ResourceCalculatorPlugin.java:182) at org.apache.hadoop.yarn.server.nodemanager.util.NodeManagerHardwareUtils.getVCores(NodeManagerHardwareUtils.java:158) at org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.serviceInit(NodeStatusUpdaterImpl.java:174) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:356) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.MiniYARNCluster$NodeManagerWrapper.serviceInit(MiniYARNCluster.java:541) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:107) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:273) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.service.Service$init.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at org.apache.slider.test.YarnMiniClusterTestBase.createMiniCluster(YarnMiniClusterTestBase.groovy:291) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:110) at org.apache.slider.test.YarnZKMiniClusterTestBase.createMiniCluster(YarnZKMiniClusterTestBase.groovy:127) at org.apache.slider.agent. rest .TestStandaloneREST.testStandaloneREST(TestStandaloneREST.groovy:52) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) 2015-11-04 17:49:31,558 [ Thread -2] INFO server.MiniYARNCluster (MiniYARNCluster.java:startResourceManager(326)) - Waiting for RM to start... 2015-11-04 17:49:31,558 [RM-0] INFO resourcemanager.ResourceManager (ResourceManager.java:transitionToActive(1024)) - Transitioning to active state 2015-11-04 17:49:31,571 [RM-0] INFO recovery.RMStateStore (RMStateStore.java:transition(487)) - Updating AMRMToken 2015-11-04 17:49:31,572 [RM-0] INFO recovery.RMStateStore (RMStateStore.java:transition(438)) - Storing RMDTMasterKey.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          As well as having a way to turn this feature off for miniclusters, the code trying to instantiate the resource calculator should recognise the falure and fallback, rather than retry. Retrying isn't going to fix this.

          Show
          stevel@apache.org Steve Loughran added a comment - As well as having a way to turn this feature off for miniclusters, the code trying to instantiate the resource calculator should recognise the falure and fallback, rather than retry. Retrying isn't going to fix this.
          Hide
          varun_saxena Varun Saxena added a comment -

          Its not retrying per say. Its just that we are trying to get memory and CPU info at multiple places. And at some places(for monitoring) its either trying to read the calculator plugin class from config and at some just directly the default one(while trying to detect NM's CPU/memory capability). As for default resource calculator plugin, Mac is not supported, hence the UnsupportedOperationException.

          While monitoring, if resource calculator plugin class is not configured, trying to load default calculator plugin(and hence this code path) is the default behavior. We cant really switch it off. But we need not print the whole stack trace for UnsupportedOperationException.

          For MiniYARNCluster, we can do a few more things.
          When we try and load default resource calculator plugin via NodeManagerHardwareUtils class(to detect NMs' CPU/memory), we can switch off this behavior via a config. Code can be rearranged so that this error doesnt show up and we check the config first. And this config can be set to false in MiniYarnCluster
          Also, a dummy plugin implementation can also be included in MiniYarnCluster and set in config so that it does not try to load default resource calculator

          Show
          varun_saxena Varun Saxena added a comment - Its not retrying per say. Its just that we are trying to get memory and CPU info at multiple places. And at some places(for monitoring) its either trying to read the calculator plugin class from config and at some just directly the default one(while trying to detect NM's CPU/memory capability). As for default resource calculator plugin, Mac is not supported, hence the UnsupportedOperationException. While monitoring, if resource calculator plugin class is not configured, trying to load default calculator plugin(and hence this code path) is the default behavior. We cant really switch it off. But we need not print the whole stack trace for UnsupportedOperationException. For MiniYARNCluster, we can do a few more things. When we try and load default resource calculator plugin via NodeManagerHardwareUtils class(to detect NMs' CPU/memory), we can switch off this behavior via a config. Code can be rearranged so that this error doesnt show up and we check the config first. And this config can be set to false in MiniYarnCluster Also, a dummy plugin implementation can also be included in MiniYarnCluster and set in config so that it does not try to load default resource calculator
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 for downgrading the stack trace to DEBUG level; anything at INFO/WARN should include the calculator plugin conf value in case that is the problem.

          and another +1 for having a way to turn this off for minicluster tests. Having a dummy plugin would be more generally useful, and avoid having yet another config option

          Show
          stevel@apache.org Steve Loughran added a comment - +1 for downgrading the stack trace to DEBUG level; anything at INFO/WARN should include the calculator plugin conf value in case that is the problem. and another +1 for having a way to turn this off for minicluster tests. Having a dummy plugin would be more generally useful, and avoid having yet another config option
          Hide
          varun_saxena Varun Saxena added a comment -

          Patch does the following :
          1. If node resource monitoring interval or container monitoring interval is <= 0, considering this is as disabling monitoring. Interval <=0 doesnt make much sense anyways. Resource calculator plugin(even the default one) wont be required if interval is <=0. Have made changes in relevant classes to take care of this change. Also, I have set this config to 0 in MiniYARNCluster. Dummy plugin wont be required in this case.
          2. In NodeManagerHardwareUtils, we take the memory and CPU from config if hardware detection is disabled irrespective of whether resource calculator plugin can be created or not . Moved around the code in the class to check for the config for disable first and returning value from config if its so. In MiniYARNCluster have explicitly set it to false. I dont think hardware detection is required for tests.
          3. Catching UnsupportedOperationException and logging it at info. No stack trace is printed. For other exceptions, stack trace will be printed(keeping it consistent with previous behavior). Maybe stack trace in case of other unexpected exceptions may be useful.

          Show
          varun_saxena Varun Saxena added a comment - Patch does the following : 1. If node resource monitoring interval or container monitoring interval is <= 0, considering this is as disabling monitoring. Interval <=0 doesnt make much sense anyways. Resource calculator plugin(even the default one) wont be required if interval is <=0. Have made changes in relevant classes to take care of this change. Also, I have set this config to 0 in MiniYARNCluster. Dummy plugin wont be required in this case. 2. In NodeManagerHardwareUtils, we take the memory and CPU from config if hardware detection is disabled irrespective of whether resource calculator plugin can be created or not . Moved around the code in the class to check for the config for disable first and returning value from config if its so. In MiniYARNCluster have explicitly set it to false. I dont think hardware detection is required for tests. 3. Catching UnsupportedOperationException and logging it at info. No stack trace is printed. For other exceptions, stack trace will be printed(keeping it consistent with previous behavior). Maybe stack trace in case of other unexpected exceptions may be useful.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 19s trunk passed
          +1 compile 0m 49s trunk passed with JDK v1.8.0_60
          +1 compile 0m 46s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 25s trunk passed
          +1 mvneclipse 0m 39s trunk passed
          -1 findbugs 1m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 7s the patch passed
          +1 compile 0m 46s the patch passed with JDK v1.8.0_60
          +1 javac 0m 46s the patch passed
          +1 compile 0m 47s the patch passed with JDK v1.7.0_79
          +1 javac 0m 47s the patch passed
          -1 checkstyle 0m 23s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 29, now 29).
          +1 mvneclipse 0m 39s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 0s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 9s the patch passed with JDK v1.7.0_79
          +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_60.
          +1 unit 8m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60.
          -1 unit 5m 8s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_60.
          +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
          +1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79.
          -1 unit 5m 10s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          52m 52s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
          JDK v1.7.0_79 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-06
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch
          JIRA Issue YARN-4330
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml
          uname Linux e89942bf5ee6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
          git revision trunk / b64242c
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9635/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9635/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 19s trunk passed +1 compile 0m 49s trunk passed with JDK v1.8.0_60 +1 compile 0m 46s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 25s trunk passed +1 mvneclipse 0m 39s trunk passed -1 findbugs 1m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 7s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_60 +1 javac 0m 46s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_79 +1 javac 0m 47s the patch passed -1 checkstyle 0m 23s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 29, now 29). +1 mvneclipse 0m 39s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 0s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_79 +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_60. +1 unit 8m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_60. -1 unit 5m 8s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_60. +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. +1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_79. -1 unit 5m 10s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 52m 52s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity JDK v1.7.0_79 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-06 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch JIRA Issue YARN-4330 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile xml uname Linux e89942bf5ee6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / b64242c Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9635/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9635/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9635/console This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          TestContainerManagerSecurity is failing even without this patch.
          Checkstyle related(longer than 80 lines).

          For findbugs, there is YARN-4298

          Show
          varun_saxena Varun Saxena added a comment - TestContainerManagerSecurity is failing even without this patch. Checkstyle related(longer than 80 lines). For findbugs, there is YARN-4298
          Hide
          elgoiri Inigo Goiri added a comment -

          Steve Loughran, is this good to go?

          Show
          elgoiri Inigo Goiri added a comment - Steve Loughran , is this good to go?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 38s Maven dependency ordering for branch
          +1 mvninstall 8m 17s trunk passed
          +1 compile 2m 31s trunk passed with JDK v1.8.0_66
          +1 compile 2m 38s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 35s trunk passed
          +1 mvneclipse 0m 44s trunk passed
          +1 findbugs 3m 9s trunk passed
          +1 javadoc 1m 16s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 26s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 28s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 2m 25s the patch passed with JDK v1.8.0_66
          +1 javac 2m 25s the patch passed
          +1 compile 2m 31s the patch passed with JDK v1.7.0_91
          +1 javac 2m 31s the patch passed
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 24 unchanged - 1 fixed = 25 total (was 25)
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 3m 47s the patch passed
          +1 javadoc 1m 16s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 22s the patch passed with JDK v1.7.0_91
          +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 52s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 6m 38s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 6m 24s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          76m 45s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch
          JIRA Issue YARN-4330
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux e063a43cc0e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2673cba
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10452/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10452/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 8m 17s trunk passed +1 compile 2m 31s trunk passed with JDK v1.8.0_66 +1 compile 2m 38s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 44s trunk passed +1 findbugs 3m 9s trunk passed +1 javadoc 1m 16s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 26s trunk passed with JDK v1.7.0_91 0 mvndep 0m 28s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 2m 25s the patch passed with JDK v1.8.0_66 +1 javac 2m 25s the patch passed +1 compile 2m 31s the patch passed with JDK v1.7.0_91 +1 javac 2m 31s the patch passed -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 24 unchanged - 1 fixed = 25 total (was 25) +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 47s the patch passed +1 javadoc 1m 16s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 22s the patch passed with JDK v1.7.0_91 +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 52s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 6m 38s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_66. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 6m 24s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 76m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch JIRA Issue YARN-4330 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e063a43cc0e3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2673cba Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10452/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10452/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10452/console This message was automatically generated.
          Hide
          ebadger Eric Badger added a comment -

          Steve Loughran, there's talk on the mailing list of releasing 2.8. Is this ready to go in? If not, should we mark the target version to 2.8.0?

          cc Akira Ajisaka for 2.8 tracking purposes

          Show
          ebadger Eric Badger added a comment - Steve Loughran , there's talk on the mailing list of releasing 2.8. Is this ready to go in? If not, should we mark the target version to 2.8.0? cc Akira Ajisaka for 2.8 tracking purposes
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s YARN-4330 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch
          JIRA Issue YARN-4330
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13510/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s YARN-4330 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771077/YARN-4330.01.patch JIRA Issue YARN-4330 Console output https://builds.apache.org/job/PreCommit-YARN-Build/13510/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ebadger Eric Badger added a comment -

          I applied the most recent patch the branch-2.8 and ran TestMRTimelineEventHandling, which uses the MiniYARNCluster (I'm running MacOS Sierra). 2 of the 3 tests in the class consistently fail with the stacktraces as shown below. I didn't dig into the tests any further, but I imagine that this is reproducible on other machines.

          Running org.apache.hadoop.mapred.TestMRTimelineEventHandling
          Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 93.809 sec <<< FAILURE! - in org.apache.hadoop.mapred.TestMRTimelineEventHandling
          testMRTimelineEventHandling(org.apache.hadoop.mapred.TestMRTimelineEventHandling)  Time elapsed: 35.821 sec  <<< FAILURE!
          java.lang.AssertionError: expected:<2> but was:<3>
          	at org.apache.hadoop.mapred.TestMRTimelineEventHandling.testMRTimelineEventHandling(TestMRTimelineEventHandling.java:105)
          
          testMapreduceJobTimelineServiceEnabled(org.apache.hadoop.mapred.TestMRTimelineEventHandling)  Time elapsed: 32.703 sec  <<< FAILURE!
          java.lang.AssertionError: expected:<2> but was:<3>
          	at org.apache.hadoop.mapred.TestMRTimelineEventHandling.testMapreduceJobTimelineServiceEnabled(TestMRTimelineEventHandling.java:162)
          
          Show
          ebadger Eric Badger added a comment - I applied the most recent patch the branch-2.8 and ran TestMRTimelineEventHandling , which uses the MiniYARNCluster (I'm running MacOS Sierra). 2 of the 3 tests in the class consistently fail with the stacktraces as shown below. I didn't dig into the tests any further, but I imagine that this is reproducible on other machines. Running org.apache.hadoop.mapred.TestMRTimelineEventHandling Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 93.809 sec <<< FAILURE! - in org.apache.hadoop.mapred.TestMRTimelineEventHandling testMRTimelineEventHandling(org.apache.hadoop.mapred.TestMRTimelineEventHandling) Time elapsed: 35.821 sec <<< FAILURE! java.lang.AssertionError: expected:<2> but was:<3> at org.apache.hadoop.mapred.TestMRTimelineEventHandling.testMRTimelineEventHandling(TestMRTimelineEventHandling.java:105) testMapreduceJobTimelineServiceEnabled(org.apache.hadoop.mapred.TestMRTimelineEventHandling) Time elapsed: 32.703 sec <<< FAILURE! java.lang.AssertionError: expected:<2> but was:<3> at org.apache.hadoop.mapred.TestMRTimelineEventHandling.testMapreduceJobTimelineServiceEnabled(TestMRTimelineEventHandling.java:162)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Sorry, somehow I'd completely missed this. Apologies: I know exactly how it feels to have a patch neglected.

          Let's see what yetus says if I kick it off against trunk

          Show
          stevel@apache.org Steve Loughran added a comment - Sorry, somehow I'd completely missed this. Apologies: I know exactly how it feels to have a patch neglected. Let's see what yetus says if I kick it off against trunk
          Hide
          varun_saxena Varun Saxena added a comment -

          The patch no longer applies cleanly. Give me a day, I will put up a new patch for review.
          Also after YARN-5662, there is a slight modification required in the patch.

          Show
          varun_saxena Varun Saxena added a comment - The patch no longer applies cleanly. Give me a day, I will put up a new patch for review. Also after YARN-5662 , there is a slight modification required in the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 8m 5s trunk passed
          +1 compile 2m 48s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 28s trunk passed
          +1 mvneclipse 0m 46s trunk passed
          +1 findbugs 2m 23s trunk passed
          +1 javadoc 1m 3s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 8s the patch passed
          +1 compile 2m 16s the patch passed
          +1 javac 2m 16s the patch passed
          -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 22s the patch passed
          +1 javadoc 0m 54s the patch passed
          +1 unit 2m 16s hadoop-yarn-common in the patch passed.
          -1 unit 14m 58s hadoop-yarn-server-nodemanager in the patch failed.
          -1 unit 4m 26s hadoop-yarn-server-tests in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          56m 47s



          Reason Tests
          Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization
            hadoop.yarn.server.TestContainerManagerSecurity



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-4330
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835639/YARN-4330.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux a24df45a5514 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6fbfb50
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13562/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13562/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 8m 5s trunk passed +1 compile 2m 48s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 46s trunk passed +1 findbugs 2m 23s trunk passed +1 javadoc 1m 3s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 2m 16s the patch passed +1 javac 2m 16s the patch passed -0 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 22s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 2m 16s hadoop-yarn-common in the patch passed. -1 unit 14m 58s hadoop-yarn-server-nodemanager in the patch failed. -1 unit 4m 26s hadoop-yarn-server-tests in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 56m 47s Reason Tests Failed junit tests hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-4330 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835639/YARN-4330.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a24df45a5514 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fbfb50 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13562/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13562/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13562/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Test failures are unrelated.
          I have not introduced any new configuration for disabling node monitoring like we have for container monitoring. Just using duration to disable it, primarily because this is a test related change.

          Show
          varun_saxena Varun Saxena added a comment - Test failures are unrelated. I have not introduced any new configuration for disabling node monitoring like we have for container monitoring. Just using duration to disable it, primarily because this is a test related change.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Saxena,
          Jenkins failed tests seems to pass for me locally and Overall the patch looks fine except for the following nits :

          1. ContainersMonitorImpl.java, ln no 186: do we need this additional check monitoringInterval > 0; as there is already boolean configuration("yarn.nodemanager.container-monitor.enabled") for it i feel these checks are not required.
          2. NodeManagerHardwareUtils.java, ln no 40: name "isEnabled" can be modified to isHardwareDetectionEnabled ?

          Other changes seems to be reorganization, so i am ok with other changes.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Saxena , Jenkins failed tests seems to pass for me locally and Overall the patch looks fine except for the following nits : ContainersMonitorImpl.java, ln no 186: do we need this additional check monitoringInterval > 0; as there is already boolean configuration( "yarn.nodemanager.container-monitor.enabled" ) for it i feel these checks are not required. NodeManagerHardwareUtils.java, ln no 40: name "isEnabled" can be modified to isHardwareDetectionEnabled ? Other changes seems to be reorganization, so i am ok with other changes.
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Naganarasimha G R for the review.

          do we need this additional check monitoringInterval > 0;

          This was added because i am considering node monitoring as disabled if its <=0. Did not want to introduce a new config for test only change. So I just carried forward the same principle for container monitoring because a monitoring of interval of <=0 does not make any sense. I do not have a strong opinion on this though.

          NodeManagerHardwareUtils.java, ln no 40: name "isEnabled" can be modified to isHardwareDetectionEnabled ?

          Ok. Can do so.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Naganarasimha G R for the review. do we need this additional check monitoringInterval > 0; This was added because i am considering node monitoring as disabled if its <=0. Did not want to introduce a new config for test only change. So I just carried forward the same principle for container monitoring because a monitoring of interval of <=0 does not make any sense. I do not have a strong opinion on this though. NodeManagerHardwareUtils.java, ln no 40: name "isEnabled" can be modified to isHardwareDetectionEnabled ? Ok. Can do so.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Varun Saxena for the explanation, i think for the first comment we can keep it as existing behavior so that it works for 2.8 as the configuration for container monitoring is not there in 2.8. And can you please take care of other comment ?
          Steve Loughran, any further comments are we can go ahead with the approach as captured in the patch?

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Varun Saxena for the explanation, i think for the first comment we can keep it as existing behavior so that it works for 2.8 as the configuration for container monitoring is not there in 2.8. And can you please take care of other comment ? Steve Loughran , any further comments are we can go ahead with the approach as captured in the patch?
          Hide
          varun_saxena Varun Saxena added a comment -

          Uploading a patch after changing isEnabled to isHardwareDetectionEnabled

          Show
          varun_saxena Varun Saxena added a comment - Uploading a patch after changing isEnabled to isHardwareDetectionEnabled
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 6m 44s trunk passed
          +1 checkstyle 0m 48s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 1m 14s trunk passed
          +1 findbugs 2m 30s trunk passed
          +1 javadoc 1m 29s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 6s the patch passed
          +1 compile 5m 1s the patch passed
          +1 javac 5m 1s the patch passed
          -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
          +1 mvnsite 1m 47s the patch passed
          +1 mvneclipse 1m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 2m 50s the patch passed
          +1 javadoc 1m 25s the patch passed
          +1 unit 2m 30s hadoop-yarn-common in the patch passed.
          +1 unit 16m 4s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 4m 51s hadoop-yarn-server-tests in the patch failed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          69m 12s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestDiskFailures
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue YARN-4330
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838033/YARN-4330.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 7427c8f241a5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbb133c
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13828/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13828/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13828/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13828/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 6m 44s trunk passed +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 1m 14s trunk passed +1 findbugs 2m 30s trunk passed +1 javadoc 1m 29s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 5m 1s the patch passed +1 javac 5m 1s the patch passed -0 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74) +1 mvnsite 1m 47s the patch passed +1 mvneclipse 1m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 50s the patch passed +1 javadoc 1m 25s the patch passed +1 unit 2m 30s hadoop-yarn-common in the patch passed. +1 unit 16m 4s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 4m 51s hadoop-yarn-server-tests in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 69m 12s Reason Tests Failed junit tests hadoop.yarn.server.TestDiskFailures   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue YARN-4330 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838033/YARN-4330.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 7427c8f241a5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbb133c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13828/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13828/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13828/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13828/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          +1, approach seems to be fine. Could you confirm whether the test case failures are not related to the patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - +1, approach seems to be fine. Could you confirm whether the test case failures are not related to the patch ?
          Hide
          varun_saxena Varun Saxena added a comment - - edited

          Yes they are unrelated. We already have JIRAs' for these failures.

          Show
          varun_saxena Varun Saxena added a comment - - edited Yes they are unrelated. We already have JIRAs' for these failures.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Varun Saxena, Will wait for a day before committing !

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Varun Saxena , Will wait for a day before committing !
          Hide
          elgoiri Inigo Goiri added a comment -

          After YARN-5356, I think that NodeManagerHardwareUtils should use getNodeResourceMonitorPlugin() to get the ResourceCalculatorPlugin.

          Show
          elgoiri Inigo Goiri added a comment - After YARN-5356 , I think that NodeManagerHardwareUtils should use getNodeResourceMonitorPlugin() to get the ResourceCalculatorPlugin .
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Inigo Goiri for letting us know... Will make the change.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Inigo Goiri for letting us know... Will make the change.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Inigo Goiri & Varun Saxena,

          I think that NodeManagerHardwareUtils should use getNodeResourceMonitorPlugin() to get the ResourceCalculatorPlugin.

          I would like to differ here, focus of the jira here is to refactor the code and avoid the logs in Mini yarn cluster, So would not like to include changes outside the scope and may be we can raise a new jira and handle it there ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Inigo Goiri & Varun Saxena , I think that NodeManagerHardwareUtils should use getNodeResourceMonitorPlugin() to get the ResourceCalculatorPlugin. I would like to differ here, focus of the jira here is to refactor the code and avoid the logs in Mini yarn cluster, So would not like to include changes outside the scope and may be we can raise a new jira and handle it there ?
          Hide
          varun_saxena Varun Saxena added a comment - - edited

          Agree... I was under the impression that we get Resource calculator plugin by passing the relevant class name in NodeManagerHardwareUtils but we do not in current code. It is passed from the caller i.e. primarily from ContainersMonitorImpl. So if something specific has to be done to load Node resource monitor plugin, that should be done in another JIRA because I do not see the need wrt current methods in the class.

          Show
          varun_saxena Varun Saxena added a comment - - edited Agree... I was under the impression that we get Resource calculator plugin by passing the relevant class name in NodeManagerHardwareUtils but we do not in current code. It is passed from the caller i.e. primarily from ContainersMonitorImpl. So if something specific has to be done to load Node resource monitor plugin, that should be done in another JIRA because I do not see the need wrt current methods in the class.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi all, If no more comments i think its good enough to go in. Will commit it by end of today ...

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi all, If no more comments i think its good enough to go in. Will commit it by end of today ...
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Varun Saxena,
          Patch seems to be not applying can you check and rebase !

          Show
          Naganarasimha Naganarasimha G R added a comment - Varun Saxena , Patch seems to be not applying can you check and rebase !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 2s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 5m 5s trunk passed
          +1 checkstyle 0m 44s trunk passed
          +1 mvnsite 1m 36s trunk passed
          +1 mvneclipse 1m 0s trunk passed
          -1 findbugs 0m 20s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
          +1 javadoc 1m 12s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 4s the patch passed
          +1 compile 4m 35s the patch passed
          +1 javac 4m 35s the patch passed
          -0 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 57s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 19s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml)
          +1 javadoc 1m 11s the patch passed
          +1 unit 2m 23s hadoop-yarn-common in the patch passed.
          +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed.
          -1 unit 4m 35s hadoop-yarn-server-tests in the patch failed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          62m 7s



          Reason Tests
          Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.yarn.server.TestMiniYarnClusterNodeUtilization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-4330
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840008/YARN-4330.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux db3df7ffe195 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a926f89
          Default Java 1.8.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14018/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14018/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 2s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 5m 5s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 1m 0s trunk passed -1 findbugs 0m 20s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml) +1 javadoc 1m 12s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 4s the patch passed +1 compile 4m 35s the patch passed +1 javac 4m 35s the patch passed -0 checkstyle 0m 43s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25) +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 19s patch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/target/findbugsXml.xml) +1 javadoc 1m 11s the patch passed +1 unit 2m 23s hadoop-yarn-common in the patch passed. +1 unit 13m 40s hadoop-yarn-server-nodemanager in the patch passed. -1 unit 4m 35s hadoop-yarn-server-tests in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 62m 7s Reason Tests Failed junit tests hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-4330 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840008/YARN-4330.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux db3df7ffe195 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a926f89 Default Java 1.8.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/14018/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14018/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14018/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          test case failure are not related and findbugs do not run for hadoop-yarn-server-tests so went ahead with the commit, It applies successfully on trunk and branch-2, Varun Saxena can you check for branch-2.8 as its failing ?

          Show
          Naganarasimha Naganarasimha G R added a comment - test case failure are not related and findbugs do not run for hadoop-yarn-server-tests so went ahead with the commit, It applies successfully on trunk and branch-2, Varun Saxena can you check for branch-2.8 as its failing ?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10879 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10879/)
          YARN-4330. MiniYARNCluster is showing multiple Failed to instantiate (naganarasimha_gr: rev 3541ed80685f25486f33ef0f553854ccbdeb51d4)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorPlugin.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeResourceMonitorImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10879 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10879/ ) YARN-4330 . MiniYARNCluster is showing multiple Failed to instantiate (naganarasimha_gr: rev 3541ed80685f25486f33ef0f553854ccbdeb51d4) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ResourceCalculatorPlugin.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeResourceMonitorImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Hide
          andrew.wang Andrew Wang added a comment -

          I set the fix versions based on current git state. Please update the 2.x fix version if this goes back to 2.8.

          Show
          andrew.wang Andrew Wang added a comment - I set the fix versions based on current git state. Please update the 2.x fix version if this goes back to 2.8.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Saxena & Steve Loughran,
          Is it ok to fix this issue in 2.9 and trunk ? shall i resolve this issue or still you guys have plans for 2.8 ?
          IMO its not a must for 2.8 but feel its good to have. Please share your thoughts

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Saxena & Steve Loughran , Is it ok to fix this issue in 2.9 and trunk ? shall i resolve this issue or still you guys have plans for 2.8 ? IMO its not a must for 2.8 but feel its good to have. Please share your thoughts
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Will wait for a day more and if none has any concerns on closing this issue then will resolve the issue as closed in 2.9 and trunk.

          Show
          Naganarasimha Naganarasimha G R added a comment - Will wait for a day more and if none has any concerns on closing this issue then will resolve the issue as closed in 2.9 and trunk.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          lets just go for 2.9; its an irritant in 2.8, but not much worse than all the other log messages

          Show
          stevel@apache.org Steve Loughran added a comment - lets just go for 2.9; its an irritant in 2.8, but not much worse than all the other log messages
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Steve Loughran for confirming, resolving the issue

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Steve Loughran for confirming, resolving the issue

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development