Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.7.1, 2.6.2
-
Component/s: resourcemanager
-
Labels:
-
Target Version/s:
-
Hadoop Flags:Reviewed
Description
This issue exists in both branch-2.7 and branch-2.6
<file classname='org.apache.hadoop.yarn.server.resourcemanager.recovery.ZKRMStateStore$ZKSyncOperationCallback'> <BugInstance type='SIC_INNER_SHOULD_BE_STATIC' priority='Normal' category='PERFORMANCE' message='Should org.apache.hadoop.yarn.server.resourcemanager.recovery.ZKRMStateStore$ZKSyncOperationCallback be a _static_ inner class?' lineNumber='118'/></file>
Below issue exists only in branch-2.6
<file classname='org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt'> <BugInstance type='IS2_INCONSISTENT_SYNC' priority='Normal' category='MT_CORRECTNESS' message='Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt.queue; locked 57% of time' lineNumber='261'/>
Issue Links
- is related to
-
YARN-2938
Fix new findbugs warnings in hadoop-yarn-resourcemanager and hadoop-yarn-applicationhistoryservice
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Sure...Nobody has taken it up as well.
Ok. Move it to 2.6.4. Thanks Varun!
Attaching a patch for branch-2.7.
I'm thinking it's okay to add a section in findbugs-exclude.xml to fix the below warning.
<file classname='org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt'> <BugInstance type='IS2_INCONSISTENT_SYNC' priority='Normal' category='MT_CORRECTNESS' message='Inconsistent
In branch-2.7, there is a section to ignore the warning, added by YARN-2938.
I'll attach a patch for branch-2.6 shortly.
Remove it from 2.6.4 which is mostly for critical bug fix.
Attaching the same patch again to run tests on branch-2.7.
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 0s | Docker mode activated. |
| -1 | patch | 0m 6s | |
| Subsystem | Report/Notes |
|---|---|
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12788639/YARN-4328.branch-2.7.00.patch |
| JIRA Issue | |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/10586/console |
| Powered by | Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Rebased.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 27s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 6m 40s | branch-2.7 passed |
| +1 | compile | 0m 25s | branch-2.7 passed with JDK v1.8.0_72 |
| +1 | compile | 0m 27s | branch-2.7 passed with JDK v1.7.0_95 |
| +1 | checkstyle | 0m 22s | branch-2.7 passed |
| +1 | mvnsite | 0m 34s | branch-2.7 passed |
| +1 | mvneclipse | 0m 14s | branch-2.7 passed |
| -1 | findbugs | 1m 8s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. |
| +1 | javadoc | 0m 21s | branch-2.7 passed with JDK v1.8.0_72 |
| +1 | javadoc | 0m 25s | branch-2.7 passed with JDK v1.7.0_95 |
| +1 | mvninstall | 0m 29s | the patch passed |
| +1 | compile | 0m 23s | the patch passed with JDK v1.8.0_72 |
| +1 | javac | 0m 23s | the patch passed |
| +1 | compile | 0m 25s | the patch passed with JDK v1.7.0_95 |
| +1 | javac | 0m 25s | the patch passed |
| -1 | checkstyle | 0m 18s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 1 new + 230 unchanged - 1 fixed = 231 total (was 231) |
| +1 | mvnsite | 0m 31s | the patch passed |
| +1 | mvneclipse | 0m 12s | the patch passed |
| -1 | whitespace | 0m 0s | The patch has 1227 line(s) that end in whitespace. Use git apply --whitespace=fix. |
| -1 | whitespace | 0m 34s | The patch has 95 line(s) with tabs. |
| +1 | findbugs | 1m 11s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) |
| +1 | javadoc | 0m 19s | the patch passed with JDK v1.8.0_72 |
| +1 | javadoc | 0m 22s | the patch passed with JDK v1.7.0_95 |
| -1 | unit | 52m 48s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. |
| -1 | unit | 53m 56s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. |
| -1 | asflicense | 44m 8s | Patch generated 77 ASF License warnings. |
| 167m 56s |
| Reason | Tests |
|---|---|
| JDK v1.8.0_72 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
| hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
| JDK v1.7.0_95 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
| hadoop.yarn.server.resourcemanager.TestAMAuthorization |
This message was automatically generated.
2.7.3 is under release process, changing target-version to 2.7.4.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 10m 45s | branch-2.7 passed |
| +1 | compile | 0m 27s | branch-2.7 passed with JDK v1.8.0_101 |
| +1 | compile | 0m 28s | branch-2.7 passed with JDK v1.7.0_101 |
| +1 | checkstyle | 0m 24s | branch-2.7 passed |
| +1 | mvnsite | 0m 59s | branch-2.7 passed |
| +1 | mvneclipse | 0m 18s | branch-2.7 passed |
| -1 | findbugs | 1m 13s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. |
| +1 | javadoc | 0m 20s | branch-2.7 passed with JDK v1.8.0_101 |
| +1 | javadoc | 0m 23s | branch-2.7 passed with JDK v1.7.0_101 |
| +1 | mvninstall | 0m 27s | the patch passed |
| +1 | compile | 0m 22s | the patch passed with JDK v1.8.0_101 |
| +1 | javac | 0m 22s | the patch passed |
| +1 | compile | 0m 26s | the patch passed with JDK v1.7.0_101 |
| +1 | javac | 0m 26s | the patch passed |
| -1 | checkstyle | 0m 18s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 230 unchanged - 1 fixed = 231 total (was 231) |
| +1 | mvnsite | 0m 31s | the patch passed |
| +1 | mvneclipse | 0m 14s | the patch passed |
| -1 | whitespace | 0m 0s | The patch has 1652 line(s) that end in whitespace. Use git apply --whitespace=fix. |
| -1 | whitespace | 0m 44s | The patch 70 line(s) with tabs. |
| +1 | findbugs | 1m 13s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) |
| +1 | javadoc | 0m 15s | the patch passed with JDK v1.8.0_101 |
| +1 | javadoc | 0m 20s | the patch passed with JDK v1.7.0_101 |
| -1 | unit | 50m 3s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. |
| -1 | unit | 50m 53s | hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. |
| +1 | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| 123m 2s |
| Reason | Tests |
|---|---|
| JDK v1.8.0_101 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
| hadoop.yarn.server.resourcemanager.TestAMAuthorization | |
| JDK v1.7.0_101 Failed junit tests | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
| hadoop.yarn.server.resourcemanager.TestAMAuthorization |
This message was automatically generated.
Sangjin Lee, will we have a 2.6.6 release ?
If not, this need not go in branch-2.6
Committed to branch-2.7, branch-2.6
Thanks Akira Ajisaka for your contribution
It's unclear whether there will be 2.6.6, given that we don't have a clear EOL policy. I'll revive that discussion soon. In any case, I think it's OK to commit to branch-2.6 for now, which you've done. Thanks.
Had missed adding this JIRA to CHANGES.txt.
Have added the same.
Hi, can this move out of 2.6.3? Thanks!