Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4325

Nodemanager log handlers fail to send finished/failed events in some cases

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      From a long running cluster, we found tens of thousands of stale apps still be recovered in NM restart recovery.
      After investigating, there are three issues cause app state leak in NM state-store:
      1. APPLICATION_LOG_HANDLING_FAILED is not handled with remove App in NMStateStore.
      2. APPLICATION_LOG_HANDLING_FAILED event is missing in sent when hit aggregator's doAppLogAggregation() exception case.
      3. Only Application in FINISHED status receiving APPLICATION_LOG_FINISHED has transition to remove app in NM state store. Application in other status - like APPLICATION_RESOURCES_CLEANUP will ignore the event and later forget to remove this app from NM state store even after app get finished.

      1. ApplicationImpl.PNG
        82 kB
        Junping Du
      2. YARN-4325.patch
        7 kB
        Junping Du
      3. YARN-4325-v1.1.patch
        12 kB
        Junping Du
      4. YARN-4325-v1.patch
        12 kB
        Junping Du
      5. YARN-4325-v2.patch
        9 kB
        Junping Du
      6. YARN-4325-v3.1.patch
        14 kB
        Junping Du
      7. YARN-4325-v3.patch
        14 kB
        Junping Du
      8. YARN-4325-v4.1.patch
        15 kB
        Junping Du
      9. YARN-4325-v4.patch
        15 kB
        Junping Du

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Junping Du, the JIRA is a little light on details, will help if you can paste exception / log messages etc.

          Also, does this only happen with mis-configuration? And you are planning to work on this soon? If not, I'd not hold 2.7.2 off for this.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Junping Du , the JIRA is a little light on details, will help if you can paste exception / log messages etc. Also, does this only happen with mis-configuration? And you are planning to work on this soon? If not, I'd not hold 2.7.2 off for this.
          Hide
          djp Junping Du added a comment -

          Hi Vinod Kumar Vavilapalli, we found in a long running cluster, NMs recovery will try to recover tens of thousands of apps and most of them are old and stale. For now, the removal of app state in NM state store is triggered by ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED which created by aggregation or non-aggregation log handling only.

          So I were suspecting the purge of app state could be affected by log aggregation exceptions, like some permission issue below:

          2015-10-13 01:58:40,277 WARN  logaggregation.LogAggregationService (LogAggregationService.java:verifyAndCreateRemoteLogDir(195)) - Remote Root Log Dir [/app-logs] already exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The cluster may have problems with multiple users.
          1111336 2015-10-13 01:58:40,277 WARN  logaggregation.AppLogAggregatorImpl (AppLogAggregatorImpl.java:<init>(182)) - rollingMonitorInterval is set as -1. The log rolling mornitoring interval is disabled. The logs will be aggregated after this application is finished.
          

          I am still debugging it, please free free to move to release after 2.7.2.

          Show
          djp Junping Du added a comment - Hi Vinod Kumar Vavilapalli , we found in a long running cluster, NMs recovery will try to recover tens of thousands of apps and most of them are old and stale. For now, the removal of app state in NM state store is triggered by ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED which created by aggregation or non-aggregation log handling only. So I were suspecting the purge of app state could be affected by log aggregation exceptions, like some permission issue below: 2015-10-13 01:58:40,277 WARN logaggregation.LogAggregationService (LogAggregationService.java:verifyAndCreateRemoteLogDir(195)) - Remote Root Log Dir [/app-logs] already exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The cluster may have problems with multiple users. 1111336 2015-10-13 01:58:40,277 WARN logaggregation.AppLogAggregatorImpl (AppLogAggregatorImpl.java:<init>(182)) - rollingMonitorInterval is set as -1. The log rolling mornitoring interval is disabled. The logs will be aggregated after this application is finished. I am still debugging it, please free free to move to release after 2.7.2.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Okay, moving it out while you continue debugging.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Okay, moving it out while you continue debugging.
          Hide
          zsl2007 zhangshilong added a comment -

          If permissions with hdfs is right, is there any other problem?
          If set yarn.log-aggregation-enable = false, does NM recovery work well?

          Show
          zsl2007 zhangshilong added a comment - If permissions with hdfs is right, is there any other problem? If set yarn.log-aggregation-enable = false, does NM recovery work well?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Junping Du, any update on your debugging?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Junping Du , any update on your debugging?
          Hide
          djp Junping Du added a comment -

          If set yarn.log-aggregation-enable = false, does NM recovery work well?

          It supposed to be. YARN-2079 address non-aggregation log cases.

          Junping Du, any update on your debugging?

          No. Unfortunately, I didn't track the original cluster again. Let's move it out of 2.7.3 and 2.6.5 and fix it next time we see this again...

          Show
          djp Junping Du added a comment - If set yarn.log-aggregation-enable = false, does NM recovery work well? It supposed to be. YARN-2079 address non-aggregation log cases. Junping Du, any update on your debugging? No. Unfortunately, I didn't track the original cluster again. Let's move it out of 2.7.3 and 2.6.5 and fix it next time we see this again...
          Hide
          djp Junping Du added a comment - - edited

          We hit the same issue in a cluster recently again. After checking log, related code and state machine graph for ApplicationImpl (attached). There are three issues cause app state leak in NM state-store
          1. APPLICATION_LOG_HANDLING_FAILED is not handled with remove App in NMStateStore.
          2. APPLICATION_LOG_HANDLING_FAILED event is missing in sent when hit aggregator's doAppLogAggregation() exception case.
          3. Only Application in FINISHED status receiving APPLICATION_LOG_FINISHED has transition to remove app in NM state store. Application in other status - like APPLICATION_RESOURCES_CLEANUP will ignore the event and later forget to remove this app from NM state store even after app get finished.
          Will put up a patch soon to fix this issue.

          Show
          djp Junping Du added a comment - - edited We hit the same issue in a cluster recently again. After checking log, related code and state machine graph for ApplicationImpl (attached). There are three issues cause app state leak in NM state-store 1. APPLICATION_LOG_HANDLING_FAILED is not handled with remove App in NMStateStore. 2. APPLICATION_LOG_HANDLING_FAILED event is missing in sent when hit aggregator's doAppLogAggregation() exception case. 3. Only Application in FINISHED status receiving APPLICATION_LOG_FINISHED has transition to remove app in NM state store. Application in other status - like APPLICATION_RESOURCES_CLEANUP will ignore the event and later forget to remove this app from NM state store even after app get finished. Will put up a patch soon to fix this issue.
          Hide
          djp Junping Du added a comment -

          Put a demo patch first, a completed patch with tests will come later.

          Show
          djp Junping Du added a comment - Put a demo patch first, a completed patch with tests will come later.
          Hide
          djp Junping Du added a comment -

          Add related unit test in v1 patch.

          Show
          djp Junping Du added a comment - Add related unit test in v1 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 0m 21s trunk passed with JDK v1.8.0_92
          +1 compile 0m 26s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 28s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 50s trunk passed
          +1 javadoc 0m 17s trunk passed with JDK v1.8.0_92
          +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 23s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_92
          -1 javac 2m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92 with JDK v1.8.0_92 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
          +1 javac 0m 21s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_95
          -1 javac 2m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17)
          +1 javac 0m 23s the patch passed
          -1 checkstyle 0m 13s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34)
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 0s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_92
          +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95
          +1 unit 11m 9s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_92.
          +1 unit 11m 41s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          37m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:7b1c37a
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801269/YARN-4325-v1.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 74a164e8816f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6f26b66
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92: https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92.txt
          javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11263/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11263/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 0m 21s trunk passed with JDK v1.8.0_92 +1 compile 0m 26s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 50s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_92 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 23s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_92 -1 javac 2m 26s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92 with JDK v1.8.0_92 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) +1 javac 0m 21s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_95 -1 javac 2m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17) +1 javac 0m 23s the patch passed -1 checkstyle 0m 13s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_92 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_95 +1 unit 11m 9s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_92. +1 unit 11m 41s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 37m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:7b1c37a JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801269/YARN-4325-v1.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 74a164e8816f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f26b66 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92: https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_92.txt javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11263/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11263/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11263/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Update to v1.1 patch to fix javac, checkstyle and whitespace warning.

          Show
          djp Junping Du added a comment - Update to v1.1 patch to fix javac, checkstyle and whitespace warning.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 24s trunk passed
          +1 compile 0m 27s trunk passed with JDK v1.8.0_91
          +1 compile 0m 27s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 52s trunk passed
          +1 javadoc 0m 19s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 24s the patch passed with JDK v1.8.0_91
          +1 javac 0m 24s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.7.0_95
          +1 javac 0m 26s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 18s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_95
          +1 unit 11m 28s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 11m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          39m 39s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802662/YARN-4325-v1.1.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a233c450cb8c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2835f14
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11361/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11361/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 24s trunk passed +1 compile 0m 27s trunk passed with JDK v1.8.0_91 +1 compile 0m 27s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 52s trunk passed +1 javadoc 0m 19s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 25s the patch passed +1 compile 0m 24s the patch passed with JDK v1.8.0_91 +1 javac 0m 24s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_95 +1 javac 0m 26s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_95 +1 unit 11m 28s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 39m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802662/YARN-4325-v1.1.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a233c450cb8c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2835f14 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11361/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11361/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Can someone in watch list review patch here? Thanks!

          Show
          djp Junping Du added a comment - Can someone in watch list review patch here? Thanks!
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the patch!

          For AppCompletelyDoneTransition it seems a little odd that we fire off a log event then remove the app that goes with that event. I would expect we would either wait for the log finished/failed event and cleanup in the FINISHED state like we normally do or not send the log event at all since we already know it is failed/done. Is the better fix to have the log aggregators properly return a log failed event in these cases?

          Show
          jlowe Jason Lowe added a comment - Thanks for the patch! For AppCompletelyDoneTransition it seems a little odd that we fire off a log event then remove the app that goes with that event. I would expect we would either wait for the log finished/failed event and cleanup in the FINISHED state like we normally do or not send the log event at all since we already know it is failed/done. Is the better fix to have the log aggregators properly return a log failed event in these cases?
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe for review and comments!

          For AppCompletelyDoneTransition it seems a little odd that we fire off a log event then remove the app that goes with that event.

          There is a case that the log event (LogHandlerAppFinishedEvent) won't be handled as aggregator for this application has problem during initiating app before (YARN-4984 fix this to skip creating unnecessary aggregator threads). In this case, we need to handle remove app from NM state store here. Isn't it? I agree that it could be better to combine the logic that either send the log event or remove the apps from NM state store, and will update patch according to it.

          Is the better fix to have the log aggregators properly return a log failed event in these cases?

          After the fix in YARN-4984. log aggregators won't be created in case of initiation failure to get rid of thread leaks. However, log failed event should be sent earlier in this case, so we mark the logHandlingDone flag to true. When app is finished and logHandlingDone is true, we just cleanup application from NM state store directly. Any concern for this logic?

          Show
          djp Junping Du added a comment - Thanks Jason Lowe for review and comments! For AppCompletelyDoneTransition it seems a little odd that we fire off a log event then remove the app that goes with that event. There is a case that the log event (LogHandlerAppFinishedEvent) won't be handled as aggregator for this application has problem during initiating app before ( YARN-4984 fix this to skip creating unnecessary aggregator threads). In this case, we need to handle remove app from NM state store here. Isn't it? I agree that it could be better to combine the logic that either send the log event or remove the apps from NM state store, and will update patch according to it. Is the better fix to have the log aggregators properly return a log failed event in these cases? After the fix in YARN-4984 . log aggregators won't be created in case of initiation failure to get rid of thread leaks. However, log failed event should be sent earlier in this case, so we mark the logHandlingDone flag to true. When app is finished and logHandlingDone is true, we just cleanup application from NM state store directly. Any concern for this logic?
          Hide
          jlowe Jason Lowe added a comment - - edited

          I'm just thinking the explicit boolean check and special-case logic is a bit ugly compared to the typical flow. If we simply changed the log handlers so they don't ignore events and always send a response then I don't think we need the special-case tracking. For example, if the log handlers receive an event for an app they are no longer tracking (because the app log handling failed to init or whatever) then it immediately sends back the APPLICATION_LOG_HANDLING_FAILED or APPLICATION_LOG_HANDLING_FINISHED event. Then we can have the app state machine always clean up in the final finished state as normal rather than having special-case removal logic in other states.

          Show
          jlowe Jason Lowe added a comment - - edited I'm just thinking the explicit boolean check and special-case logic is a bit ugly compared to the typical flow. If we simply changed the log handlers so they don't ignore events and always send a response then I don't think we need the special-case tracking. For example, if the log handlers receive an event for an app they are no longer tracking (because the app log handling failed to init or whatever) then it immediately sends back the APPLICATION_LOG_HANDLING_FAILED or APPLICATION_LOG_HANDLING_FINISHED event. Then we can have the app state machine always clean up in the final finished state as normal rather than having special-case removal logic in other states.
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe for comments. I agree that adding a boolean flag may not be a very decent solution. However, given APPLICATION_LOG_HANDLING_FAILED event could be sent when app is still running, we have to cache this event (in boolean flag or some other way) so later we can do app cleanup when app is finished.
          Do we have better way to achieve this?

          Show
          djp Junping Du added a comment - Thanks Jason Lowe for comments. I agree that adding a boolean flag may not be a very decent solution. However, given APPLICATION_LOG_HANDLING_FAILED event could be sent when app is still running, we have to cache this event (in boolean flag or some other way) so later we can do app cleanup when app is finished. Do we have better way to achieve this?
          Hide
          jlowe Jason Lowe added a comment -

          Yes, what I'm proposing is to have the log handlers always respond to the APPLICATION_FINISHED event. We can look at this problem in two ways: either the bug is in the ApplicationImpl because it doesn't track that log handling failed and sometimes needs to clean up the app in other states, or the bug is in the log handlers because they failed to respond to the APPLICATION_FINISHED event when the application terminated. If the log handlers always responded to the APPLICATION_FINISHED event with an APPLICATION_LOG_HANDLING_FAILED or APPLICATION_LOG_HANDLING_FINISHED event, wouldn't that also solve the problem? Then ApplicationImpl can simply wait until the terminal finished state to receive one of the log handling replies and then clean up the app in one place rather than several places depending upon the special case being handled.

          Show
          jlowe Jason Lowe added a comment - Yes, what I'm proposing is to have the log handlers always respond to the APPLICATION_FINISHED event. We can look at this problem in two ways: either the bug is in the ApplicationImpl because it doesn't track that log handling failed and sometimes needs to clean up the app in other states, or the bug is in the log handlers because they failed to respond to the APPLICATION_FINISHED event when the application terminated. If the log handlers always responded to the APPLICATION_FINISHED event with an APPLICATION_LOG_HANDLING_FAILED or APPLICATION_LOG_HANDLING_FINISHED event, wouldn't that also solve the problem? Then ApplicationImpl can simply wait until the terminal finished state to receive one of the log handling replies and then clean up the app in one place rather than several places depending upon the special case being handled.
          Hide
          djp Junping Du added a comment -

          Okay. Your proposal sounds more clean.
          I update v2 patch. Can you take a look at again? Thx!

          Show
          djp Junping Du added a comment - Okay. Your proposal sounds more clean. I update v2 patch. Can you take a look at again? Thx!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 22s trunk passed
          +1 compile 0m 27s trunk passed with JDK v1.8.0_91
          +1 compile 0m 29s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 54s trunk passed
          +1 javadoc 0m 20s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 23s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 27s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_91
          -1 javac 2m 38s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91 with JDK v1.8.0_91 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
          +1 javac 0m 23s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.7.0_95
          -1 javac 3m 4s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17)
          +1 javac 0m 26s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 0m 29s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 7s the patch passed
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95
          -1 unit 11m 41s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_91.
          -1 unit 11m 51s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          40m 0s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestContainerManagerRecovery
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestContainerManagerRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803452/YARN-4325-v2.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 264b3a7112fd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / acb509b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt
          javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11417/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11417/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 22s trunk passed +1 compile 0m 27s trunk passed with JDK v1.8.0_91 +1 compile 0m 29s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 54s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 23s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 27s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_91 -1 javac 2m 38s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91 with JDK v1.8.0_91 generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) +1 javac 0m 23s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_95 -1 javac 3m 4s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17) +1 javac 0m 26s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 7s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95 -1 unit 11m 41s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_91. -1 unit 11m 51s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 40m 0s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestContainerManagerRecovery JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.TestContainerManagerRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803452/YARN-4325-v2.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 264b3a7112fd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / acb509b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt javac hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11417/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11417/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11417/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Junping! The test failure is related. In addition to the javac warning that should be cleaned up, it looks like there's an unlikely code path in NonAggregatingLogHandler where if we fail to lookup the appId then it doesn't respond to the APPLICATION_FINISHED event.

          Show
          jlowe Jason Lowe added a comment - Thanks, Junping! The test failure is related. In addition to the javac warning that should be cleaned up, it looks like there's an unlikely code path in NonAggregatingLogHandler where if we fail to lookup the appId then it doesn't respond to the APPLICATION_FINISHED event.
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe for review and comments. v3 patch fix the unit test failure and javac warning and address your comments on non-aggregation log handler.

          Show
          djp Junping Du added a comment - Thanks Jason Lowe for review and comments. v3 patch fix the unit test failure and javac warning and address your comments on non-aggregation log handler.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 0s trunk passed
          +1 compile 0m 25s trunk passed with JDK v1.8.0_91
          +1 compile 0m 24s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 28s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 51s trunk passed
          +1 javadoc 0m 19s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 22s the patch passed with JDK v1.8.0_91
          +1 javac 0m 22s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_95
          +1 javac 0m 23s the patch passed
          -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 5 new + 143 unchanged - 1 fixed = 148 total (was 144)
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 18s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 20s the patch passed with JDK v1.7.0_95
          +1 unit 11m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 11m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          39m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803713/YARN-4325-v3.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2d3e55fb2dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 27c4e90
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11431/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11431/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11431/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11431/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 0s trunk passed +1 compile 0m 25s trunk passed with JDK v1.8.0_91 +1 compile 0m 24s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 51s trunk passed +1 javadoc 0m 19s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 22s the patch passed with JDK v1.8.0_91 +1 javac 0m 22s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_95 +1 javac 0m 23s the patch passed -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 5 new + 143 unchanged - 1 fixed = 148 total (was 144) +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 20s the patch passed with JDK v1.7.0_95 +1 unit 11m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 39m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803713/YARN-4325-v3.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2d3e55fb2dfe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27c4e90 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11431/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11431/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11431/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11431/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Fix checkstyle and whitespace issue in v3.1 patch.

          Show
          djp Junping Du added a comment - Fix checkstyle and whitespace issue in v3.1 patch.
          Hide
          djp Junping Du added a comment -

          The Jenkins doesn't get triggered automatically for some reason... manually kick off the test.

          Show
          djp Junping Du added a comment - The Jenkins doesn't get triggered automatically for some reason... manually kick off the test.
          Hide
          jlowe Jason Lowe added a comment -

          Appears Jenkins is having difficulty posting to JIRA. Overall was +1 from https://builds.apache.org/job/PreCommit-YARN-Build/11448/console.

          Patch is looking better, but there's still an issue in the NonAggregatingLogHandler. First the added code seems redundant, since just a few lines earlier it sent the same event:

                // Inform the application before the actual delete itself, so that links
                // to logs will no longer be there on NM web-UI.
                NonAggregatingLogHandler.this.dispatcher.getEventHandler().handle(
                  new ApplicationEvent(this.applicationId,
                    ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED));
                if (localAppLogDirs.size() > 0) {
                  NonAggregatingLogHandler.this.delService.delete(user, null,
                    (Path[]) localAppLogDirs.toArray(new Path[localAppLogDirs.size()]));
                }
                try {
                  NonAggregatingLogHandler.this.stateStore.removeLogDeleter(
                      this.applicationId);
                } catch (IOException e) {
                  LOG.error("Error removing log deletion state", e);
                } finally {
                  NonAggregatingLogHandler.this.dispatcher.getEventHandler().handle(
                      new ApplicationEvent(this.applicationId,
                          ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED));
                }
          

          It looks to me that once we get the LogDeleterRunnable going we're always sending the necessary event without any additional changes. What I meant by my previous comment was fixing the early out from this code where we initially receive the finished event:

                case APPLICATION_FINISHED:
                  LogHandlerAppFinishedEvent appFinishedEvent =
                      (LogHandlerAppFinishedEvent) event;
                  ApplicationId appId = appFinishedEvent.getApplicationId();
                  // Schedule - so that logs are available on the UI till they're deleted.
                  LOG.info("Scheduling Log Deletion for application: "
                      + appId + ", with delay of "
                      + this.deleteDelaySeconds + " seconds");
                  String user = appOwners.remove(appId);
                  if (user == null) {
                    LOG.error("Unable to locate user for " + appId);
                    break;
                  }
          

          In the unlikely event that we can't lookup the user for an appID we need to send a failed event so ApplicationImpl can cleanup the app from the state store since there won't be a LogDeleterRunnable to do it.

          Show
          jlowe Jason Lowe added a comment - Appears Jenkins is having difficulty posting to JIRA. Overall was +1 from https://builds.apache.org/job/PreCommit-YARN-Build/11448/console . Patch is looking better, but there's still an issue in the NonAggregatingLogHandler. First the added code seems redundant, since just a few lines earlier it sent the same event: // Inform the application before the actual delete itself, so that links // to logs will no longer be there on NM web-UI. NonAggregatingLogHandler. this .dispatcher.getEventHandler().handle( new ApplicationEvent( this .applicationId, ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED)); if (localAppLogDirs.size() > 0) { NonAggregatingLogHandler. this .delService.delete(user, null , (Path[]) localAppLogDirs.toArray( new Path[localAppLogDirs.size()])); } try { NonAggregatingLogHandler. this .stateStore.removeLogDeleter( this .applicationId); } catch (IOException e) { LOG.error( "Error removing log deletion state" , e); } finally { NonAggregatingLogHandler. this .dispatcher.getEventHandler().handle( new ApplicationEvent( this .applicationId, ApplicationEventType.APPLICATION_LOG_HANDLING_FINISHED)); } It looks to me that once we get the LogDeleterRunnable going we're always sending the necessary event without any additional changes. What I meant by my previous comment was fixing the early out from this code where we initially receive the finished event: case APPLICATION_FINISHED: LogHandlerAppFinishedEvent appFinishedEvent = (LogHandlerAppFinishedEvent) event; ApplicationId appId = appFinishedEvent.getApplicationId(); // Schedule - so that logs are available on the UI till they're deleted. LOG.info( "Scheduling Log Deletion for application: " + appId + ", with delay of " + this .deleteDelaySeconds + " seconds" ); String user = appOwners.remove(appId); if (user == null ) { LOG.error( "Unable to locate user for " + appId); break ; } In the unlikely event that we can't lookup the user for an appID we need to send a failed event so ApplicationImpl can cleanup the app from the state store since there won't be a LogDeleterRunnable to do it.
          Hide
          djp Junping Du added a comment -

          Nice catch, Jason Lowe! v4 patch incorporate your comments and add a test to verify the case.

          Show
          djp Junping Du added a comment - Nice catch, Jason Lowe ! v4 patch incorporate your comments and add a test to verify the case.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 20s trunk passed
          +1 compile 0m 23s trunk passed with JDK v1.8.0_91
          +1 compile 0m 27s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 29s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 57s trunk passed
          +1 javadoc 0m 21s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_91
          +1 javac 0m 23s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.7.0_95
          +1 javac 0m 26s the patch passed
          -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 2 new + 141 unchanged - 2 fixed = 143 total (was 143)
          +1 mvnsite 0m 30s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 20s the patch passed with JDK v1.7.0_95
          +1 unit 11m 47s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 11m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          39m 56s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803960/YARN-4325-v4.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5a0c8873f4b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3fa1380
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11456/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11456/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11456/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 20s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_91 +1 compile 0m 27s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 57s trunk passed +1 javadoc 0m 21s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 25s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_91 +1 javac 0m 23s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_95 +1 javac 0m 26s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 2 new + 141 unchanged - 2 fixed = 143 total (was 143) +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 20s the patch passed with JDK v1.7.0_95 +1 unit 11m 47s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 45s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 39m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803960/YARN-4325-v4.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5a0c8873f4b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3fa1380 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11456/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11456/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11456/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Two check-style (indentation) issues get reported by Jenkins. One is not valid the other one get fixed in v4.1 patch.

          Show
          djp Junping Du added a comment - Two check-style (indentation) issues get reported by Jenkins. One is not valid the other one get fixed in v4.1 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 34s trunk passed
          +1 compile 0m 22s trunk passed with JDK v1.8.0_91
          +1 compile 0m 26s trunk passed with JDK v1.7.0_101
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 28s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 50s trunk passed
          +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 22s trunk passed with JDK v1.7.0_101
          +1 mvninstall 0m 24s the patch passed
          +1 compile 0m 20s the patch passed with JDK v1.8.0_91
          +1 javac 0m 20s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_101
          +1 javac 0m 23s the patch passed
          -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 141 unchanged - 2 fixed = 142 total (was 143)
          +1 mvnsite 0m 26s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 0s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 19s the patch passed with JDK v1.7.0_101
          +1 unit 11m 19s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 11m 53s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          38m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804044/YARN-4325-v4.1.patch
          JIRA Issue YARN-4325
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3f792f4c6b1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7be53b6
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11470/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11470/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11470/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 34s trunk passed +1 compile 0m 22s trunk passed with JDK v1.8.0_91 +1 compile 0m 26s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 50s trunk passed +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 22s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 24s the patch passed +1 compile 0m 20s the patch passed with JDK v1.8.0_91 +1 javac 0m 20s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_101 +1 javac 0m 23s the patch passed -1 checkstyle 0m 17s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 141 unchanged - 2 fixed = 142 total (was 143) +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_101 +1 unit 11m 19s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 53s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 38m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804044/YARN-4325-v4.1.patch JIRA Issue YARN-4325 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3f792f4c6b1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11470/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11470/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11470/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          The left checkstyle issue is not valid. Jason Lowe, mind to take a look at it again?

          Show
          djp Junping Du added a comment - The left checkstyle issue is not valid. Jason Lowe , mind to take a look at it again?
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Junping! I committed this to trunk, branch-2, and branch-2.8.

          Show
          jlowe Jason Lowe added a comment - Thanks, Junping! I committed this to trunk, branch-2, and branch-2.8.
          Hide
          djp Junping Du added a comment -

          Thanks Jason Lowe for review and commit!

          Show
          djp Junping Du added a comment - Thanks Jason Lowe for review and commit!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9766 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9766/)
          YARN-4325. Nodemanager log handlers fail to send finished/failed events (jlowe: rev 81effb7dcde2b31423438d6f1b8b8204d4ca05b3)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/NonAggregatingLogHandler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/TestNonAggregatingLogHandler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManagerRecovery.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/LogAggregationService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9766 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9766/ ) YARN-4325 . Nodemanager log handlers fail to send finished/failed events (jlowe: rev 81effb7dcde2b31423438d6f1b8b8204d4ca05b3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/NonAggregatingLogHandler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/loghandler/TestNonAggregatingLogHandler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManagerRecovery.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/LogAggregationService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java

            People

            • Assignee:
              djp Junping Du
              Reporter:
              djp Junping Du
            • Votes:
              0 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development