Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4311

Removing nodes from include and exclude lists will not remove them from decommissioned nodes list

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In order to fully forget about a node, removing the node from include and exclude list is not sufficient. The RM lists it under Decomm-ed nodes. The tricky part that Jason Lowe pointed out was the case when include lists are not used, in that case we don't want the nodes to fall off if they are not active.

      1. YARN-4311-branch-2.7.001.patch
        27 kB
        Kuhu Shukla
      2. YARN-4311-branch-2.7.002.patch
        29 kB
        Kuhu Shukla
      3. YARN-4311-branch-2.7.003.patch
        28 kB
        Kuhu Shukla
      4. YARN-4311-branch-2.7.004.patch
        31 kB
        Kuhu Shukla
      5. YARN-4311-v1.patch
        8 kB
        Kuhu Shukla
      6. YARN-4311-v10.patch
        34 kB
        Kuhu Shukla
      7. YARN-4311-v11.patch
        34 kB
        Kuhu Shukla
      8. YARN-4311-v11.patch
        34 kB
        Kuhu Shukla
      9. YARN-4311-v12.patch
        35 kB
        Kuhu Shukla
      10. YARN-4311-v13.patch
        35 kB
        Kuhu Shukla
      11. YARN-4311-v13.patch
        35 kB
        Kuhu Shukla
      12. YARN-4311-v14.patch
        35 kB
        Kuhu Shukla
      13. YARN-4311-v15.patch
        48 kB
        Kuhu Shukla
      14. YARN-4311-v16.patch
        48 kB
        Kuhu Shukla
      15. YARN-4311-v17.patch
        46 kB
        Kuhu Shukla
      16. YARN-4311-v18.patch
        46 kB
        Kuhu Shukla
      17. YARN-4311-v2.patch
        33 kB
        Kuhu Shukla
      18. YARN-4311-v3.patch
        34 kB
        Kuhu Shukla
      19. YARN-4311-v4.patch
        36 kB
        Kuhu Shukla
      20. YARN-4311-v5.patch
        36 kB
        Kuhu Shukla
      21. YARN-4311-v6.patch
        36 kB
        Kuhu Shukla
      22. YARN-4311-v7.patch
        43 kB
        Kuhu Shukla
      23. YARN-4311-v8.patch
        41 kB
        Kuhu Shukla
      24. YARN-4311-v9.patch
        41 kB
        Kuhu Shukla

        Issue Links

          Activity

          Hide
          kshukla Kuhu Shukla added a comment -

          This is a preliminary proposal patch. Through this change, any node is checked if it should be removed from all lists by the isInvalidAndAbsent() method. There are however different outcomes based on the initial state of the node.

          If the node state is running (,is part of the include list) and is taken out of the list, followed by -refreshNodes (and it is not of course in the exclude list), the node is shutdown and shutdown node count is incremented . The node is not considered a decommed node.

          If the node is in both exclude and include list and -refreshNodes has been done, (meaning it is a decommissioned node,) then removing it from both those lists takes it out completely not showing up in shutdown or decommed or unhealthy or active lists. There is one case where shutdown counters are misleading and which this patch hasnt addressed. If the node was running and was taken out of include list, and it comes back up after being added to the include list, the shutdown counters still stick to the same value. This needs to be changed since current state transitions dont account for it.

          Need some inputs from the community on the semantics of such a fix. It may be a good idea to have them counted (but not listed) as shutdown nodes in the first case since any mistake in configuring the include list will lose all information about the nodes (counters and nodelists) which may be undesirable.

          Appreciate any comments/suggestions/caveats. I have not fixed associated test failures through this patch.

          Show
          kshukla Kuhu Shukla added a comment - This is a preliminary proposal patch. Through this change, any node is checked if it should be removed from all lists by the isInvalidAndAbsent() method. There are however different outcomes based on the initial state of the node. If the node state is running (,is part of the include list) and is taken out of the list, followed by -refreshNodes (and it is not of course in the exclude list), the node is shutdown and shutdown node count is incremented . The node is not considered a decommed node. If the node is in both exclude and include list and -refreshNodes has been done, (meaning it is a decommissioned node,) then removing it from both those lists takes it out completely not showing up in shutdown or decommed or unhealthy or active lists. There is one case where shutdown counters are misleading and which this patch hasnt addressed. If the node was running and was taken out of include list, and it comes back up after being added to the include list, the shutdown counters still stick to the same value. This needs to be changed since current state transitions dont account for it. Need some inputs from the community on the semantics of such a fix. It may be a good idea to have them counted (but not listed) as shutdown nodes in the first case since any mistake in configuring the include list will lose all information about the nodes (counters and nodelists) which may be undesirable. Appreciate any comments/suggestions/caveats. I have not fixed associated test failures through this patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 12s trunk passed
          +1 compile 0m 20s trunk passed with JDK v1.8.0_60
          +1 compile 0m 23s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 12s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 5s trunk passed
          +1 javadoc 0m 21s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 25s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_60
          +1 javac 0m 21s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_79
          +1 javac 0m 23s the patch passed
          -1 checkstyle 0m 11s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 86, now 87).
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 16s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 25s the patch passed with JDK v1.7.0_79
          -1 unit 58m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_60.
          -1 unit 59m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          129m 2s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_79 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770360/YARN-4311-v1.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux f5b2e6b212ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build@2/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
          git revision trunk / 957f031
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9623/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9623/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 12s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_60 +1 compile 0m 23s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 12s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 21s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 25s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 26s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_60 +1 javac 0m 21s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_79 +1 javac 0m 23s the patch passed -1 checkstyle 0m 11s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 86, now 87). +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 16s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 25s the patch passed with JDK v1.7.0_79 -1 unit 58m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_60. -1 unit 59m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 129m 2s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_79 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770360/YARN-4311-v1.patch JIRA Issue YARN-4311 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux f5b2e6b212ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build@2/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 957f031 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-YARN-Build/9623/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9623/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9623/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Jason Lowe, Wangda Tan, request for comments. Thanks a lot.

          Show
          kshukla Kuhu Shukla added a comment - Jason Lowe , Wangda Tan , request for comments. Thanks a lot.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the patch, Kuhu! Test failures are related, please look into them.

          In general the patch seems like a reasonable approach. There needs to be some way for admins to remove nodes that are no longer relevant to the cluster, and AFAIK there's no supported way to do this short of restarting the resourcemanager. As nodes churn in and out of the cluster, they will simply accumulate in the decommissioned or lost nodes buckets until the next resourcemanager restart.

          My main concern is the behavior when someone botches the include list (e.g.: accidentally truncates the includes list file and refreshes). At that point all of the cluster nodes will disappear from the resourcemanager with no indication of what happened (except potentially the shutdown metric will increment by the number of nodes lost). Today they will all go into the decommissioned bucket, but with this patch they'll simply disappear. This either needs to be "as designed" behavior, or we'd have to implement a separate mechanism outside of the include/exclude lists to direct the RM to "forget" a node. I believe HDFS recently was changed to behave this was as well wrt. the include/exclude lists and forgetting nodes (see HDFS-8950), so I'm inclined to be consistent with that and say it's "as designed."

          Some comments on the patch itself:

          isInvalidAndAbsent doesn't have the same handling of IP's as isValidNode does.

          It might also be clearer if isInvalidAndAbsent were just named isUntracked or isUntrackedNode indicating those are nodes we aren't tracking in any way.

          isInvalidAndAbsent doesn't lock hostsReader like isValidNode does.

          What about refreshNodesGracefully? That also refreshes the host include/exclude lists and arguably needs similar logic. We need to discuss what it means to gracefully refresh the list when the node completely disappears from both the include and exclude list. Should it still gracefully decommission, and how do we make sure that node is properly tracked? If graceful, does it automatically disappear when the decommission completes since it's not in either list?

          Nit: While looping over the nodes, if the node is valid then there's no reason to check if its not valid and absent. So it could be simplified to the following:

              for (NodeId nodeId: rmContext.getRMNodes().keySet()) {
                if (!isValidNode(nodeId.getHost())) {
                  RMNodeEventType nodeEventType = isInvalidAndAbsent(nodeId.getHost()) ? RMNodeEventType.SHUTDOWN : RMNodeEventType.DECOMMISSION;
                  this.rmContext.getDispatcher().getEventHandler().handle(
                      new RMNodeEvent(nodeId, nodeEventType));
                }
              }
          
          Show
          jlowe Jason Lowe added a comment - Thanks for the patch, Kuhu! Test failures are related, please look into them. In general the patch seems like a reasonable approach. There needs to be some way for admins to remove nodes that are no longer relevant to the cluster, and AFAIK there's no supported way to do this short of restarting the resourcemanager. As nodes churn in and out of the cluster, they will simply accumulate in the decommissioned or lost nodes buckets until the next resourcemanager restart. My main concern is the behavior when someone botches the include list (e.g.: accidentally truncates the includes list file and refreshes). At that point all of the cluster nodes will disappear from the resourcemanager with no indication of what happened (except potentially the shutdown metric will increment by the number of nodes lost). Today they will all go into the decommissioned bucket, but with this patch they'll simply disappear. This either needs to be "as designed" behavior, or we'd have to implement a separate mechanism outside of the include/exclude lists to direct the RM to "forget" a node. I believe HDFS recently was changed to behave this was as well wrt. the include/exclude lists and forgetting nodes (see HDFS-8950 ), so I'm inclined to be consistent with that and say it's "as designed." Some comments on the patch itself: isInvalidAndAbsent doesn't have the same handling of IP's as isValidNode does. It might also be clearer if isInvalidAndAbsent were just named isUntracked or isUntrackedNode indicating those are nodes we aren't tracking in any way. isInvalidAndAbsent doesn't lock hostsReader like isValidNode does. What about refreshNodesGracefully? That also refreshes the host include/exclude lists and arguably needs similar logic. We need to discuss what it means to gracefully refresh the list when the node completely disappears from both the include and exclude list. Should it still gracefully decommission, and how do we make sure that node is properly tracked? If graceful, does it automatically disappear when the decommission completes since it's not in either list? Nit: While looping over the nodes, if the node is valid then there's no reason to check if its not valid and absent. So it could be simplified to the following: for (NodeId nodeId: rmContext.getRMNodes().keySet()) { if (!isValidNode(nodeId.getHost())) { RMNodeEventType nodeEventType = isInvalidAndAbsent(nodeId.getHost()) ? RMNodeEventType.SHUTDOWN : RMNodeEventType.DECOMMISSION; this .rmContext.getDispatcher().getEventHandler().handle( new RMNodeEvent(nodeId, nodeEventType)); } }
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Jason Lowe for the comments.
          For graceful refresh nodes, I was looking at YARN-41 and YARN-3223. For this fix, if we remove the node from all lists when isUntracked is true, the decommissioning node falls back to the same behavior as a decommissioned node. Would it be better for both refreshNodes and refreshNodesGracefully that if the node is 'untracked' it should be moved to shutdown nodes, irrespective of its previous state and then be taken out of shutdown nodes after a timeout?

          Let me know if this makes more sense. Thanks!

          Show
          kshukla Kuhu Shukla added a comment - Thank you Jason Lowe for the comments. For graceful refresh nodes, I was looking at YARN-41 and YARN-3223 . For this fix, if we remove the node from all lists when isUntracked is true, the decommissioning node falls back to the same behavior as a decommissioned node. Would it be better for both refreshNodes and refreshNodesGracefully that if the node is 'untracked' it should be moved to shutdown nodes, irrespective of its previous state and then be taken out of shutdown nodes after a timeout? Let me know if this makes more sense. Thanks!
          Hide
          jlowe Jason Lowe added a comment -

          Sorry, I couldn't find a reference to isUntracked in trunk nor in YARN-3223. So not sure if I understand exactly what is being asked.

          To be consistent with HDFS the node should be gracefully decommissioned if it it appears in the include and exclude list simultaneously, otherwise once it's removed from the include list it's a hard decommission.

          We could implement a "grace period" where nodes that were removed from the cluster are still "tracked" in the UI for a while before being removed. That may help with some of the potentially confusing cases where a node is accidentally booted from the cluster.

          Show
          jlowe Jason Lowe added a comment - Sorry, I couldn't find a reference to isUntracked in trunk nor in YARN-3223 . So not sure if I understand exactly what is being asked. To be consistent with HDFS the node should be gracefully decommissioned if it it appears in the include and exclude list simultaneously, otherwise once it's removed from the include list it's a hard decommission. We could implement a "grace period" where nodes that were removed from the cluster are still "tracked" in the UI for a while before being removed. That may help with some of the potentially confusing cases where a node is accidentally booted from the cluster.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thanks Jason Lowe. I was referring to my isInvalidAndAbsent method which should be called isUntracked() as per last comment. Sorry for the confusion.

          To be consistent with HDFS the node should be gracefully decommissioned if it it appears in the include and exclude list simultaneously, otherwise once it's removed from the include list it's a hard decommission.

          I see. This clarifies my doubt about decommissioning nodes that are taken out of include lists.

          We could implement a "grace period" where nodes that were removed from the cluster are still "tracked" in the UI for a while before being removed.

          Could these be part of shutdown nodes or do we need a separate category for such nodes? Would just the count of such nodes suffice or do we want to view them while its within the grace period?

          Show
          kshukla Kuhu Shukla added a comment - Thanks Jason Lowe . I was referring to my isInvalidAndAbsent method which should be called isUntracked() as per last comment. Sorry for the confusion. To be consistent with HDFS the node should be gracefully decommissioned if it it appears in the include and exclude list simultaneously, otherwise once it's removed from the include list it's a hard decommission. I see. This clarifies my doubt about decommissioning nodes that are taken out of include lists. We could implement a "grace period" where nodes that were removed from the cluster are still "tracked" in the UI for a while before being removed. Could these be part of shutdown nodes or do we need a separate category for such nodes? Would just the count of such nodes suffice or do we want to view them while its within the grace period?
          Hide
          jlowe Jason Lowe added a comment - - edited

          Could these be part of shutdown nodes or do we need a separate category for such nodes? Would just the count of such nodes suffice or do we want to view them while its within the grace period?

          The intent is the list of nodes would be visible from the UI for some period of time, so users can see where a particular node went after the update. I think these nodes could be part of the shutdown category since they were told to shutdown and leave the cluster.

          Show
          jlowe Jason Lowe added a comment - - edited Could these be part of shutdown nodes or do we need a separate category for such nodes? Would just the count of such nodes suffice or do we want to view them while its within the grace period? The intent is the list of nodes would be visible from the UI for some period of time, so users can see where a particular node went after the update. I think these nodes could be part of the shutdown category since they were told to shutdown and leave the cluster.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thanks Jason Lowe. Will rework my patch accordingly.

          Show
          kshukla Kuhu Shukla added a comment - Thanks Jason Lowe . Will rework my patch accordingly.
          Hide
          kshukla Kuhu Shukla added a comment -

          This patch addresses graceful and other versions of refreshNodes and also adds a time stamp based check for nodes per RM_NODE_REMOVAL_CHK_INTERVAL_MSEC in the inactive list that should be untracked and removes nodes based on RM_NODE_REMOVAL_TIMEOUT_MSEC. A decommissioned node is not transitioned to shutdown but timer acts on it just as it would on a shutdown node.

          A decommissioning node will transition to shutdown if it was found to be 'untracked'.

          The unit test tries out several scenarios to check if the metrics and node lists are proper. I can break it into more tests if the idea behind it looks acceptable.

          Show
          kshukla Kuhu Shukla added a comment - This patch addresses graceful and other versions of refreshNodes and also adds a time stamp based check for nodes per RM_NODE_REMOVAL_CHK_INTERVAL_MSEC in the inactive list that should be untracked and removes nodes based on RM_NODE_REMOVAL_TIMEOUT_MSEC . A decommissioned node is not transitioned to shutdown but timer acts on it just as it would on a shutdown node. A decommissioning node will transition to shutdown if it was found to be 'untracked'. The unit test tries out several scenarios to check if the metrics and node lists are proper. I can break it into more tests if the idea behind it looks acceptable.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 10m 19s trunk passed with JDK v1.8.0_66
          +1 compile 10m 28s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 1m 47s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 3m 44s trunk passed
          +1 javadoc 1m 29s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 4s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 36s the patch passed
          +1 compile 10m 43s the patch passed with JDK v1.8.0_66
          +1 javac 10m 43s the patch passed
          +1 compile 10m 54s the patch passed with JDK v
          +1 javac 10m 54s the patch passed
          -1 checkstyle 1m 13s Patch generated 5 new checkstyle issues in root (total was 396, now 400).
          +1 mvnsite 1m 43s the patch passed
          +1 mvneclipse 0m 47s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 23s the patch passed
          +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 40s the patch passed with JDK v1.7.0_85
          -1 unit 0m 26s hadoop-yarn-api in the patch failed with JDK v1.8.0_66.
          -1 unit 66m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 25s hadoop-yarn-api in the patch failed with JDK v1.7.0_85.
          -1 unit 68m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          +1 unit 0m 59s hadoop-sls in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          218m 41s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775340/YARN-4311-v2.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 85a08a0c45f0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 53e3bf7
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9841/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9841/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 2s trunk passed +1 compile 10m 19s trunk passed with JDK v1.8.0_66 +1 compile 10m 28s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 13s trunk passed +1 mvnsite 1m 47s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 3m 44s trunk passed +1 javadoc 1m 29s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 4s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 36s the patch passed +1 compile 10m 43s the patch passed with JDK v1.8.0_66 +1 javac 10m 43s the patch passed +1 compile 10m 54s the patch passed with JDK v +1 javac 10m 54s the patch passed -1 checkstyle 1m 13s Patch generated 5 new checkstyle issues in root (total was 396, now 400). +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 47s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 23s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 40s the patch passed with JDK v1.7.0_85 -1 unit 0m 26s hadoop-yarn-api in the patch failed with JDK v1.8.0_66. -1 unit 66m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.8.0_66. -1 unit 0m 25s hadoop-yarn-api in the patch failed with JDK v1.7.0_85. -1 unit 68m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 unit 0m 59s hadoop-sls in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 218m 41s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_85 Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775340/YARN-4311-v2.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 85a08a0c45f0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53e3bf7 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9841/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9841/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9841/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Fixed one test failure in TestYarnConfigurationFields by adding the new configs to yarn-default. TestAMAuthorization and TestClientRMTokens are unrelated and fail as per YARN-4318 and YARN-4306.

          Corrected check-style issues.

          Show
          kshukla Kuhu Shukla added a comment - Fixed one test failure in TestYarnConfigurationFields by adding the new configs to yarn-default. TestAMAuthorization and TestClientRMTokens are unrelated and fail as per YARN-4318 and YARN-4306 . Corrected check-style issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 8s trunk passed
          +1 compile 8m 58s trunk passed with JDK v1.8.0_66
          +1 compile 9m 29s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 2m 5s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 4m 38s trunk passed
          +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 16s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 56s the patch passed
          +1 compile 8m 50s the patch passed with JDK v1.8.0_66
          +1 javac 8m 50s the patch passed
          +1 compile 9m 26s the patch passed with JDK v1.7.0_85
          +1 javac 9m 26s the patch passed
          -1 checkstyle 1m 2s Patch generated 1 new checkstyle issues in root (total was 396, now 396).
          +1 mvnsite 2m 3s the patch passed
          +1 mvneclipse 0m 55s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 12s the patch passed
          +1 javadoc 1m 49s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 19s the patch passed with JDK v1.7.0_85
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 37s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          -1 unit 67m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          154m 58s



          Reason Tests
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775671/YARN-4311-v3.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 67da7caa899d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a2c3bfc
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9851/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9851/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 8s trunk passed +1 compile 8m 58s trunk passed with JDK v1.8.0_66 +1 compile 9m 29s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 4s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 4m 38s trunk passed +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 16s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 56s the patch passed +1 compile 8m 50s the patch passed with JDK v1.8.0_66 +1 javac 8m 50s the patch passed +1 compile 9m 26s the patch passed with JDK v1.7.0_85 +1 javac 9m 26s the patch passed -1 checkstyle 1m 2s Patch generated 1 new checkstyle issues in root (total was 396, now 396). +1 mvnsite 2m 3s the patch passed +1 mvneclipse 0m 55s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 12s the patch passed +1 javadoc 1m 49s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 19s the patch passed with JDK v1.7.0_85 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 0m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 1m 37s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 67m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 154m 58s Reason Tests JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775671/YARN-4311-v3.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 67da7caa899d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2c3bfc findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9851/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9851/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9851/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -
           TestClientRMTokens.testShortCircuitRenewCancelDifferentHostSamePort:316->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:<null>
            TestClientRMTokens.testShortCircuitRenewCancelDifferentHostDifferentPort:327->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:<null>
            TestClientRMTokens.testShortCircuitRenewCancelSameHostDifferentPort:305->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:<null>
          
          Tests in error: 
            TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name...
            TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name...
            TestClientRMTokens.testShortCircuitRenewCancel:285->checkShortCircuitRenewCancel:353 ? NullPointer
            TestClientRMTokens.testShortCircuitRenewCancelWildcardAddress:294->checkShortCircuitRenewCancel:353 ? NullPointer
          

          Unrelated test failures as from before. Checkstyle error may be something we could ignore since it is on the number of lines in the YarnConfiguration file.

          ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1: File length is 2,321 lines (max allowed is 2,000).
          

          Jason Lowe appreciate your review comments. Thanks a lot.

          Show
          kshukla Kuhu Shukla added a comment - TestClientRMTokens.testShortCircuitRenewCancelDifferentHostSamePort:316->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:< null > TestClientRMTokens.testShortCircuitRenewCancelDifferentHostDifferentPort:327->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:< null > TestClientRMTokens.testShortCircuitRenewCancelSameHostDifferentPort:305->checkShortCircuitRenewCancel:363 expected:<getProxy> but was:< null > Tests in error: TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name... TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name... TestClientRMTokens.testShortCircuitRenewCancel:285->checkShortCircuitRenewCancel:353 ? NullPointer TestClientRMTokens.testShortCircuitRenewCancelWildcardAddress:294->checkShortCircuitRenewCancel:353 ? NullPointer Unrelated test failures as from before. Checkstyle error may be something we could ignore since it is on the number of lines in the YarnConfiguration file. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:1: File length is 2,321 lines (max allowed is 2,000). Jason Lowe appreciate your review comments. Thanks a lot.
          Hide
          kshukla Kuhu Shukla added a comment -

          Eric Payne, request for comments and review. Thanks a lot.

          Show
          kshukla Kuhu Shukla added a comment - Eric Payne , request for comments and review. Thanks a lot.
          Hide
          templedf Daniel Templeton added a comment -

          In the constructor, you check if the inactive nodes list entries are null before using them. Is that necessary? Further down in refreshNodes() you don't. Same thing in refreshNodesGracefully().

          Inside the new for loop in refreshNodes() you should combine the nested ifs into a single conditional.

          The multiple ifs and returns in isUntracked() should be combined:

            public boolean isUntrackedNode(String hostName) {
              boolean untracked = false;
              String ip = resolver.resolve(hostName);
          
              includesFile =
                  conf.get(YarnConfiguration.RM_NODES_INCLUDE_FILE_PATH,
                      YarnConfiguration.DEFAULT_RM_NODES_INCLUDE_FILE_PATH);
          
              synchronized (hostsReader) {
                Set<String> hostsList = hostsReader.getHosts();
                Set<String> excludeList = hostsReader.getExcludedHosts();
          
                untracked = !hostsList.isEmpty() &&
                    !hostsList.contains(hostName) && !hostsList.contains(ip) &&
                    !excludeList.contains(hostName) && !excludeList.contains(ip);
              }
          
              return untracked;
            }
          

          Do note that with this solution, if a user does a node refresh at least once per node removal check interval, no nodes will ever be expunged because the timestamp will continually be updated and never exceed the interval.

          Show
          templedf Daniel Templeton added a comment - In the constructor, you check if the inactive nodes list entries are null before using them. Is that necessary? Further down in refreshNodes() you don't. Same thing in refreshNodesGracefully() . Inside the new for loop in refreshNodes() you should combine the nested ifs into a single conditional. The multiple ifs and returns in isUntracked() should be combined: public boolean isUntrackedNode( String hostName) { boolean untracked = false ; String ip = resolver.resolve(hostName); includesFile = conf.get(YarnConfiguration.RM_NODES_INCLUDE_FILE_PATH, YarnConfiguration.DEFAULT_RM_NODES_INCLUDE_FILE_PATH); synchronized (hostsReader) { Set< String > hostsList = hostsReader.getHosts(); Set< String > excludeList = hostsReader.getExcludedHosts(); untracked = !hostsList.isEmpty() && !hostsList.contains(hostName) && !hostsList.contains(ip) && !excludeList.contains(hostName) && !excludeList.contains(ip); } return untracked; } Do note that with this solution, if a user does a node refresh at least once per node removal check interval, no nodes will ever be expunged because the timestamp will continually be updated and never exceed the interval.
          Hide
          templedf Daniel Templeton added a comment -

          Oh, and I'm a big proponent of using blank lines to make the code easier to read.

          Show
          templedf Daniel Templeton added a comment - Oh, and I'm a big proponent of using blank lines to make the code easier to read.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thanks Daniel Templeton. Attaching an updated patch. I removed the null check on entry set after some thought on how the entries are updated for an iterator. Made the suggested changes as well.

          Show
          kshukla Kuhu Shukla added a comment - Thanks Daniel Templeton . Attaching an updated patch. I removed the null check on entry set after some thought on how the entries are updated for an iterator. Made the suggested changes as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 33s trunk passed
          +1 compile 7m 50s trunk passed with JDK v1.8.0_66
          +1 compile 8m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 1m 59s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 4m 18s trunk passed
          +1 javadoc 1m 42s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 38s the patch passed
          +1 compile 7m 53s the patch passed with JDK v1.8.0_66
          +1 javac 7m 53s the patch passed
          +1 compile 8m 38s the patch passed with JDK v1.7.0_91
          +1 javac 8m 38s the patch passed
          -1 checkstyle 1m 3s Patch generated 1 new checkstyle issues in root (total was 396, now 396).
          +1 mvnsite 1m 58s the patch passed
          +1 mvneclipse 0m 56s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 51s the patch passed
          +1 javadoc 1m 38s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 1s the patch passed with JDK v1.7.0_91
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 69m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 71m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          221m 21s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780571/YARN-4311-v4.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 8d88df3ba3e5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96d8f1d
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10157/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10157/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 33s trunk passed +1 compile 7m 50s trunk passed with JDK v1.8.0_66 +1 compile 8m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 4s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 4m 18s trunk passed +1 javadoc 1m 42s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 7m 53s the patch passed with JDK v1.8.0_66 +1 javac 7m 53s the patch passed +1 compile 8m 38s the patch passed with JDK v1.7.0_91 +1 javac 8m 38s the patch passed -1 checkstyle 1m 3s Patch generated 1 new checkstyle issues in root (total was 396, now 396). +1 mvnsite 1m 58s the patch passed +1 mvneclipse 0m 56s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 51s the patch passed +1 javadoc 1m 38s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 1s the patch passed with JDK v1.7.0_91 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 69m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 71m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 221m 21s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780571/YARN-4311-v4.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 8d88df3ba3e5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96d8f1d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10157/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10157/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Do note that with this solution, if a user does a node refresh at least once per node removal check interval, no nodes will ever be expunged because the timestamp will continually be updated and never exceed the interval.

          Still need to address that. Will update patch shortly.

          Show
          kshukla Kuhu Shukla added a comment - Do note that with this solution, if a user does a node refresh at least once per node removal check interval, no nodes will ever be expunged because the timestamp will continually be updated and never exceed the interval. Still need to address that. Will update patch shortly.
          Hide
          kshukla Kuhu Shukla added a comment -

          Added a check before setting the timestamp of an untracked node such that its updated the first time it transitions as an untracked node and never again.

          Show
          kshukla Kuhu Shukla added a comment - Added a check before setting the timestamp of an untracked node such that its updated the first time it transitions as an untracked node and never again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 43s trunk passed
          +1 compile 7m 50s trunk passed with JDK v1.8.0_66
          +1 compile 9m 36s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 2m 1s trunk passed
          +1 mvneclipse 1m 20s trunk passed
          +1 findbugs 4m 19s trunk passed
          -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 38s the patch passed
          +1 compile 7m 49s the patch passed with JDK v1.8.0_66
          +1 javac 7m 49s the patch passed
          +1 compile 8m 49s the patch passed with JDK v1.7.0_91
          +1 javac 8m 49s the patch passed
          -1 checkstyle 1m 15s Patch generated 1 new checkstyle issues in root (total was 395, now 395).
          +1 mvnsite 2m 0s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 5m 35s the patch passed
          -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 javadoc 4m 22s the patch passed with JDK v1.7.0_91
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 67m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 67m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          218m 27s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781319/YARN-4311-v5.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux ba43cf6a8d94 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fd8065a
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10213/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10213/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 43s trunk passed +1 compile 7m 50s trunk passed with JDK v1.8.0_66 +1 compile 9m 36s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 1s trunk passed +1 mvneclipse 1m 20s trunk passed +1 findbugs 4m 19s trunk passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 7m 49s the patch passed with JDK v1.8.0_66 +1 javac 7m 49s the patch passed +1 compile 8m 49s the patch passed with JDK v1.7.0_91 +1 javac 8m 49s the patch passed -1 checkstyle 1m 15s Patch generated 1 new checkstyle issues in root (total was 395, now 395). +1 mvnsite 2m 0s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 5m 35s the patch passed -1 javadoc 0m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 4m 22s the patch passed with JDK v1.7.0_91 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 67m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 67m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 218m 27s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781319/YARN-4311-v5.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ba43cf6a8d94 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fd8065a Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10213/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10213/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10213/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Jason Lowe, Daniel Templeton request for your comments. Thank you!

          Show
          kshukla Kuhu Shukla added a comment - Jason Lowe , Daniel Templeton request for your comments. Thank you!
          Hide
          templedf Daniel Templeton added a comment -

          Thanks, Kuhu Shukla.

          Can we simplify this:

                  if (rmNode != null) {
                    if (acceptedStates.contains(rmNode.getState())) {
                      results.add(rmNode);
                    }
                  }
          

          to this:

                  if ((rmNode != null) && acceptedStates.contains(rmNode.getState())) {
                    results.add(rmNode);
                  }
          

          In general, I think it's preferable to split a line somewhere other than on a "." if convenient. There are a handful of other indentation and formatting issues, but this is the only one that bugs me enough to mention:

              if(finalState == NodeState.SHUTDOWN && rmNode.context.getNodesListManager().
                  isUntrackedNode(rmNode.hostName)) {
          

          should be:

              if (finalState == NodeState.SHUTDOWN &&
                  rmNode.context.getNodesListManager().isUntrackedNode(rmNode.hostName)) {
          

          Note the space after the "if".

          Otherwise, it looks good. Unit tests look reasonable. Thanks!

          Show
          templedf Daniel Templeton added a comment - Thanks, Kuhu Shukla . Can we simplify this: if (rmNode != null ) { if (acceptedStates.contains(rmNode.getState())) { results.add(rmNode); } } to this: if ((rmNode != null ) && acceptedStates.contains(rmNode.getState())) { results.add(rmNode); } In general, I think it's preferable to split a line somewhere other than on a "." if convenient. There are a handful of other indentation and formatting issues, but this is the only one that bugs me enough to mention: if (finalState == NodeState.SHUTDOWN && rmNode.context.getNodesListManager(). isUntrackedNode(rmNode.hostName)) { should be: if (finalState == NodeState.SHUTDOWN && rmNode.context.getNodesListManager().isUntrackedNode(rmNode.hostName)) { Note the space after the "if". Otherwise, it looks good. Unit tests look reasonable. Thanks!
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Daniel for the comments.
          Attaching revised patch with corrected indents etc.

          Show
          kshukla Kuhu Shukla added a comment - Thank you Daniel for the comments. Attaching revised patch with corrected indents etc.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 45s trunk passed
          +1 compile 7m 48s trunk passed with JDK v1.8.0_66
          +1 compile 8m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 1m 57s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          +1 findbugs 4m 24s trunk passed
          -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 37s the patch passed
          +1 compile 8m 29s the patch passed with JDK v1.8.0_66
          +1 javac 8m 29s the patch passed
          +1 compile 8m 48s the patch passed with JDK v1.7.0_91
          +1 javac 8m 48s the patch passed
          -1 checkstyle 1m 3s Patch generated 1 new checkstyle issues in root (total was 396, now 396).
          +1 mvnsite 1m 57s the patch passed
          +1 mvneclipse 0m 53s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 56s the patch passed
          -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 67m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 67m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          215m 31s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781619/YARN-4311-v6.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 41225fdc3dc6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e5df366
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10231/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10231/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 45s trunk passed +1 compile 7m 48s trunk passed with JDK v1.8.0_66 +1 compile 8m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 50s trunk passed +1 findbugs 4m 24s trunk passed -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 1s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 37s the patch passed +1 compile 8m 29s the patch passed with JDK v1.8.0_66 +1 javac 8m 29s the patch passed +1 compile 8m 48s the patch passed with JDK v1.7.0_91 +1 javac 8m 48s the patch passed -1 checkstyle 1m 3s Patch generated 1 new checkstyle issues in root (total was 396, now 396). +1 mvnsite 1m 57s the patch passed +1 mvneclipse 0m 53s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 56s the patch passed -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 67m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 67m 34s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 215m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781619/YARN-4311-v6.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 41225fdc3dc6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5df366 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10231/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10231/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10231/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          While updating the test for YARN-3102, I modified the writeToHostsFile to have the file object passed as an argument. I am updating this patch with the same change to be consistent. No changes to the non-test code.

          Show
          kshukla Kuhu Shukla added a comment - While updating the test for YARN-3102 , I modified the writeToHostsFile to have the file object passed as an argument. I am updating this patch with the same change to be consistent. No changes to the non-test code.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 36s trunk passed
          +1 compile 8m 5s trunk passed with JDK v1.8.0_66
          +1 compile 8m 52s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 10s trunk passed
          +1 mvneclipse 1m 5s trunk passed
          +1 findbugs 4m 23s trunk passed
          +1 javadoc 1m 42s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 0s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 40s the patch passed
          +1 compile 9m 11s the patch passed with JDK v1.8.0_66
          +1 javac 9m 11s the patch passed
          +1 compile 8m 50s the patch passed with JDK v1.7.0_91
          +1 javac 8m 50s the patch passed
          -1 checkstyle 1m 6s Patch generated 1 new checkstyle issues in root (total was 395, now 395).
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 1m 5s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 49s the patch passed
          +1 javadoc 1m 45s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91
          +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 71m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 1m 3s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          219m 56s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781958/YARN-4311-v7.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c52d5cd691f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fbb5868
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10258/testReport/
          modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10258/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 8m 5s trunk passed with JDK v1.8.0_66 +1 compile 8m 52s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 10s trunk passed +1 mvneclipse 1m 5s trunk passed +1 findbugs 4m 23s trunk passed +1 javadoc 1m 42s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 0s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 40s the patch passed +1 compile 9m 11s the patch passed with JDK v1.8.0_66 +1 javac 9m 11s the patch passed +1 compile 8m 50s the patch passed with JDK v1.7.0_91 +1 javac 8m 50s the patch passed -1 checkstyle 1m 6s Patch generated 1 new checkstyle issues in root (total was 395, now 395). +1 mvnsite 2m 1s the patch passed +1 mvneclipse 1m 5s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 49s the patch passed +1 javadoc 1m 45s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91 +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 71m 23s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 1m 3s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 219m 56s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781958/YARN-4311-v7.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c52d5cd691f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fbb5868 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10258/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10258/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10258/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch!

          I'd like to see the getTimestamp/setTimestamp methods be a bit more specific, like getInactiveTimestamp or getUntrackedTimestamp or something similar. Currently it sounds like a generic timestamp and therefore is unclear what the context is and when it should and should not be used.

          Similarly I think the property names are a bit too vague. Would like to see "inactive", "untracked" or some other adjective in the name to qualify when the properties apply.

          Nit: interval and timeout sound similar without qualification, e.g.: there's already expiry-interval properties that are really timeouts. Should interval be check-interval or something to distinguish it? And would it make sense to derive one from the other, similar to what is done for AM/NM expiry interval? (e.g: interval could be a fraction of timeout, potentially with a maximum interval cap of 10 minutes or something.) That's another way to eliminate the potential for confusion or misconfig, but it does make it a little more inflexible.

          Nit: There should be whitespace between the properties for readability and consistency with the rest of the file. Typically the property name and default are clustered together with gaps between different properties.

          Why does isUntrackedNode do a conf lookup and assign includesFile? It seems unrelated to what it's doing, and if it is related, why not also excludesFile? This gets called in a loop, potentially over many nodes. conf lookups can be a bit pricey, and we should avoid doing them if they're not needed.

          Time.monotonicNow should be used for the timestamps rather than System.currentTimeMillis to avoid problems when the system time is adjusted.

          The call to Timer.purge after Timer.cancel is redundant. There are no tasks on the timer after Timer.cancel is called.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! I'd like to see the getTimestamp/setTimestamp methods be a bit more specific, like getInactiveTimestamp or getUntrackedTimestamp or something similar. Currently it sounds like a generic timestamp and therefore is unclear what the context is and when it should and should not be used. Similarly I think the property names are a bit too vague. Would like to see "inactive", "untracked" or some other adjective in the name to qualify when the properties apply. Nit: interval and timeout sound similar without qualification, e.g.: there's already expiry-interval properties that are really timeouts. Should interval be check-interval or something to distinguish it? And would it make sense to derive one from the other, similar to what is done for AM/NM expiry interval? (e.g: interval could be a fraction of timeout, potentially with a maximum interval cap of 10 minutes or something.) That's another way to eliminate the potential for confusion or misconfig, but it does make it a little more inflexible. Nit: There should be whitespace between the properties for readability and consistency with the rest of the file. Typically the property name and default are clustered together with gaps between different properties. Why does isUntrackedNode do a conf lookup and assign includesFile? It seems unrelated to what it's doing, and if it is related, why not also excludesFile? This gets called in a loop, potentially over many nodes. conf lookups can be a bit pricey, and we should avoid doing them if they're not needed. Time.monotonicNow should be used for the timestamps rather than System.currentTimeMillis to avoid problems when the system time is adjusted. The call to Timer.purge after Timer.cancel is redundant. There are no tasks on the timer after Timer.cancel is called.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Jason Lowe for the review comments. I have updated the patch. The interval is 1/2 the value of the timeout config field( or should it be 1/3 like the NM expiry interval, although that could be excessive in my opinion). The default timeout is 1 minute. The interval is capped at 10 minutes.

          Show
          kshukla Kuhu Shukla added a comment - Thank you Jason Lowe for the review comments. I have updated the patch. The interval is 1/2 the value of the timeout config field( or should it be 1/3 like the NM expiry interval, although that could be excessive in my opinion). The default timeout is 1 minute. The interval is capped at 10 minutes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 48s Maven dependency ordering for branch
          +1 mvninstall 8m 3s trunk passed
          -1 compile 0m 40s root in trunk failed with JDK v1.8.0_66.
          +1 compile 7m 17s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 2m 11s trunk passed
          +1 mvneclipse 1m 2s trunk passed
          +1 findbugs 4m 22s trunk passed
          +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 34s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 6m 3s the patch passed with JDK v1.8.0_66
          -1 javac 8m 17s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 622 new issues (was 111, now 733).
          +1 javac 6m 3s the patch passed
          -1 compile 0m 43s root in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 43s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 1m 2s Patch generated 2 new checkstyle issues in root (total was 397, now 398).
          +1 mvnsite 2m 0s the patch passed
          +1 mvneclipse 0m 53s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 55s the patch passed
          +1 javadoc 1m 44s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 1m 23s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 28s Patch does not generate ASF License warnings.
          196m 12s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782345/YARN-4311-v8.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c9b79a521873 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 817cc1f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt
          findbugs v3.0.0
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10288/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10288/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 8m 3s trunk passed -1 compile 0m 40s root in trunk failed with JDK v1.8.0_66. +1 compile 7m 17s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 11s trunk passed +1 mvneclipse 1m 2s trunk passed +1 findbugs 4m 22s trunk passed +1 javadoc 1m 40s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91 0 mvndep 0m 34s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 6m 3s the patch passed with JDK v1.8.0_66 -1 javac 8m 17s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 622 new issues (was 111, now 733). +1 javac 6m 3s the patch passed -1 compile 0m 43s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 43s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 2s Patch generated 2 new checkstyle issues in root (total was 397, now 398). +1 mvnsite 2m 0s the patch passed +1 mvneclipse 0m 53s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 55s the patch passed +1 javadoc 1m 44s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 1m 23s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 196m 12s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782345/YARN-4311-v8.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c9b79a521873 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 817cc1f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 compile https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10288/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10288/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10288/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Fixed the one checkstyle issue I introduced. The javac and compile failures are from hadoop-common package where I have not changed any code. Not sure if this is related to HADOOP-8887.

          Show
          kshukla Kuhu Shukla added a comment - Fixed the one checkstyle issue I introduced. The javac and compile failures are from hadoop-common package where I have not changed any code. Not sure if this is related to HADOOP-8887 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 35s Maven dependency ordering for branch
          +1 mvninstall 7m 39s trunk passed
          -1 compile 5m 2s root in trunk failed with JDK v1.8.0_66.
          -1 compile 5m 40s root in trunk failed with JDK v1.7.0_91.
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 2m 5s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 4m 28s trunk passed
          +1 javadoc 1m 45s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 5s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 34s Maven dependency ordering for patch
          +1 mvninstall 1m 37s the patch passed
          -1 compile 1m 45s root in the patch failed with JDK v1.8.0_66.
          -1 javac 1m 45s root in the patch failed with JDK v1.8.0_66.
          -1 compile 1m 58s root in the patch failed with JDK v1.7.0_91.
          -1 javac 1m 58s root in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 1m 5s Patch generated 1 new checkstyle issues in root (total was 396, now 396).
          +1 mvnsite 1m 54s the patch passed
          +1 mvneclipse 0m 48s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 49s the patch passed
          +1 javadoc 1m 38s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 57s the patch passed with JDK v1.7.0_91
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 65m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 67m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 0m 56s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          195m 10s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782542/YARN-4311-v9.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 2aefcfd4fd59 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1da762c
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10302/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10302/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 35s Maven dependency ordering for branch +1 mvninstall 7m 39s trunk passed -1 compile 5m 2s root in trunk failed with JDK v1.8.0_66. -1 compile 5m 40s root in trunk failed with JDK v1.7.0_91. +1 checkstyle 1m 9s trunk passed +1 mvnsite 2m 5s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 4m 28s trunk passed +1 javadoc 1m 45s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 5s trunk passed with JDK v1.7.0_91 0 mvndep 0m 34s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed -1 compile 1m 45s root in the patch failed with JDK v1.8.0_66. -1 javac 1m 45s root in the patch failed with JDK v1.8.0_66. -1 compile 1m 58s root in the patch failed with JDK v1.7.0_91. -1 javac 1m 58s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 5s Patch generated 1 new checkstyle issues in root (total was 396, now 396). +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 49s the patch passed +1 javadoc 1m 38s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 57s the patch passed with JDK v1.7.0_91 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 65m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 67m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 0m 56s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 195m 10s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782542/YARN-4311-v9.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2aefcfd4fd59 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1da762c Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/branch-compile-root-jdk1.7.0_91.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10302/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10302/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10302/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Jason Lowe, Daniel Templeton, Requesting comments. The new failures with compile and javac sections are unrelated, test failures are consistent and unrelated. Thanks!

          Show
          kshukla Kuhu Shukla added a comment - Jason Lowe , Daniel Templeton , Requesting comments. The new failures with compile and javac sections are unrelated, test failures are consistent and unrelated. Thanks!
          Hide
          kshukla Kuhu Shukla added a comment -

          Rebasing patch after YARN-3102. Tests from ResourceManager pass locally.

          Show
          kshukla Kuhu Shukla added a comment - Rebasing patch after YARN-3102 . Tests from ResourceManager pass locally.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 1m 10s Maven dependency ordering for branch
          +1 mvninstall 7m 2s trunk passed
          +1 compile 6m 7s trunk passed with JDK v1.8.0_66
          +1 compile 6m 45s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 56s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 4m 16s trunk passed
          +1 javadoc 1m 37s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 8s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 34s Maven dependency ordering for patch
          +1 mvninstall 1m 33s the patch passed
          +1 compile 5m 45s the patch passed with JDK v1.8.0_66
          +1 javac 5m 45s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.7.0_91
          +1 javac 6m 44s the patch passed
          +1 checkstyle 1m 9s the patch passed
          +1 mvnsite 1m 56s the patch passed
          +1 mvneclipse 0m 53s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 11s the patch passed
          +1 javadoc 1m 40s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 9s the patch passed with JDK v1.7.0_91
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 61m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 63m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          198m 45s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785797/YARN-4311-v10.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 2f800755331c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 700a176
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10470/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10470/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 10s Maven dependency ordering for branch +1 mvninstall 7m 2s trunk passed +1 compile 6m 7s trunk passed with JDK v1.8.0_66 +1 compile 6m 45s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 56s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 4m 16s trunk passed +1 javadoc 1m 37s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 8s trunk passed with JDK v1.7.0_91 0 mvndep 0m 34s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 5m 45s the patch passed with JDK v1.8.0_66 +1 javac 5m 45s the patch passed +1 compile 6m 44s the patch passed with JDK v1.7.0_91 +1 javac 6m 44s the patch passed +1 checkstyle 1m 9s the patch passed +1 mvnsite 1m 56s the patch passed +1 mvneclipse 0m 53s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 11s the patch passed +1 javadoc 1m 40s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 9s the patch passed with JDK v1.7.0_91 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 61m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 63m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 198m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785797/YARN-4311-v10.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2f800755331c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 700a176 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10470/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10470/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10470/console This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Request for comments Jason Lowe, Daniel Templeton. Thanks a lot. Test failures are known, unrelated and documented.

          Show
          kshukla Kuhu Shukla added a comment - Request for comments Jason Lowe , Daniel Templeton . Thanks a lot. Test failures are known, unrelated and documented.
          Hide
          kshukla Kuhu Shukla added a comment -

          Rebasing patch after YARN-3223. Requesting Jason Lowe, Daniel Templeton for review/comments. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Rebasing patch after YARN-3223 . Requesting Jason Lowe , Daniel Templeton for review/comments. Thanks a lot!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 8m 38s trunk passed
          +1 compile 11m 46s trunk passed with JDK v1.8.0_72
          +1 compile 9m 12s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 2m 4s trunk passed
          +1 mvneclipse 0m 56s trunk passed
          +1 findbugs 4m 15s trunk passed
          +1 javadoc 2m 19s trunk passed with JDK v1.8.0_72
          +1 javadoc 4m 39s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 23s Maven dependency ordering for patch
          +1 mvninstall 2m 54s the patch passed
          +1 compile 16m 13s the patch passed with JDK v1.8.0_72
          +1 javac 16m 13s the patch passed
          +1 compile 9m 38s the patch passed with JDK v1.7.0_95
          +1 javac 9m 38s the patch passed
          +1 checkstyle 1m 13s the patch passed
          +1 mvnsite 2m 6s the patch passed
          +1 mvneclipse 0m 57s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 5m 12s the patch passed
          +1 javadoc 2m 6s the patch passed with JDK v1.8.0_72
          +1 javadoc 4m 16s the patch passed with JDK v1.7.0_95
          +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 79m 14s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72.
          +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 75m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          254m 38s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789211/YARN-4311-v11.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d7b9a1ed1e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9ed17f1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10609/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10609/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 8m 38s trunk passed +1 compile 11m 46s trunk passed with JDK v1.8.0_72 +1 compile 9m 12s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 4m 15s trunk passed +1 javadoc 2m 19s trunk passed with JDK v1.8.0_72 +1 javadoc 4m 39s trunk passed with JDK v1.7.0_95 0 mvndep 0m 23s Maven dependency ordering for patch +1 mvninstall 2m 54s the patch passed +1 compile 16m 13s the patch passed with JDK v1.8.0_72 +1 javac 16m 13s the patch passed +1 compile 9m 38s the patch passed with JDK v1.7.0_95 +1 javac 9m 38s the patch passed +1 checkstyle 1m 13s the patch passed +1 mvnsite 2m 6s the patch passed +1 mvneclipse 0m 57s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 5m 12s the patch passed +1 javadoc 2m 6s the patch passed with JDK v1.8.0_72 +1 javadoc 4m 16s the patch passed with JDK v1.7.0_95 +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.8.0_72. +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 79m 14s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_72. +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.8.0_72. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 75m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 254m 38s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789211/YARN-4311-v11.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d7b9a1ed1e8a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9ed17f1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10609/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10609/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10609/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Re-attaching the v11 patch with no changes to trigger another pre-commit since TestResourceTrackerService failure are not reproducible locally and from investigation seem related to the sleep based wait. Need to see if this failure is consistent. Also checked that it applies clean to trunk.

          Show
          kshukla Kuhu Shukla added a comment - Re-attaching the v11 patch with no changes to trigger another pre-commit since TestResourceTrackerService failure are not reproducible locally and from investigation seem related to the sleep based wait. Need to see if this failure is consistent. Also checked that it applies clean to trunk.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 40s trunk passed
          +1 compile 5m 46s trunk passed with JDK v1.8.0_74
          +1 compile 6m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 55s trunk passed
          +1 mvneclipse 0m 54s trunk passed
          +1 findbugs 3m 57s trunk passed
          +1 javadoc 1m 37s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 9s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 38s the patch passed
          +1 compile 5m 53s the patch passed with JDK v1.8.0_74
          +1 javac 5m 53s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          +1 checkstyle 1m 11s the patch passed
          +1 mvnsite 1m 54s the patch passed
          +1 mvneclipse 0m 53s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 50s the patch passed
          +1 javadoc 1m 42s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 9s the patch passed with JDK v1.7.0_95
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
          -1 unit 66m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 67m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          205m 23s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791196/YARN-4311-v11.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux cca994f7083c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a9f00a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10697/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10697/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 5m 46s trunk passed with JDK v1.8.0_74 +1 compile 6m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 55s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 3m 57s trunk passed +1 javadoc 1m 37s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 9s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_74 +1 javac 5m 53s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 1m 11s the patch passed +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 53s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 50s the patch passed +1 javadoc 1m 42s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 9s the patch passed with JDK v1.7.0_95 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_74. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 66m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_74. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 67m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 205m 23s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791196/YARN-4311-v11.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux cca994f7083c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a9f00a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10697/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10697/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10697/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe, Daniel Templeton for review/comments. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe , Daniel Templeton for review/comments. Thanks a lot!
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe, Daniel Templeton for review/comments. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe, Daniel Templeton for review/comments. Thanks a lot!
          Hide
          templedf Daniel Templeton added a comment -

          I don't have any further comments. LGTM.

          Show
          templedf Daniel Templeton added a comment - I don't have any further comments. LGTM.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! Sorry for the delay in getting back to the review.

          The property documentation should not refer to RMNodes, as users who are not savvy on the source code may be confused by it. Similarly the documentation should elaborate a bit on how a node is "declared untracked".

          Nit: The timer task should just grab the current time once and cache it in a local rather than hammering on it in the loop.

          Nit: Same current time comment for the refresh cases, and I think it's worth factoring the common loop over the inactive nodes into a private utility method.

          Nit: The timer task logic ends up calling isUntrackedNode unnecessarily often, and it's the more expensive check to make. It think it would be better to check that first, since each conditional clause requires knowing the result anyway. For example, something like this:

            long now = Time.monotonicNow();
            if (isUntrackedNode(rmNode.getHostName())) {
              if (rmNode.getUntrackedTimestamp == 0) {
                rmNode.setUntrackedTimeStamp(now);
              } else if (now - rmNode.getUntrackedTimeStamp() > nodeRemovalTimeout) {
                [...node removal logic..]
              }
            } else {
              rmNode.setUntrackedTimeStamp(0);
            }
          
          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! Sorry for the delay in getting back to the review. The property documentation should not refer to RMNodes, as users who are not savvy on the source code may be confused by it. Similarly the documentation should elaborate a bit on how a node is "declared untracked". Nit: The timer task should just grab the current time once and cache it in a local rather than hammering on it in the loop. Nit: Same current time comment for the refresh cases, and I think it's worth factoring the common loop over the inactive nodes into a private utility method. Nit: The timer task logic ends up calling isUntrackedNode unnecessarily often, and it's the more expensive check to make. It think it would be better to check that first, since each conditional clause requires knowing the result anyway. For example, something like this: long now = Time.monotonicNow(); if (isUntrackedNode(rmNode.getHostName())) { if (rmNode.getUntrackedTimestamp == 0) { rmNode.setUntrackedTimeStamp(now); } else if (now - rmNode.getUntrackedTimeStamp() > nodeRemovalTimeout) { [...node removal logic..] } } else { rmNode.setUntrackedTimeStamp(0); }
          Hide
          kshukla Kuhu Shukla added a comment -

          Thanks a lot for all the reviews! Updating patch as per Jason's comments. Additionally added a log line at info level when the untracked node is removed upon timeout.

          Show
          kshukla Kuhu Shukla added a comment - Thanks a lot for all the reviews! Updating patch as per Jason's comments. Additionally added a log line at info level when the untracked node is removed upon timeout.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          -1 mvninstall 2m 41s root in trunk failed.
          -1 compile 1m 7s root in trunk failed with JDK v1.8.0_74.
          -1 compile 1m 15s root in trunk failed with JDK v1.7.0_95.
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 50s trunk passed
          +1 findbugs 3m 46s trunk passed
          +1 javadoc 1m 38s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 5s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 41s the patch passed
          -1 compile 1m 15s root in the patch failed with JDK v1.8.0_74.
          -1 javac 1m 15s root in the patch failed with JDK v1.8.0_74.
          -1 compile 1m 17s root in the patch failed with JDK v1.7.0_95.
          -1 javac 1m 17s root in the patch failed with JDK v1.7.0_95.
          +1 checkstyle 1m 7s the patch passed
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 46s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 42s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 4s the patch passed with JDK v1.7.0_95
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
          -1 unit 72m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 73m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_95.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          192m 1s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795508/YARN-4311-v12.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 72f1104ffeb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e5ff0ea
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-compile-root-jdk1.8.0_74.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-compile-root-jdk1.7.0_95.txt
          findbugs v3.0.0
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10882/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10882/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch -1 mvninstall 2m 41s root in trunk failed. -1 compile 1m 7s root in trunk failed with JDK v1.8.0_74. -1 compile 1m 15s root in trunk failed with JDK v1.7.0_95. +1 checkstyle 1m 8s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 50s trunk passed +1 findbugs 3m 46s trunk passed +1 javadoc 1m 38s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 5s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed -1 compile 1m 15s root in the patch failed with JDK v1.8.0_74. -1 javac 1m 15s root in the patch failed with JDK v1.8.0_74. -1 compile 1m 17s root in the patch failed with JDK v1.7.0_95. -1 javac 1m 17s root in the patch failed with JDK v1.7.0_95. +1 checkstyle 1m 7s the patch passed +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 46s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 42s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 4s the patch passed with JDK v1.7.0_95 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_74. +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 72m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_74. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 73m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_95. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 192m 1s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795508/YARN-4311-v12.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 72f1104ffeb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5ff0ea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-compile-root-jdk1.8.0_74.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/branch-compile-root-jdk1.7.0_95.txt findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.8.0_74.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10882/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10882/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10882/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Maven and javac failures are unrelated and coming from hdfs project.

          symbol:   class StripedBlockInfo
          [ERROR] location: package org.apache.hadoop.hdfs.protocol
          [ERROR] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java:[212,26] error: cannot find symbol
          [ERROR] symbol:   class StripedBlockInfo
          [ERROR] location: interface DataTransferProtocol
          [ERROR] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java:[31,38] error: cannot find symbol
          [ERROR] symbol:   class StripedBlockInfo
          

          ASF license warnings are also hdfs related.
          Test failures are consistent, unrelated and known issues.
          Thank you so much Jason Lowe for the review, requesting comments for the revised patch. I have additionally added a log line at info level when the node is removed from the inactive list to better track when nodes finally go away. Should this be at debug level?

          Show
          kshukla Kuhu Shukla added a comment - Maven and javac failures are unrelated and coming from hdfs project. symbol: class StripedBlockInfo [ERROR] location: package org.apache.hadoop.hdfs.protocol [ERROR] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtocol.java:[212,26] error: cannot find symbol [ERROR] symbol: class StripedBlockInfo [ERROR] location: interface DataTransferProtocol [ERROR] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java:[31,38] error: cannot find symbol [ERROR] symbol: class StripedBlockInfo ASF license warnings are also hdfs related. Test failures are consistent, unrelated and known issues. Thank you so much Jason Lowe for the review, requesting comments for the revised patch. I have additionally added a log line at info level when the node is removed from the inactive list to better track when nodes finally go away. Should this be at debug level?
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe for review/comments. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe for review/comments. Thanks a lot!
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! Everything looks great except nodes list should not be possessive, i.e.: "nodes' list" should just be "nodes list".

          I have additionally added a log line at info level when the node is removed from the inactive list to better track when nodes finally go away. Should this be at debug level?

          I think it's fine to log it at INFO. It should be a relatively rare log message, and it helps explain to users/admins why a node disappeared from the RM UI.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! Everything looks great except nodes list should not be possessive, i.e.: "nodes' list" should just be "nodes list". I have additionally added a log line at info level when the node is removed from the inactive list to better track when nodes finally go away. Should this be at debug level? I think it's fine to log it at INFO. It should be a relatively rare log message, and it helps explain to users/admins why a node disappeared from the RM UI.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Jason Lowe! Updated patch with the one minor change in yarn-default.xml.

          Show
          kshukla Kuhu Shukla added a comment - Thank you Jason Lowe ! Updated patch with the one minor change in yarn-default.xml.
          Hide
          kshukla Kuhu Shukla added a comment -

          ... and the Log line during removal.

          Show
          kshukla Kuhu Shukla added a comment - ... and the Log line during removal.
          Hide
          kshukla Kuhu Shukla added a comment -

          Same patch, trying to get PreCommit to pick it up.

          Show
          kshukla Kuhu Shukla added a comment - Same patch, trying to get PreCommit to pick it up.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 37s trunk passed
          +1 compile 5m 50s trunk passed with JDK v1.8.0_74
          +1 compile 6m 48s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 52s trunk passed
          +1 mvneclipse 0m 56s trunk passed
          +1 findbugs 3m 55s trunk passed
          +1 javadoc 1m 42s trunk passed with JDK v1.8.0_74
          +1 javadoc 4m 5s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 35s the patch passed
          +1 compile 5m 48s the patch passed with JDK v1.8.0_74
          +1 javac 5m 48s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          +1 checkstyle 1m 10s the patch passed
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74
          +1 javadoc 4m 5s the patch passed with JDK v1.7.0_95
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_74.
          +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_74.
          -1 unit 64m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_74.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          200m 54s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796547/YARN-4311-v14.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 2b4c60f2f4c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 256c82f
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10929/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10929/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 5m 50s trunk passed with JDK v1.8.0_74 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 3m 55s trunk passed +1 javadoc 1m 42s trunk passed with JDK v1.8.0_74 +1 javadoc 4m 5s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 5m 48s the patch passed with JDK v1.8.0_74 +1 javac 5m 48s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 1m 10s the patch passed +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_74 +1 javadoc 4m 5s the patch passed with JDK v1.7.0_95 +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_74. +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_74. -1 unit 64m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_74. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_74. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 10s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 200m 54s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796547/YARN-4311-v14.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2b4c60f2f4c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 256c82f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-YARN-Build/10929/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10929/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10929/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          New test failure of TestRMAdminService#testResourcePersistentForNMRegistrationWithNewResource is failing with or without the patch, opened YARN-4912. Other test failures are known. @Requesting Jason Lowe for comments/review. Thanks a lot!!

          Show
          kshukla Kuhu Shukla added a comment - New test failure of TestRMAdminService#testResourcePersistentForNMRegistrationWithNewResource is failing with or without the patch, opened YARN-4912 . Other test failures are known. @Requesting Jason Lowe for comments/review. Thanks a lot!!
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe for comments/review. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe for comments/review. Thanks a lot!
          Hide
          jlowe Jason Lowe added a comment -

          +1 latest patch lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 latest patch lgtm. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Kuhu for the contribution and to Daniel for additional review! I committed this to trunk, branch-2, and branch-2.8.

          Show
          jlowe Jason Lowe added a comment - Thanks to Kuhu for the contribution and to Daniel for additional review! I committed this to trunk, branch-2, and branch-2.8.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9558 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9558/)
          YARN-4311. Removing nodes from include and exclude lists will not remove (jlowe: rev 1cbcd4a491e6a57d466c2897335614dc6770b475)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9558 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9558/ ) YARN-4311 . Removing nodes from include and exclude lists will not remove (jlowe: rev 1cbcd4a491e6a57d466c2897335614dc6770b475) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you so much Jason Lowe for the detailed help and review! Appreciate the help.

          Show
          kshukla Kuhu Shukla added a comment - Thank you so much Jason Lowe for the detailed help and review! Appreciate the help.
          Hide
          kshukla Kuhu Shukla added a comment -

          Attaching branch-2.7 version of the patch.

          Show
          kshukla Kuhu Shukla added a comment - Attaching branch-2.7 version of the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 9m 53s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 6m 2s branch-2.7 passed
          +1 compile 5m 37s branch-2.7 passed with JDK v1.8.0_77
          +1 compile 6m 7s branch-2.7 passed with JDK v1.7.0_95
          +1 checkstyle 1m 36s branch-2.7 passed
          +1 mvnsite 1m 50s branch-2.7 passed
          +1 mvneclipse 0m 52s branch-2.7 passed
          -1 findbugs 1m 1s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings.
          -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings.
          +1 javadoc 1m 30s branch-2.7 passed with JDK v1.8.0_77
          +1 javadoc 3m 19s branch-2.7 passed with JDK v1.7.0_95
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 34s the patch passed
          +1 compile 5m 33s the patch passed with JDK v1.8.0_77
          +1 javac 5m 33s the patch passed
          +1 compile 6m 15s the patch passed with JDK v1.7.0_95
          +1 javac 6m 15s the patch passed
          -1 checkstyle 1m 33s root: patch generated 35 new + 1187 unchanged - 0 fixed = 1222 total (was 1187)
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 51s the patch passed
          -1 whitespace 0m 0s The patch has 8070 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 3m 58s The patch has 440 line(s) with tabs.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 41s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95
          +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 41s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 52m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95.
          -1 asflicense 4m 56s Patch generated 145 ASF License warnings.
          192m 26s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797732/YARN-4311-branch-2.7.001.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 11c519ec63f2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 262d769
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10995/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10995/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 9m 53s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 6m 2s branch-2.7 passed +1 compile 5m 37s branch-2.7 passed with JDK v1.8.0_77 +1 compile 6m 7s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 1m 36s branch-2.7 passed +1 mvnsite 1m 50s branch-2.7 passed +1 mvneclipse 0m 52s branch-2.7 passed -1 findbugs 1m 1s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings. +1 javadoc 1m 30s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 3m 19s branch-2.7 passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 34s the patch passed +1 compile 5m 33s the patch passed with JDK v1.8.0_77 +1 javac 5m 33s the patch passed +1 compile 6m 15s the patch passed with JDK v1.7.0_95 +1 javac 6m 15s the patch passed -1 checkstyle 1m 33s root: patch generated 35 new + 1187 unchanged - 0 fixed = 1222 total (was 1187) +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 51s the patch passed -1 whitespace 0m 0s The patch has 8070 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 3m 58s The patch has 440 line(s) with tabs. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 41s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95 +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 1m 41s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 52m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 53m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95. -1 asflicense 4m 56s Patch generated 145 ASF License warnings. 192m 26s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797732/YARN-4311-branch-2.7.001.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 11c519ec63f2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 262d769 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10995/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10995/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/10995/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Addressed failure of TestNMExpiry along with most of the checkstyle issues except Javadoc missing comments suggestions. ASF warnings, whitespace issues and findbugs warnings are unrelated.

          Show
          kshukla Kuhu Shukla added a comment - Addressed failure of TestNMExpiry along with most of the checkstyle issues except Javadoc missing comments suggestions. ASF warnings, whitespace issues and findbugs warnings are unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 5m 53s branch-2.7 passed
          +1 compile 5m 28s branch-2.7 passed with JDK v1.8.0_77
          +1 compile 6m 20s branch-2.7 passed with JDK v1.7.0_95
          +1 checkstyle 1m 34s branch-2.7 passed
          +1 mvnsite 1m 49s branch-2.7 passed
          +1 mvneclipse 0m 52s branch-2.7 passed
          -1 findbugs 1m 2s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings.
          -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings.
          +1 javadoc 1m 32s branch-2.7 passed with JDK v1.8.0_77
          +1 javadoc 3m 20s branch-2.7 passed with JDK v1.7.0_95
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 33s the patch passed
          +1 compile 5m 28s the patch passed with JDK v1.8.0_77
          +1 javac 5m 28s the patch passed
          +1 compile 6m 9s the patch passed with JDK v1.7.0_95
          +1 javac 6m 9s the patch passed
          -1 checkstyle 1m 30s root: patch generated 15 new + 1187 unchanged - 0 fixed = 1202 total (was 1187)
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 49s the patch passed
          -1 whitespace 0m 1s The patch has 8479 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 4m 11s The patch has 440 line(s) with tabs.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 26s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 13s the patch passed with JDK v1.7.0_95
          +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 36s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 52m 45s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 48s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_95.
          -1 asflicense 4m 51s Patch generated 145 ASF License warnings.
          182m 4s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797847/YARN-4311-branch-2.7.002.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 98c5de0babd8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 801c95c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11008/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11008/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 5m 53s branch-2.7 passed +1 compile 5m 28s branch-2.7 passed with JDK v1.8.0_77 +1 compile 6m 20s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 1m 34s branch-2.7 passed +1 mvnsite 1m 49s branch-2.7 passed +1 mvneclipse 0m 52s branch-2.7 passed -1 findbugs 1m 2s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings. +1 javadoc 1m 32s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 3m 20s branch-2.7 passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 5m 28s the patch passed with JDK v1.8.0_77 +1 javac 5m 28s the patch passed +1 compile 6m 9s the patch passed with JDK v1.7.0_95 +1 javac 6m 9s the patch passed -1 checkstyle 1m 30s root: patch generated 15 new + 1187 unchanged - 0 fixed = 1202 total (was 1187) +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 49s the patch passed -1 whitespace 0m 1s The patch has 8479 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 4m 11s The patch has 440 line(s) with tabs. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 13s the patch passed with JDK v1.7.0_95 +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 1m 36s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 52m 45s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 48s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 53m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.7.0_95. -1 asflicense 4m 51s Patch generated 145 ASF License warnings. 182m 4s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestResourceTrackerService JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797847/YARN-4311-branch-2.7.002.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 98c5de0babd8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 801c95c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11008/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11008/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11008/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          More fixes and nits.

          Show
          kshukla Kuhu Shukla added a comment - More fixes and nits.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 20s Maven dependency ordering for branch
          +1 mvninstall 5m 44s branch-2.7 passed
          +1 compile 5m 13s branch-2.7 passed with JDK v1.8.0_77
          +1 compile 5m 58s branch-2.7 passed with JDK v1.7.0_95
          +1 checkstyle 1m 32s branch-2.7 passed
          +1 mvnsite 1m 47s branch-2.7 passed
          +1 mvneclipse 0m 51s branch-2.7 passed
          -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings.
          -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings.
          +1 javadoc 1m 27s branch-2.7 passed with JDK v1.8.0_77
          +1 javadoc 3m 12s branch-2.7 passed with JDK v1.7.0_95
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 5m 7s the patch passed with JDK v1.8.0_77
          +1 javac 5m 7s the patch passed
          +1 compile 5m 59s the patch passed with JDK v1.7.0_95
          +1 javac 5m 59s the patch passed
          -1 checkstyle 1m 30s root: patch generated 11 new + 1187 unchanged - 0 fixed = 1198 total (was 1187)
          +1 mvnsite 1m 45s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          -1 whitespace 0m 0s The patch has 8887 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 4m 33s The patch has 440 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 37s the patch passed
          +1 javadoc 1m 26s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 12s the patch passed with JDK v1.7.0_95
          +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 37s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 52m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95.
          -1 asflicense 4m 47s Patch generated 145 ASF License warnings.
          179m 32s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797895/YARN-4311-branch-2.7.003.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux be2028fa6fb3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 801c95c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11011/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11011/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 5m 44s branch-2.7 passed +1 compile 5m 13s branch-2.7 passed with JDK v1.8.0_77 +1 compile 5m 58s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 1m 32s branch-2.7 passed +1 mvnsite 1m 47s branch-2.7 passed +1 mvneclipse 0m 51s branch-2.7 passed -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. -1 findbugs 0m 30s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings. +1 javadoc 1m 27s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 3m 12s branch-2.7 passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 5m 7s the patch passed with JDK v1.8.0_77 +1 javac 5m 7s the patch passed +1 compile 5m 59s the patch passed with JDK v1.7.0_95 +1 javac 5m 59s the patch passed -1 checkstyle 1m 30s root: patch generated 11 new + 1187 unchanged - 0 fixed = 1198 total (was 1187) +1 mvnsite 1m 45s the patch passed +1 mvneclipse 0m 52s the patch passed -1 whitespace 0m 0s The patch has 8887 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 4m 33s The patch has 440 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 37s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 12s the patch passed with JDK v1.7.0_95 +1 unit 0m 18s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 1m 37s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 52m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 53m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95. -1 asflicense 4m 47s Patch generated 145 ASF License warnings. 179m 32s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestResourceTrackerService Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797895/YARN-4311-branch-2.7.003.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux be2028fa6fb3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 801c95c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11011/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11011/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11011/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          TestResourceTrackerService#testNodeRemoval passes locally but is flaky since the wait period was set to the minimum wait time which may get exceeded during removal. I have added waitForNodeRemoval that waits for the node to get removed before asserting. This fix should be added to the test in trunk although it was not seen in the precommits. I will do so after some review comments on this.

          Show
          kshukla Kuhu Shukla added a comment - TestResourceTrackerService#testNodeRemoval passes locally but is flaky since the wait period was set to the minimum wait time which may get exceeded during removal. I have added waitForNodeRemoval that waits for the node to get removed before asserting. This fix should be added to the test in trunk although it was not seen in the precommits. I will do so after some review comments on this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 5m 53s branch-2.7 passed
          +1 compile 7m 1s branch-2.7 passed with JDK v1.8.0_77
          +1 compile 6m 12s branch-2.7 passed with JDK v1.7.0_95
          +1 checkstyle 1m 36s branch-2.7 passed
          +1 mvnsite 1m 55s branch-2.7 passed
          +1 mvneclipse 0m 56s branch-2.7 passed
          -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings.
          -1 findbugs 0m 33s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings.
          +1 javadoc 1m 31s branch-2.7 passed with JDK v1.8.0_77
          +1 javadoc 3m 13s branch-2.7 passed with JDK v1.7.0_95
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 29s the patch passed
          +1 compile 5m 7s the patch passed with JDK v1.8.0_77
          +1 javac 5m 7s the patch passed
          +1 compile 5m 58s the patch passed with JDK v1.7.0_95
          +1 javac 5m 58s the patch passed
          -1 checkstyle 1m 30s root: patch generated 11 new + 1187 unchanged - 0 fixed = 1198 total (was 1187)
          +1 mvnsite 1m 46s the patch passed
          +1 mvneclipse 0m 52s the patch passed
          -1 whitespace 0m 0s The patch has 9295 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 4m 24s The patch has 440 line(s) with tabs.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 49s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_77
          +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 52m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_95.
          -1 asflicense 4m 51s Patch generated 145 ASF License warnings.
          183m 18s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797897/YARN-4311-branch-2.7.004.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux c3fbb2da5748 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 801c95c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11012/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11012/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 5m 53s branch-2.7 passed +1 compile 7m 1s branch-2.7 passed with JDK v1.8.0_77 +1 compile 6m 12s branch-2.7 passed with JDK v1.7.0_95 +1 checkstyle 1m 36s branch-2.7 passed +1 mvnsite 1m 55s branch-2.7 passed +1 mvneclipse 0m 56s branch-2.7 passed -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. -1 findbugs 0m 33s hadoop-tools/hadoop-sls in branch-2.7 has 11 extant Findbugs warnings. +1 javadoc 1m 31s branch-2.7 passed with JDK v1.8.0_77 +1 javadoc 3m 13s branch-2.7 passed with JDK v1.7.0_95 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 5m 7s the patch passed with JDK v1.8.0_77 +1 javac 5m 7s the patch passed +1 compile 5m 58s the patch passed with JDK v1.7.0_95 +1 javac 5m 58s the patch passed -1 checkstyle 1m 30s root: patch generated 11 new + 1187 unchanged - 0 fixed = 1198 total (was 1187) +1 mvnsite 1m 46s the patch passed +1 mvneclipse 0m 52s the patch passed -1 whitespace 0m 0s The patch has 9295 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 4m 24s The patch has 440 line(s) with tabs. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 49s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95 +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 1m 46s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 52m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 49s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 20s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 53m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.7.0_95. -1 asflicense 4m 51s Patch generated 145 ASF License warnings. 183m 18s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797897/YARN-4311-branch-2.7.004.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c3fbb2da5748 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 801c95c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-sls-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11012/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11012/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11012/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe for reviews on branch-2.7 version of the patch.

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe for reviews on branch-2.7 version of the patch.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! Couple of comments:

          The patch has a lot of diffs from the trunk patch. I would expect them to be somewhat similar, but there's a lot of unnecessary diffs here, like final modifiers in one but not the other, inconsistent line breaks for essentially the same change, etc. Please examine the diff of the two patches and keep in mind these should be the minimal necessary. Otherwise we're just making other backports to branch-2.7 that much more difficult. If we really need the final modifiers, etc, then why didn't we need them in the trunk patch?

          When we walk the inactive nodes list to remove nodes, what if the node isn't in the DECOMMISSIONED state (e.g.: LOST, REBOOTED)? Wondering if the decommissioned metric could go negative in those cases and we could end up with wrong lost/rebooted metrics. If so, I believe this could happen in the trunk patch as well.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! Couple of comments: The patch has a lot of diffs from the trunk patch. I would expect them to be somewhat similar, but there's a lot of unnecessary diffs here, like final modifiers in one but not the other, inconsistent line breaks for essentially the same change, etc. Please examine the diff of the two patches and keep in mind these should be the minimal necessary. Otherwise we're just making other backports to branch-2.7 that much more difficult. If we really need the final modifiers, etc, then why didn't we need them in the trunk patch? When we walk the inactive nodes list to remove nodes, what if the node isn't in the DECOMMISSIONED state (e.g.: LOST, REBOOTED)? Wondering if the decommissioned metric could go negative in those cases and we could end up with wrong lost/rebooted metrics. If so, I believe this could happen in the trunk patch as well.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thank you Jason Lowe for the comments. The final variables and the line breaks stem from a large number of checkstyle warnings which did not show up for trunk precommit but only for branch-2.7. I can revert that to what it was with minimal diff from the trunk version. I need to cross check if we could run into bad metrics for LOST, REBOOTED nodes and shall update shortly. Appreciate the insight!

          Show
          kshukla Kuhu Shukla added a comment - Thank you Jason Lowe for the comments. The final variables and the line breaks stem from a large number of checkstyle warnings which did not show up for trunk precommit but only for branch-2.7. I can revert that to what it was with minimal diff from the trunk version. I need to cross check if we could run into bad metrics for LOST, REBOOTED nodes and shall update shortly. Appreciate the insight!
          Hide
          kshukla Kuhu Shukla added a comment -

          The problem does exist. In a scenario where the node being removed from the list is already in REBOOTED, LOST state then node metrics would go out of sync.
          There are 2 approaches to solve this:
          1. Have the appropriate metrics decremented and let the timer remove such nodes.
          2. Have the timer remove only nodes that are DECOMMISSIONED.

          Both LOST and REBOOTED states are self arcs to themselves in the Finite State Machine, just like DECOMMISSIONED nodes, so that removes some complexity if we go with option 1.

          Jason Lowe, Requesting you for your comments on the 2 approaches and which one sounds better.

          Will open a follow up JIRA shortly.

          Show
          kshukla Kuhu Shukla added a comment - The problem does exist. In a scenario where the node being removed from the list is already in REBOOTED, LOST state then node metrics would go out of sync. There are 2 approaches to solve this: 1. Have the appropriate metrics decremented and let the timer remove such nodes. 2. Have the timer remove only nodes that are DECOMMISSIONED. Both LOST and REBOOTED states are self arcs to themselves in the Finite State Machine, just like DECOMMISSIONED nodes, so that removes some complexity if we go with option 1. Jason Lowe , Requesting you for your comments on the 2 approaches and which one sounds better. Will open a follow up JIRA shortly.
          Hide
          jlowe Jason Lowe added a comment -

          No need for a followup JIRA, I'll revert the one in trunk until we work through the metrics issues.

          Show
          jlowe Jason Lowe added a comment - No need for a followup JIRA, I'll revert the one in trunk until we work through the metrics issues.
          Hide
          jlowe Jason Lowe added a comment -

          I reverted this from trunk, branch-2, and branch-2.8 until we can work through the lost, rebooted nodes case and make sure the node metrics won't be adversely affected by this change.

          Show
          jlowe Jason Lowe added a comment - I reverted this from trunk, branch-2, and branch-2.8 until we can work through the lost, rebooted nodes case and make sure the node metrics won't be adversely affected by this change.
          Hide
          jlowe Jason Lowe added a comment -

          If we only remove truly untracked nodes then option 1 should be OK. Therefore we won't remove LOST nodes that are still listed in the include list, and admins can see that those nodes are still supposed to be part of the cluster but are not currently active.

          Show
          jlowe Jason Lowe added a comment - If we only remove truly untracked nodes then option 1 should be OK. Therefore we won't remove LOST nodes that are still listed in the include list, and admins can see that those nodes are still supposed to be part of the cluster but are not currently active.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9592 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9592/)
          Revert "YARN-4311. Removing nodes from include and exclude lists will (jlowe: rev 2a5da97f81d69b481e4d1324a47e64bb55b9407c)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9592 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9592/ ) Revert " YARN-4311 . Removing nodes from include and exclude lists will (jlowe: rev 2a5da97f81d69b481e4d1324a47e64bb55b9407c) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
          Hide
          kshukla Kuhu Shukla added a comment -

          Updated patch for addressing rebooted, lost NMs which adds logic to the Node Removal Timer logic. Also added tests for the two and additional test to see if Unhealthy nodes also follow the removal protocol.

          Show
          kshukla Kuhu Shukla added a comment - Updated patch for addressing rebooted, lost NMs which adds logic to the Node Removal Timer logic. Also added tests for the two and additional test to see if Unhealthy nodes also follow the removal protocol.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 48s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 6m 1s trunk passed with JDK v1.8.0_77
          +1 compile 6m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 1m 58s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 3m 55s trunk passed
          +1 javadoc 1m 45s trunk passed with JDK v1.8.0_77
          +1 javadoc 4m 14s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 38s the patch passed
          +1 compile 5m 46s the patch passed with JDK v1.8.0_77
          +1 javac 5m 46s the patch passed
          +1 compile 6m 48s the patch passed with JDK v1.7.0_95
          +1 javac 6m 48s the patch passed
          -1 checkstyle 1m 10s root: patch generated 12 new + 383 unchanged - 0 fixed = 395 total (was 383)
          +1 mvnsite 2m 1s the patch passed
          +1 mvneclipse 0m 57s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 1m 43s the patch passed with JDK v1.8.0_77
          +1 javadoc 4m 15s the patch passed with JDK v1.7.0_95
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 81m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 81m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          236m 31s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Switch statement found in org.apache.hadoop.yarn.server.resourcemanager.NodesListManager.decrInactiveNMMetrics(RMNode) where default case is missing At NodesListManager.java:where default case is missing At NodesListManager.java:[lines 154-165]
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799244/YARN-4311-v15.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 707f270aeedf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8b729e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11116/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11116/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 6m 1s trunk passed with JDK v1.8.0_77 +1 compile 6m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 13s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 3m 55s trunk passed +1 javadoc 1m 45s trunk passed with JDK v1.8.0_77 +1 javadoc 4m 14s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 5m 46s the patch passed with JDK v1.8.0_77 +1 javac 5m 46s the patch passed +1 compile 6m 48s the patch passed with JDK v1.7.0_95 +1 javac 6m 48s the patch passed -1 checkstyle 1m 10s root: patch generated 12 new + 383 unchanged - 0 fixed = 395 total (was 383) +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 57s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 43s the patch passed with JDK v1.8.0_77 +1 javadoc 4m 15s the patch passed with JDK v1.7.0_95 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 81m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 81m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 236m 31s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Switch statement found in org.apache.hadoop.yarn.server.resourcemanager.NodesListManager.decrInactiveNMMetrics(RMNode) where default case is missing At NodesListManager.java:where default case is missing At NodesListManager.java: [lines 154-165] JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799244/YARN-4311-v15.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 707f270aeedf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8b729e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11116/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11116/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11116/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Fixing checkstyle and findbugs issues. Test failures are locally passing and unrelated.

          Show
          kshukla Kuhu Shukla added a comment - Fixing checkstyle and findbugs issues. Test failures are locally passing and unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 7m 27s trunk passed
          +1 compile 7m 52s trunk passed with JDK v1.8.0_77
          +1 compile 7m 50s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 1m 57s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          +1 findbugs 3m 53s trunk passed
          +1 javadoc 1m 36s trunk passed with JDK v1.8.0_77
          +1 javadoc 4m 12s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 37s the patch passed
          +1 compile 5m 38s the patch passed with JDK v1.8.0_77
          +1 javac 5m 38s the patch passed
          +1 compile 6m 32s the patch passed with JDK v1.7.0_95
          +1 javac 6m 32s the patch passed
          +1 checkstyle 1m 8s the patch passed
          +1 mvnsite 1m 52s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 41s the patch passed
          +1 javadoc 1m 40s the patch passed with JDK v1.8.0_77
          +1 javadoc 4m 11s the patch passed with JDK v1.7.0_95
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_77.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_77.
          -1 unit 76m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77.
          +1 unit 0m 50s hadoop-sls in the patch passed with JDK v1.8.0_77.
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 76m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          227m 6s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799980/YARN-4311-v16.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux ed2d54e912ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7da5847
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11160/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11160/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 27s trunk passed +1 compile 7m 52s trunk passed with JDK v1.8.0_77 +1 compile 7m 50s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 10s trunk passed +1 mvnsite 1m 57s trunk passed +1 mvneclipse 0m 55s trunk passed +1 findbugs 3m 53s trunk passed +1 javadoc 1m 36s trunk passed with JDK v1.8.0_77 +1 javadoc 4m 12s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 5m 38s the patch passed with JDK v1.8.0_77 +1 javac 5m 38s the patch passed +1 compile 6m 32s the patch passed with JDK v1.7.0_95 +1 javac 6m 32s the patch passed +1 checkstyle 1m 8s the patch passed +1 mvnsite 1m 52s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 41s the patch passed +1 javadoc 1m 40s the patch passed with JDK v1.8.0_77 +1 javadoc 4m 11s the patch passed with JDK v1.7.0_95 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_77. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_77. -1 unit 76m 7s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_77. +1 unit 0m 50s hadoop-sls in the patch passed with JDK v1.8.0_77. +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 76m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 227m 6s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799980/YARN-4311-v16.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ed2d54e912ee 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7da5847 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-YARN-Build/11160/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11160/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11160/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Sorry for the delay in getting back to this.

          I think the changes to ResourceTrackerService are unnecessary. This patch should not be changing the semantics of which nodes are allowed to participate in the cluster. In practice I don't think those changes actually modify the behavior, since it is impossible for a node to be valid yet untracked at the same time.

          I also think the logic in RMNodeImpl.deactivateNode could be simpler. If we're putting a node in the inactive node list and the node is untracked then we want to set the timestamp. At that point we don't care what the state of the node is, so I think the SHUTDOWN state check is unnecessary. If somehow the state was LOST, REBOOTED, DECOMMISSIONED, etc. we'd still want to start the clock ticking on removing the untracked node once we add it to the inactive node list.

          Show
          jlowe Jason Lowe added a comment - Sorry for the delay in getting back to this. I think the changes to ResourceTrackerService are unnecessary. This patch should not be changing the semantics of which nodes are allowed to participate in the cluster. In practice I don't think those changes actually modify the behavior, since it is impossible for a node to be valid yet untracked at the same time. I also think the logic in RMNodeImpl.deactivateNode could be simpler. If we're putting a node in the inactive node list and the node is untracked then we want to set the timestamp. At that point we don't care what the state of the node is, so I think the SHUTDOWN state check is unnecessary. If somehow the state was LOST, REBOOTED, DECOMMISSIONED, etc. we'd still want to start the clock ticking on removing the untracked node once we add it to the inactive node list.
          Hide
          kshukla Kuhu Shukla added a comment -

          Thanks Jason! Rebased patch and added changes per review comments.

          Show
          kshukla Kuhu Shukla added a comment - Thanks Jason! Rebased patch and added changes per review comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 6m 19s trunk passed with JDK v1.8.0_91
          +1 compile 7m 5s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 16s trunk passed
          +1 mvnsite 1m 55s trunk passed
          +1 mvneclipse 0m 55s trunk passed
          -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 36s trunk passed with JDK v1.8.0_91
          +1 javadoc 4m 13s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 33s the patch passed
          +1 compile 6m 19s the patch passed with JDK v1.8.0_91
          +1 javac 6m 19s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_95
          +1 javac 6m 49s the patch passed
          -1 checkstyle 1m 11s root: patch generated 2 new + 373 unchanged - 0 fixed = 375 total (was 373)
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 51s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 4m 45s the patch passed
          +1 javadoc 1m 42s the patch passed with JDK v1.8.0_91
          +1 javadoc 4m 10s the patch passed with JDK v1.7.0_95
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_91.
          +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          -1 unit 44m 1s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 44m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          162m 2s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801825/YARN-4311-v17.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux cf8237022d62 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11310/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11310/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 6m 19s trunk passed with JDK v1.8.0_91 +1 compile 7m 5s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 16s trunk passed +1 mvnsite 1m 55s trunk passed +1 mvneclipse 0m 55s trunk passed -1 findbugs 1m 5s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 36s trunk passed with JDK v1.8.0_91 +1 javadoc 4m 13s trunk passed with JDK v1.7.0_95 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 6m 19s the patch passed with JDK v1.8.0_91 +1 javac 6m 19s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed -1 checkstyle 1m 11s root: patch generated 2 new + 373 unchanged - 0 fixed = 375 total (was 373) +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 51s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 45s the patch passed +1 javadoc 1m 42s the patch passed with JDK v1.8.0_91 +1 javadoc 4m 10s the patch passed with JDK v1.7.0_95 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_91. +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. -1 unit 44m 1s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91. +1 unit 0m 52s hadoop-sls in the patch passed with JDK v1.8.0_91. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 44m 58s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 162m 2s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801825/YARN-4311-v17.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux cf8237022d62 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11310/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11310/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11310/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Correcting minute checkstyle nit in RMNode.java (removing public modifier).
          TestContainerResourceUsage#testUsageAfterAMRestartWithMultipleContainers failure is tracked through YARN-5024, although testUsageAfterAMRestartKeepContainers also seems to be related. They fail irrespective of the patch.

          TestRMWebServicesNodes fails per YARN-4947 and is unrelated to this patch. Other failures are long standing known test failures.

          Findbugs warning is from EventDispatcher.java which is unrelated to this change AFAIK.

          Bug type DM_EXIT (click for details) 
          In class org.apache.hadoop.yarn.event.EventDispatcher$EventProcessor
          In method org.apache.hadoop.yarn.event.EventDispatcher$EventProcessor.run()
          At EventDispatcher.java:[line 80]
          
          Show
          kshukla Kuhu Shukla added a comment - Correcting minute checkstyle nit in RMNode.java (removing public modifier). TestContainerResourceUsage#testUsageAfterAMRestartWithMultipleContainers failure is tracked through YARN-5024 , although testUsageAfterAMRestartKeepContainers also seems to be related. They fail irrespective of the patch. TestRMWebServicesNodes fails per YARN-4947 and is unrelated to this patch. Other failures are long standing known test failures. Findbugs warning is from EventDispatcher.java which is unrelated to this change AFAIK. Bug type DM_EXIT (click for details) In class org.apache.hadoop.yarn.event.EventDispatcher$EventProcessor In method org.apache.hadoop.yarn.event.EventDispatcher$EventProcessor.run() At EventDispatcher.java:[line 80]
          Hide
          kshukla Kuhu Shukla added a comment -

          Opened YARN-5032 for tracking TestContainerResourceUsage#testUsageAfterAMRestartKeepContainers failure.

          Show
          kshukla Kuhu Shukla added a comment - Opened YARN-5032 for tracking TestContainerResourceUsage#testUsageAfterAMRestartKeepContainers failure.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 2m 6s Maven dependency ordering for branch
          +1 mvninstall 6m 50s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_91
          +1 compile 6m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 1m 54s trunk passed
          +1 mvneclipse 0m 52s trunk passed
          -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 38s trunk passed with JDK v1.8.0_91
          +1 javadoc 4m 10s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 36s the patch passed
          +1 compile 5m 52s the patch passed with JDK v1.8.0_91
          +1 javac 5m 52s the patch passed
          +1 compile 6m 42s the patch passed with JDK v1.7.0_95
          +1 javac 6m 42s the patch passed
          +1 checkstyle 1m 9s the patch passed
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 54s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 52s the patch passed with JDK v1.8.0_91
          +1 javadoc 4m 9s the patch passed with JDK v1.7.0_95
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          -1 unit 44m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 44m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          162m 13s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801885/YARN-4311-v18.patch
          JIRA Issue YARN-4311
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux f5da0b2ca975 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 45a753c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11314/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11314/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 2m 6s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_91 +1 compile 6m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 9s trunk passed +1 mvnsite 1m 54s trunk passed +1 mvneclipse 0m 52s trunk passed -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 38s trunk passed with JDK v1.8.0_91 +1 javadoc 4m 10s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 36s the patch passed +1 compile 5m 52s the patch passed with JDK v1.8.0_91 +1 javac 5m 52s the patch passed +1 compile 6m 42s the patch passed with JDK v1.7.0_95 +1 javac 6m 42s the patch passed +1 checkstyle 1m 9s the patch passed +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 52s the patch passed with JDK v1.8.0_91 +1 javadoc 4m 9s the patch passed with JDK v1.7.0_95 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_91. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. -1 unit 44m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_91. +1 unit 0m 51s hadoop-sls in the patch passed with JDK v1.8.0_91. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_95. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 44m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_95. +1 unit 0m 53s hadoop-sls in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 162m 13s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801885/YARN-4311-v18.patch JIRA Issue YARN-4311 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f5da0b2ca975 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 45a753c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11314/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-tools/hadoop-sls U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11314/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kshukla Kuhu Shukla added a comment -

          Requesting Jason Lowe for review/comments. Thanks a lot!

          Show
          kshukla Kuhu Shukla added a comment - Requesting Jason Lowe for review/comments. Thanks a lot!
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9722 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9722/)
          YARN-4311. Removing nodes from include and exclude lists will not remove (jlowe: rev d0da13229cf692579c8c9db47a93f6c6255392c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9722 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9722/ ) YARN-4311 . Removing nodes from include and exclude lists will not remove (jlowe: rev d0da13229cf692579c8c9db47a93f6c6255392c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMServerUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NodesListManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Kuhu! I committed this to trunk, branch-2, and branch-2.8.

          Show
          jlowe Jason Lowe added a comment - Thanks, Kuhu! I committed this to trunk, branch-2, and branch-2.8.

            People

            • Assignee:
              kshukla Kuhu Shukla
              Reporter:
              kshukla Kuhu Shukla
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development