Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4298

Fix findbugs warnings in hadoop-yarn-common

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      <file classname='org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl'>
      <BugInstance type='IS2_INCONSISTENT_SYNC' priority='Normal' category='MT_CORRECTNESS' message='Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.builder; locked 95% of time' lineNumber='390'/>
      <BugInstance type='IS2_INCONSISTENT_SYNC' priority='Normal' category='MT_CORRECTNESS' message='Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.proto; locked 94% of time' lineNumber='390'/>
      <BugInstance type='IS2_INCONSISTENT_SYNC' priority='Normal' category='MT_CORRECTNESS' message='Inconsistent synchronization of org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl.viaProto; locked 94% of time' lineNumber='390'/>
      </file>
      
      1. 0002-YARN-4298.patch
        2 kB
        Sunil G
      2. 0001-YARN-4298.patch
        1 kB
        Sunil G

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #637 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/637/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #637 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/637/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2574 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2574/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2574 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2574/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1445 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1445/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1445 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1445/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #723 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/723/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #723 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/723/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #712 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/712/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #712 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/712/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2654/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2654/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8873 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8873/)
          YARN-4298. Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8873 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8873/ ) YARN-4298 . Fix findbugs warnings in hadoop-yarn-common. Contributed by (aajisaka: rev 8c0133f3d4c85733c1e0389d1ee39f1eab58c0b9) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/AllocateResponsePBImpl.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          hadoop.yarn.webapp.TestWebApp

          The test is broken by HADOOP-12584. Now the patch is reverted, so the test doesn't fail.

          Show
          ajisakaa Akira Ajisaka added a comment - hadoop.yarn.webapp.TestWebApp The test is broken by HADOOP-12584 . Now the patch is reverted, so the test doesn't fail.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed v1 patch to trunk and branch-2. Thanks Varun Saxena for reporting this issue and thanks Sunil G for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed v1 patch to trunk and branch-2. Thanks Varun Saxena for reporting this issue and thanks Sunil G for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Sunil G for creating and testing the patch. Filed YETUS-207.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Sunil G for creating and testing the patch. Filed YETUS-207 .
          Hide
          sunilg Sunil G added a comment -

          Thanks Akira. Yes, manual runs are passing fine.

          Show
          sunilg Sunil G added a comment - Thanks Akira. Yes, manual runs are passing fine.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 for v1 patch. I manually tested the patch by the following commands.

          $ mvn install -DskipTests
          $ cd hadoop-yarn-project/hadoop-yarn
          $ mvn findbugs:findbugs
          

          There are no warnings in hadoop-yarn-project module after applying the patch. Jenkins reports findbugs warnings before applying the patch. I'll file a jira for this issue.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 for v1 patch. I manually tested the patch by the following commands. $ mvn install -DskipTests $ cd hadoop-yarn-project/hadoop-yarn $ mvn findbugs:findbugs There are no warnings in hadoop-yarn-project module after applying the patch. Jenkins reports findbugs warnings before applying the patch. I'll file a jira for this issue.
          Hide
          sunilg Sunil G added a comment -

          Thanks Varun Saxena !!

          Even after that fix, same warnings are shown. I will have a re-look in this now by locally verifying it.

          Show
          sunilg Sunil G added a comment - Thanks Varun Saxena !! Even after that fix, same warnings are shown. I will have a re-look in this now by locally verifying it.
          Hide
          varun_saxena Varun Saxena added a comment -

          please let me know if this is handled by you in any other tickets.

          Thanks for taking this up Sunil G. No, I havent handled it anywhere else.

          Show
          varun_saxena Varun Saxena added a comment - please let me know if this is handled by you in any other tickets. Thanks for taking this up Sunil G . No, I havent handled it anywhere else.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 31s trunk passed
          +1 compile 0m 28s trunk passed with JDK v1.8.0_66
          +1 compile 0m 31s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 37s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_66
          +1 javac 0m 28s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.7.0_85
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 35s the patch passed
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 37s the patch passed with JDK v1.7.0_85
          -1 unit 2m 8s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          -1 unit 2m 19s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          24m 31s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773713/0002-YARN-4298.patch
          JIRA Issue YARN-4298
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6caabb2a8af0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / da10163
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9757/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9757/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 31s trunk passed +1 compile 0m 28s trunk passed with JDK v1.8.0_66 +1 compile 0m 31s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 37s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_66 +1 javac 0m 28s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_85 +1 javac 0m 30s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 37s the patch passed with JDK v1.7.0_85 -1 unit 2m 8s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. -1 unit 2m 19s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 24m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773713/0002-YARN-4298.patch JIRA Issue YARN-4298 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6caabb2a8af0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / da10163 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9757/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9757/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9757/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          In AllocateResponseImpl, convertTo/FromProtoFormat also is synchronized, couple of methods missed that. Adding it.

          Show
          sunilg Sunil G added a comment - In AllocateResponseImpl, convertTo/FromProtoFormat also is synchronized, couple of methods missed that. Adding it.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 27s trunk passed
          +1 compile 0m 28s trunk passed with JDK v1.8.0_66
          +1 compile 0m 30s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 35s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 37s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_66
          +1 javac 0m 28s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.7.0_85
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 37s the patch passed
          +1 javadoc 0m 33s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 37s the patch passed with JDK v1.7.0_85
          -1 unit 2m 8s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          -1 unit 2m 20s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          24m 37s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773712/0001-YARN-4298.patch
          JIRA Issue YARN-4298
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fe97d000a578 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / da10163
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9756/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9756/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 27s trunk passed +1 compile 0m 28s trunk passed with JDK v1.8.0_66 +1 compile 0m 30s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 14s trunk passed -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 0m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 37s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 33s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_66 +1 javac 0m 28s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_85 +1 javac 0m 31s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 37s the patch passed with JDK v1.7.0_85 -1 unit 2m 8s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. -1 unit 2m 20s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 24m 37s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.webapp.TestWebApp JDK v1.7.0_85 Failed junit tests hadoop.yarn.webapp.TestWebApp Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773712/0001-YARN-4298.patch JIRA Issue YARN-4298 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fe97d000a578 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / da10163 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9756/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9756/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9756/console This message was automatically generated.
          Hide
          sunilg Sunil G added a comment -

          And thanks Varun Saxena for reporting this. I gave a patch here, please let me know if this is handled by you in any other tickets.

          Show
          sunilg Sunil G added a comment - And thanks Varun Saxena for reporting this. I gave a patch here, please let me know if this is handled by you in any other tickets.
          Hide
          sunilg Sunil G added a comment -

          This issue came after YARN-4170, somehow missed this as jenkins showed no warnings inside findbugs warnings report.

          Attaching a patch to correct this. Sorry for the inconvenience. Rohith Sharma K S could you please check this.

          Show
          sunilg Sunil G added a comment - This issue came after YARN-4170 , somehow missed this as jenkins showed no warnings inside findbugs warnings report. Attaching a patch to correct this. Sorry for the inconvenience. Rohith Sharma K S could you please check this.

            People

            • Assignee:
              sunilg Sunil G
              Reporter:
              varun_saxena Varun Saxena
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development