Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4279

Mark ApplicationId and ApplicationAttemptId static methods as @Public, @Unstable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: client
    • Labels:
      None

      Description

      The classes ApplicationId and ApplicationAttemptId both have newInstance() methods tagged as @Private. Yet they are useful in testing, as the alternative is to create and configure the PBImpl classes -which are significantly more private.

      The fact that mapreduce's MRBuilderUtils uses one of the methods shows that YARN apps do need access to the methods.

      Marking them as public would make it clear that other YARN apps were using them for their production or test code, rather than today, where they are used and depended on, yet without the YARN team's knowledge.

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        patch 001, changes markers on newInstance methods. no tests -untestable

        Show
        stevel@apache.org Steve Loughran added a comment - patch 001, changes markers on newInstance methods. no tests -untestable
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 29s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 2s There were no new javac warning messages.
        +1 javadoc 10m 31s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 7s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.
            41m 47s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767594/YARN-4279-001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 9cb5d35
        hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9491/artifact/patchprocess/testrun_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9491/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9491/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 2s There were no new javac warning messages. +1 javadoc 10m 31s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 38s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-api.     41m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767594/YARN-4279-001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9cb5d35 hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9491/artifact/patchprocess/testrun_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9491/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9491/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        No tests needed. Any reviewers?

        Show
        stevel@apache.org Steve Loughran added a comment - No tests needed. Any reviewers?
        Hide
        aw Allen Wittenauer added a comment -

        makes sense. lgtm. +1

        Show
        aw Allen Wittenauer added a comment - makes sense. lgtm. +1
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8822 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8822/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8822 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8822/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1419 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1419/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1419 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1419/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #681 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/681/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #681 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/681/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2622 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2622/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2622 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2622/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #693 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/693/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #693 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/693/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #617 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/617/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #617 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/617/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2555 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2555/)
        YARN-4279. Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2555 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2555/ ) YARN-4279 . Mark ApplicationId and ApplicationAttemptId static methods as (stevel: rev 253e0404f37ee7d889b52cc910e51e5fbde8ac8a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationAttemptId.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationId.java

          People

          • Assignee:
            stevel@apache.org Steve Loughran
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development