Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.6.0
Description
Typo in description section of yarn-default.xml, under the properties:
yarn.nodemanager.disk-health-checker.min-healthy-disks
yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage
yarn.nodemanager.disk-health-checker.min-free-space-per-disk-mb
yarn.nodemanager.disk-health-checker.disk-utilization-watermark-low-per-disk-percentage
The reference to yarn-nodemanager.local-dirs should be yarn.nodemanager.local-dirs
Attachments
Attachments
- YARN-4241.branch-2.7.patch
- 2 kB
- Akira Ajisaka
- YARN-4241.003.patch
- 2 kB
- Anthony Rojas
- YARN-4241.002.patch
- 2 kB
- Anthony Rojas
- YARN-4241.patch.1
- 2 kB
- Anthony Rojas
- YARN-4241.patch
- 2 kB
- Anthony Rojas
Issue Links
- is duplicated by
-
YARN-4286 yarn-default.xml has a typo: yarn-nodemanager.local-dirs should be yarn.nodemanager.local-dirs
- Resolved
Activity
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | pre-patch | 17m 34s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | javac | 8m 50s | There were no new javac warning messages. |
+1 | javadoc | 11m 21s | There were no new javadoc warning messages. |
-1 | release audit | 0m 20s | The applied patch generated 1 release audit warnings. |
-1 | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. |
+1 | install | 1m 43s | mvn install still works. |
+1 | eclipse:eclipse | 0m 41s | The patch built with eclipse:eclipse. |
-1 | yarn tests | 2m 11s | Tests failed in hadoop-yarn-common. |
42m 45s |
Reason | Tests |
---|---|
Failed unit tests | hadoop.yarn.logaggregation.TestAggregatedLogsBlock |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12765653/YARN-4241.patch |
Optional Tests | javadoc javac unit |
git revision | trunk / 0841940 |
Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9382/artifact/patchprocess/patchReleaseAuditProblems.txt |
whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/9382/artifact/patchprocess/whitespace.txt |
hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/9382/artifact/patchprocess/testrun_hadoop-yarn-common.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9382/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9382/console |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | patch | 0m 0s | The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. |
0 | pre-patch | 15m 41s | Pre-patch trunk compilation is healthy. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | javac | 8m 13s | There were no new javac warning messages. |
+1 | javadoc | 10m 37s | There were no new javadoc warning messages. |
-1 | release audit | 0m 19s | The applied patch generated 1 release audit warnings. |
+1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
+1 | install | 1m 30s | mvn install still works. |
+1 | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. |
+1 | yarn tests | 2m 1s | Tests passed in hadoop-yarn-common. |
38m 57s |
Subsystem | Report/Notes |
---|---|
Patch URL | http://issues.apache.org/jira/secure/attachment/12765674/YARN-4241.patch.1 |
Optional Tests | javadoc javac unit |
git revision | trunk / 0841940 |
Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9384/artifact/patchprocess/patchReleaseAuditProblems.txt |
hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/9384/artifact/patchprocess/testrun_hadoop-yarn-common.txt |
Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9384/testReport/ |
Java | 1.7.0_55 |
uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9384/console |
This message was automatically generated.
anthony@cloudera.com thank you for taking this issue. Could you update an additional entry of yarn.nodemanager.disk-health-checker.disk-utilization-watermark-low-per-disk-percentage?
<description>The low threshold percentage of disk space used when a bad disk is marked as good. Values can range from 0.0 to 100.0. This applies to yarn-nodemanager.local-dirs and yarn.nodemanager.log-dirs.
Linking to YARN-3943 to add the "yarn.nodemanager.disk-health-checker.disk-utilization-watermark-low-per-disk-percentage" property in yarn-default.xml
anthony@cloudera.com the patch cannot be applied straightforwardly. Could you rebase it on trunk code?
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 6s | docker + precommit patch detected. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
+1 | mvninstall | 3m 20s | trunk passed |
+1 | mvneclipse | 0m 13s | trunk passed |
+1 | javadoc | 0m 29s | trunk passed with JDK v1.8.0_60 |
+1 | javadoc | 0m 30s | trunk passed with JDK v1.7.0_79 |
+1 | mvninstall | 0m 26s | the patch passed |
+1 | mvneclipse | 0m 11s | the patch passed |
+1 | whitespace | 0m 0s | Patch has no whitespace issues. |
+1 | xml | 0m 1s | The patch has no ill-formed XML file. |
+1 | javadoc | 0m 27s | the patch passed with JDK v1.8.0_60 |
+1 | javadoc | 0m 31s | the patch passed with JDK v1.7.0_79 |
+1 | unit | 1m 50s | hadoop-yarn-common in the patch passed with JDK v1.8.0_60. |
+1 | unit | 2m 0s | hadoop-yarn-common in the patch passed with JDK v1.7.0_79. |
+1 | asflicense | 0m 23s | Patch does not generate ASF License warnings. |
11m 14s |
Subsystem | Report/Notes |
---|---|
Docker | Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-11 |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12771618/YARN-4241.003.patch |
JIRA Issue | |
Optional Tests | asflicense javac javadoc mvninstall unit xml |
uname | Linux fc5abe8a282f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh |
git revision | trunk / 6e4562b |
Default Java | 1.7.0_79 |
Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 |
JDK v1.7.0_79 Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9654/testReport/ |
modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common |
Max memory used | 227MB |
Powered by | Apache Yetus http://yetus.apache.org |
Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9654/console |
This message was automatically generated.
Jenkins build looks to be done incorrectly by some reason: https://builds.apache.org/job/PreCommit-YARN-Build/9652/
Kicked another Jenkins build: https://builds.apache.org/job/PreCommit-YARN-Build/9654/
I'd like to raise the priority to major because the configuration does not work if users copy-and-paste the wrong parameter. Checking this in.
Committed this to trunk, branch-2, branch-2.7, and branch-2.6. Thanks anthony@cloudera.com for the contribution and thanks ozawa for reviewing the patches.
FAILURE: Integrated in Hadoop-trunk-Commit #8790 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8790/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
Attaching the patch used for branch-2.7 and branch-2.6.
yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage was introduced by YARN-4176 and the property does not exist in branch-2.7 or branch-2.6, so I rebased the patch.
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #595 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/595/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk #1391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1391/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2595 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2595/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #667 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/667/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #655 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/655/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
FAILURE: Integrated in Hadoop-Hdfs-trunk #2534 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2534/)
YARN-4241. Fix typo of property name in yarn-default.xml. Contributed by (aajisaka: rev 23d0db551cc63def9acbab2473e58fb1c52f85e0)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
- hadoop-yarn-project/CHANGES.txt
Thanks Anthony for your contribution and thanks Akira for your committing.
Pulled this into 2.7.2 to keep the release up-to-date with 2.6.3. Changing fix-versions to reflect the same.
Attaching patch for review.