Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently ApplicationClientProtocol#updateApplicationPriority() API returns empty UpdateApplicationPriorityResponse response.
      But RM update priority to the cluster.max-priority if the given priority is greater than cluster.max-priority. In this scenarios, need to intimate back to client that updated priority rather just keeping quite where client assumes that given priority itself is taken.

      During application submission also has same scenario can happen, but I feel when
      explicitly invoke via ApplicationClientProtocol#updateApplicationPriority(), response should have updated priority in response.

      1. 0004-YARN-4164.patch
        17 kB
        Rohith Sharma K S
      2. 0003-YARN-4164.patch
        17 kB
        Rohith Sharma K S
      3. 0002-YARN-4164.patch
        16 kB
        Rohith Sharma K S
      4. 0001-YARN-4164.patch
        16 kB
        Rohith Sharma K S

        Activity

        Hide
        rohithsharma Rohith Sharma K S added a comment -

        The API public void updateApplicationPriority(Priority newPriority, ApplicationId applicationId) throws YarnException; should return Priority instead of void return type.

        Show
        rohithsharma Rohith Sharma K S added a comment - The API public void updateApplicationPriority(Priority newPriority, ApplicationId applicationId) throws YarnException; should return Priority instead of void return type.
        Hide
        sunilg Sunil G added a comment -

        Hi Rohith Sharma K S
        Thanks for raising this. To an extent I also feel that this is fine.
        From client side, if we want to verify the change immediately after calling updateApplicationPriority, we can avoid an RPC call. (as scheduler is capable of doing max-cap with max-cluster-priority, its good to respond back with what we changed). This is a clear advantage.

        However reporting back the changed value is not much conventional from what I see n hadoop apis much. But if it adds value, I think its ok. Looping Jian He.

        Show
        sunilg Sunil G added a comment - Hi Rohith Sharma K S Thanks for raising this. To an extent I also feel that this is fine. From client side, if we want to verify the change immediately after calling updateApplicationPriority , we can avoid an RPC call. (as scheduler is capable of doing max-cap with max-cluster-priority, its good to respond back with what we changed). This is a clear advantage. However reporting back the changed value is not much conventional from what I see n hadoop apis much. But if it adds value, I think its ok. Looping Jian He .
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating initial version of patch.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updating initial version of patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 21m 10s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 javadoc 10m 19s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 34s The applied patch generated 1 new checkstyle issues (total was 2, now 3).
        -1 whitespace 0m 2s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 6m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 104m 23s Tests failed in hadoop-mapreduce-client-jobclient.
        +1 yarn tests 0m 30s Tests passed in hadoop-yarn-api.
        +1 yarn tests 7m 7s Tests passed in hadoop-yarn-client.
        +1 yarn tests 2m 7s Tests passed in hadoop-yarn-common.
        -1 yarn tests 61m 55s Tests failed in hadoop-yarn-server-resourcemanager.
            227m 29s  



        Reason Tests
        Failed unit tests hadoop.mapred.TestNetworkedJob
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingUpdate
        Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerFairShare



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767339/0001-YARN-4164.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7f0e1eb
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
        hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-api.txt
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9476/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9476/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 21m 10s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 19s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 34s The applied patch generated 1 new checkstyle issues (total was 2, now 3). -1 whitespace 0m 2s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 6m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 104m 23s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 30s Tests passed in hadoop-yarn-api. +1 yarn tests 7m 7s Tests passed in hadoop-yarn-client. +1 yarn tests 2m 7s Tests passed in hadoop-yarn-common. -1 yarn tests 61m 55s Tests failed in hadoop-yarn-server-resourcemanager.     227m 29s   Reason Tests Failed unit tests hadoop.mapred.TestNetworkedJob   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerQueueACLs   hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingUpdate Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerFairShare Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767339/0001-YARN-4164.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7f0e1eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9476/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9476/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9476/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Hi Rohith Sharma K S
        Thanks for updating patch.

        I have one suggestion here, UpdateApplicationPriorityResponse can now report back the updated priority. But user wont understand what exactly is this, as the name suggests only priority. So it can be more like succefullyUpdatedPriority, rather than keeping a success flag.
        Also when we skip priority update like in cases mentioned in YARN-4141, we can set this return value as "null" or ""n/a", to indicate operation has not done. Thoughts?

        Show
        sunilg Sunil G added a comment - Hi Rohith Sharma K S Thanks for updating patch. I have one suggestion here, UpdateApplicationPriorityResponse can now report back the updated priority. But user wont understand what exactly is this, as the name suggests only priority. So it can be more like succefullyUpdatedPriority , rather than keeping a success flag. Also when we skip priority update like in cases mentioned in YARN-4141 , we can set this return value as "null" or ""n/a", to indicate operation has not done. Thoughts?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        rather than keeping a success flag.

        Right, the patches returns priority only.

        we can set this return value as "null"

        currently "null" is sent back to client if application is already in completing states.

        Show
        rohithsharma Rohith Sharma K S added a comment - rather than keeping a success flag. Right, the patches returns priority only. we can set this return value as "null" currently "null" is sent back to client if application is already in completing states.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch, kindly review

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch, kindly review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 30m 20s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 11m 9s There were no new javac warning messages.
        +1 javadoc 14m 10s There were no new javadoc warning messages.
        +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 3m 34s The applied patch generated 1 new checkstyle issues (total was 2, now 3).
        -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 2m 1s mvn install still works.
        +1 eclipse:eclipse 0m 48s The patch built with eclipse:eclipse.
        +1 findbugs 8m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 mapreduce tests 147m 4s Tests failed in hadoop-mapreduce-client-jobclient.
        +1 yarn tests 0m 39s Tests passed in hadoop-yarn-api.
        -1 yarn tests 7m 36s Tests failed in hadoop-yarn-client.
        +1 yarn tests 2m 37s Tests passed in hadoop-yarn-common.
        +1 yarn tests 66m 9s Tests passed in hadoop-yarn-server-resourcemanager.
            296m 31s  



        Reason Tests
        Failed unit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestMiniMRClientCluster
          hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestNonExistentJob
          hadoop.mapreduce.v2.TestUberAM
          hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          hadoop.yarn.client.api.impl.TestYarnClient
        Timed out tests org.apache.hadoop.mapreduce.TestLargeSort
          org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768938/0002-YARN-4164.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 96677be
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
        hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-api.txt
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-common.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9587/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9587/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 30m 20s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 11m 9s There were no new javac warning messages. +1 javadoc 14m 10s There were no new javadoc warning messages. +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 34s The applied patch generated 1 new checkstyle issues (total was 2, now 3). -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 2m 1s mvn install still works. +1 eclipse:eclipse 0m 48s The patch built with eclipse:eclipse. +1 findbugs 8m 58s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 147m 4s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 39s Tests passed in hadoop-yarn-api. -1 yarn tests 7m 36s Tests failed in hadoop-yarn-client. +1 yarn tests 2m 37s Tests passed in hadoop-yarn-common. +1 yarn tests 66m 9s Tests passed in hadoop-yarn-server-resourcemanager.     296m 31s   Reason Tests Failed unit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestMiniMRClientCluster   hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestNonExistentJob   hadoop.mapreduce.v2.TestUberAM   hadoop.mapreduce.v2.TestMRJobsWithHistoryService   hadoop.yarn.client.api.impl.TestYarnClient Timed out tests org.apache.hadoop.mapreduce.TestLargeSort   org.apache.hadoop.mapreduce.lib.output.TestJobOutputCommitter Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768938/0002-YARN-4164.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 96677be Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9587/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9587/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9587/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the patch Rohith Sharma K S,
        Yes as you mentioned, as per the patch priority will be returned as null if the app is in COMPLETED_APP_STATES, but IMHO i would not like to return null as it might lead to NPE in the client side if not properly handled, how about just returning the app's priority itself. If required to show proper logs then additional msg can be sent as part of response. The behavior what i have mentioned is also what It is currently in the REST side too. Thoughts?
        If you agree to my comment i think we can to do some correction in the REST side too as we are makiyng use of rm.getClientRMService() i.e. return the priority from the UpdateApplicationPriorityResponse.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Rohith Sharma K S , Yes as you mentioned, as per the patch priority will be returned as null if the app is in COMPLETED_APP_STATES, but IMHO i would not like to return null as it might lead to NPE in the client side if not properly handled, how about just returning the app's priority itself. If required to show proper logs then additional msg can be sent as part of response. The behavior what i have mentioned is also what It is currently in the REST side too. Thoughts? If you agree to my comment i think we can to do some correction in the REST side too as we are makiyng use of rm.getClientRMService() i.e. return the priority from the UpdateApplicationPriorityResponse.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Also can you take a look @ checkstyle and white space ? Findbugs seems to be unrelated to this patch

        Show
        Naganarasimha Naganarasimha G R added a comment - Also can you take a look @ checkstyle and white space ? Findbugs seems to be unrelated to this patch
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch fixing review comment that null will not be returned instead priority of an application will be returned.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch fixing review comment that null will not be returned instead priority of an application will be returned.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 30s trunk passed
        +1 compile 11m 6s trunk passed with JDK v1.8.0_66
        +1 compile 10m 33s trunk passed with JDK v1.7.0_85
        +1 checkstyle 1m 10s trunk passed
        +1 mvnsite 2m 56s trunk passed
        +1 mvneclipse 1m 18s trunk passed
        +1 findbugs 5m 43s trunk passed
        +1 javadoc 2m 25s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 45s trunk passed with JDK v1.7.0_85
        +1 mvninstall 2m 42s the patch passed
        +1 compile 10m 28s the patch passed with JDK v1.8.0_66
        +1 cc 10m 28s the patch passed
        -1 javac 20m 54s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751).
        +1 javac 10m 28s the patch passed
        +1 compile 10m 30s the patch passed with JDK v1.7.0_85
        +1 cc 10m 30s the patch passed
        -1 javac 31m 24s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745).
        +1 javac 10m 30s the patch passed
        -1 checkstyle 1m 11s Patch generated 4 new checkstyle issues in root (total was 122, now 126).
        +1 mvnsite 2m 55s the patch passed
        +1 mvneclipse 1m 18s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 6m 37s the patch passed
        +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 47s the patch passed with JDK v1.7.0_85
        +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
        -1 unit 70m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 49m 41s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 113m 53s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 39s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
        +1 unit 2m 42s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
        -1 unit 68m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
        -1 unit 49m 53s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
        +1 unit 112m 25s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85.
        -1 asflicense 0m 35s Patch generated 15 ASF License warnings.
        565m 50s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMService
          hadoop.yarn.client.TestGetGroups
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMService
          hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774995/0003-YARN-4164.patch
        JIRA Issue YARN-4164
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux ebb8759cfe73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1c05393
        findbugs v3.0.0
        javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
        javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9824/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9824/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 30s trunk passed +1 compile 11m 6s trunk passed with JDK v1.8.0_66 +1 compile 10m 33s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 10s trunk passed +1 mvnsite 2m 56s trunk passed +1 mvneclipse 1m 18s trunk passed +1 findbugs 5m 43s trunk passed +1 javadoc 2m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 45s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 42s the patch passed +1 compile 10m 28s the patch passed with JDK v1.8.0_66 +1 cc 10m 28s the patch passed -1 javac 20m 54s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751). +1 javac 10m 28s the patch passed +1 compile 10m 30s the patch passed with JDK v1.7.0_85 +1 cc 10m 30s the patch passed -1 javac 31m 24s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745). +1 javac 10m 30s the patch passed -1 checkstyle 1m 11s Patch generated 4 new checkstyle issues in root (total was 122, now 126). +1 mvnsite 2m 55s the patch passed +1 mvneclipse 1m 18s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 6m 37s the patch passed +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 47s the patch passed with JDK v1.7.0_85 +1 unit 0m 29s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 70m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 41s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 113m 53s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 39s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 42s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 68m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 49m 53s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 unit 112m 25s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 35s Patch generated 15 ASF License warnings. 565m 50s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMService   hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774995/0003-YARN-4164.patch JIRA Issue YARN-4164 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux ebb8759cfe73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c05393 findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9824/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9824/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9824/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S for updating the patch.

            Priority updateApplicationPriority =
                client.updateApplicationPriority(appId, newAppPriority);
            if (newAppPriority.equals(updateApplicationPriority)) {
              sysout.println("Successfully updated the application "
                  + applicationId + " with priority '" + priority + "'");
            } else {
              sysout.println("Updated the application  " + applicationId
                  + " to cluster max priority '" + updateApplicationPriority + "'");
            }
        

        There is another corner case here when App is in its FINAL states. In that case, scheduler will not update the priority and last set priority is now returned. So this CLI handling will fall into else case and will print that "Updated the application to cluster max priority" which looks incorrect.

        One possibility is that, we can look into cluster max priority here to print correct message. I am not very interested in banging RM again with a remote request to get cluster priority, so may be we can get cluster max priority also in response. Again this seems more information in response. OR simply we can print the message in else case as a general message which is common for both cases. Thoughts?

        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S for updating the patch. Priority updateApplicationPriority = client.updateApplicationPriority(appId, newAppPriority); if (newAppPriority.equals(updateApplicationPriority)) { sysout.println( "Successfully updated the application " + applicationId + " with priority '" + priority + "'" ); } else { sysout.println( "Updated the application " + applicationId + " to cluster max priority '" + updateApplicationPriority + "'" ); } There is another corner case here when App is in its FINAL states. In that case, scheduler will not update the priority and last set priority is now returned. So this CLI handling will fall into else case and will print that "Updated the application to cluster max priority" which looks incorrect. One possibility is that, we can look into cluster max priority here to print correct message. I am not very interested in banging RM again with a remote request to get cluster priority, so may be we can get cluster max priority also in response. Again this seems more information in response. OR simply we can print the message in else case as a general message which is common for both cases. Thoughts?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I think just log message update with clarity should be fine. I will update the patch with log message change.

        Show
        rohithsharma Rohith Sharma K S added a comment - I think just log message update with clarity should be fine. I will update the patch with log message change.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch changing sysout message.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch changing sysout message.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 24s trunk passed
        +1 compile 8m 5s trunk passed with JDK v1.8.0_66
        +1 compile 8m 53s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 0s trunk passed
        +1 mvnsite 2m 31s trunk passed
        +1 mvneclipse 1m 7s trunk passed
        +1 findbugs 4m 51s trunk passed
        +1 javadoc 1m 55s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 13s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 18s the patch passed
        +1 compile 7m 54s the patch passed with JDK v1.8.0_66
        -1 cc 16m 49s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 16, now 16).
        +1 cc 7m 54s the patch passed
        +1 javac 7m 54s the patch passed
        +1 compile 8m 46s the patch passed with JDK v1.7.0_91
        +1 cc 8m 46s the patch passed
        -1 javac 25m 36s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723).
        +1 javac 8m 46s the patch passed
        +1 checkstyle 0m 57s the patch passed
        +1 mvnsite 2m 30s the patch passed
        +1 mvneclipse 1m 7s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 5m 35s the patch passed
        +1 javadoc 1m 53s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 14s the patch passed with JDK v1.7.0_91
        +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
        +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
        -1 unit 59m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 49m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 104m 42s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
        +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
        -1 unit 59m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        -1 unit 49m 40s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
        -1 unit 101m 57s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 29s Patch generated 17 ASF License warnings.
        507m 13s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.client.TestGetGroups
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.client.TestGetGroups
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777691/0004-YARN-4164.patch
        JIRA Issue YARN-4164
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 0303b31045cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5b7078d
        findbugs v3.0.0
        cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt
        javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9976/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
        Max memory used 75MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9976/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 24s trunk passed +1 compile 8m 5s trunk passed with JDK v1.8.0_66 +1 compile 8m 53s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 0s trunk passed +1 mvnsite 2m 31s trunk passed +1 mvneclipse 1m 7s trunk passed +1 findbugs 4m 51s trunk passed +1 javadoc 1m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 13s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 18s the patch passed +1 compile 7m 54s the patch passed with JDK v1.8.0_66 -1 cc 16m 49s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 16, now 16). +1 cc 7m 54s the patch passed +1 javac 7m 54s the patch passed +1 compile 8m 46s the patch passed with JDK v1.7.0_91 +1 cc 8m 46s the patch passed -1 javac 25m 36s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). +1 javac 8m 46s the patch passed +1 checkstyle 0m 57s the patch passed +1 mvnsite 2m 30s the patch passed +1 mvneclipse 1m 7s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 35s the patch passed +1 javadoc 1m 53s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 14s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 59m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 104m 42s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 59m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 40s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 101m 57s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 29s Patch generated 17 ASF License warnings. 507m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777691/0004-YARN-4164.patch JIRA Issue YARN-4164 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 0303b31045cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5b7078d findbugs v3.0.0 cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9976/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9976/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S for updating the patch. Looks good. Jian He, could you pls help to take a look also.

        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S for updating the patch. Looks good. Jian He , could you pls help to take a look also.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Looking into the HadoopQA result,

        -1 cc 16m 49s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 16, now 16).

        Not caused by this patch

        -1 javac 25m 36s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723).

        Not caused by this patch

        And test failures are not related this patch.
        YARN side test case failure JIRA's are tracked by umbrella jira YARN-4478
        MapReduce test case failure are tracked by MAPREDUCE-6580 and MAPREDUCE-6579

        Show
        rohithsharma Rohith Sharma K S added a comment - Looking into the HadoopQA result, -1 cc 16m 49s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 16, now 16). Not caused by this patch -1 javac 25m 36s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). Not caused by this patch And test failures are not related this patch. YARN side test case failure JIRA's are tracked by umbrella jira YARN-4478 MapReduce test case failure are tracked by MAPREDUCE-6580 and MAPREDUCE-6579
        Hide
        jianhe Jian He added a comment -

        lgtm, +1

        Show
        jianhe Jian He added a comment - lgtm, +1
        Hide
        jianhe Jian He added a comment -

        Committed trunk, branch-2, branch-2.8 thanks Rohith Sharma K S !
        Thanks Sunil G, Naganarasimha G R for reviewing !

        Show
        jianhe Jian He added a comment - Committed trunk, branch-2, branch-2.8 thanks Rohith Sharma K S ! Thanks Sunil G , Naganarasimha G R for reviewing !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8999 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8999/)
        YARN-4164. Changed updateApplicationPriority API to return the updated (jianhe: rev 85c24660481f33684a42a7f6d665d3117577c780)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8999 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8999/ ) YARN-4164 . Changed updateApplicationPriority API to return the updated (jianhe: rev 85c24660481f33684a42a7f6d665d3117577c780) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Jian He for review and committing patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Jian He for review and committing patch
        Hide
        djp Junping Du added a comment -

        This patch goes to branch-2 only instead of branch-2.8, set 2.9 as fix version.

        Show
        djp Junping Du added a comment - This patch goes to branch-2 only instead of branch-2.8, set 2.9 as fix version.
        Hide
        jianhe Jian He added a comment -

        merged the patch to 2.8 too

        Show
        jianhe Jian He added a comment - merged the patch to 2.8 too

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            rohithsharma Rohith Sharma K S
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development