Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
-
Component/s: None
-
Labels:None
-
Target Version/s:
Description
all App Attempt Info logLinks begin with "//" instead of "http://" or "https://"
Issue Links
- is broken by
-
YARN-1553
Do not use HttpConfig.isSecure() in YARN
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
FAILURE: Integrated in Hadoop-Hdfs-trunk #2272 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2272/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2294 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2294/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #351 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/351/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/CHANGES.txt
FAILURE: Integrated in Hadoop-Yarn-trunk #1082 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1082/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #345 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/345/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
FAILURE: Integrated in Hadoop-trunk-Commit #8402 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8402/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
- hadoop-yarn-project/CHANGES.txt
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java
Committed to trunk, branch-2 and branch-2.7. Thanks Jonathan!
Sounds good. I'll commit it tomorrow morning IST.
You can do it if you like. Please ensure it makes it into trunk, branch-2, and branch-2.7.
+1 for the latest patch. Will you go ahead and commit it or would you like me to do it?
Looks like YARN-1553 introduced this error. You can see that it is present both in the RM web services and the RMAppBlock by looking at a specific app page source for the RM:port/cluster/app/app_id. The browser is very accommodating and takes you to the correct address which is why this has been hidden for a long time. If you are ok with this, I would like to check this in.
Thanks for the patch Jonathan Eagles. Can you clarify something - according to https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Application_Attempts_API - the logsLink has the scheme. Is the existing documentation wrong?
+1 for the latest patch.
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| -1 | pre-patch | 21m 7s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | tests included | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | javac | 7m 47s | There were no new javac warning messages. |
| +1 | javadoc | 10m 4s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 0m 49s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 25s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 29s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| +1 | yarn tests | 53m 55s | Tests passed in hadoop-yarn-server-resourcemanager. |
| 97m 33s |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753834/YARN-4103.3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c006c3a |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8985/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-resourcemanager.html |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8985/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8985/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8985/console |
This message was automatically generated.
Addressing unit test failures in patch 3
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| -1 | pre-patch | 16m 56s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | javac | 7m 52s | There were no new javac warning messages. |
| +1 | javadoc | 9m 55s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| +1 | checkstyle | 0m 50s | There were no new checkstyle issues. |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 31s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 28s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| -1 | yarn tests | 54m 19s | Tests failed in hadoop-yarn-server-resourcemanager. |
| 93m 50s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService |
| hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753780/YARN-4103.2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7d6687f |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8976/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-resourcemanager.html |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8976/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8976/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8976/console |
This message was automatically generated.
| -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| -1 | pre-patch | 17m 3s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | javac | 8m 5s | There were no new javac warning messages. |
| +1 | javadoc | 10m 6s | There were no new javadoc warning messages. |
| +1 | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. |
| -1 | checkstyle | 0m 49s | The applied patch generated 4 new checkstyle issues (total was 51, now 53). |
| +1 | whitespace | 0m 0s | The patch has no lines that end in whitespace. |
| +1 | install | 1m 30s | mvn install still works. |
| +1 | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. |
| +1 | findbugs | 1m 28s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| -1 | yarn tests | 52m 12s | Tests failed in hadoop-yarn-server-resourcemanager. |
| 92m 11s |
| Reason | Tests |
|---|---|
| Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation |
| hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps |
| Subsystem | Report/Notes |
|---|---|
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753606/YARN-4103.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4620767 |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8961/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-resourcemanager.html |
| checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8961/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8961/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8961/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8961/console |
This message was automatically generated.
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #334 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/334/)
YARN-4103. RM WebServices missing scheme for appattempts logLinks. Contributed by Jonathan Eagles. (vvasudev: rev 40d222e862063dc6c474cc6e8de0dce6c4395012)