Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None

      Description

      Lots of places in container-executor are now using PATH_MAX, which is simply too small on a lot of platforms. We should use a larger buffer size and be done with it.

      1. YARN-4017.001.patch
        8 kB
        Sidharta Seethana

        Activity

        Show
        aw Allen Wittenauer added a comment - - edited http://insanecoding.blogspot.com/2007/11/pathmax-simply-isnt.html and https://www.gnu.org/software/hurd/hurd/porting/guidelines.html has some good discussion.
        Hide
        vvasudev Varun Vasudev added a comment -

        What would you recommend as the buffer size? 16K?

        Show
        vvasudev Varun Vasudev added a comment - What would you recommend as the buffer size? 16K?
        Hide
        sidharta-s Sidharta Seethana added a comment -

        It seems to me that using a defined value of 4096 should suffice. I'll upload a patch shortly.

        Show
        sidharta-s Sidharta Seethana added a comment - It seems to me that using a defined value of 4096 should suffice. I'll upload a patch shortly.
        Hide
        sidharta-s Sidharta Seethana added a comment -

        uploading a patch with changes to container-executor to remove use to PATH_MAX .

        Show
        sidharta-s Sidharta Seethana added a comment - uploading a patch with changes to container-executor to remove use to PATH_MAX .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        -1 release audit 0m 17s The applied patch generated 1 release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 yarn tests 8m 41s Tests passed in hadoop-yarn-server-nodemanager.
            24m 37s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765750/YARN-4017.001.patch
        Optional Tests javac unit
        git revision trunk / 8f19538
        Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9389/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9389/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9389/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9389/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. -1 release audit 0m 17s The applied patch generated 1 release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 yarn tests 8m 41s Tests passed in hadoop-yarn-server-nodemanager.     24m 37s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765750/YARN-4017.001.patch Optional Tests javac unit git revision trunk / 8f19538 Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9389/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9389/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9389/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9389/console This message was automatically generated.
        Hide
        sidharta-s Sidharta Seethana added a comment -

        The release artifact is unrelated to this JIRA. The patch simply uses a different constant (defined in configuration.h) instead of PATH_MAX - no additional tests are required.

        Varun Vasudev , could you please review this patch? Thank you.

        Show
        sidharta-s Sidharta Seethana added a comment - The release artifact is unrelated to this JIRA. The patch simply uses a different constant (defined in configuration.h) instead of PATH_MAX - no additional tests are required. Varun Vasudev , could you please review this patch? Thank you.
        Hide
        vvasudev Varun Vasudev added a comment -

        +1. I'll commit this tomorrow if no one objects.

        Show
        vvasudev Varun Vasudev added a comment - +1. I'll commit this tomorrow if no one objects.
        Hide
        vvasudev Varun Vasudev added a comment -

        Committed to trunk and branch-2. Thanks Sidharta Seethana!

        Show
        vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Sidharta Seethana !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8616 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8616/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8616 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8616/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2463/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2463/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/517/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/517/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1253 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1253/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1253 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1253/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2426 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2426/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2426 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2426/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/529/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/529/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #488 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/488/)
        YARN-4017. container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #488 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/488/ ) YARN-4017 . container-executor overuses PATH_MAX. Contributed by Sidharta (vvasudev: rev 5b6bae00942c495e4be6ea2b8eb0676a48468dc6) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.h hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
        Hide
        sidharta-s Sidharta Seethana added a comment -

        thanks!

        Show
        sidharta-s Sidharta Seethana added a comment - thanks!

          People

          • Assignee:
            sidharta-s Sidharta Seethana
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development