Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4009

CORS support for ResourceManager REST API

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Currently the REST API's do not have CORS support. This means any UI (running in browser) cannot consume the REST API's. For ex Tez UI would like to use the REST API for getting application, application attempt information exposed by the API's.

      It would be very useful if CORS is enabled for the REST API's.

      1. YARN-4009.001.patch
        64 kB
        Varun Vasudev
      2. YARN-4009.002.patch
        64 kB
        Varun Vasudev
      3. YARN-4009.003.patch
        65 kB
        Varun Vasudev
      4. YARN-4009.004.patch
        65 kB
        Varun Vasudev
      5. YARN-4009.005.patch
        71 kB
        Varun Vasudev
      6. YARN-4009.006.patch
        73 kB
        Varun Vasudev
      7. YARN-4009.007.patch
        74 kB
        Varun Vasudev
      8. YARN-4009.8.patch
        73 kB
        Jonathan Eagles
      9. YARN-4009.LOGGING.patch
        73 kB
        Jonathan Eagles
      10. YARN-4009.LOGGING.patch
        73 kB
        Jonathan Eagles

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Cross origin support exists for Timeline Service V1, linking related tickets.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Cross origin support exists for Timeline Service V1, linking related tickets.
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded the initial patch. It refactors the timeline service CORS support and moves it into hadoop-yarn-server-common.

          To preserve the current timeline service behaviour, I've renamed the classes to YarnCrossOriginFilterInitializer and YarnCrossOriginFilter. The timeline service CrossOriginFilterInitializer inherits from YarnCrossOriginFilterInitializer and allows the existing configs to work without any change.

          I added a getPrefix function and modified the getFilterParameters function in YarnCrossOriginFilterInitializer to allow it to be shared by the timeline service and YARN.

          Jonathan Eagles, Prakash Ramachandran - can you please review the changes?

          Show
          vvasudev Varun Vasudev added a comment - Uploaded the initial patch. It refactors the timeline service CORS support and moves it into hadoop-yarn-server-common. To preserve the current timeline service behaviour, I've renamed the classes to YarnCrossOriginFilterInitializer and YarnCrossOriginFilter. The timeline service CrossOriginFilterInitializer inherits from YarnCrossOriginFilterInitializer and allows the existing configs to work without any change. I added a getPrefix function and modified the getFilterParameters function in YarnCrossOriginFilterInitializer to allow it to be shared by the timeline service and YARN. Jonathan Eagles , Prakash Ramachandran - can you please review the changes?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 20m 50s Pre-patch trunk has 7 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 51s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 1s Site still builds.
          -1 checkstyle 1m 48s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common.
          -1 yarn tests 2m 51s Tests failed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 26s Tests passed in hadoop-yarn-server-common.
              54m 20s  



          Reason Tests
          Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogDeletionService
            hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer
            hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilter
            hadoop.yarn.server.timeline.webapp.TestTimelineWebServicesWithSSL



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753551/YARN-4009.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 2e251a7
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8960/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8960/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 50s Pre-patch trunk has 7 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. -1 checkstyle 1m 48s The applied patch generated 5 new checkstyle issues (total was 0, now 5). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common. -1 yarn tests 2m 51s Tests failed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 26s Tests passed in hadoop-yarn-server-common.     54m 20s   Reason Tests Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogDeletionService   hadoop.yarn.server.applicationhistoryservice.TestApplicationHistoryServer   hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilter   hadoop.yarn.server.timeline.webapp.TestTimelineWebServicesWithSSL Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753551/YARN-4009.001.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 2e251a7 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8960/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8960/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8960/console This message was automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          The general approach seems to be correct, allowing for backwards compatibility while offering the new feature to more YARN services. I'll have a look at the patch more in detail this week.

          Show
          jeagles Jonathan Eagles added a comment - The general approach seems to be correct, allowing for backwards compatibility while offering the new feature to more YARN services. I'll have a look at the patch more in detail this week.
          Hide
          vvasudev Varun Vasudev added a comment -

          Jonathan Eagles - did you get a chance to review the patch? Thanks!

          Show
          vvasudev Varun Vasudev added a comment - Jonathan Eagles - did you get a chance to review the patch? Thanks!
          Hide
          jeagles Jonathan Eagles added a comment -

          Varun Vasudev, going to take a look tomorrow.

          Show
          jeagles Jonathan Eagles added a comment - Varun Vasudev , going to take a look tomorrow.
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded a newer version of the patch with some documentation fixed.

          Show
          vvasudev Varun Vasudev added a comment - Uploaded a newer version of the patch with some documentation fixed.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 21m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 10m 10s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 3s Site still builds.
          -1 checkstyle 1m 47s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 48s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
              56m 33s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756213/YARN-4009.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / bf2f2b4
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9162/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9162/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 10m 10s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 3s Site still builds. -1 checkstyle 1m 47s The applied patch generated 5 new checkstyle issues (total was 0, now 5). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 36s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 48s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.     56m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756213/YARN-4009.002.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / bf2f2b4 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/diffcheckstylehadoop-yarn-server-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9162/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9162/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9162/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded a new version of the patch that moves the filter into hadoop-common. No reason why the filter needs to be YARN specific.

          Show
          vvasudev Varun Vasudev added a comment - Uploaded a new version of the patch that moves the filter into hadoop-common. No reason why the filter needs to be YARN specific.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 23m 31s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 javadoc 10m 0s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 2s Site still builds.
          -1 checkstyle 2m 10s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 5m 26s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 27s Tests passed in hadoop-common.
          -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common.
          +1 yarn tests 3m 47s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
              85m 1s  



          Reason Tests
          FindBugs module:hadoop-yarn-server-applicationhistoryservice
          Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogsBlock



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756252/YARN-4009.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / bf2f2b4
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/diffcheckstylehadoop-common.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-applicationhistoryservice.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9168/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9168/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 23m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 0s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 2s Site still builds. -1 checkstyle 2m 10s The applied patch generated 5 new checkstyle issues (total was 0, now 5). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 5m 26s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 common tests 23m 27s Tests passed in hadoop-common. -1 yarn tests 1m 56s Tests failed in hadoop-yarn-common. +1 yarn tests 3m 47s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.     85m 1s   Reason Tests FindBugs module:hadoop-yarn-server-applicationhistoryservice Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogsBlock Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756252/YARN-4009.003.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / bf2f2b4 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/diffcheckstylehadoop-common.txt Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-applicationhistoryservice.html hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9168/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9168/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9168/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Fixed findbugs warning.

          Show
          vvasudev Varun Vasudev added a comment - Fixed findbugs warning.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 28m 25s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 53s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 2s Site still builds.
          -1 checkstyle 2m 32s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 5m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 12s Tests passed in hadoop-common.
          +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 13s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
              89m 44s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756279/YARN-4009.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / bf2f2b4
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9174/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9174/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 28m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 2s Site still builds. -1 checkstyle 2m 32s The applied patch generated 5 new checkstyle issues (total was 0, now 5). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 5m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 12s Tests passed in hadoop-common. +1 yarn tests 2m 0s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 13s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.     89m 44s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756279/YARN-4009.004.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / bf2f2b4 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9174/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9174/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9174/console This message was automatically generated.
          Hide
          hitesh Hitesh Shah added a comment -

          Couple of questions:

          if (!initializers.contains(CrossOriginFilterInitializer.class.getName())) {
                if(conf.getBoolean(YarnConfiguration
                    .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED, YarnConfiguration
                        .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED_DEFAULT)) {
                  initializers = CrossOriginFilterInitializer.class.getName() + ","
                      + initializers;
                  modifiedInitializers = true;
                }
              }
          

          I see this code in Timeline which makes it easier to enable cross-origin support just for Timeline. I am assuming Timeline also looks at the hadoop filters defined in core-site? What happens when both of these are enabled at the same time with different settings?

          Not sure if there is a question of selecting enabling cors support for different services such as NN webservices vs RM webservices.

          Apart from the above, if a global config is good enough, patch looks good.

          Show
          hitesh Hitesh Shah added a comment - Couple of questions: if (!initializers.contains(CrossOriginFilterInitializer.class.getName())) { if (conf.getBoolean(YarnConfiguration .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED, YarnConfiguration .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED_DEFAULT)) { initializers = CrossOriginFilterInitializer.class.getName() + "," + initializers; modifiedInitializers = true ; } } I see this code in Timeline which makes it easier to enable cross-origin support just for Timeline. I am assuming Timeline also looks at the hadoop filters defined in core-site? What happens when both of these are enabled at the same time with different settings? Not sure if there is a question of selecting enabling cors support for different services such as NN webservices vs RM webservices. Apart from the above, if a global config is good enough, patch looks good.
          Hide
          hitesh Hitesh Shah added a comment -
          Show
          hitesh Hitesh Shah added a comment - Jonathan Eagles ?
          Hide
          hitesh Hitesh Shah added a comment -

          Jonathan Eagles Any comments on the patch?

          Show
          hitesh Hitesh Shah added a comment - Jonathan Eagles Any comments on the patch?
          Hide
          jeagles Jonathan Eagles added a comment -

          I have reviewed the patch and have run with the timeline cross origin filter for a long time now. From a usage concern, Cross origin support is only needed for browser running javascript that reaches out to web services. Is there a need to allow the design to enable this only for webservices (REST APIs) instead of the whole webserver (builtin UIs and REST apis)? Also, seconding Hitesh Shah's comment regarding turning this on per service. Patch looks good other that these design questions.

          Show
          jeagles Jonathan Eagles added a comment - I have reviewed the patch and have run with the timeline cross origin filter for a long time now. From a usage concern, Cross origin support is only needed for browser running javascript that reaches out to web services. Is there a need to allow the design to enable this only for webservices (REST APIs) instead of the whole webserver (builtin UIs and REST apis)? Also, seconding Hitesh Shah 's comment regarding turning this on per service. Patch looks good other that these design questions.
          Hide
          vvasudev Varun Vasudev added a comment -

          What happens when both of these are enabled at the same time with different settings?

          If the filter is set in core-site.xml, it will be enabled irrespective of the value set in yarn.timeline-service.http-cross-origin.enabled. There is no change in behavior here - if a user sets the existing timeline CORS filter in core-site.xml, it will override the value set in yarn.timeline-service.http-cross-origin.enabled.

          Is there a need to allow the design to enable this only for webservices (REST APIs) instead of the whole webserver (builtin UIs and REST apis)?

          I don't think there's any such need. As far as I can tell, we don't treat http requests differently i.e. webservices and builtin UI requests are treated the same.

          Not sure if there is a question of selecting enabling cors support for different services such as NN webservices vs RM webservices.

          I thought about this - I'm not sure there's any benefit to adding one more set of config knobs. The chances are if you're fine with enabling CORS for the RM, you're probably fine enabling it for the NMs and the timeline server as well. If a user wishes to disable or enable CORS for a particular service, they can always set the filter initializers to the appropriate value on the node the service is running on(either via core-site.xml or yarn-site.xml).

          Show
          vvasudev Varun Vasudev added a comment - What happens when both of these are enabled at the same time with different settings? If the filter is set in core-site.xml, it will be enabled irrespective of the value set in yarn.timeline-service.http-cross-origin.enabled. There is no change in behavior here - if a user sets the existing timeline CORS filter in core-site.xml, it will override the value set in yarn.timeline-service.http-cross-origin.enabled. Is there a need to allow the design to enable this only for webservices (REST APIs) instead of the whole webserver (builtin UIs and REST apis)? I don't think there's any such need. As far as I can tell, we don't treat http requests differently i.e. webservices and builtin UI requests are treated the same. Not sure if there is a question of selecting enabling cors support for different services such as NN webservices vs RM webservices. I thought about this - I'm not sure there's any benefit to adding one more set of config knobs. The chances are if you're fine with enabling CORS for the RM, you're probably fine enabling it for the NMs and the timeline server as well. If a user wishes to disable or enable CORS for a particular service, they can always set the filter initializers to the appropriate value on the node the service is running on(either via core-site.xml or yarn-site.xml).
          Hide
          hitesh Hitesh Shah added a comment -

          Thinking more on this, a global config might be something that is okay to start with ( we already have a huge proliferation of configs which users do not set ). If there are concerns raised down the line, it should likely be easy enough to add yarn and hdfs specific configs which would override the global one in a compatible manner? Jonathan Eagles comments?

          Show
          hitesh Hitesh Shah added a comment - Thinking more on this, a global config might be something that is okay to start with ( we already have a huge proliferation of configs which users do not set ). If there are concerns raised down the line, it should likely be easy enough to add yarn and hdfs specific configs which would override the global one in a compatible manner? Jonathan Eagles comments?
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded a new version of the patch that adds additional configs to enable/disable CORS globally. This will allow individual services to enable CORS without it affecting all web services.

          Show
          vvasudev Varun Vasudev added a comment - Uploaded a new version of the patch that adds additional configs to enable/disable CORS globally. This will allow individual services to enable CORS without it affecting all web services.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 27m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 8m 0s There were no new javac warning messages.
          +1 javadoc 10m 2s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 5s Site still builds.
          -1 checkstyle 3m 20s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          -1 checkstyle 3m 56s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 9m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 40s Tests passed in hadoop-common.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          -1 yarn tests 1m 57s Tests failed in hadoop-yarn-common.
          -1 yarn tests 3m 7s Tests failed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
          -1 yarn tests 7m 19s Tests failed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 52m 16s Tests failed in hadoop-yarn-server-resourcemanager.
              154m 55s  



          Reason Tests
          Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogsBlock
            hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
            hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers
            hadoop.yarn.server.nodemanager.webapp.TestNMWebServices
            hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761924/YARN-4009.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / c890c51
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9245/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9245/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 27m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 5s Site still builds. -1 checkstyle 3m 20s The applied patch generated 5 new checkstyle issues (total was 0, now 5). -1 checkstyle 3m 56s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 9m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 40s Tests passed in hadoop-common. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. -1 yarn tests 1m 57s Tests failed in hadoop-yarn-common. -1 yarn tests 3m 7s Tests failed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common. -1 yarn tests 7m 19s Tests failed in hadoop-yarn-server-nodemanager. -1 yarn tests 52m 16s Tests failed in hadoop-yarn-server-resourcemanager.     154m 55s   Reason Tests Failed unit tests hadoop.yarn.logaggregation.TestAggregatedLogsBlock   hadoop.yarn.server.timeline.webapp.TestTimelineWebServices   hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers   hadoop.yarn.server.nodemanager.webapp.TestNMWebServices   hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels   hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodes   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesFairScheduler Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761924/YARN-4009.005.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / c890c51 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9245/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9245/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9245/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          The test failures are unrelated to the patch. The tests pass on my machine - it looks like some other process took the ports and the http servers couldn't start.

          Show
          vvasudev Varun Vasudev added a comment - The test failures are unrelated to the patch. The tests pass on my machine - it looks like some other process took the ports and the http servers couldn't start.
          Hide
          jeagles Jonathan Eagles added a comment -

          Will take a look at this tomorrow. The test failures are looking suspicious to me since they are all web services related. address in use errors - did one of the tests fail and leave the service running?

          Show
          jeagles Jonathan Eagles added a comment - Will take a look at this tomorrow. The test failures are looking suspicious to me since they are all web services related. address in use errors - did one of the tests fail and leave the service running?
          Hide
          vvasudev Varun Vasudev added a comment -

          Kicked off another Jenkins to confirm the test case issue.

          Show
          vvasudev Varun Vasudev added a comment - Kicked off another Jenkins to confirm the test case issue.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 25m 48s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 11s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 7s Site still builds.
          -1 checkstyle 3m 6s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          -1 checkstyle 3m 37s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 9m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 24m 33s Tests passed in hadoop-common.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 1s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 55s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 8m 33s Tests passed in hadoop-yarn-server-nodemanager.
          +1 yarn tests 60m 30s Tests passed in hadoop-yarn-server-resourcemanager.
              164m 54s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761924/YARN-4009.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / e52bc69
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9253/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9253/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 25m 48s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 7s Site still builds. -1 checkstyle 3m 6s The applied patch generated 5 new checkstyle issues (total was 0, now 5). -1 checkstyle 3m 37s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 9m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 24m 33s Tests passed in hadoop-common. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 1s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 55s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 25s Tests passed in hadoop-yarn-server-common. +1 yarn tests 8m 33s Tests passed in hadoop-yarn-server-nodemanager. +1 yarn tests 60m 30s Tests passed in hadoop-yarn-server-resourcemanager.     164m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761924/YARN-4009.005.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / e52bc69 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9253/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9253/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9253/console This message was automatically generated.
          Hide
          hitesh Hitesh Shah added a comment -

          Jonathan Eagles Did you get a chance to look at the latest patch?

          Show
          hitesh Hitesh Shah added a comment - Jonathan Eagles Did you get a chance to look at the latest patch?
          Hide
          jeagles Jonathan Eagles added a comment -

          +1. I have tried this patch out and reviewed the code. Minor nits

          • Configuration usage set(config setting, 'true") is better as setBoolean(config setting, true)
          • timeline server now uses its own different way to enable. So if i turn on resource manager and timeline server both on but nothing else, I get a CORS disabled message in the timeline server log even though it is enabled. Could you file a jira to address this spurious log message?
          Show
          jeagles Jonathan Eagles added a comment - +1. I have tried this patch out and reviewed the code. Minor nits Configuration usage set( config setting , 'true") is better as setBoolean( config setting , true) timeline server now uses its own different way to enable. So if i turn on resource manager and timeline server both on but nothing else, I get a CORS disabled message in the timeline server log even though it is enabled. Could you file a jira to address this spurious log message?
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded a new patch to address Jonathan's comments.

          Configuration usage set(config setting, 'true") is better as setBoolean(config setting, true)

          Fixed.

          timeline server now uses its own different way to enable. So if i turn on resource manager and timeline server both on but nothing else, I get a CORS disabled message in the timeline server log even though it is enabled. Could you file a jira to address this spurious log message?

          Fixed.

          Show
          vvasudev Varun Vasudev added a comment - Uploaded a new patch to address Jonathan's comments. Configuration usage set(config setting, 'true") is better as setBoolean(config setting, true) Fixed. timeline server now uses its own different way to enable. So if i turn on resource manager and timeline server both on but nothing else, I get a CORS disabled message in the timeline server log even though it is enabled. Could you file a jira to address this spurious log message? Fixed.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 27m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 8m 4s There were no new javac warning messages.
          +1 javadoc 11m 30s There were no new javadoc warning messages.
          -1 release audit 0m 19s The applied patch generated 1 release audit warnings.
          +1 site 3m 35s Site still builds.
          -1 checkstyle 3m 29s The applied patch generated 6 new checkstyle issues (total was 0, now 6).
          -1 checkstyle 4m 4s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 55s mvn install still works.
          +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
          +1 findbugs 11m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 8m 1s Tests passed in hadoop-common.
          +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 8s Tests passed in hadoop-yarn-common.
          +1 yarn tests 4m 5s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 29s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 9m 2s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 60m 23s Tests failed in hadoop-yarn-server-resourcemanager.
              154m 50s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.TestRM



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764977/YARN-4009.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 30e2f83
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html
          Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9345/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9345/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 27m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 11m 30s There were no new javadoc warning messages. -1 release audit 0m 19s The applied patch generated 1 release audit warnings. +1 site 3m 35s Site still builds. -1 checkstyle 3m 29s The applied patch generated 6 new checkstyle issues (total was 0, now 6). -1 checkstyle 4m 4s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 55s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 11m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 1s Tests passed in hadoop-common. +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 8s Tests passed in hadoop-yarn-common. +1 yarn tests 4m 5s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 29s Tests passed in hadoop-yarn-server-common. +1 yarn tests 9m 2s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 60m 23s Tests failed in hadoop-yarn-server-resourcemanager.     154m 50s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens Timed out tests org.apache.hadoop.yarn.server.resourcemanager.TestRM Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764977/YARN-4009.006.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 30e2f83 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9345/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9345/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9345/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          The release audit and findbugs issues are unrelated to the patch. The tests pass on my local machine.

          Show
          vvasudev Varun Vasudev added a comment - The release audit and findbugs issues are unrelated to the patch. The tests pass on my local machine.
          Hide
          jeagles Jonathan Eagles added a comment -

          Varun Vasudev, I'm wondering one more thing. Instead of adding logic for disabling the log message, I was thinking about changing the logic in ApplicationHistoryServer. Seems like we could just modify the logic below to avoid double adding the cross origin filter. What do you think?

              if (!initializers.contains(CrossOriginFilterInitializer.class.getName())) {
                if(conf.getBoolean(YarnConfiguration
                    .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED, YarnConfiguration
                        .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED_DEFAULT)) {
                  if (initializers.length() != 0) {
                    initializers += ",";
                  }
                  initializers += CrossOriginFilterInitializer.class.getName();
                  modifiedInitializers = true;
                }
              }
          
          
          Show
          jeagles Jonathan Eagles added a comment - Varun Vasudev , I'm wondering one more thing. Instead of adding logic for disabling the log message, I was thinking about changing the logic in ApplicationHistoryServer. Seems like we could just modify the logic below to avoid double adding the cross origin filter. What do you think? if (!initializers.contains(CrossOriginFilterInitializer.class.getName())) { if (conf.getBoolean(YarnConfiguration .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED, YarnConfiguration .TIMELINE_SERVICE_HTTP_CROSS_ORIGIN_ENABLED_DEFAULT)) { if (initializers.length() != 0) { initializers += "," ; } initializers += CrossOriginFilterInitializer.class.getName(); modifiedInitializers = true ; } }
          Hide
          vvasudev Varun Vasudev added a comment -

          Jonathan Eagles - just to make sure we're on the same page - you're suggesting that if we find the HttpCrossOriginFilterInitializer(which is present in hadoop-common) in the filter initializers list, we should just remove it from the initializers list and use the timeline server configurations instead?

          Show
          vvasudev Varun Vasudev added a comment - Jonathan Eagles - just to make sure we're on the same page - you're suggesting that if we find the HttpCrossOriginFilterInitializer(which is present in hadoop-common) in the filter initializers list, we should just remove it from the initializers list and use the timeline server configurations instead?
          Hide
          jeagles Jonathan Eagles added a comment -

          Varun Vasudev, I'm trying hard to find a balance here. On the one hand I want to support backwards compatibility on the other hand I want configuration to be simple. I want to support way that I can enable only RM and timeline CORS support while only specifying the configuration once (not once for common CORS and once for timeline CORS). However, I want to support both the old configuration parameters.

          Proposals
          1) If timeline CORS is enabled () we can have the timeline cors configuration override the common CORS if they are present otherwise use the common configuration.
          2) Create a second timeline enabled flag that will only use the new CORS classes, configs and behavior. This will allow the the old way using the old configs with timeline prefix to work, but allow users to migrate to the new way to simplify configuration.

          What do you think?

          Show
          jeagles Jonathan Eagles added a comment - Varun Vasudev , I'm trying hard to find a balance here. On the one hand I want to support backwards compatibility on the other hand I want configuration to be simple. I want to support way that I can enable only RM and timeline CORS support while only specifying the configuration once (not once for common CORS and once for timeline CORS). However, I want to support both the old configuration parameters. Proposals 1) If timeline CORS is enabled () we can have the timeline cors configuration override the common CORS if they are present otherwise use the common configuration. 2) Create a second timeline enabled flag that will only use the new CORS classes, configs and behavior. This will allow the the old way using the old configs with timeline prefix to work, but allow users to migrate to the new way to simplify configuration. What do you think?
          Hide
          vvasudev Varun Vasudev added a comment -

          Jonathan Eagles - makes sense. I'll put up a patch with your proposals incorporated.

          Show
          vvasudev Varun Vasudev added a comment - Jonathan Eagles - makes sense. I'll put up a patch with your proposals incorporated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Uploaded a new patch to address Jonathan Eagles suggestions.

          Show
          vvasudev Varun Vasudev added a comment - Uploaded a new patch to address Jonathan Eagles suggestions.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 31m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 9m 6s There were no new javac warning messages.
          +1 javadoc 11m 50s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 26s Site still builds.
          -1 checkstyle 3m 57s The applied patch generated 6 new checkstyle issues (total was 0, now 6).
          -1 checkstyle 4m 41s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 3s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 2m 28s mvn install still works.
          +1 eclipse:eclipse 0m 48s The patch built with eclipse:eclipse.
          +1 findbugs 12m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 8m 37s Tests failed in hadoop-common.
          +1 yarn tests 0m 31s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 35s Tests passed in hadoop-yarn-common.
          +1 yarn tests 4m 46s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 32s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 9m 34s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 65m 3s Tests failed in hadoop-yarn-server-resourcemanager.
              169m 30s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766370/YARN-4009.007.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / da16c9b
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9431/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9431/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 31m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 9m 6s There were no new javac warning messages. +1 javadoc 11m 50s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 site 3m 26s Site still builds. -1 checkstyle 3m 57s The applied patch generated 6 new checkstyle issues (total was 0, now 6). -1 checkstyle 4m 41s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 3s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 2m 28s mvn install still works. +1 eclipse:eclipse 0m 48s The patch built with eclipse:eclipse. +1 findbugs 12m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 8m 37s Tests failed in hadoop-common. +1 yarn tests 0m 31s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 35s Tests passed in hadoop-yarn-common. +1 yarn tests 4m 46s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 32s Tests passed in hadoop-yarn-server-common. +1 yarn tests 9m 34s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 65m 3s Tests failed in hadoop-yarn-server-resourcemanager.     169m 30s   Reason Tests Failed unit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766370/YARN-4009.007.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / da16c9b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9431/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9431/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9431/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          The test failures are unrelated to the patch.

          Show
          vvasudev Varun Vasudev added a comment - The test failures are unrelated to the patch.
          Hide
          vvasudev Varun Vasudev added a comment -

          Jonathan Eagles - did you get a chance to review the latest patch?

          Show
          vvasudev Varun Vasudev added a comment - Jonathan Eagles - did you get a chance to review the latest patch?
          Hide
          jeagles Jonathan Eagles added a comment -

          Varun Vasudev, made a small tweak to get rid of the setLoggingDisabled call. If you are ok with this change, I would like to check this in.

          Show
          jeagles Jonathan Eagles added a comment - Varun Vasudev , made a small tweak to get rid of the setLoggingDisabled call. If you are ok with this change, I would like to check this in.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 1s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767844/YARN-4009.LOGGING.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / d759b4b
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9513/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 1s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767844/YARN-4009.LOGGING.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / d759b4b Console output https://builds.apache.org/job/PreCommit-YARN-Build/9513/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 37m 26s Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 10m 39s There were no new javac warning messages.
          +1 javadoc 13m 43s There were no new javadoc warning messages.
          +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
          +1 site 4m 19s Site still builds.
          -1 checkstyle 4m 33s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          -1 checkstyle 5m 19s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 57s mvn install still works.
          +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse.
          +1 findbugs 12m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 8m 6s Tests failed in hadoop-common.
          +1 yarn tests 0m 33s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 27s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 49s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 32s Tests passed in hadoop-yarn-server-common.
          +1 yarn tests 10m 1s Tests passed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 62m 29s Tests failed in hadoop-yarn-server-resourcemanager.
              176m 56s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767880/YARN-4009.LOGGING.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / ee9b80a
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9514/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9514/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 37m 26s Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 10m 39s There were no new javac warning messages. +1 javadoc 13m 43s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. +1 site 4m 19s Site still builds. -1 checkstyle 4m 33s The applied patch generated 5 new checkstyle issues (total was 0, now 5). -1 checkstyle 5m 19s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 57s mvn install still works. +1 eclipse:eclipse 0m 42s The patch built with eclipse:eclipse. +1 findbugs 12m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 8m 6s Tests failed in hadoop-common. +1 yarn tests 0m 33s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 27s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 49s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 32s Tests passed in hadoop-yarn-server-common. +1 yarn tests 10m 1s Tests passed in hadoop-yarn-server-nodemanager. -1 yarn tests 62m 29s Tests failed in hadoop-yarn-server-resourcemanager.     176m 56s   Reason Tests Failed unit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767880/YARN-4009.LOGGING.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / ee9b80a Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-common.html Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9514/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9514/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9514/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Jonathan Eagles - with your patch, the timeline service will always require its own CORS configuration. Is my understanding correct? In that case, we should remove

          +  /** Enables cross origin support for timeline server. Uses the filter
          +   * in hadoop common instead of the timeline server specific one. */
          +  public static final String TIMELINE_SERVICE_CROSS_ORIGIN_ENABLED =
          +      TIMELINE_SERVICE_PREFIX + "cross-origin.enabled";
          +
          

          from YarnConfiguration.java.

          The rest of the patch looks good to me.

          Show
          vvasudev Varun Vasudev added a comment - Jonathan Eagles - with your patch, the timeline service will always require its own CORS configuration. Is my understanding correct? In that case, we should remove + /** Enables cross origin support for timeline server. Uses the filter + * in hadoop common instead of the timeline server specific one. */ + public static final String TIMELINE_SERVICE_CROSS_ORIGIN_ENABLED = + TIMELINE_SERVICE_PREFIX + "cross-origin.enabled" ; + from YarnConfiguration.java. The rest of the patch looks good to me.
          Hide
          jeagles Jonathan Eagles added a comment -

          Varun Vasudev, you are correct. There is no need for the new flag in the current code base. Removed in patch 8. If yarn.timeline-service.http-cross-origin.enabled is true then it will use timeline conf values and the fall back to the common conf settings. I think this is an acceptable compromise between backwards compatibility and utilizing the new functionality.

          Show
          jeagles Jonathan Eagles added a comment - Varun Vasudev , you are correct. There is no need for the new flag in the current code base. Removed in patch 8. If yarn.timeline-service.http-cross-origin.enabled is true then it will use timeline conf values and the fall back to the common conf settings. I think this is an acceptable compromise between backwards compatibility and utilizing the new functionality.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 28m 55s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 9m 30s There were no new javac warning messages.
          +1 javadoc 12m 20s There were no new javadoc warning messages.
          +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings.
          +1 site 4m 14s Site still builds.
          -1 checkstyle 3m 26s The applied patch generated 5 new checkstyle issues (total was 0, now 5).
          -1 checkstyle 4m 3s The applied patch generated 2 new checkstyle issues (total was 211, now 212).
          -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 46s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          -1 findbugs 12m 0s The patch appears to introduce 4 new Findbugs (version 3.0.0) warnings.
          +1 common tests 9m 26s Tests passed in hadoop-common.
          +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 24s Tests passed in hadoop-yarn-common.
          +1 yarn tests 4m 22s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 0m 26s Tests passed in hadoop-yarn-server-common.
          -1 yarn tests 9m 12s Tests failed in hadoop-yarn-server-nodemanager.
          -1 yarn tests 65m 12s Tests failed in hadoop-yarn-server-resourcemanager.
              166m 55s  



          Reason Tests
          FindBugs module:hadoop-yarn-common
          FindBugs module:hadoop-yarn-server-nodemanager
          Failed unit tests hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12768100/YARN-4009.8.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 960201b
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/whitespace.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9531/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9531/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 28m 55s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 9m 30s There were no new javac warning messages. +1 javadoc 12m 20s There were no new javadoc warning messages. +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings. +1 site 4m 14s Site still builds. -1 checkstyle 3m 26s The applied patch generated 5 new checkstyle issues (total was 0, now 5). -1 checkstyle 4m 3s The applied patch generated 2 new checkstyle issues (total was 211, now 212). -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 46s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. -1 findbugs 12m 0s The patch appears to introduce 4 new Findbugs (version 3.0.0) warnings. +1 common tests 9m 26s Tests passed in hadoop-common. +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 24s Tests passed in hadoop-yarn-common. +1 yarn tests 4m 22s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 0m 26s Tests passed in hadoop-yarn-server-common. -1 yarn tests 9m 12s Tests failed in hadoop-yarn-server-nodemanager. -1 yarn tests 65m 12s Tests failed in hadoop-yarn-server-resourcemanager.     166m 55s   Reason Tests FindBugs module:hadoop-yarn-common FindBugs module:hadoop-yarn-server-nodemanager Failed unit tests hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768100/YARN-4009.8.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 960201b checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/diffcheckstylehadoop-common.txt https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-common.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9531/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9531/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9531/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Makes sense. +1 for the latest patch.

          Show
          vvasudev Varun Vasudev added a comment - Makes sense. +1 for the latest patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8695 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8695/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8695 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8695/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-yarn-project/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Hide
          jeagles Jonathan Eagles added a comment -

          Thank you Varun Vasudev for putting this work together.

          Show
          jeagles Jonathan Eagles added a comment - Thank you Varun Vasudev for putting this work together.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/574/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/574/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/587/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/587/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1310 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1310/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1310 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1310/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-yarn-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2520 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2520/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2520 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2520/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/530/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/530/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2466 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2466/)
          YARN-4009. CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2466 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2466/ ) YARN-4009 . CORS support for ResourceManager REST API. ( Varun Vasudev (jeagles: rev f8adeb712dc834c27cec15c04a986f2f635aba83) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HttpCrossOriginFilterInitializer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/http/CrossOriginFilter.java hadoop-yarn-project/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/http/TestCrossOriginFilter.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/WebServer.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilterInitializer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeManagerRest.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestHttpCrossOriginFilterInitializer.java

            People

            • Assignee:
              vvasudev Varun Vasudev
              Reporter:
              pramachandran Prakash Ramachandran
            • Votes:
              1 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development