Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4005

Completed container whose app is finished is not removed from NMStateStore

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.2, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      If a container is completed and its corresponding app is finished, NM only removes it from its context and does not add it to 'recentlyStoppedContainers' when calling 'getContainerStatuses'. Then NM will not remove it from NMStateStore.

        Activity

        Hide
        hex108 Jun Gong added a comment -

        NM only removes containers in 'recentlyStoppedContainers' from NMStateStore, so we need add completed containers to 'recentlyStoppedContainers'.

        Show
        hex108 Jun Gong added a comment - NM only removes containers in 'recentlyStoppedContainers' from NMStateStore, so we need add completed containers to 'recentlyStoppedContainers'.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 6s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 40s There were no new javac warning messages.
        +1 javadoc 9m 43s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 20s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 21s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 6m 8s Tests passed in hadoop-yarn-server-nodemanager.
            42m 30s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12748183/YARN-4005.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 93d50b7
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8737/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8737/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8737/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 6s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 43s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 8s Tests passed in hadoop-yarn-server-nodemanager.     42m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748183/YARN-4005.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 93d50b7 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8737/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8737/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8737/console This message was automatically generated.
        Hide
        sandflee sandflee added a comment -

        seems there's no need to add to recentlyStoppedContainers, we could just remove container info from NMStateStore if app is finished.

        Show
        sandflee sandflee added a comment - seems there's no need to add to recentlyStoppedContainers, we could just remove container info from NMStateStore if app is finished.
        Hide
        hex108 Jun Gong added a comment -

        Yes, I think the result will be same.

        Show
        hex108 Jun Gong added a comment - Yes, I think the result will be same.
        Hide
        hex108 Jun Gong added a comment -

        Yes, I think the result will be same.

        Show
        hex108 Jun Gong added a comment - Yes, I think the result will be same.
        Hide
        hex108 Jun Gong added a comment -

        Jian He, could you please help review it? Thanks.

        Show
        hex108 Jun Gong added a comment - Jian He , could you please help review it? Thanks.
        Hide
        jianhe Jian He added a comment -

        Committed to trunk and branch-2, thanks Jun Gong !

        Show
        jianhe Jian He added a comment - Committed to trunk and branch-2, thanks Jun Gong !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8295 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8295/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8295 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8295/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hex108 Jun Gong added a comment -

        Thanks Jian He for the review and commit!

        Show
        hex108 Jun Gong added a comment - Thanks Jian He for the review and commit!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/)
        YARN-4005. Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/ ) YARN-4005 . Completed container whose app is finished is possibly not removed from NMStateStore. Contributed by Jun Gong (jianhe: rev 38aed1a94ed7b6da62e2445b5610bc02b1cddeeb) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java hadoop-yarn-project/CHANGES.txt
        Hide
        jlowe Jason Lowe added a comment -

        I pulled this in to branch-2.7 as well.

        Show
        jlowe Jason Lowe added a comment - I pulled this in to branch-2.7 as well.
        Hide
        jlowe Jason Lowe added a comment -

        Also committed to branch-2.6.

        Show
        jlowe Jason Lowe added a comment - Also committed to branch-2.6.

          People

          • Assignee:
            hex108 Jun Gong
            Reporter:
            hex108 Jun Gong
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development